diff --git a/app/Http/Controllers/OpenBanking/BinanceController.php b/app/Http/Controllers/OpenBanking/BinanceController.php index 2411ceec..81aed0f7 100644 --- a/app/Http/Controllers/OpenBanking/BinanceController.php +++ b/app/Http/Controllers/OpenBanking/BinanceController.php @@ -41,11 +41,6 @@ class BinanceController extends CryptoPortfolioConnectController return null; } - protected function validationFailureLogMessage(): string - { - return 'Binance credential validation failed'; - } - protected function credentialErrorMessage(\Throwable $e): string { return 'Invalid API credentials or failed to connect to Binance.'; diff --git a/app/Http/Controllers/OpenBanking/BitpandaController.php b/app/Http/Controllers/OpenBanking/BitpandaController.php index cd5e44d9..bc3779ff 100644 --- a/app/Http/Controllers/OpenBanking/BitpandaController.php +++ b/app/Http/Controllers/OpenBanking/BitpandaController.php @@ -41,11 +41,6 @@ class BitpandaController extends CryptoPortfolioConnectController return null; } - protected function validationFailureLogMessage(): string - { - return 'Bitpanda credential validation failed'; - } - protected function credentialErrorMessage(\Throwable $e): string { return 'Invalid API key or failed to connect to Bitpanda.'; diff --git a/app/Http/Controllers/OpenBanking/CoinbaseController.php b/app/Http/Controllers/OpenBanking/CoinbaseController.php index 423f4351..0628278a 100644 --- a/app/Http/Controllers/OpenBanking/CoinbaseController.php +++ b/app/Http/Controllers/OpenBanking/CoinbaseController.php @@ -41,11 +41,6 @@ class CoinbaseController extends CryptoPortfolioConnectController return null; } - protected function validationFailureLogMessage(): string - { - return 'Coinbase credential validation failed'; - } - protected function credentialErrorMessage(\Throwable $e): string { return 'Invalid API credentials or failed to connect to Coinbase.'; diff --git a/app/Http/Controllers/OpenBanking/IndexaCapitalController.php b/app/Http/Controllers/OpenBanking/IndexaCapitalController.php index 9ecbd02a..66ca187d 100644 --- a/app/Http/Controllers/OpenBanking/IndexaCapitalController.php +++ b/app/Http/Controllers/OpenBanking/IndexaCapitalController.php @@ -46,11 +46,6 @@ class IndexaCapitalController extends OpenBankingConnectController return $client->getUser(); } - protected function validationFailureLogMessage(): string - { - return 'Indexa Capital token validation failed'; - } - protected function credentialErrorMessage(\Throwable $e): string { return 'Invalid API token or failed to connect to Indexa Capital.'; @@ -58,6 +53,8 @@ class IndexaCapitalController extends OpenBankingConnectController /** * Build the pending accounts data in the same format as EnableBanking. + * + * @param array{accounts?: array} $providerData */ protected function buildPendingAccounts(mixed $providerData, User $user): array { diff --git a/app/Http/Controllers/OpenBanking/InteractiveBrokersController.php b/app/Http/Controllers/OpenBanking/InteractiveBrokersController.php index 564c2dbd..15127b00 100644 --- a/app/Http/Controllers/OpenBanking/InteractiveBrokersController.php +++ b/app/Http/Controllers/OpenBanking/InteractiveBrokersController.php @@ -48,11 +48,6 @@ class InteractiveBrokersController extends OpenBankingConnectController return $client->fetchStatement(); } - protected function validationFailureLogMessage(): string - { - return 'Interactive Brokers connection validation failed'; - } - /** * Turn a Flex failure into a message the user can act on: bad credentials, * a busy/rate-limited service, or a statement that is still generating. diff --git a/app/Http/Controllers/OpenBanking/OpenBankingConnectController.php b/app/Http/Controllers/OpenBanking/OpenBankingConnectController.php index 4403ff0a..310c383b 100644 --- a/app/Http/Controllers/OpenBanking/OpenBankingConnectController.php +++ b/app/Http/Controllers/OpenBanking/OpenBankingConnectController.php @@ -42,8 +42,6 @@ abstract class OpenBankingConnectController extends Controller */ abstract protected function fetchProviderData(array $validated): mixed; - abstract protected function validationFailureLogMessage(): string; - abstract protected function credentialErrorMessage(\Throwable $e): string; /** @@ -77,7 +75,10 @@ abstract class OpenBankingConnectController extends Controller try { $providerData = $this->fetchProviderData($validated); } catch (\Throwable $e) { - Log::warning($this->validationFailureLogMessage(), ['error' => $e->getMessage()]); + Log::warning('OpenBanking credential validation failed', [ + 'provider' => $this->provider()->value, + 'error' => $e->getMessage(), + ]); return response()->json([ 'message' => $this->credentialErrorMessage($e),