refactor(requests): dedupe UpdateAutomationRuleRequest (#476)

## What

`UpdateAutomationRuleRequest` was **byte-identical** to
`StoreAutomationRuleRequest` (verified with `diff`): same `rules()`,
`passedValidation()`, `withValidator()`.

Now it simply extends the Store request.

## Stats

- **-74 / +1 lines**

## Checks

- `php artisan test --filter=AutomationRule` — 63 passed (211
assertions)
- `vendor/bin/pint --dirty` — applied

Part of duplication-removal series (#475 was first).
This commit is contained in:
Víctor Falcón 2026-06-03 17:29:23 +02:00 committed by GitHub
parent aa3b811027
commit 65acab4512
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 74 deletions

View File

@ -2,77 +2,4 @@
namespace App\Http\Requests\Settings;
use Illuminate\Contracts\Validation\ValidationRule;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Validation\Rule;
class UpdateAutomationRuleRequest extends FormRequest
{
/**
* Determine if the user is authorized to make this request.
*/
public function authorize(): bool
{
return true;
}
/**
* Get the validation rules that apply to the request.
*
* @return array<string, ValidationRule|array<mixed>|string>
*/
public function rules(): array
{
return [
'title' => ['required', 'string', 'max:255'],
'priority' => ['required', 'integer', 'min:0'],
'rules_json' => ['required', 'json', function ($attribute, $value, $fail) {
$decoded = json_decode($value, true);
if (! is_array($decoded) || empty($decoded)) {
$fail('The rules JSON must be a valid JsonLogic object.');
}
}],
'action_category_id' => [
'nullable',
'string',
Rule::exists('categories', 'id')->where(function ($query) {
$query->where('user_id', auth()->id());
}),
],
'action_note' => ['nullable', 'string'],
'action_note_iv' => ['nullable', 'string', 'required_with:action_note'],
'action_label_ids' => ['nullable', 'array'],
'action_label_ids.*' => [
'required',
'string',
'uuid',
Rule::exists('labels', 'id')->where(function ($query) {
$query->where('user_id', auth()->id());
}),
],
];
}
/**
* Decode the rules_json string into an array so the model's array cast doesn't double-encode it.
*/
protected function passedValidation(): void
{
$this->merge([
'rules_json' => json_decode($this->rules_json, true),
]);
}
/**
* Configure the validator instance.
*/
public function withValidator($validator): void
{
$validator->after(function ($validator) {
$hasLabels = ! empty($this->action_label_ids);
if (! $this->action_category_id && ! $hasLabels) {
$validator->errors()->add('action_category_id', 'At least one action (category or labels) must be provided.');
}
});
}
}
class UpdateAutomationRuleRequest extends StoreAutomationRuleRequest {}