RomanNum3ral
/
whisper-money
mirror of https://github.com/whisper-money/whisper-money.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat(open-banking): enable manage bank accounts for everyone 

Remove the ManageBankAccounts Pennant feature that gated the per-connection
manage-accounts surface to the admin user, making the flow available to all
users. Drops the feature class, the controller gate, the shared Inertia flag,
and the frontend conditional.
This commit is contained in:
Víctor Falcón 2026-06-20 19:26:29 +02:00
parent 7fb190683c
commit 97d122c95e
8 changed files with 27 additions and 88 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
app/Features/ManageBankAccounts.php
View File

@ -1,23 +0,0 @@
<?php
namespace App\Features;
use App\Models\User;
/**
* Gates the per-connection "Manage Accounts" surface while it is being rolled
* out. For now it is limited to the admin user (ADMIN_EMAIL) so the flow can be
* dogfooded before a wider release.
*
* @api
*/
class ManageBankAccounts
{
/**
* Resolve the feature's initial value.
*/
public function resolve(?User $user): bool
{
return $user?->isAdmin() ?? false;
}
}

11
app/Http/Controllers/OpenBanking/ConnectionAccountController.php
View File

@ -3,7 +3,6 @@
namespace App\Http\Controllers\OpenBanking;
use App\Contracts\BankingProviderInterface;
use App\Features\ManageBankAccounts;
use App\Http\Controllers\Controller;
use App\Http\Requests\OpenBanking\MapConnectionAccountRequest;
use App\Jobs\SyncBankingConnectionJob;
@ -16,7 +15,6 @@ use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Inertia\Inertia;
use Inertia\Response;
use Laravel\Pennant\Feature;
class ConnectionAccountController extends Controller
{
@ -24,7 +22,6 @@ class ConnectionAccountController extends Controller
public function index(Request $request, BankingConnection $connection): Response
{
$this->ensureFeatureEnabled();
$this->authorizeConnection($connection);
$user = $request->user();
@ -44,8 +41,6 @@ class ConnectionAccountController extends Controller
public function map(MapConnectionAccountRequest $request, BankingConnection $connection, AccountUserCurrencyService $accountUserCurrencyService): RedirectResponse
{
$this->ensureFeatureEnabled();
$validated = $request->validated();
$uid = $validated['bank_account_uid'];
@ -109,7 +104,6 @@ class ConnectionAccountController extends Controller
public function unlink(BankingConnection $connection, Account $account): RedirectResponse
{
$this->ensureFeatureEnabled();
$this->authorizeConnection($connection);
if ($account->banking_connection_id !== $connection->id) {
@ -124,11 +118,6 @@ class ConnectionAccountController extends Controller
return back()->with('success', __('Account is no longer syncing. It is now a manual account.'));
}
private function ensureFeatureEnabled(): void
{
abort_unless(Feature::for(auth()->user())->active(ManageBankAccounts::class), 403);
}
private function authorizeConnection(BankingConnection $connection): void
{
if ($connection->user_id !== auth()->id()) {

4
app/Http/Middleware/HandleInertiaRequests.php
View File

@ -5,7 +5,6 @@ namespace App\Http\Middleware;
use App\Enums\BankingConnectionStatus;
use App\Enums\BankingProvider;
use App\Features\CalculateBalancesOnImport;
use App\Features\ManageBankAccounts;
use App\Features\TransactionAnalysis;
use App\Models\BankingConnection;
use App\Services\CurrencyOptions;
@ -180,21 +179,18 @@ class HandleInertiaRequests extends Middleware
'cashflow' => true,
'calculateBalancesOnImport' => false,
'transactionAnalysis' => false,
'manageBankAccounts' => false,
];
}
$features = Feature::for($user)->values([
CalculateBalancesOnImport::class,
TransactionAnalysis::class,
ManageBankAccounts::class,
]);
return [
'cashflow' => true,
'calculateBalancesOnImport' => $features[CalculateBalancesOnImport::class] !== false,
'transactionAnalysis' => $features[TransactionAnalysis::class] !== false,
'manageBankAccounts' => $features[ManageBankAccounts::class] !== false,
];
}

1
resources/js/pages/settings/connections.test.tsx
View File

@ -29,7 +29,6 @@ vi.mock('@inertiajs/react', () => ({
cashflow: true,
calculateBalancesOnImport: false,
transactionAnalysis: false,
manageBankAccounts: true,
},
},
}),

36
resources/js/pages/settings/connections.tsx
View File

@ -44,8 +44,7 @@ interface Props {
}
export default function ConnectionsPage({ connections }: Props) {
const { auth, flash, subscriptionsEnabled, features } =
usePage<SharedData>().props;
const { auth, flash, subscriptionsEnabled } = usePage<SharedData>().props;
const isDemoAccount = auth?.isDemoAccount ?? false;
const isFreePlan = subscriptionsEnabled && !auth?.hasProPlan;
const [connectDialogOpen, setConnectDialogOpen] = useState(false);
@ -287,23 +286,22 @@ export default function ConnectionsPage({ connections }: Props) {
{__('Map Accounts')}
</DropdownMenuItem>
)}
{features.manageBankAccounts &&
canManageAccounts(
connection,
) && (
<DropdownMenuItem
onClick={() =>
router.visit(
`/open-banking/connections/${connection.id}/accounts`,
)
}
>
<Wallet className="mr-2 h-4 w-4" />
{__(
'Manage Accounts',
)}
</DropdownMenuItem>
)}
{canManageAccounts(
connection,
) && (
<DropdownMenuItem
onClick={() =>
router.visit(
`/open-banking/connections/${connection.id}/accounts`,
)
}
>
<Wallet className="mr-2 h-4 w-4" />
{__(
'Manage Accounts',
)}
</DropdownMenuItem>
)}
{hasAuthError(
connection,
) && (

1
resources/js/types/index.d.ts vendored
View File

@ -43,7 +43,6 @@ export interface Features {
cashflow: boolean;
calculateBalancesOnImport: boolean;
transactionAnalysis: boolean;
manageBankAccounts: boolean;
}
export interface ExpiredBankingConnectionNotification {

1
tests/Feature/InertiaSharedDataTest.php
View File

@ -44,7 +44,6 @@ test('shared feature flags do not include coinbase flag', function () {
'cashflow' => true,
'calculateBalancesOnImport' => false,
'transactionAnalysis' => false,
'manageBankAccounts' => false,
]);
});

38
tests/Feature/OpenBanking/ConnectionAccountTest.php
View File

@ -17,21 +17,13 @@ beforeEach(function () {
]);
});
/**
* The manage-accounts surface is gated behind the ManageBankAccounts feature,
* which is only active for the admin user. Mark the created user as the admin so
* the gate lets the request through.
*/
function adminUser(): User
function onboardedUser(): User
{
$user = User::factory()->onboarded()->create();
config(['mail.admin_email' => $user->email]);
return $user;
return User::factory()->onboarded()->create();
}
test('index renders the manage page with synced and available accounts', function () {
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create(['user_id' => $user->id]);
Account::factory()->for($user)->create([
@ -56,7 +48,7 @@ test('index renders the manage page with synced and available accounts', functio
});
test('refresh discovers bank accounts that are not yet synced', function () {
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create(['user_id' => $user->id]);
Account::factory()->for($user)->create([
@ -94,7 +86,7 @@ test('refresh discovers bank accounts that are not yet synced', function () {
test('map create adds a new synced account and dispatches a sync', function () {
Queue::fake();
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create([
'user_id' => $user->id,
'aspsp_name' => 'Test Bank',
@ -125,7 +117,7 @@ test('map create adds a new synced account and dispatches a sync', function () {
test('map link moves syncing to another account and unlinks the previous one', function () {
Queue::fake();
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create(['user_id' => $user->id]);
$source = Account::factory()->for($user)->create([
@ -160,7 +152,7 @@ test('map link moves syncing to another account and unlinks the previous one', f
});
test('unlink stops syncing but keeps the account and its transactions', function () {
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create(['user_id' => $user->id]);
$account = Account::factory()->for($user)->create([
@ -182,7 +174,7 @@ test('unlink stops syncing but keeps the account and its transactions', function
});
test('index is forbidden for another user\'s connection', function () {
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create([
'user_id' => User::factory()->onboarded()->create()->id,
]);
@ -193,7 +185,7 @@ test('index is forbidden for another user\'s connection', function () {
});
test('unlink rejects an account that does not belong to the connection', function () {
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create(['user_id' => $user->id]);
$account = Account::factory()->for($user)->create([
'banking_connection_id' => null,
@ -204,18 +196,8 @@ test('unlink rejects an account that does not belong to the connection', functio
->assertNotFound();
});
test('manage accounts is forbidden when the feature is disabled', function () {
$user = User::factory()->onboarded()->create();
config(['mail.admin_email' => 'someone-else@example.com']);
$connection = BankingConnection::factory()->create(['user_id' => $user->id]);
$this->actingAs($user)
->get(route('open-banking.connection-accounts.index', $connection))
->assertForbidden();
});
test('map link rejects a non-transactional target account', function () {
$user = adminUser();
$user = onboardedUser();
$connection = BankingConnection::factory()->create(['user_id' => $user->id]);
$loan = Account::factory()->for($user)->create([
'banking_connection_id' => null,