fix(currency): degrade gracefully when rates return 404 (#449)

## Problem

`PHP-LARAVEL-2M` (High, escalating, 38 events) — `RuntimeException:
Failed to fetch currency rates for xxx on 2025-12-31: HTTP 404` crashing
`/dashboard`.

A user holds an account in currency `xxx` (ISO 4217 "no/unknown
currency"). No rate file exists for it, so every candidate URL returns
404. `CurrencyConversionService::fetchRates` threw an unhandled
`RuntimeException` that bubbled past the graceful-degradation logic in
`ExchangeRateService::convert` and broke the whole dashboard render.

## Fix

Distinguish **permanent** 404s from **transient** failures:
- All sources return 404 → log a warning and return `[]`. Callers
already handle empty rates (return unconverted / zero amount).
- Timeouts / 5xx / connection errors → still throw, so real outages stay
visible.

## Tests

- New: unknown base currency with all-404 sources returns `0.0` instead
of throwing.
- Existing "throws when both primary and fallback fail" (500s) still
passes — transient errors still surface.

Fixes PHP-LARAVEL-2M.
This commit is contained in:
Víctor Falcón 2026-05-29 14:44:56 +02:00 committed by GitHub
parent 5119528149
commit bef657c2ed
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 1 deletions

View File

@ -86,6 +86,11 @@ class CurrencyConversionService
foreach ($this->rateUrls($currency, $candidateDate) as $url) {
try {
$response = Http::timeout(10)->get($url);
if ($response->notFound()) {
continue;
}
$response->throw();
return $response->json($currency) ?? [];
@ -95,7 +100,16 @@ class CurrencyConversionService
}
}
throw new RuntimeException("Failed to fetch currency rates for {$currency} on {$date}: {$lastException?->getMessage()}", 0, $lastException);
if ($lastException !== null) {
throw new RuntimeException("Failed to fetch currency rates for {$currency} on {$date}: {$lastException->getMessage()}", 0, $lastException);
}
Log::warning('Currency rates unavailable, all sources returned 404', [
'currency' => $currency,
'date' => $date,
]);
return [];
}
/**

View File

@ -73,6 +73,18 @@ test('throws when both primary and fallback fail', function () {
$service->convert('BTC', 'EUR', 1.0, '2026-01-15');
})->throws(RuntimeException::class);
test('returns zero when base currency is unknown and all sources return 404', function () {
Http::fake([
'cdn.jsdelivr.net/*' => Http::response('Not Found', 404),
'currency-api.pages.dev/*' => Http::response('Not Found', 404),
]);
$service = new CurrencyConversionService;
$result = $service->convert('BTC', 'XXX', 1.0, '2026-01-15');
expect($result)->toBe(0.0);
});
test('falls back to previous historical date when requested release is missing', function () {
Http::fake([
'cdn.jsdelivr.net/npm/@fawazahmed0/currency-api@2025-12-10/*' => Http::response('Not Found', 404),