From dafc58f49f0a832a45bbd3f02fd39340e575a4d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20Falc=C3=B3n?= <victoor89@gmail.com>
Date: Sun, 12 Apr 2026 16:38:00 +0100
Subject: [PATCH] fix: clarify account creation modal copy (#274)

## Summary
- update the create account modal copy to explicitly mention loans and
property accounts
- clarify the manual option so users understand it also covers manually
created real-estate accounts
- update the browser test assertion to match the revised dialog copy
---
 lang/es.json                                              | 6 +++---
 .../js/components/accounts/create-account-dialog.tsx      | 8 +++++---
 tests/Browser/BankAccountsTest.php                        | 2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/lang/es.json b/lang/es.json
index 6fda0a19..9509b700 100644
--- a/lang/es.json
+++ b/lang/es.json
@@ -114,10 +114,10 @@
     "Add More Accounts": "Agregar M\u00e1s Cuentas",
     "Add More Accounts?": "\u00bfAgregar M\u00e1s Cuentas?",
     "Add Transaction": "Agregar Transacci\u00f3n",
-    "Add a new bank account to track your transactions.": "Agrega una nueva cuenta bancaria para rastrear tus transacciones.",
+    "Add a bank account, loan, or property to your workspace.": "Agrega una cuenta bancaria, un prestamo o una propiedad a tu espacio de trabajo.",
     "Add a new category to organize your transactions.": "Agrega una nueva categor\u00eda para organizar tus transacciones.",
     "Add a new label to tag your transactions.": "Agrega una nueva etiqueta para etiquetar tus transacciones.",
-    "Add an account and import transactions manually.": "A\u00f1ade una cuenta e importa transacciones manualmente.",
+    "Create bank accounts, loans, or properties manually and import transactions.": "Crea cuentas bancarias, prestamos o propiedades manualmente e importa transacciones.",
     "Add another account": "Agregar otra cuenta",
     "Add another account to track more of your finances.": "Agrega otra cuenta para rastrear m\u00e1s de tus finanzas.",
     "Add labels": "Agregar etiquetas",
@@ -286,7 +286,7 @@
     "Chinese Yuan": "Yuan chino",
     "Choose how to handle each account from :bank. You can create new accounts, link to existing ones, or skip.": "Elige c\u00f3mo gestionar cada cuenta de :bank. Puedes crear nuevas cuentas, vincularlas a las existentes u omitirlas.",
     "Choose how to report this transfer": "Elige como mostrar esta transferencia",
-    "Choose how you want to add your account.": "Elige c\u00f3mo quieres a\u00f1adir tu cuenta.",
+    "Create a bank account, loan, or property to track it manually.": "Crea una cuenta bancaria, un prestamo o una propiedad para seguirla manualmente.",
     "Choose the account where transactions will be imported": "Elige la cuenta donde se importar\u00e1n las transacciones",
     "Choose the color palette for your charts": "Elige la paleta de colores para tus gr\u00e1ficos",
     "Choose the plan that works for you": "Elige el plan que funcione para ti",
diff --git a/resources/js/components/accounts/create-account-dialog.tsx b/resources/js/components/accounts/create-account-dialog.tsx
index 4c1d7bda..6457fddd 100644
--- a/resources/js/components/accounts/create-account-dialog.tsx
+++ b/resources/js/components/accounts/create-account-dialog.tsx
@@ -240,9 +240,11 @@ export function CreateAccountDialog({
                         <DialogTitle>{__('Create Account')}</DialogTitle>
                         <DialogDescription>
                             {mode === 'choice'
-                                ? __('Choose how you want to add your account.')
+                                ? __(
+                                      'Add a bank account, loan, or property to your workspace.',
+                                  )
                                 : __(
-                                      'Add a new bank account to track your transactions.',
+                                      'Create a bank account, loan, or property to track it manually.',
                                   )}
                         </DialogDescription>
                     </DialogHeader>
@@ -261,7 +263,7 @@ export function CreateAccountDialog({
                                     </p>
                                     <p className="text-xs text-balance text-muted-foreground">
                                         {__(
-                                            'Add an account and import transactions manually.',
+                                            'Create bank accounts, loans, or properties manually and import transactions.',
                                         )}
                                     </p>
                                 </div>
diff --git a/tests/Browser/BankAccountsTest.php b/tests/Browser/BankAccountsTest.php
index 1ae63148..b04324a0 100644
--- a/tests/Browser/BankAccountsTest.php
+++ b/tests/Browser/BankAccountsTest.php
@@ -51,7 +51,7 @@ it('can open create account dialog', function () {
     $page->assertSee('Bank accounts')
         ->click('Create Account')
         ->wait(0.5)
-        ->assertSee('Add a new bank account to track your transactions')
+        ->assertSee('Create a bank account, loan, or property to track it manually')
         ->assertNoJavascriptErrors();
 });