whisper-money

Commit Graph

Author	SHA1	Message	Date
Víctor Falcón	d27905ec3d	refactor(requests): share account detail validation rules (#481 ) ## What Real-estate detail rule block (~10 fields) was duplicated in 4 requests; loan detail block in 2. Variants differ only by `sometimes` on `property_type` and presence of `revaluation_percentage`. New `ValidatesAccountDetailRules` trait: - `realEstateDetailRules(propertyTypeSometimes:, withRevaluation:)` - `loanDetailRules()` ## Stats - -115 / +83 lines; one source of truth for these field rules ## Checks - `php artisan test --filter="Account\|RealEstate\|Loan"` — 355 passed (1744 assertions) - `vendor/bin/pint --dirty` — pass Part of duplication-removal series (#475–#480).	2026-06-03 19:01:03 +02:00
Víctor Falcón	fe692e37c3	refactor(requests): share category cashflow direction resolution (#479 ) ## What `StoreCategoryRequest` and `UpdateCategoryRequest` had identical 24-line `prepareForValidation()` deriving `cashflow_direction` from category type. Moved to `app/Http/Requests/Concerns/ResolvesCategoryCashflowDirection` trait. ## Stats - -48 / +43 lines (net small, removes a whole duplicated logic block that must stay in sync) ## Checks - `php artisan test --filter=Categor` — 104 passed (565 assertions) - `vendor/bin/pint --dirty` — pass Part of duplication-removal series (#475–#478).	2026-06-03 17:39:40 +02:00
Víctor Falcón	cc63a86a1c	refactor(requests): extract user-owned exists rules to trait (#477 ) ## What The `Rule::exists('x', 'id')->where(fn => user_id)` ownership closure was repeated 19× across 10 Form Requests (categories, labels, accounts, typed accounts). New `app/Http/Requests/Concerns/ValidatesUserOwnedResources` trait: - `$this->userOwned('categories' \| 'labels' \| 'accounts')` - `$this->userOwnedAccountOfType(AccountType::Loan \| RealEstate)` `UpdateAutomationRuleRequest` intentionally untouched — #476 makes it extend Store. ## Stats - -110 / +63 lines ## Checks - `php artisan test --filter="Transaction\|Budget\|Account\|AutomationRule\|RealEstate\|Loan"` — 641 passed (3052 assertions), 1 skipped - `vendor/bin/pint --dirty` — pass Part of duplication-removal series (#475, #476).	2026-06-03 17:33:54 +02:00

Author

SHA1

Message

Date

Víctor Falcón

d27905ec3d

refactor(requests): share account detail validation rules (#481 )

## What

Real-estate detail rule block (~10 fields) was duplicated in **4
requests**; loan detail block in **2**. Variants differ only by
`sometimes` on `property_type` and presence of `revaluation_percentage`.

New `ValidatesAccountDetailRules` trait:

- `realEstateDetailRules(propertyTypeSometimes:, withRevaluation:)`
- `loanDetailRules()`

## Stats

- **-115 / +83 lines**; one source of truth for these field rules

## Checks

- `php artisan test --filter="Account|RealEstate|Loan"` — 355 passed
(1744 assertions)
- `vendor/bin/pint --dirty` — pass

Part of duplication-removal series (#475–#480).

2026-06-03 19:01:03 +02:00

Víctor Falcón

fe692e37c3

refactor(requests): share category cashflow direction resolution (#479 )

## What

`StoreCategoryRequest` and `UpdateCategoryRequest` had identical 24-line
`prepareForValidation()` deriving `cashflow_direction` from category
type.

Moved to `app/Http/Requests/Concerns/ResolvesCategoryCashflowDirection`
trait.

## Stats

- **-48 / +43 lines** (net small, removes a whole duplicated logic block
that must stay in sync)

## Checks

- `php artisan test --filter=Categor` — 104 passed (565 assertions)
- `vendor/bin/pint --dirty` — pass

Part of duplication-removal series (#475–#478).

2026-06-03 17:39:40 +02:00

Víctor Falcón

cc63a86a1c

refactor(requests): extract user-owned exists rules to trait (#477 )

## What

The `Rule::exists('x', 'id')->where(fn => user_id)` ownership closure
was repeated **19×** across 10 Form Requests (categories, labels,
accounts, typed accounts).

New `app/Http/Requests/Concerns/ValidatesUserOwnedResources` trait:

- `$this->userOwned('categories' | 'labels' | 'accounts')`
- `$this->userOwnedAccountOfType(AccountType::Loan | RealEstate)`

`UpdateAutomationRuleRequest` intentionally untouched — #476 makes it
extend Store.

## Stats

- **-110 / +63 lines**

## Checks

- `php artisan test
--filter="Transaction|Budget|Account|AutomationRule|RealEstate|Loan"` —
641 passed (3052 assertions), 1 skipped
- `vendor/bin/pint --dirty` — pass

Part of duplication-removal series (#475, #476).

2026-06-03 17:33:54 +02:00

3 Commits