whisper-money/tests/Feature/OpenBanking
Víctor Falcón c42a48a952
chore: Remove account-mapping feature flag (#252)
## Summary

- Removes the `account-mapping` Pennant feature flag entirely, making
the account mapping flow (pending accounts data + map-accounts page) the
default and only code path
- Removes the old direct-creation branches from all banking controllers
(Authorization, Bitpanda, Binance, IndexaCapital)
- Extracts a shared `CreatesAccountsFromPending` trait for the
onboarding auto-create logic
- Updates all controller tests to reflect the always-on mapping behavior

## Changes

### Backend
- **AppServiceProvider** — removed `account-mapping` flag definition
- **AuthorizationController** — removed flag check +
`createAccountsFromSession()` dead code; always stores
`pending_accounts_data` and redirects to mapping
- **BitpandaController / BinanceController / IndexaCapitalController** —
removed flag checks, old inline account creation, and unused imports
- **HandleInertiaRequests / ActivateDevelopmentFeatures /
ResolvesFeatures** — removed `account-mapping` from flag arrays
- **New `CreatesAccountsFromPending` trait** — shared auto-create logic
for onboarding path (to be consumed next)

### Frontend
- Removed `'account-mapping'` from the TypeScript `Features` interface

### Tests
- Merged flag-specific test variants into single always-on tests
- Removed redundant tests that tested the old disabled-flag code path
- Updated assertions to check `pending_accounts_data` instead of direct
account creation
2026-04-01 12:09:22 +02:00
..
AccountMappingTest.php chore: Remove account-mapping feature flag (#252) 2026-04-01 12:09:22 +02:00
AuthorizationControllerTest.php chore: Remove account-mapping feature flag (#252) 2026-04-01 12:09:22 +02:00
BalanceSyncServiceTest.php feat: Integrate EnableBanking as open banking provider (#106) 2026-02-12 09:09:28 +01:00
BinanceBalanceSyncTest.php perf: make banking syncs incremental on subsequent runs (#141) 2026-02-23 15:10:40 +01:00
BinanceControllerTest.php chore: Remove account-mapping feature flag (#252) 2026-04-01 12:09:22 +02:00
BitpandaBalanceSyncTest.php feat: investment benefits — show gains/losses on investment accounts (#140) 2026-02-23 13:59:10 +01:00
BitpandaControllerTest.php chore: Remove account-mapping feature flag (#252) 2026-04-01 12:09:22 +02:00
ConnectionControllerTest.php feat(connections): filter already-connected institutions from connect bank dialog (#217) 2026-03-11 12:06:49 +00:00
IndexaCapitalBalanceSyncTest.php fix(open-banking): use net_amounts for Indexa Capital invested amount calculation (#156) 2026-02-25 15:45:31 +01:00
IndexaCapitalControllerTest.php chore: Remove account-mapping feature flag (#252) 2026-04-01 12:09:22 +02:00
InstitutionControllerTest.php feat: Integrate EnableBanking as open banking provider (#106) 2026-02-12 09:09:28 +01:00
OpenBankingFeatureFlagTest.php fix(onboarding): gate connect bank option behind open-banking feature flag (#197) 2026-03-03 20:49:27 +00:00
SyncBankingConnectionJobTest.php chore: Remove account-mapping feature flag (#252) 2026-04-01 12:09:22 +02:00
SyncBinanceHistoricalBalancesJobTest.php chore: upgrade Laravel 12 to 13 (#242) 2026-03-25 12:56:33 +00:00
SyncRetryAndLoggingTest.php chore: Remove account-mapping feature flag (#252) 2026-04-01 12:09:22 +02:00
TransactionSyncServiceTest.php feat: Add per-bank description formatter for bank-synced transactions (#120) 2026-02-13 09:54:58 +01:00