RomanNum3ral
/
whisper-money
mirror of https://github.com/whisper-money/whisper-money.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
whisper-money/tests/Feature
History
Víctor Falcón 8a8d5962b5
refactor: Simplify transaction endpoints architecture (#76) 
## Summary

Simplifies transaction endpoints by separating sync API (read-only) from
web routes (mutations). This creates clearer architectural boundaries
and fixes inconsistent label behavior.

## Architecture Changes

### Before
- Sync API handled both sync (GET) and mutations (POST/PATCH/DELETE)
- Frontend used sync API for all operations
- Bulk updates merged labels, single updates replaced them

### After  
- **Sync API**: Read-only GET endpoint for IndexedDB sync
- **Web Routes**: All mutations (create, update, delete, bulk
operations)
- **Consistent behavior**: All label updates replace instead of merge

## Endpoint Mapping

| Operation | Old Endpoint | New Endpoint |
|-----------|-------------|--------------|
| Fetch/Sync | `GET /api/sync/transactions` | `GET
/api/sync/transactions` ✅ |
| Create | `POST /api/sync/transactions` | `POST /transactions` |
| Update | `PATCH /api/sync/transactions/{id}` | `PATCH
/transactions/{id}` |
| Delete | `DELETE /api/sync/transactions/{id}` | `DELETE
/transactions/{id}` |
| Bulk Update | `PATCH /transactions/bulk` | `PATCH /transactions/bulk`
✅ |

## Backend Changes

### TransactionSyncController
- ✅ Simplified to read-only `index()` method
- ✅ Removed `store()`, `update()`, `destroy()` methods
- ✅ Added docblock clarifying purpose

### TransactionController
- ✅ Fixed `store()` to return labels with `id, name, color`
- ✅ Fixed `update()` to return labels with `id, name, color`  
- ✅ Changed `bulkUpdate()` to replace labels instead of merging

### Cleanup
- ✅ Removed `UpdateTransactionSyncRequest` (no longer needed)
- ✅ Updated `routes/api.php` to only have GET for sync

## Frontend Changes

### transaction-sync.ts
- ✅ Updated `create()` → `POST /transactions`
- ✅ Updated `update()` → `PATCH /transactions/{id}`
- ✅ Updated `delete()` → `DELETE /transactions/{id}`
- ✅ Replaced all `fetch()` calls with `axios`
- ✅ Removed manual CSRF token handling

## Test Changes

### TransactionSyncTest
- ✅ Removed create/update/delete tests
- ✅ Kept only read-only sync tests
- ✅ Added test for labels format

### BulkUpdateTransactionsTest  
- ✅ Added test verifying label replacement behavior

## Test Results

All tests passing! ✅

```
Tests:    42 passed (235 assertions)
Duration: 6.17s

✓ TransactionTest: 29 tests
✓ TransactionSyncTest: 4 tests
✓ BulkUpdateTransactionsTest: 9 tests
```

## Benefits

1. **Clear separation of concerns**: Sync API is read-only, web routes
handle mutations
2. **Consistent label behavior**: All updates replace labels (not merge)
3. **Standardized HTTP client**: Axios everywhere, automatic CSRF
handling
4. **Reduced complexity**: Removed duplicate form request class
5. **Better architecture**: Aligns with intended design

## Breaking Changes

None - All changes are internal to how the frontend calls the backend.
The functionality remains the same from the user's perspective.

## Files Changed

- `app/Http/Controllers/Sync/TransactionSyncController.php`
- `app/Http/Controllers/TransactionController.php`
- `app/Http/Requests/UpdateTransactionSyncRequest.php` (deleted)
- `resources/js/services/transaction-sync.ts`
- `routes/api.php`
- `tests/Feature/Sync/TransactionSyncTest.php`
- `tests/Feature/BulkUpdateTransactionsTest.php`
 		2026-01-25 16:15:17 +01:00
..
Auth feat(queue): Implement queueable email jobs with rate limiting 2025-12-30 07:22:18 +01:00
Console test: Improve demo reset tests performance 2026-01-22 10:24:07 +01:00
Jobs/Drip Add subscription cancellation email with manual trigger command (#47) 2025-12-30 20:32:44 +01:00
Listeners Add subscription cancellation email with manual trigger command (#47) 2025-12-30 20:32:44 +01:00
Onboarding User Onboarding Flow (#23) 2025-12-12 13:06:08 +01:00
Settings Add currency selection to user profile settings (#41) 2025-12-30 07:22:19 +01:00
Sync refactor: Simplify transaction endpoints architecture (#76) 2026-01-25 16:15:17 +01:00
AccountBalanceControllerTest.php Accounts: new pages to list, and see account details (#13) 2025-12-05 14:33:18 +01:00
AccountControllerTest.php test: Optimize tests performance 2026-01-17 19:20:23 +01:00
AutomationRuleTest.php chore: Simplify IndexedDB sync by moving to Inertia shared props (#63) 2026-01-19 19:15:26 +01:00
BudgetFeatureFlagTest.php Add Budgeting Feature to Track and Manage Spending (#36) 2026-01-21 15:25:50 +01:00
BudgetHistoricalAssignmentTest.php feat: Load transactions history on budget created (#72) 2026-01-22 11:10:15 +01:00
BudgetTest.php Add Budgeting Feature to Track and Manage Spending (#36) 2026-01-21 15:25:50 +01:00
BudgetTransactionServiceTest.php feat: Load transactions history on budget created (#72) 2026-01-22 11:10:15 +01:00
BulkUpdateTransactionsTest.php refactor: Simplify transaction endpoints architecture (#76) 2026-01-25 16:15:17 +01:00
CashflowAnalyticsTest.php test: Optimize tests performance 2026-01-17 19:20:23 +01:00
DashboardAnalyticsTest.php test: Optimize tests performance 2026-01-17 19:20:23 +01:00
DashboardTest.php User Onboarding Flow (#23) 2025-12-12 13:06:08 +01:00
DeleteUserCommandTest.php test: Optimize tests performance 2026-01-17 19:20:23 +01:00
DemoAccountRestrictionsTest.php Demo Account Experience (#51) 2026-01-07 10:58:14 +01:00
EncryptionTest.php User Onboarding Flow (#23) 2025-12-12 13:06:08 +01:00
ExampleTest.php Install Pest 2025-11-07 12:01:58 +00:00
IdorVulnerabilityTest.php refactor: Simplify transaction endpoints architecture (#76) 2026-01-25 16:15:17 +01:00
InertiaSharedDataTest.php SEO landing page 2025-11-25 11:33:11 +01:00
LabelTest.php feat: add transaction labels feature (#24) 2025-12-13 13:02:19 +01:00
SitemapTest.php User Onboarding Flow (#23) 2025-12-12 13:06:08 +01:00
SubscriptionTest.php User Onboarding Flow (#23) 2025-12-12 13:06:08 +01:00
TransactionTest.php feat: Add label support to single transaction update endpoint (#75) 2026-01-24 17:54:54 +01:00
UserLeadTest.php Add User Lead functionality and tests 2025-11-25 10:31:25 +01:00