whisper-money/database/migrations
Víctor Falcón c9a70ffa1a
feat(accounts): count shared accounts at the owner's percentage (#750)
## Why

Some accounts are shared. A joint account funded 50/50 with a partner
holds money that is only half yours, so its expenses and income should
only count towards your figures by half — otherwise the dashboard and
the cashflow screen overstate both sides of every month.

## What

An account can now be configured with **the share of it you actually
own**, in Settings → Accounts → Edit account.

- **Transactions are always weighted** by that percentage. This covers
the cashflow screen (summary, sankey, trend, category breakdown) and the
dashboard (cashflow summary, monthly spending, top categories).
- **Balances stay at face value by default**, so an account keeps
matching what the bank shows. An opt-in checkbox — only offered below
100% — applies the same percentage to the balance as well, which then
flows through net worth, its evolution, and the account cards.

Defaults are 100% / opt-in off, so existing users see no change at all.

## How

The share is computed at exactly two choke points, one per code path:

- **PHP** — `ConvertsTransactionCurrency::convertTransactionAmount()`
applies `Account::shareOfAmount()` after the currency conversion,
covering every row-by-row analytics consumer.
- **SQL** — `Transaction::OWNED_AMOUNT_SQL` plus the
`joinOwningAccount()` scope weigh the four aggregate queries that never
hydrate models.

Balances go through `BalanceLookup::forAccounts()`, the single point
every net-worth, evolution and account-metrics reader already shares —
so they all stay consistent for free, while the surfaces that must show
the real bank figure (the balance editor, imports, bank sync) read
`account_balances` directly and are untouched.

`ownership_percentage` is a **signed** `tinyInteger` on purpose: MySQL
promotes `signed * unsigned` to `BIGINT UNSIGNED`, which overflows on
the negative amount of an expense. A test caught this.

## Deliberate boundaries

- **Transaction rows keep showing the real amount.** A row should say
what the bank actually charged; only totals are your share.
- **The balance editor writes the full amount**, and now says so when
the account is shared — that is what stops a shared balance being halved
again on every correction.
- **Percentages are whole numbers, 1–100.** A three-way split (33.33%)
is not expressible yet.
- **Configurable on edit only.** `StoreAccountRequest` and the create
form are unchanged, so a new joint account counts at 100% until you edit
it.

## Known gap (follow-up)

**Budgets are not weighted.** `budget_transactions.amount` is a snapshot
written at assignment time, so a 50% account still counts at 100% in
budget spend, carry-over and threshold alerts. Fixing it properly needs
the write path weighted, a re-snapshot when the percentage changes, and
a backfill of existing rows — a separate PR rather than a line in this
one. Until then a shared account can read €400 on the dashboard and €800
in Budgets for the same category.

Loan/mortgage *projections* also seed off the raw latest balance, so a
shared **loan** with the balance opt-in on draws a step at today's date.
Narrow, and follow-up material.

## Testing

`tests/Feature/SharedAccountOwnershipTest.php` covers every weighted
endpoint, net worth with and without the balance opt-in, the 1–100
validation, and pins the PHP and SQL rounding to the same answer on an
uneven share (33% of an odd amount).

Manual QA on real local data (June 2026, account "Daily" set to 50%):

| | Before | After |
|---|---|---|
| Cashflow income | €4,460 | €4,057 (−€403 = half of the account's
€805.80) |
| Cashflow expenses | €4,122 | €3,217 (−€905 = half of the account's
€1,809.85) |
| Net worth (opt-in off) | 30,516,453 | 30,516,453 — unchanged |
| Net worth (opt-in on) | 30,516,453 | 30,470,797 (−45,656 = half of the
€913.12 balance) |

Also verified: the balance editor still prefills the real €244,310.08
and shows the shared-account notice; an empty percentage field leaves
the setting untouched instead of resetting to 100%; out-of-range values
are rejected.

## Demo


https://github.com/user-attachments/assets/de47e41a-ff72-4b2b-8e5b-51076e048504


<!-- PLACEHOLDER: drag the QA video here -->
2026-08-11 13:26:54 +00:00
..
0001_01_01_000000_create_users_table.php
…
0001_01_01_000001_create_cache_table.php
…
0001_01_01_000002_create_jobs_table.php
…
2025_08_26_100418_add_two_factor_columns_to_users_table.php
…
2025_11_07_135255_add_encryption_salt_to_users_table.php
…
2025_11_07_135256_create_encrypted_messages_table.php
…
2025_11_07_150038_create_banks_table.php
…
2025_11_07_150122_create_accounts_table.php
…
2025_11_07_150613_create_categories_table.php
…
2025_11_07_150659_create_transactions_table.php
…
2025_11_07_184056_modify_banks_table_add_user_id_and_simplify_name.php
…
2025_11_07_185018_change_banks_logo_to_text.php
…
2025_11_08_140230_change_transactions_id_to_uuid.php
…
2025_11_08_141344_make_category_id_nullable_in_transactions_table.php
…
2025_11_08_144530_add_soft_deletes_to_transactions_table.php
…
2025_11_10_110100_create_automation_rules_table.php
…
2025_11_15_172640_create_account_balances_table.php
…
2025_11_15_175636_change_transactions_amount_to_bigint.php
…
2025_11_15_195739_convert_all_ids_to_uuid.php
…
2025_11_18_184409_create_user_leads_table.php
…
2025_11_28_104227_add_source_to_transactions_table.php
…
2025_11_29_170353_add_type_to_categories_table.php
…
2025_11_29_170955_fix_account_balances_unique_constraint.php
…
2025_12_01_101443_add_unique_constraint_to_categories_table.php
…
2025_12_06_112515_create_customer_columns.php
…
2025_12_06_112516_create_subscriptions_table.php
…
2025_12_06_112517_create_subscription_items_table.php
…
2025_12_06_112518_add_meter_id_to_subscription_items_table.php
…
2025_12_06_112519_add_meter_event_name_to_subscription_items_table.php
…
2025_12_10_142006_add_onboarded_at_to_users_table.php
…
2025_12_12_092647_create_labels_table.php
…
2025_12_12_092650_create_label_transaction_table.php
…
2025_12_12_092651_create_automation_rule_labels_table.php
…
2025_12_12_141955_update_labels_unique_constraint_include_deleted_at.php
…
2025_12_16_151952_create_user_mail_logs_table.php
…
2025_12_19_092437_create_budgets_table.php
…
2025_12_19_092443_create_budget_periods_table.php
…
2025_12_19_092446_create_budget_transactions_table.php
…
2025_12_20_154221_create_features_table.php
…
2025_12_29_063338_add_currency_code_to_users_table.php
…
2026_01_08_192757_add_email_identifier_to_user_mail_logs.php
…
2026_01_08_204223_update_user_mail_logs_unique_constraint.php
…
2026_01_21_151353_add_indexes_for_budget_transaction_assignment.php
…
2026_01_22_071325_add_processing_historical_to_budget_periods.php
…
2026_01_22_143232_add_locale_to_users_table.php
…
2026_02_08_103953_create_user_settings_table.php
…
2026_02_09_110624_add_encrypted_to_accounts_table.php
…
2026_02_09_131403_make_description_iv_nullable_on_transactions.php
…
2026_02_09_144915_create_banking_connections_table.php
…
2026_02_09_144959_add_banking_connection_fields_to_accounts_table.php
…
2026_02_09_144959_add_external_transaction_id_to_transactions_table.php
…
2026_02_10_085759_add_aspsp_logo_to_banking_connections_table.php
…
2026_02_10_095639_add_raw_data_to_transactions_table.php
…
2026_02_11_113115_add_pending_accounts_data_to_banking_connections_table.php
…
2026_02_11_113119_add_linked_at_to_accounts_table.php
…
2026_02_13_083716_add_original_description_to_transactions_table.php
…
2026_02_18_084241_add_api_token_to_banking_connections_table.php
…
2026_02_18_110556_add_api_secret_to_banking_connections_table.php
…
2026_02_20_074846_create_exchange_rates_table.php
…
2026_02_22_180317_add_invested_amount_to_account_balances_table.php
…
2026_02_24_193117_fix_budget_transaction_refund_amounts.php
…
2026_03_03_114620_add_paywall_seen_at_to_users_table.php
…
2026_03_04_085843_add_waitlist_columns_to_user_leads_table.php
…
2026_03_04_094926_add_locale_to_user_leads_table.php
…
2026_03_12_095411_add_iban_to_accounts_table.php
…
2026_03_18_112307_add_cashflow_direction_to_categories_table.php
…
2026_03_19_151039_add_include_loans_in_net_worth_chart_to_user_settings_table.php
…
2026_03_20_110659_create_real_estate_details_table.php
…
2026_03_20_132058_make_bank_id_nullable_on_accounts_table.php
…
2026_03_20_154755_add_include_real_estate_in_net_worth_chart_to_user_settings_table.php
…
2026_03_25_125717_add_revaluation_percentage_to_real_estate_details_table.php
…
2026_03_25_132244_create_loan_details_table.php
…
2026_03_30_123011_add_consecutive_sync_failures_to_banking_connections_table.php
…
2026_03_30_123011_create_banking_sync_logs_table.php
…
2026_04_14_120000_add_email_verification_to_user_leads_table.php
…
2026_04_16_063515_add_bank_transactions_email_cutoff_at_to_banking_connections_table.php
…
2026_04_16_092644_add_timezone_to_users_table.php
…
2026_04_22_084113_add_deleted_at_to_users_table.php
…
2026_04_25_092824_add_launch_columns_to_user_leads_table.php
…
2026_05_05_070442_add_rate_limited_until_to_banking_connections_table.php
…
2026_05_05_132023_convert_custom_budgets_to_monthly.php
…
2026_05_13_085027_add_dedup_fingerprint_to_transactions_table.php
…
2026_05_25_115100_update_default_saving_and_investment_category_types.php
…
2026_05_26_061232_add_reinvitation_columns_to_user_leads_table.php
…
2026_05_27_061513_add_counterparty_names_to_transactions_table.php
…
2026_05_28_073203_update_categories_unique_constraint_for_soft_deletes.php
…
2026_05_29_085835_update_saving_and_investment_category_cashflow_direction.php
…
2026_06_01_085554_create_budget_category_table.php
…
2026_06_01_085554_create_budget_label_table.php
…
2026_06_01_085554_migrate_budget_category_label_to_pivots.php
…
2026_06_02_090000_add_parent_id_to_categories_table.php
…
2026_06_02_094823_add_notify_on_bank_transactions_synced_to_user_settings_table.php
…
2026_06_05_120000_create_saved_filters_table.php
…
2026_06_05_185212_add_state_token_to_banking_connections_table.php
…
2026_06_08_114044_add_analysis_days_to_saved_filters_table.php
…
2026_06_09_124010_add_analysis_mode_to_saved_filters_table.php
…
2026_06_10_083644_add_last_logged_in_at_to_users_table.php
…
2026_06_10_084055_add_last_active_at_to_users_table.php
…
2026_06_12_134225_create_ai_consents_table.php
…
2026_06_12_134523_create_suggestion_runs_table.php
…
2026_06_12_134524_create_rule_suggestions_table.php
…
2026_06_13_000000_add_is_catch_all_to_budgets_table.php
…
2026_06_15_120911_add_ai_categorization_fields_to_transactions_table.php
…
2026_06_15_120911_add_origin_to_automation_rules_table.php
…
2026_06_15_120911_create_category_corrections_table.php
…
2026_06_17_081319_add_ai_suggested_category_to_transactions_table.php
…
2026_06_17_114601_create_integration_requests_table.php
…
2026_06_17_114602_create_integration_request_votes_table.php
…
2026_06_17_120850_add_status_to_integration_requests_table.php
…
2026_06_17_122001_seed_initial_integration_requests.php
…
2026_06_17_141827_add_comment_to_integration_requests_table.php
…
2026_06_18_092830_drop_unique_user_vote_from_integration_request_votes_table.php
…
2026_06_19_134854_create_stuck_cohort_snapshots_table.php
…
2026_06_20_105609_align_accounts_encrypted_flag_with_plaintext_names.php
…
2026_06_20_165235_add_position_to_accounts_table.php
…
2026_06_26_124609_add_ai_model_to_transactions_table.php
…
2026_06_27_000000_backfill_xxx_account_currencies.php
…
2026_06_27_114559_add_refunded_at_to_subscriptions_table.php
…
2026_06_27_154041_add_hidden_on_dashboard_to_accounts_table.php
…
2026_06_29_161916_add_transactions_last_visited_at_to_users_table.php
…
2026_07_01_064324_add_ai_consent_prompt_dismissed_at_to_users_table.php
…
2026_07_02_133321_add_user_source_created_at_index_to_transactions_table.php
…
2026_07_06_120000_create_spaces_table.php
…
2026_07_06_120001_create_space_user_table.php
…
2026_07_06_120002_create_space_invitations_table.php
…
2026_07_06_120003_add_current_space_id_to_users_table.php
…
2026_07_06_120004_add_space_id_to_owned_tables.php
…
2026_07_06_120005_backfill_spaces.php
…
2026_07_17_125642_create_personal_access_tokens_table.php
…
2026_07_17_154027_create_oauth_auth_codes_table.php
…
2026_07_17_154028_create_oauth_access_tokens_table.php
…
2026_07_17_154029_create_oauth_refresh_tokens_table.php
…
2026_07_17_154030_create_oauth_clients_table.php
…
2026_07_17_154031_create_oauth_device_codes_table.php
…
2026_07_18_104433_create_account_import_configs_table.php
…
2026_07_18_111320_add_upsell_source_to_subscriptions_table.php
…
2026_07_24_083854_add_notification_toggles_to_budgets_table.php
…
2026_07_24_083855_add_budget_notification_defaults_to_user_settings_table.php
…
2026_07_24_083855_add_limit_notified_flags_to_budget_periods_table.php
…
2026_07_24_100000_enable_budget_notifications_by_default.php
…
2026_07_25_102200_disable_budget_new_transaction_notifications.php fix(budgets): keep per-transaction email notifications opt-in (#735) 2026-07-25 12:36:13 +02:00
2026_08_09_150908_retry_enable_banking_connections_stuck_after_auth_failures.php fix(banking): stop unclassified bank responses from silently killing a connection (#742) 2026-08-09 17:26:34 +02:00
2026_08_10_090000_add_ownership_to_accounts_table.php feat(accounts): count shared accounts at the owner's percentage (#750) 2026-08-11 13:26:54 +00:00
2026_08_10_144811_create_mcp_tool_calls_table.php feat(mcp): record MCP tool usage and report it with stats:mcp-usage (#760) 2026-08-11 10:27:32 +02:00