0f3cdd41aa
## Summary Removes the `ManageBankAccounts` Pennant feature flag that gated the per-connection "Manage Accounts" surface to the admin user, making the flow available to all users. ## Changes - Delete the `App\Features\ManageBankAccounts` feature class. - `ConnectionAccountController`: drop the `ensureFeatureEnabled()` gate (3 call sites + method) and the `Feature`/`ManageBankAccounts` imports. Access stays guarded by `authorizeConnection()` (connection ownership). - `HandleInertiaRequests`: stop sharing the `manageBankAccounts` Inertia flag. - Frontend: remove the flag from the `Features` type, the `features.manageBankAccounts` conditional in `connections.tsx` (now gated solely by `canManageAccounts`), and the now-unused `features` destructure. - Tests: update `InertiaSharedDataTest` and the `connections.test.tsx` mock; simplify the `adminUser()` helper to `onboardedUser()` in `ConnectionAccountTest` and remove the "forbidden when feature disabled" test. ## Testing - `vendor/bin/pint --dirty` — pass - `php artisan test tests/Feature/OpenBanking/ConnectionAccountTest.php tests/Feature/InertiaSharedDataTest.php` — 17 passed - `bunx vitest run resources/js/pages/settings/connections.test.tsx` — pass - `bun run lint` / `bun run format` — clean |
||
|---|---|---|
| .. | ||
| Concerns | ||
| AccountMappingController.php | ||
| AuthorizationController.php | ||
| BinanceController.php | ||
| BitpandaController.php | ||
| CoinbaseController.php | ||
| ConnectionAccountController.php | ||
| ConnectionController.php | ||
| IndexaCapitalController.php | ||
| InstitutionController.php | ||
| WiseController.php | ||