Both reviewers flagged that the income/expense ternary silently treated any non-Income type as the expense side. Replace it with a match that throws on Savings/Investment/Transfer, so a future miscall fails loudly instead of returning a wrong total. Behavior is unchanged for the only current callers (Income and Expense). |
||
|---|---|---|
| .. | ||
| Concerns | ||
| AccountController.php | ||
| CashflowAnalyticsController.php | ||
| CategoryMonthlyBreakdownController.php | ||
| DashboardAnalyticsController.php | ||
| ImportDataController.php | ||
| SavedFilterController.php | ||
| TransactionAnalysisController.php | ||
| TransactionController.php | ||