Commit Graph

5712 Commits

Author SHA1 Message Date
Simon Pinfold cca4da6e00 Cap tag-filter lists at 100 entries, all spellings
Review finding: unbounded tag lists fan out into one correlated EXISTS
per tag on both page and count statements. Cap each list at 100
normalized entries with 400 INVALID_TAG_FILTER naming the parameter.

Applies to the legacy spellings as well — a deliberate, decided
exception to the old-names-behave-identically rule, since a cap only on
new names would leave the same fan-out reachable through the aliases.
2026-08-05 13:36:37 -07:00
Simon Pinfold 4eb312cd6c Silence per-request DeprecationWarning in the tag-filter remap shim
Reading the deprecated include_tags/exclude_tags fields by attribute
fires pydantic's DeprecationWarning on every list/refine request even
for callers using only the new names. The warning is aimed at API
clients, not the server's own remap; read via model_dump instead.
2026-08-05 13:32:50 -07:00
Simon Pinfold 43ccc2b6e0 Move schemas_in import to module scope in test_list_filter
Review feedback: no import cycle requires the local import.
2026-08-05 13:24:11 -07:00
Simon Pinfold e3ec8202e5 Document tags_all/tags_any/tags_none in openapi.yaml, deprecate aliases
Add the three tag-filter parameters to both listAssets and
getAssetTagHistogram parameter blocks and mark include_tags/exclude_tags
deprecated: true, keeping the spec in step with the runtime schemas so
generated clients can discover the new filters while the aliases stay
present for existing consumers.
2026-08-05 13:20:02 -07:00
Simon Pinfold e204ab9f84 Pin tag-value opacity: case-sensitive matching, byte-exact conflict check
The prod tag survey (~/comfy/prod-model-tag-shape.md) found live
case-distinct tag pairs (SEEDVR2/seedvr2) that resolve differently, so
the contract now states tag values are opaque byte-strings. Pin that:
case-distinct tags filter separately, and a case-distinct all/none pair
is not an INVALID_TAG_FILTER conflict.
2026-08-05 13:14:55 -07:00
Simon Pinfold ace88101a1 Address review findings: positional-compat, deprecation metadata, test matrix
- Move any_tags to the end of the four touched signatures: inserting it
  mid-signature silently misbound pre-existing positional callers (e.g.
  a caller passing name_contains positionally would have it consumed as
  any_tags).
- Mark include_tags/exclude_tags Field(deprecated=True) on both list
  schemas so generated schema metadata matches the contract, not just a
  comment (schemas_out.py already uses this form for Asset.name).
- Add tests: legal cross-slot old/new combinations, repeated query-key
  concatenation (pins Core behavior; outside the cross-platform
  contract), tags_any two-page cursor consistency (total/has_more/
  no-overlap), refine-route mixed-spelling rejection + legacy-conflict
  preservation, and schema deprecation metadata.
2026-08-05 13:14:55 -07:00
Simon Pinfold 2119d97297 Implement tags_all/tags_any/tags_none on the assets list API (BE-6600)
Adds the three canonically-named tag filter params to GET /api/assets and
GET /api/assets/tags/refine:

- tags_all: asset carries every tag (replaces include_tags)
- tags_any: asset carries at least one tag (new)
- tags_none: asset carries no tag (replaces exclude_tags)

Clauses intersect; tags_none always wins. include_tags/exclude_tags remain
as permanent deprecated aliases and behave exactly as before when used on
their own.

Invalid combinations return 400 INVALID_TAG_FILTER, but only when the
request uses at least one new-name parameter (non-empty after
normalisation):

- mixed spellings of one slot (include_tags with tags_all, exclude_tags
  with tags_none)
- the same tag in the effective all-list and none-list (query can never
  match)

Old-names-only requests gain no new error paths: include_tags=a&exclude_tags=a
still returns an empty 200. tags_any/tags_none overlap stays valid (dead
term, not a dead query).
2026-08-05 13:14:55 -07:00
Comfy Org PR Bot 6f7cd7fcea
Bump comfyui-frontend-package to 1.48.6 (#15301) 2026-08-04 19:53:21 -07:00
comfyanonymous de23a547f1
Update the Features section with more up to date stuff. (#15302) 2026-08-04 19:45:30 -07:00
rattus ba1d0efc9f
comfy-aimdo 0.4.13 (#15290)
Comfy-aimdo 0.4.12 increases error logging reliablity to help root
cause os errors in some of the C APIs that are causing issues for
some users.

The log is also unified with python logging, so non-terminal users
see the logs properly.

Aimdo 0.4.13 fixes a bug in async-offload + MRU primary weights
allocation. https://github.com/Comfy-Org/ComfyUI/issues/15284
2026-08-04 21:47:11 -04:00
Daxiong (Lin) 2bbb200dc9
chore: update workflow templates to v0.11.31 (#15297)
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
2026-08-04 17:29:44 -07:00
Alexander Piskun e7970cb2ce
[Partner Nodes] feat(BFL): add Flux 3 video model (#15295)
* [Partner Nodes] feat(BFL): add Flux 3 video model

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>

* [Partner Nodes] fix(BFL): harden keyframe value check

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>

---------

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
2026-08-04 17:26:10 -07:00
Alexander Piskun 1868372da0
[Partner Nodes] feat(TopazAI): add Bloom 2 and Wonder 3.5 models support (#15294)
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2026-08-04 22:51:09 +03:00
rattus 40dbdc1bef
restore SDPA non-cudnn small attention bypass (#15296)
This is performance critical for ACE step.
2026-08-04 15:25:25 -04:00
Alexander Piskun c44dea1880
[Partner Nodes] chore(Kling): remove retired legacy models and Virtual Try-On API (#15249)
Signed-off-by: bigcat88 <bigcat88@icloud.com>
2026-08-04 19:24:21 +03:00
comfyanonymous 9a9fdb10ed
Harden some nodes against potential issues related to combos. (#15277) 2026-08-03 23:55:13 -04:00
rivadart 16e3f3034f
fix(minimax): cast raw parameters to input device in H3 VAEs (#15268) 2026-08-03 19:06:12 -04:00
comfyanonymous e377e26304
Don't pin too much memory on Linux systems with no swap partition. (#15266) 2026-08-03 16:29:47 -04:00
Comfy Org PR Bot 14b05228ce
Bump comfyui-frontend-package to 1.47.12 (#15244)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2026-08-02 22:03:37 -07:00
comfyanonymous b1693ecba9 ComfyUI v0.30.0 2026-08-02 22:49:14 -04:00
Daxiong (Lin) 6eba7739f0
chore: update workflow templates to v0.11.27 (#15239) 2026-08-02 19:47:04 -07:00
Daxiong (Lin) f72b68878e
Update workflow templates to v0.11.26 (#15228) 2026-08-02 22:29:02 -04:00
Jukka Seppänen 57500fc5bc
feat: Support MiniMax-H3 (CORE-375) (#15224) 2026-08-02 22:28:29 -04:00
Oliver Freyermuth b53e247c94
rename comfy/logging.py to comfy/internal_logging.py (#15231)
This avoids name collision (circular imports) for external custom nodes,
for which the comfy path is pushed into sys.path so Python's own logging module
is shadowed otherwise.

fixes: #15229
2026-08-02 16:20:27 -04:00
rattus 611f2a4e0f
fix pin registration priority (#15226)
This priority scheme was broken in the case where you have pin
registration exhaustion while loading a VBAR that gets a big evicition.
The weight would stay in the loaded set but inherit the MRU priority
against other workflow models WRT pin registration which leads to async
offload without pinning.

Fix by universally promiting active pin registration above workflow
pins without concern for the weights/weights-loaded split. This diverges
from the actual budgeting where the split still makes sense.
2026-08-02 08:16:06 -07:00
Alexander Piskun 364081170f
[Partner Nodes] feat(Minimax): add 768P resolution for H3 model (#15227)
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2026-08-02 17:10:47 +03:00
rattus 8084083d4b
comfy-aimdo 0.4.11 (#15215)
Changes:

Remove sequential scan hint
Prefer NVML pressure on windows
Add async malloc clamp option (unused by comfy so far)
Workaround AMD windows GPU virtual address space leak

The largest change is the NVML pressure, which works around a cuMemGetInfo
drift from actual VRAM in some circumstances.
2026-08-02 06:55:37 -04:00
comfyanonymous f06a187f50
Handle case where swap memory query fails on windows. (#15219) 2026-08-02 01:12:12 -04:00
comfyanonymous 532a16f3b9
Disable gradients on diffusion models. (#15218) 2026-08-01 20:15:51 -07:00
comfyanonymous e0951a9c7e
Let the save text node save in csv format. (#15217) 2026-08-01 22:27:37 -04:00
comfyanonymous 41a3e160d7
Use the actual function to check if the path is within the dir. (#15216) 2026-08-01 22:15:17 -04:00
Jukka Seppänen 49a7422892
Support latent previews for nested latents (#15196) 2026-08-01 19:57:15 -04:00
comfyanonymous e803f24ea0
Let the VAEDecodeAudio node decode nested audio. (#15211) 2026-08-01 16:38:42 -04:00
comfyanonymous e8e233cdf6
Update comfy-kitchen version to 0.2.26 (#15208) 2026-08-01 15:10:39 -04:00
Alexander Piskun 1091c47b3a
[Partner Nodes] chore(Bria): increase price for video endpoints (#15186)
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2026-08-01 20:43:42 +03:00
Alexander Piskun d8e6aa55f3
[Partner Nodes] feat(xAI): update nodes for grok-imagine-video-1.5 model (#15197)
* [Partner Nodes] feat(xAI): update nodes for grok-imagine-video-1.5 model

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2026-08-01 20:30:00 +03:00
comfyanonymous 2881e61610
Store mp4 metadata at the beginning of the file when possible. (#15195) 2026-08-01 03:21:28 -04:00
comfyanonymous 235b466a0c
Add crf option to save video node. (#15191) 2026-08-01 00:27:48 -04:00
comfyanonymous a1c421994c
Expand k, v when attention backend would fall back to math because gqa. (#15190) 2026-07-31 15:17:56 -07:00
Alexander Piskun 6cedd34343
[Partner Nodes] fix(ByteDance): encode stereo reference audio without doubling its duration (#15177)
* [Partner Nodes] fix(ByteDance): encode stereo reference audio without doubling its duration

Signed-off-by: bigcat88 <bigcat88@icloud.com>
2026-07-31 21:57:45 +03:00
Daxiong (Lin) 0b73ae83a1
chore: update workflow templates to v0.11.23 (#15187) 2026-08-01 02:20:55 +08:00
rattus 7c806288d5
ops: apply the custom placeholder logic to Linux too (#15181)
Windows has proven this logic works for a long time and there are
corner cases where this materialization actual consumes real RAM
on linux.

Its not as bad as the original windows commit charge surge, but
its still a detectable transient leak. So simplify and unify.
2026-07-31 10:44:09 -07:00
rattus de5625a64a
Delay dynamic pin cleanup until model destruction (#15183) 2026-07-31 10:29:47 -07:00
Alexander Piskun 9bd9815eab
[Partner Nodes] chore(Bria): adjust pricing for other video endpoints (#15171)
Signed-off-by: bigcat88 <bigcat88@icloud.com>
2026-07-31 19:59:53 +03:00
blepping 831710d257
Don't assume sampler_function has a __name__ attribute in detail logging (#15179) 2026-07-31 19:12:17 +03:00
Terry Jia 5cc026f5b8
fix: resend cached histogram UI for CurveEditor after page refresh (#15152) 2026-07-31 03:07:31 -04:00
Daxiong (Lin) 7dd4627460
Add minimax h3 support (#15167) 2026-07-30 19:30:32 -07:00
Daxiong (Lin) b6fe23b4f1
chore: update workflow templates to v0.11.20 (#15165) 2026-07-30 19:27:06 -07:00
Alexander Piskun f65f45511b
[Partner Nodes] feat(Ideogram): add new P-Image model support (#15154) 2026-07-30 19:22:34 -07:00
Alexander Piskun 51d0405540
[Partner Nodes] chore(Bria): adjust pricing for the Bria Video Remove Background nodes (#15155) 2026-07-30 19:18:03 -07:00