Commit Graph

1595 Commits

Author SHA1 Message Date
Anton Hvornum 4d65639724
Fixes the crash on empty profile choice. Since generic_select() returns None, we can't pipe that into Profile() (at least not yet) 2021-04-22 10:31:32 +02:00
Anton Hvornum 46b872aa61 Re-working top-level-profile lambda to be a parameter to list_profiles() instead. When skipping a profile, None is returned from somewhere and it causes a glitch. So trying to figure out where and what by cleaning up a bit 2021-04-21 14:37:23 +02:00
SecondThundeR 8d9a542962 Add clarifying log text for generic_select 2021-04-20 17:10:28 +03:00
SecondThundeR 3facc2e58d Fix TabError issue after uncommenting 2021-04-20 15:25:46 +03:00
SecondThundeR 06e846796d Fix infinite loop on incorrect input of gateway IP 2021-04-20 15:07:52 +03:00
SecondThundeR 1d37e5a49e Uncomment new check for gateway IP address 2021-04-20 15:02:11 +03:00
SecondThundeR 1d04c92258 Add sort parameter for generic_select
Updated required features to support these change
2021-04-20 14:45:54 +03:00
SecondThundeR d2eacffff8 Update some functions
Here are list of changes:
- Added IP/subnet validation using Python's `ipaddress` module
- Added workaround for network configuration modes where user can enter DHCP or IP without brackets.
- Returned local printing options for some functions to keep `The above list...`
- Moved booleans for `generic_select` below options and text parameters
- Imported some functions from `archinstall` to reduce the`archinstall.` part of the lines.
- Reduced variable name length for simplicity
- Fixed some typos
2021-04-19 20:34:35 +03:00
SecondThundeR a316846121 Replace input with generic_select where necessary
Here are list of changes:
> From now on, `generic_select` will be called "Select function", for clarity

- Slightly updated select function
- Removed options output for some functions, where it's better to do with select function
- Added sorting for all lists passed to select function
- Replaced `dict.values()` with `dict` as options parameter
- Simplified input checking for all functions that use the select function
- Added temporary *(for now)* workaround for passing `?` and `help` inputs
- Merged fix for `partition.format()`
2021-04-17 16:35:21 +03:00
SecondThundeR 9991b19a06 Initial rework of generic_select function
Here are list of changes:
- Removed `sort` parameter, since every function has a sorted list in most cases
- Added two new parameters to disable local output of options items and allow empty input from the user by returning None
- Added a while loop, where it returns each time a RequirementError is raised
- Added log info for each input error to help figure out what the problem is
- Changed the check of the stripped input length to compare with 0, since the length cannot be less than 0
- Changed `isdigit` to `isnumeric`, which returns False if given digit is negative
- Slightly changed a check for an out of range error
- Removed displaying the list of available options when input is incorrect, in order to prevent the screen from overflowing
- Added log info if options list is empty
- Added log info if options are not dictionary or list
- Added dictionary values conversion to accept only list and dictionaries as option
- Added sorting dictionary values by default
2021-04-17 12:54:04 +03:00
Anton Hvornum 7be93adb99
Merge pull request #320 from SecondThundeR/language-select-fix
Fix selecting language layout by name
2021-04-17 08:03:45 +00:00
Владислав 6e5ea3aa65
Fix selecting language layout by name 2021-04-17 10:56:46 +03:00
Anton Hvornum 407290b034
Merge pull request #311 from dylanmtaylor/patch-5
These could affect whether the code builds/runs correctly
2021-04-16 07:54:52 +00:00
Dylan M. Taylor 88071ef9c0
.toml files could also possibly affect behavior. 2021-04-15 18:47:34 -04:00
Dylan M. Taylor 769a5b5f74
These could affect whether the code builds/runs correctly
They should not be ignored.
2021-04-15 18:46:44 -04:00
Anton Hvornum 65c6807cc9
Merge pull request #310 from SecondThundeR/workflow-features
Add ignore rules for iso-build.yaml
2021-04-15 19:07:12 +00:00
Anton Hvornum 3279de08ad
Revert `README` addition, it's catched by **.md 2021-04-15 21:07:06 +02:00
Anton Hvornum 0128ae6647
Added README to ignore 2021-04-15 20:55:36 +02:00
Владислав 6264099428
Add ignore rules for iso-build.yaml
These rules ignore all unrelated files and folders that are not needed to build the ISO.
2021-04-15 21:09:02 +03:00
Anton Hvornum 0f9b7a9c8e
Merge pull request #309 from SecondThundeR/readme-branch
Fix README table of content
2021-04-15 15:32:42 +00:00
SecondThundeR 0fd0fb05ff Fix README table of content
Also commented out the code responsible for centering the logo for future decisions
2021-04-15 18:12:36 +03:00
Anton Hvornum 6eab0290ae
Spelling error 2021-04-15 17:06:43 +02:00
Anton Hvornum c13f294ef5
Merge pull request #307 from dylanmtaylor/patch-5
Bump to 2.1.4
2021-04-15 14:02:36 +00:00
Dylan M. Taylor 1affee7c7b
Bump to 2.1.4 2021-04-15 10:00:57 -04:00
Anton Hvornum c9e1d4a8c3
Merge pull request #304 from advaithm/master
Fixing kbd layout issues and non-logical crashes in guided.py questions
2021-04-14 11:30:24 +00:00
Anton Hvornum 4e2c3c3dc7
Language issue 2021-04-14 13:26:14 +02:00
Anton Hvornum 3f101be225
Increased margin to facilitate error output 2021-04-14 13:21:15 +02:00
Anton Hvornum 12b43f443b
Removed layout filtering
This caused languages such as `be-latin1` to be hidden both in Search and direct input.
Because as an example that layout belongs to `azerty` and not `qwerty`.
2021-04-14 13:16:18 +02:00
Anton Hvornum 7f29f9d283
Added a default keyboard layout
This is just in case either the search step or the selector inputs nothing.
Something has to be set, and the default is US.
2021-04-14 13:14:12 +02:00
Anton Hvornum 1aadfa98c4
Added a safety net to language selection 2021-04-14 12:46:18 +02:00
Anton Hvornum 48c679d501
Updated README's minimal example 2021-04-14 12:17:17 +02:00
Anton Hvornum 5b3a122141
Updated the loop logic for mirrors
It wouldn't break out of the loop since the `valid_mirror` variable was never changed.
2021-04-14 12:08:37 +02:00
Anton Hvornum 99fb1304ea
Updated the loop logic for packages
It wouldn't loop over the question again, so correct for that.
2021-04-14 12:06:15 +02:00
Anton Hvornum c07d286f57
Modified return value back to {} 2021-04-14 11:58:51 +02:00
Anton Hvornum 91723e7dd9
Reverted back to raise 2021-04-14 11:55:40 +02:00
Anton Hvornum 7ae4b170b3
Removed excessive import
The exceptions are already exposed in `archinstall.<exception>`.
This might change in the future tho.
2021-04-14 11:53:31 +02:00
advaithm 7e12a2abc4
Merge branch 'master' of github.com:advaithm/archinstall 2021-04-14 14:48:11 +05:30
advaithm df3f7af91b
reworked mirror selection 2021-04-14 14:47:57 +05:30
Anton Hvornum c13c109bff
Removed a \t 2021-04-14 11:16:31 +02:00
Anton Hvornum 5aad809274
Converted back to a raise exception.
Since we simply forgot to actually call `raise` here (my bad) I think that will be better, and we handle it where we need to.
2021-04-14 11:10:09 +02:00
advaithm b08b2f3062
another patch for line 249 2021-04-14 14:29:46 +05:30
advaithm 78a9f0077e
fixed line 249 2021-04-14 14:21:53 +05:30
advaithm 8e9a09a8ff
typo 2021-04-14 14:18:18 +05:30
advaithm 85bcc58951
missed a merge 2021-04-14 14:16:11 +05:30
advaithm efd23e67d6
return {} not None 2021-04-14 14:07:22 +05:30
advaithm 757aa15f95
git automerge removed some important stuff 2021-04-14 14:05:37 +05:30
Anton Hvornum 82710fe381
Merge pull request #302 from dylanmtaylor/patch-5
Fix some more awesome installation issues
2021-04-14 08:28:38 +00:00
advaithm b292981de6
rebased to latest commits 2021-04-14 13:50:54 +05:30
advaithm 3347d04bfa
fixed issues raised in a review 2021-04-14 13:46:47 +05:30
Anton Hvornum af2671c1ec
Merge pull request #301 from dylanmtaylor/patch-3
Fix warning on BIOS/MBR systems
2021-04-14 05:52:23 +00:00