RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(test): snapshot.test.ts — forward the BrowserManager through the handleReadCommand bridge (same class as compare-board) 

Upstream v1.64.1.0 changed handleReadCommand's signature to (command, args, session, bm), but this file's local bridge still called it with the old 3-arg shape, leaving bm undefined. read-commands.ts:186's now-unconditional JS-origin assertion then TypeErrors on bm.hasCookieImports(), which is exactly the bug already fixed in compare-board.test.ts (8a37d902).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Stefan Andrei 2026-08-16 07:51:48 +03:00
parent e42e196eef
commit 715c8778ea
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
browse/test/snapshot.test.ts
View File

@ -14,7 +14,10 @@ import { handleMetaCommand } from '../src/meta-commands';
import * as fs from 'fs';
const handleReadCommand = (cmd: string, args: string[], b: BrowserManager) =>
_handleReadCommand(cmd, args, b.getActiveSession());
// Regression: the bridge must forward `b` — read-commands' now-unconditional
// JS-origin assertion calls bm.hasCookieImports(); omitting it TypeErrors
// every read.
_handleReadCommand(cmd, args, b.getActiveSession(), b);
const handleWriteCommand = (cmd: string, args: string[], b: BrowserManager) =>
_handleWriteCommand(cmd, args, b.getActiveSession(), b);