RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(test): observability check 11 floor 6 -> 5 after shell-free spawn removed promptFile unlink 

aa3bd6f0 deleted the prompt temp file (and its /* non-fatal */ marker) when it
dropped shell interpolation. The invariant — every runner I/O path wrapped
non-fatally — still holds at the 5 remaining sites, now named in the comment.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan 2026-08-07 13:29:34 -07:00
parent 718b821ce3
commit dc4be9c70d
No known key found for this signature in database
GPG Key ID: C1F69E85C74EFE1D
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/helpers/observability.test.ts
View File

@ -92,9 +92,10 @@ describe('session-runner observability', () => {
); );
// Count non-fatal comments — should be present for each new I/O path // Count non-fatal comments — should be present for each new I/O path
const nonFatalCount = (src.match(/\/\* non-fatal \*\//g) || []).length; const nonFatalCount = (src.match(/\/\* non-fatal \*\//g) || []).length;
// Original had 2 (promptFile unlink + failure transcript), we added 4 more // Five wrapped I/O sites: runDir creation, progress.log append, heartbeat
// (runDir creation, progress.log, heartbeat, NDJSON append) // write, per-test NDJSON append, failure-transcript write. (Was 6 until
expect(nonFatalCount).toBeGreaterThanOrEqual(6); // the shell-free spawn removed the promptFile unlink and its marker.)
expect(nonFatalCount).toBeGreaterThanOrEqual(5);
}); });
}); });