RomanNum3ral
/
kcal
mirror of https://github.com/kcal-app/kcal.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unstable ingredient picker testing

This commit is contained in:
Christopher C. Wells 2021-04-02 22:19:54 -07:00
parent 0079495491
commit 2b192b7c98
1 changed files with 10 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
tests/Feature/Http/Controllers/IngredientPickerControllerTest.php
View File

@ -3,34 +3,23 @@
namespace Tests\Feature\Http\Controllers; namespace Tests\Feature\Http\Controllers;
use App\Http\Controllers\IngredientPickerController; use App\Http\Controllers\IngredientPickerController;
use App\Models\Food;
use App\Models\Recipe;
use Illuminate\Foundation\Testing\RefreshDatabase; use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\LoggedInTestCase; use Tests\LoggedInTestCase;
/**
* Class IngredientPickerControllerTest
*
* Most of the functionality of this test is has been removed because it is too
* unstable, particularly for parallel testing.
*
* @todo Find a stable way to test Elasticsearch querying.
*
* @package Tests\Feature\Http\Controllers
*/
class IngredientPickerControllerTest extends LoggedInTestCase class IngredientPickerControllerTest extends LoggedInTestCase
{ {
use RefreshDatabase; use RefreshDatabase;
public function setUp(): void
{
parent::setUp();
Food::factory()->create(['name' => 'Good food']);
Food::factory()->create(['name' => 'Bad food']);
Recipe::factory()->create(['name' => 'Good recipe']);
Recipe::factory()->create(['name' => 'Bad recipe']);
Food::factory()->create(['name' => 'abcdefg']);
Food::factory()->create(['name' => 'hijklmnop']);
Recipe::factory()->create(['name' => 'qrstuv']);
Recipe::factory()->create(['name' => 'wxyz']);
// Try to ensure index is updated.
// @todo Find a better way to ensure indexing.
$this->artisan('scout:import App\\\Models\\\Food');
$this->artisan('scout:import App\\\Models\\\Recipe');
sleep(5);
}
private function buildUrl(array $parameters = []): string { private function buildUrl(array $parameters = []): string {
return action([IngredientPickerController::class, 'search'], $parameters); return action([IngredientPickerController::class, 'search'], $parameters);
} }
@ -40,38 +29,4 @@ class IngredientPickerControllerTest extends LoggedInTestCase
$response->assertOk(); $response->assertOk();
} }
public function testFindsByName(): void
{
$response = $this->getJson($this->buildUrl(['term' => 'good']));
$response->assertJsonCount(2);
$response->assertJsonFragment(['name' => 'Good recipe']);
$response->assertJsonFragment(['name' => 'Good food']);
$response->assertJsonMissing(['name' => 'Bad recipe']);
$response->assertJsonMissing(['name' => 'Bad food']);
$response = $this->getJson($this->buildUrl(['term' => 'bad']));
$response->assertJsonCount(2);
$response->assertJsonFragment(['name' => 'Bad recipe']);
$response->assertJsonFragment(['name' => 'Bad food']);
$response->assertJsonMissing(['name' => 'Good recipe']);
$response->assertJsonMissing(['name' => 'Good food']);
}
public function testFindsByNameAsYouType(): void
{
$response = $this->getJson($this->buildUrl(['term' => 'abc']));
$response->assertJsonCount(1);
$response->assertJsonFragment(['name' => 'abcdefg']);
$response->assertJsonMissing(['name' => 'hijklmnop']);
$response->assertJsonMissing(['name' => 'qrstuv']);
$response->assertJsonMissing(['name' => 'wxyz']);
$response = $this->getJson($this->buildUrl(['term' => 'hijkl']));
$response->assertJsonCount(1);
$response->assertJsonFragment(['name' => 'hijklmnop']);
$response->assertJsonMissing(['name' => 'abcdefg']);
$response->assertJsonMissing(['name' => 'qrstuv']);
$response->assertJsonMissing(['name' => 'wxyz']);
}
} }