RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: clean up comments in resolver test

This commit is contained in:
tanishqtayade 2026-06-26 13:15:44 +05:30
parent 9944e28a06
commit 48913efb7d
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_resolver.py
View File

@ -56,9 +56,7 @@ def test_caching_hostname_resolver_no_addresses_not_cached():
def test_caching_hostname_resolver_dnscache_disabled_rejects_storage():
# Regression test for LocalCache(limit=0) rejecting storage
# when DNSCACHE_ENABLED=False. _CachingResolutionReceiver writes
# directly to dnscache, so we verify nothing is stored.
def fake_resolve(receiver, *_):
receiver.resolutionBegan(Mock())
receiver.addressResolved(Mock())
@ -68,10 +66,8 @@ def test_caching_hostname_resolver_dnscache_disabled_rejects_storage():
reactor = Mock()
reactor.nameResolver.resolveHostName.side_effect = fake_resolve
# cache_size=0 simulates DNSCACHE_ENABLED=False
resolver = CachingHostnameResolver(reactor, cache_size=0)
resolver.resolveHostName(Mock(), "example.com")
# dnscache should remain empty despite address being resolved
assert "example.com" not in dnscache
assert len(dnscache) == 0