mirror of https://github.com/scrapy/scrapy.git
Remove IFeedStorage from the tests.
This commit is contained in:
parent
9c0b55af0b
commit
7f0e998662
|
|
@ -20,7 +20,6 @@ import lxml.etree
|
|||
import pytest
|
||||
from testfixtures import LogCapture
|
||||
from w3lib.url import file_uri_to_path
|
||||
from zope.interface import implementer
|
||||
|
||||
import scrapy
|
||||
from scrapy import Spider, signals
|
||||
|
|
@ -31,7 +30,6 @@ from scrapy.extensions.feedexport import (
|
|||
FeedExporter,
|
||||
FeedSlot,
|
||||
FileFeedStorage,
|
||||
IFeedStorage,
|
||||
)
|
||||
from scrapy.utils.python import to_unicode
|
||||
from scrapy.utils.test import get_crawler
|
||||
|
|
@ -91,7 +89,6 @@ class FailingBlockingFeedStorage(DummyBlockingFeedStorage):
|
|||
raise OSError("Cannot store")
|
||||
|
||||
|
||||
@implementer(IFeedStorage)
|
||||
class LogOnStoreFileStorage:
|
||||
"""
|
||||
This storage logs inside `store` method.
|
||||
|
|
@ -1234,7 +1231,6 @@ class TestFeedExport(TestFeedExportBase):
|
|||
|
||||
@coroutine_test
|
||||
async def test_storage_file_no_postprocessing(self):
|
||||
@implementer(IFeedStorage)
|
||||
class Storage:
|
||||
def __init__(self, uri, *, feed_options=None):
|
||||
pass
|
||||
|
|
@ -1256,7 +1252,6 @@ class TestFeedExport(TestFeedExportBase):
|
|||
|
||||
@coroutine_test
|
||||
async def test_storage_file_postprocessing(self):
|
||||
@implementer(IFeedStorage)
|
||||
class Storage:
|
||||
def __init__(self, uri, *, feed_options=None):
|
||||
pass
|
||||
|
|
|
|||
|
|
@ -12,12 +12,11 @@ from urllib.parse import urljoin
|
|||
import lxml.etree
|
||||
import pytest
|
||||
from packaging.version import Version
|
||||
from zope.interface.verify import verifyObject
|
||||
|
||||
import scrapy
|
||||
from scrapy import Spider
|
||||
from scrapy.exceptions import NotConfigured
|
||||
from scrapy.extensions.feedexport import FeedExporter, IFeedStorage, S3FeedStorage
|
||||
from scrapy.extensions.feedexport import FeedExporter, S3FeedStorage
|
||||
from scrapy.settings import Settings
|
||||
from scrapy.utils.python import to_unicode
|
||||
from scrapy.utils.test import get_crawler
|
||||
|
|
@ -435,9 +434,6 @@ class TestBatchDeliveries(TestFeedExportBase):
|
|||
},
|
||||
},
|
||||
}
|
||||
crawler = get_crawler(settings_dict=settings)
|
||||
storage = S3FeedStorage.from_crawler(crawler, uri)
|
||||
verifyObject(IFeedStorage, storage)
|
||||
|
||||
class TestSpider(scrapy.Spider):
|
||||
name = "testspider"
|
||||
|
|
|
|||
|
|
@ -12,7 +12,6 @@ from urllib.parse import quote
|
|||
import pytest
|
||||
from testfixtures import LogCapture
|
||||
from w3lib.url import path_to_file_uri
|
||||
from zope.interface.verify import verifyObject
|
||||
|
||||
import scrapy
|
||||
from scrapy.extensions.feedexport import (
|
||||
|
|
@ -20,7 +19,6 @@ from scrapy.extensions.feedexport import (
|
|||
FileFeedStorage,
|
||||
FTPFeedStorage,
|
||||
GCSFeedStorage,
|
||||
IFeedStorage,
|
||||
S3FeedStorage,
|
||||
StdoutFeedStorage,
|
||||
)
|
||||
|
|
@ -71,11 +69,6 @@ class TestFileFeedStorage:
|
|||
finally:
|
||||
os.chdir(old_cwd)
|
||||
|
||||
def test_interface(self, tmp_path):
|
||||
path = tmp_path / "file.txt"
|
||||
st = FileFeedStorage(str(path))
|
||||
verifyObject(IFeedStorage, st)
|
||||
|
||||
@staticmethod
|
||||
def _store(path: Path, feed_options: dict[str, Any] | None = None) -> None:
|
||||
storage = FileFeedStorage(str(path), feed_options=feed_options)
|
||||
|
|
@ -131,7 +124,6 @@ class TestFTPFeedStorage:
|
|||
uri,
|
||||
feed_options=feed_options,
|
||||
)
|
||||
verifyObject(IFeedStorage, storage)
|
||||
spider = self.get_test_spider()
|
||||
file = storage.open(spider)
|
||||
file.write(content)
|
||||
|
|
@ -275,7 +267,6 @@ class TestS3FeedStorage:
|
|||
bucket = "mybucket"
|
||||
key = "export.csv"
|
||||
storage = S3FeedStorage.from_crawler(crawler, f"s3://{bucket}/{key}")
|
||||
verifyObject(IFeedStorage, storage)
|
||||
|
||||
file = mock.MagicMock()
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue