RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Move stats & log init into crawl()" 

This reverts commit 2c68c95cad.
This commit is contained in:
Jakob de Maeyer 2015-11-09 16:26:55 +01:00
parent 2c68c95cad
commit aafb31d6fb
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
scrapy/crawler.py
View File

@ -31,6 +31,17 @@ class Crawler(object):
self.settings = settings.copy()
self.signals = SignalManager(self)
self.stats = load_object(self.settings['STATS_CLASS'])(self)
handler = LogCounterHandler(self, level=settings.get('LOG_LEVEL'))
logging.root.addHandler(handler)
# lambda is assigned to Crawler attribute because this way it is not
# garbage collected after leaving __init__ scope
self.__remove_handler = lambda: logging.root.removeHandler(handler)
self.signals.connect(self.__remove_handler, signals.engine_stopped)
lf_cls = load_object(self.settings['LOG_FORMATTER'])
self.logformatter = lf_cls.from_crawler(self)
self.crawling = False
self.spider = None
@ -63,20 +74,6 @@ class Crawler(object):
self.spider = self._create_spider(*args, **kwargs)
self.spider.update_settings(self.settings)
self.settings.freeze()
self.stats = load_object(self.settings['STATS_CLASS'])(self)
handler = LogCounterHandler(self,
level=self.settings.get('LOG_LEVEL'))
logging.root.addHandler(handler)
# lambda is assigned to Crawler attribute because this way it is not
# garbage collected after leaving __init__ scope
self.__remove_handler = lambda: logging.root.removeHandler(handler)
self.signals.connect(self.__remove_handler, signals.engine_stopped)
lf_cls = load_object(self.settings['LOG_FORMATTER'])
self.logformatter = lf_cls.from_crawler(self)
self.extensions = ExtensionManager.from_crawler(self)
self.engine = self._create_engine()