Commit Graph

7843 Commits

Author SHA1 Message Date
Andrey Rakhmatullin 36dcf90184 Also test non-default async callbacks. 2020-02-11 01:00:16 +05:00
Adrián Chaves 4c6993f264
Merge branch 'master' into asyncio-parse-asyncgen 2020-02-07 21:34:54 +01:00
Mikhail Korobov b0eaf114e5
Merge pull request #4197 from elacuesta/sphinx-twisted-api
[Docs] Fix Twisted links
2020-02-07 23:51:15 +05:00
Mikhail Korobov bd7780277c
Merge pull request #4275 from abhishekh2001/master
Fixed artwork/README formatting
2020-02-07 23:44:15 +05:00
Mikhail Korobov 7e341e0f6b
Merge pull request #4291 from seregaxvm/master
add zsh -h autocomplete option
2020-02-07 23:42:10 +05:00
Mikhail Korobov c3b690a5b5
Merge pull request #4290 from dekimsey/patch-1
FilesPipeline.file_path has optional arguments
2020-02-07 23:41:31 +05:00
Mikhail Korobov 957681bcfa
Merge pull request #4272 from elacuesta/spider-middleware
Spider middleware: catch spider callback exceptions early
2020-02-07 23:40:50 +05:00
Mikhail Korobov afbaf9d430
Merge pull request #4303 from whalebot-helmsman/request_left_downloader_signal
request_left_downloader signal
2020-02-07 23:33:51 +05:00
Mikhail Korobov 0f62e44def
Merge pull request #4316 from wRAR/asyncio-parse-request-tests
Add a test for an async callbacks that returns requests.
2020-02-07 23:22:19 +05:00
Andrey Rakhmatullin 7323780c97 Support yield in async def callbacks. 2020-02-07 21:32:45 +05:00
Andrey Rakhmatullin 31f6c7112f Add a test for an async callbacks that returns requests. 2020-02-07 17:14:52 +05:00
Vostretsov Nikita 153b78e53f
Update docs/topics/signals.rst
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
2020-02-07 11:08:55 +05:00
Vostretsov Nikita 8817b9e8e9
Update docs/topics/signals.rst
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-02-07 11:07:53 +05:00
Vostretsov Nikita 2f83f3e2cb
Update docs/topics/signals.rst
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-02-07 11:07:43 +05:00
Vostretsov Nikita 84b55b7364
Update docs/topics/signals.rst
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-02-07 11:07:35 +05:00
Joy Bhalla 4f31c3ce01
Document a backward incompatibility that may affect custom schedulers (#4274) 2020-02-06 22:21:33 +01:00
Lane Shaw 3263441fbc
Update RFPDupeFilter line separator for correct universal newlines mode usage (#4283) 2020-02-06 22:14:40 +01:00
Mikhail Korobov 042e71e2b8
Merge pull request #4311 from Gallaecio/metarefresh-ignore-tags
Make METAREFRESH_IGNORE_TAGS an empty list by default
2020-02-06 23:40:45 +05:00
Mikhail Korobov 8d2705f23c
Merge pull request #4305 from Respawnz/patch-1
fix a typo in devloper-tools.rst
2020-02-06 23:17:28 +05:00
elacuesta 35dafef7f1
Specify Twisted reactor (TWISTED_REACTOR setting) (#4294)
* Add the ability to install a specific reactor

* Add docs for the TWISTED_REACTOR setting

* Add tests for the TWISTED_REACTOR setting

* Update asyncio reactor test

* Ignore W503 globally

W503 is not PEP8-compliant:
c59c4376ad

* Line length adjustment

* Adjust asyncio reactor tests

* Merge ASYNCIO_ENABLED and TWISTED_REACTOR settings

* More docs about TWISTED_REACTOR

* Fix asyncio reactor test

* Docs: fix title

* Reword docs

* Check the TWISTED_REACTOR setting outside of the installing function

* Remove unrelated change

* Update scrapy/utils/log.py

Co-Authored-By: Adrián Chaves <adrian@chaves.io>

* Update docs/topics/settings.rst

Co-Authored-By: Adrián Chaves <adrian@chaves.io>

* Update docs/topics/settings.rst

Co-Authored-By: Adrián Chaves <adrian@chaves.io>

Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-02-06 22:42:34 +05:00
Vostretsov Nikita 4be19e443e name signla catcher in accord with signal name 2020-02-06 13:46:23 +00:00
Vostretsov Nikita 4bcc0933d9 Merge branch 'request_left_downloader_signal' of github.com:whalebot-helmsman/scrapy into request_left_downloader_signal 2020-02-06 13:45:00 +00:00
Vostretsov Nikita 4a91a5427d fix typo 2020-02-06 13:44:51 +00:00
Vostretsov Nikita 6733f4d976
Update docs/topics/signals.rst
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
2020-02-06 18:40:42 +05:00
Mikhail Korobov bbbb8f1418
Merge pull request #4304 from elacuesta/remove-six-from-tox-ini
Remove elusive six occurrence from tox.ini
2020-02-06 17:09:57 +05:00
Adrián Chaves 576663e5a7 Make METAREFRESH_IGNORE_TAGS an empty list by default 2020-02-06 10:43:20 +01:00
Respawnz c2cca36821
typo 2020-02-06 05:39:15 +08:00
Eugenio Lacuesta 11941c3244
Remove elusive six occurrence from tox.ini 2020-02-05 13:27:54 -03:00
Vostretsov Nikita 3769f75386 pep8 E302 2020-02-05 12:08:08 +00:00
Vostretsov Nikita aab39f6341 docummentation for new signal 2020-02-05 11:35:03 +00:00
Vostretsov Nikita 9916f6e556 tests for new signal 2020-02-05 11:32:54 +00:00
Vostretsov Nikita ae04174884 emit new signal 2020-02-05 11:32:31 +00:00
Vostretsov Nikita 898bc00811 new signal 2020-02-05 11:31:27 +00:00
Eugenio Lacuesta fbea370c58
Rename function parameter 2020-02-05 01:35:13 -03:00
Mikhail Korobov 22f7934fcc
Merge pull request #4269 from wRAR/asyncio-parse
Support for async def callbacks.
2020-01-31 23:50:19 +05:00
Andrey Rakhmatullin cc825c21de Test returning items from an async def callback. 2020-01-30 16:17:06 +05:00
Mikhail Korobov 47b9de93a9
Merge pull request #4288 from petervandenabeele/patch-1
[Docs] 2 typos + 1 clarification in docs
2020-01-30 03:15:18 +05:00
Mikhail Korobov 534ce07b10
Merge pull request #4293 from edorofeev/fix-accept-encoding-delimiter
[HttpCompressionMiddleware] fix delimiter for Accept-Encoding header
2020-01-30 00:19:40 +05:00
Evgeny Dorofeev 4e56571a19 [HttpCompressionMiddleware] fix delimiter for Accept-Encoding header 2020-01-29 15:49:22 +03:00
Daniel Kimsey 752e8f7018 FilesPipeline.file_path has optional arguments
Documented signature doesn't match the actual interface in [files.py](https://github.com/scrapy/scrapy/blob/master/scrapy/pipelines/files.py#L520).

Specifically, it looks like it may be [called](https://github.com/scrapy/scrapy/blob/master/scrapy/pipelines/files.py#L422) without a response value.

I found this when I was implementing the pipeline with the signature `file_path(self, request, response, info)` and the following error was being return in my results :

    [(False, <twisted.python.failure.Failure builtins.TypeError: file_path() missing 1 required positional argument: 'response'>)]

Scrapy==1.8.0
2020-01-28 15:21:15 -06:00
Kevin Lloyd Bernal a3b168948c Log an error when giving up requests after too many retries (#3566) 2020-01-28 21:53:25 +01:00
Eugenio Lacuesta ad4477d335
Remove unnecessary else 2020-01-27 14:16:43 -03:00
Mikhail Korobov a6bf895474
Merge pull request #4286 from petervandenabeele/fix-documentation
[Docs] Fix variable name `author_page_links`
2020-01-27 20:57:22 +05:00
Matsievskiy S.V c9d3652230 add zsh -h autocomplete option 2020-01-27 18:24:57 +03:00
Peter Vandenabeele f72d4e93e6
[Docs] 2 typos + 1 clarification in docs
Fixing 2 small typos and adding 1 word as clarification in the downloader-middlewares.

Also, I was confused with the entries like `ref:Reppy <reppy-parser>` and similar entries.
Are these supposed to be links to other parts of the doc, or is this the intended way of showing these references ?
2020-01-26 10:48:28 +01:00
Peter Vandenabeele f3374a5047 Fix variable name `author_page_links`
I did not test this code, but the change from `href` to this
author_page_links seems to have a typo ?
2020-01-25 16:53:29 +01:00
Mikhail Korobov 8b8df31961
Merge pull request #4227 from elacuesta/name-resolver
Name resolver with IPv6 support
2020-01-25 05:03:13 +05:00
Mikhail Korobov 5f407cf657
Merge pull request #3961 from OmarFarrag/ftp_files#3928
Add FTPFileStore to FilesPipeline
2020-01-25 04:58:23 +05:00
Mikhail Korobov 7a62bd310c
Merge pull request #4126 from elacuesta/from_crawler_downloader_handlers
Download handlers: from_crawler factory method, take crawler in __init__
2020-01-25 04:52:56 +05:00
OmarFarrag 9e6d5573f1 Fix Flake8 errors 2020-01-24 15:58:52 +02:00