Commit Graph

8122 Commits

Author SHA1 Message Date
Adrián Chaves 7701c39655
Merge branch 'master' into common_commands 2020-05-15 13:44:45 +02:00
Eugenio Lacuesta 3d58e5e3be
Merge pull request #4545 from elacuesta/flake8-remove-e128
Flake8: Remove E128
2020-05-14 13:28:50 -03:00
Eugenio Lacuesta 89d0c98f7a
Merge remote-tracking branch 'upstream/master' into flake8-remove-e128 2020-05-14 11:35:30 -03:00
Eugenio Lacuesta 602bb13bdc
Merge pull request #4558 from elacuesta/flake8-remove-e741
Flake8: Remove E741
2020-05-14 11:26:59 -03:00
Eugenio Lacuesta df8a1d1c01
Flake8: Remove E741 2020-05-14 10:40:50 -03:00
Eugenio Lacuesta cfe4bf7e50
Merge pull request #4572 from noviluni/add_missed_flake8_rules
Flake8: remove E306 and F523
2020-05-14 10:38:55 -03:00
Adrián Chaves e31b6ccc45
Merge branch 'master' into flake8-remove-e128 2020-05-13 22:39:45 +02:00
marc 8971878c1d fix new detected flake8 cases 2020-05-13 14:11:10 +02:00
Andrey Rahmatullin 519f752d6d
Merge pull request #4566 from elacuesta/flake8-remove-f841
Flake8: remove F841
2020-05-13 11:46:48 +05:00
Aditya Kumar 8d1269bcbc
Cover chompjs in documentation (#4562) 2020-05-12 20:42:28 +02:00
Aditya Kumar 97532a9144
test(spiderloader): no duplicate spider names (#4560) 2020-05-12 17:10:09 +02:00
Jay Rajput 07e125f4c9 Travis CI fixes in __init__.py 2020-05-12 16:31:56 +05:30
Jay Rajput 28d223dd87
Update __init__.py 2020-05-12 15:28:22 +05:30
Jay Rajput e01c30f0d5
Update scrapy/commands/__init__.py
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-05-12 01:05:20 +05:30
willbeaufoy cf9be5344a
Prevent create_instance() returning None (#4532)
Currently create_instance() can return None if an extension is
incorrectly implemented, but the extension will still show up as
enabled in the logs. This can cause confusion, as in the linked bug.

This change prevents this occurring by throwing an error if
create_instance() will return None.
2020-05-11 20:35:25 +02:00
nsirletti cb8140a42a
Deprecate Response.body_as_unicode() (#4555)
Co-authored-by: Nicolas Sirletti <n.sirletti@gmail.com>
2020-05-11 20:20:31 +02:00
Eugenio Lacuesta 6f8758624c
Flake8: remove F841 2020-05-11 13:50:34 -03:00
Eugenio Lacuesta 25e9bc2d0d
Merge branch 'master' into flake8-remove-e128 2020-05-11 13:23:57 -03:00
Mikhail Korobov 892467cb8a
Merge pull request #4541 from elacuesta/pickle-adjustments
Pickle: use protocol 4, update tests
2020-05-11 15:16:14 +05:00
Mikhail Korobov b183579564
Merge pull request #4205 from elacuesta/bytes_received_signal
Add bytes_received signal
2020-05-11 15:09:55 +05:00
Jay Rajput 02ac6664a5 Travis CI fixes 2020-05-10 00:26:48 +05:30
Jay Rajput ed4f4f8408 Applied suggested format changes 2020-05-10 00:08:34 +05:30
Jay Rajput 92792cc3f7 Moved common_commands.py to __init__.py 2020-05-09 17:28:10 +05:30
Eugenio Lacuesta be39f274b8
Merge branch 'master' into flake8-remove-e128 2020-05-08 18:33:29 -03:00
Mikhail Korobov 794ab19660
Merge pull request #3727 from Gallaecio/pylint
Use pylint
2020-05-09 02:22:54 +05:00
Mikhail Korobov 333910f6c8
Merge pull request #4554 from elacuesta/linkextractor-remove-lambdas
Remove lambda attributes in default link extractor
2020-05-09 02:11:59 +05:00
Mikhail Korobov 707f591767
Merge pull request #4557 from elacuesta/flake8-remove-e1xx
Flake8: remove E111, E114, E116, E117, E121
2020-05-09 02:08:27 +05:00
Eugenio Lacuesta c2c3054ac1
Flake8: remove E121 2020-05-08 16:43:47 -03:00
Eugenio Lacuesta 83ce82f400
Flake8: remove E114 and E117 (unused) 2020-05-08 16:43:28 -03:00
Eugenio Lacuesta 1a157f2e26
Flake8: remove E116 2020-05-08 16:42:56 -03:00
Eugenio Lacuesta 81d0b2f61a
Flake8: remove E111 2020-05-08 16:42:50 -03:00
Eugenio Lacuesta 3ebf2a0d82
Remove lambdas in link extractor 2020-05-08 15:24:37 -03:00
Eugenio Lacuesta b852fff6f8
Style changes in link extractor 2020-05-08 15:22:41 -03:00
Antonio Gordillo Toledo cf09af787e
Remove Python 2 encoding header from files (#4553) 2020-05-08 15:45:19 +02:00
Jay Rajput dcf7235f0e Code sharing between crawl and runspider command 2020-05-08 01:48:23 +05:30
Eugenio Lacuesta 38f01dd243
Merge remote-tracking branch 'upstream/master' into flake8-remove-e128 2020-05-07 14:52:31 -03:00
Mikhail Korobov 77492cd945
Merge pull request #4543 from elacuesta/flake8-remove-e126
Flake8: remove E126
2020-05-07 22:14:51 +05:00
Eugenio Lacuesta 8b4485134e
Merge branch 'flake8-remove-e126' into flake8-remove-e128 2020-05-07 12:50:20 -03:00
Eugenio Lacuesta e0127a3123
Refactor warnings in spiderloader 2020-05-07 12:48:43 -03:00
Eugenio Lacuesta 8659b0d896
Merge remote-tracking branch 'upstream/master' into flake8-remove-e126 2020-05-07 09:24:38 -03:00
Eugenio Lacuesta 422e6429b5
Add mising len check in spiderloader 2020-05-07 09:22:14 -03:00
Adrián Chaves b59dfb75fa Update disabled Pylint checks 2020-05-07 14:15:37 +02:00
Mikhail Korobov a8f61e909f
Merge pull request #4544 from elacuesta/flake8-remove-e129
Flake8: remove E129
2020-05-07 15:08:11 +05:00
Mikhail Korobov a18bfccac2
Merge pull request #4542 from elacuesta/flake8-remove-e122-e124
Flake8: remove E122 and E124
2020-05-07 15:05:01 +05:00
Eugenio Lacuesta 7fd2085725
Merge remote-tracking branch 'upstream/master' into bytes_received_signal 2020-05-06 22:41:16 -03:00
Eugenio Lacuesta d472402a02
Fix pickle test for pypy 2020-05-06 20:30:22 -03:00
Eugenio Lacuesta 881b4f417f
Flake8: Remove E128 (tests, part 3) 2020-05-06 19:33:22 -03:00
Eugenio Lacuesta bf56517abf
Flake8: Remove E128 (tests, part 2) 2020-05-06 19:18:29 -03:00
Mikhail Korobov 2da952b928
Merge pull request #4519 from Gallaecio/test-ubuntu-bionic
Test the latest Ubuntu along the latest Python
2020-05-07 03:12:19 +05:00
Eugenio Lacuesta 9c6d13075a
Flake8: Remove E128 (tests, part 1) 2020-05-06 18:56:14 -03:00