Eugenio Lacuesta
89d0c98f7a
Merge remote-tracking branch 'upstream/master' into flake8-remove-e128
2020-05-14 11:35:30 -03:00
Eugenio Lacuesta
df8a1d1c01
Flake8: Remove E741
2020-05-14 10:40:50 -03:00
Adrián Chaves
e31b6ccc45
Merge branch 'master' into flake8-remove-e128
2020-05-13 22:39:45 +02:00
Andrey Rahmatullin
519f752d6d
Merge pull request #4566 from elacuesta/flake8-remove-f841
...
Flake8: remove F841
2020-05-13 11:46:48 +05:00
Aditya Kumar
97532a9144
test(spiderloader): no duplicate spider names ( #4560 )
2020-05-12 17:10:09 +02:00
willbeaufoy
cf9be5344a
Prevent create_instance() returning None ( #4532 )
...
Currently create_instance() can return None if an extension is
incorrectly implemented, but the extension will still show up as
enabled in the logs. This can cause confusion, as in the linked bug.
This change prevents this occurring by throwing an error if
create_instance() will return None.
2020-05-11 20:35:25 +02:00
nsirletti
cb8140a42a
Deprecate Response.body_as_unicode() ( #4555 )
...
Co-authored-by: Nicolas Sirletti <n.sirletti@gmail.com>
2020-05-11 20:20:31 +02:00
Eugenio Lacuesta
6f8758624c
Flake8: remove F841
2020-05-11 13:50:34 -03:00
Eugenio Lacuesta
25e9bc2d0d
Merge branch 'master' into flake8-remove-e128
2020-05-11 13:23:57 -03:00
Mikhail Korobov
892467cb8a
Merge pull request #4541 from elacuesta/pickle-adjustments
...
Pickle: use protocol 4, update tests
2020-05-11 15:16:14 +05:00
Mikhail Korobov
b183579564
Merge pull request #4205 from elacuesta/bytes_received_signal
...
Add bytes_received signal
2020-05-11 15:09:55 +05:00
Eugenio Lacuesta
be39f274b8
Merge branch 'master' into flake8-remove-e128
2020-05-08 18:33:29 -03:00
Mikhail Korobov
333910f6c8
Merge pull request #4554 from elacuesta/linkextractor-remove-lambdas
...
Remove lambda attributes in default link extractor
2020-05-09 02:11:59 +05:00
Eugenio Lacuesta
c2c3054ac1
Flake8: remove E121
2020-05-08 16:43:47 -03:00
Eugenio Lacuesta
3ebf2a0d82
Remove lambdas in link extractor
2020-05-08 15:24:37 -03:00
Antonio Gordillo Toledo
cf09af787e
Remove Python 2 encoding header from files ( #4553 )
2020-05-08 15:45:19 +02:00
Eugenio Lacuesta
8b4485134e
Merge branch 'flake8-remove-e126' into flake8-remove-e128
2020-05-07 12:50:20 -03:00
Eugenio Lacuesta
8659b0d896
Merge remote-tracking branch 'upstream/master' into flake8-remove-e126
2020-05-07 09:24:38 -03:00
Mikhail Korobov
a8f61e909f
Merge pull request #4544 from elacuesta/flake8-remove-e129
...
Flake8: remove E129
2020-05-07 15:08:11 +05:00
Mikhail Korobov
a18bfccac2
Merge pull request #4542 from elacuesta/flake8-remove-e122-e124
...
Flake8: remove E122 and E124
2020-05-07 15:05:01 +05:00
Eugenio Lacuesta
7fd2085725
Merge remote-tracking branch 'upstream/master' into bytes_received_signal
2020-05-06 22:41:16 -03:00
Eugenio Lacuesta
d472402a02
Fix pickle test for pypy
2020-05-06 20:30:22 -03:00
Eugenio Lacuesta
881b4f417f
Flake8: Remove E128 (tests, part 3)
2020-05-06 19:33:22 -03:00
Eugenio Lacuesta
bf56517abf
Flake8: Remove E128 (tests, part 2)
2020-05-06 19:18:29 -03:00
Mikhail Korobov
2da952b928
Merge pull request #4519 from Gallaecio/test-ubuntu-bionic
...
Test the latest Ubuntu along the latest Python
2020-05-07 03:12:19 +05:00
Eugenio Lacuesta
9c6d13075a
Flake8: Remove E128 (tests, part 1)
2020-05-06 18:56:14 -03:00
Eugenio Lacuesta
88efc98847
Flake8: remove E129
2020-05-06 16:42:47 -03:00
Eugenio Lacuesta
4c12a234ae
Flake8: Remove E126
2020-05-06 16:10:21 -03:00
Eugenio Lacuesta
cc23d1cb58
Flake8: Remove E124
2020-05-06 15:40:37 -03:00
Eugenio Lacuesta
d71804ef29
Flake8: Remove E122
2020-05-06 15:23:36 -03:00
Eugenio Lacuesta
0e382c8160
Remove unused import
2020-05-06 14:09:10 -03:00
Eugenio Lacuesta
93436f9d3a
Chain pickling exception, test_squeues.py updates
2020-05-06 14:05:27 -03:00
Eugenio Lacuesta
b1ddd7bd7b
Refactor test_squeues.py
2020-05-06 13:44:02 -03:00
Eugenio Lacuesta
8643e8d355
Flake8: remove E123 (Closing bracket does not match indentation of opening bracket's line)
2020-05-06 12:26:04 -03:00
Eugenio Lacuesta
63600243e0
Flake8: remove E125 (Continuation line with same indent as next logical line)
...
Also remove E401 from pytest.ini - no occurrences in the codebase
2020-05-06 10:26:52 -03:00
Eugenio Lacuesta
fe0c582ee0
Flake8: remove E127 in tests (continuation line over-indented for visual indent)
2020-05-06 09:49:10 -03:00
Adrián Chaves
98835a0d40
Merge branch 'master' into test-ubuntu-bionic
2020-05-06 13:59:01 +02:00
Eugenio Lacuesta
17c0cf64ae
Flake8: remove W504 code ( #4525 )
...
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-05-06 00:14:48 +02:00
Eugenio Lacuesta
4d625afda5
Merge branch 'master' into bytes_received_signal
2020-05-01 16:11:32 -03:00
Eugenio Lacuesta
f787b8483c
IPv6 test: check for the absence of DNSLookupError
2020-04-28 17:50:06 +02:00
Eugenio Lacuesta
efb6f13deb
Remove assertions from production code ( #4440 )
2020-04-23 12:40:10 +02:00
Mikhail Korobov
209ab05315
Merge pull request #4500 from victor-torres/reference-callback
...
Serialize requests with callback references as spider attribute
2020-04-17 18:58:28 +05:00
Victor Torres
1ade3fc723
trying to improve test coverage
2020-04-17 10:34:34 -03:00
Mikhail Korobov
cf39602c30
Merge pull request #4471 from elacuesta/fix-pycodestyle-e731
...
Fix pycodestyle E731 ("do not assign a lambda expression, use a def")
2020-04-16 23:17:31 +05:00
Eugenio Lacuesta
c922992277
Tests: Move code inside __main__ block
2020-04-16 11:37:37 -03:00
Eugenio Lacuesta
1f2e2a6006
Merge branch 'master' into response_ip_address
2020-04-16 11:32:37 -03:00
Victor Torres
e0921cab66
remove not used code
...
This code is not needed anymore because we're getting the
already mangled name when matching func with spider attributes.
2020-04-16 11:18:59 -03:00
Victor Torres
47a992615a
serialize requests with callback references as spider attribute
...
You could define a spider attribute that references a callback method
but if this method has a different name than your spider attribute,
the request serializer is not able to find it on the spider class.
With this commit we're fixing this behavior as we're searching for
callback references in the spider object itself instead of looking
for attributes with the same function's name, that could be different.
2020-04-15 20:03:58 -03:00
Mikhail Korobov
2d46777d0a
Merge pull request #4489 from elacuesta/remove-returnValue-function
...
Remove twisted.internet.defer.returnValue occurrences
2020-04-15 22:45:52 +05:00
Adrián Chaves
d323a57381
Merge branch 'master' into fix-pycodestyle-e731
2020-04-15 14:16:15 +02:00