Commit Graph

8092 Commits

Author SHA1 Message Date
Aditya Kumar 8d1269bcbc
Cover chompjs in documentation (#4562) 2020-05-12 20:42:28 +02:00
Aditya Kumar 97532a9144
test(spiderloader): no duplicate spider names (#4560) 2020-05-12 17:10:09 +02:00
willbeaufoy cf9be5344a
Prevent create_instance() returning None (#4532)
Currently create_instance() can return None if an extension is
incorrectly implemented, but the extension will still show up as
enabled in the logs. This can cause confusion, as in the linked bug.

This change prevents this occurring by throwing an error if
create_instance() will return None.
2020-05-11 20:35:25 +02:00
nsirletti cb8140a42a
Deprecate Response.body_as_unicode() (#4555)
Co-authored-by: Nicolas Sirletti <n.sirletti@gmail.com>
2020-05-11 20:20:31 +02:00
Mikhail Korobov 892467cb8a
Merge pull request #4541 from elacuesta/pickle-adjustments
Pickle: use protocol 4, update tests
2020-05-11 15:16:14 +05:00
Mikhail Korobov b183579564
Merge pull request #4205 from elacuesta/bytes_received_signal
Add bytes_received signal
2020-05-11 15:09:55 +05:00
Mikhail Korobov 794ab19660
Merge pull request #3727 from Gallaecio/pylint
Use pylint
2020-05-09 02:22:54 +05:00
Mikhail Korobov 333910f6c8
Merge pull request #4554 from elacuesta/linkextractor-remove-lambdas
Remove lambda attributes in default link extractor
2020-05-09 02:11:59 +05:00
Mikhail Korobov 707f591767
Merge pull request #4557 from elacuesta/flake8-remove-e1xx
Flake8: remove E111, E114, E116, E117, E121
2020-05-09 02:08:27 +05:00
Eugenio Lacuesta c2c3054ac1
Flake8: remove E121 2020-05-08 16:43:47 -03:00
Eugenio Lacuesta 83ce82f400
Flake8: remove E114 and E117 (unused) 2020-05-08 16:43:28 -03:00
Eugenio Lacuesta 1a157f2e26
Flake8: remove E116 2020-05-08 16:42:56 -03:00
Eugenio Lacuesta 81d0b2f61a
Flake8: remove E111 2020-05-08 16:42:50 -03:00
Eugenio Lacuesta 3ebf2a0d82
Remove lambdas in link extractor 2020-05-08 15:24:37 -03:00
Eugenio Lacuesta b852fff6f8
Style changes in link extractor 2020-05-08 15:22:41 -03:00
Antonio Gordillo Toledo cf09af787e
Remove Python 2 encoding header from files (#4553) 2020-05-08 15:45:19 +02:00
Mikhail Korobov 77492cd945
Merge pull request #4543 from elacuesta/flake8-remove-e126
Flake8: remove E126
2020-05-07 22:14:51 +05:00
Eugenio Lacuesta e0127a3123
Refactor warnings in spiderloader 2020-05-07 12:48:43 -03:00
Eugenio Lacuesta 8659b0d896
Merge remote-tracking branch 'upstream/master' into flake8-remove-e126 2020-05-07 09:24:38 -03:00
Eugenio Lacuesta 422e6429b5
Add mising len check in spiderloader 2020-05-07 09:22:14 -03:00
Adrián Chaves b59dfb75fa Update disabled Pylint checks 2020-05-07 14:15:37 +02:00
Mikhail Korobov a8f61e909f
Merge pull request #4544 from elacuesta/flake8-remove-e129
Flake8: remove E129
2020-05-07 15:08:11 +05:00
Mikhail Korobov a18bfccac2
Merge pull request #4542 from elacuesta/flake8-remove-e122-e124
Flake8: remove E122 and E124
2020-05-07 15:05:01 +05:00
Eugenio Lacuesta 7fd2085725
Merge remote-tracking branch 'upstream/master' into bytes_received_signal 2020-05-06 22:41:16 -03:00
Eugenio Lacuesta d472402a02
Fix pickle test for pypy 2020-05-06 20:30:22 -03:00
Mikhail Korobov 2da952b928
Merge pull request #4519 from Gallaecio/test-ubuntu-bionic
Test the latest Ubuntu along the latest Python
2020-05-07 03:12:19 +05:00
Mikhail Korobov 0a7581df23
Merge pull request #4537 from Gallaecio/restric-travis-ci-tests
Travis CI: do not run security and Flake8 on multiple jobs
2020-05-07 00:54:17 +05:00
Eugenio Lacuesta 88efc98847
Flake8: remove E129 2020-05-06 16:42:47 -03:00
Eugenio Lacuesta 4c12a234ae
Flake8: Remove E126 2020-05-06 16:10:21 -03:00
Eugenio Lacuesta cc23d1cb58
Flake8: Remove E124 2020-05-06 15:40:37 -03:00
Eugenio Lacuesta d71804ef29
Flake8: Remove E122 2020-05-06 15:23:36 -03:00
Eugenio Lacuesta 0e382c8160
Remove unused import 2020-05-06 14:09:10 -03:00
Eugenio Lacuesta 93436f9d3a
Chain pickling exception, test_squeues.py updates 2020-05-06 14:05:27 -03:00
Eugenio Lacuesta b1ddd7bd7b
Refactor test_squeues.py 2020-05-06 13:44:02 -03:00
Andrey Rahmatullin b76d280cc3
Merge pull request #4540 from elacuesta/flake8-remove-e123
Flake8: remove E123
2020-05-06 21:38:04 +05:00
Eugenio Lacuesta d0bb04f089
Switch to pickle protocol 4 2020-05-06 13:37:23 -03:00
Andrey Rahmatullin 4957a0a172
Merge pull request #4539 from elacuesta/flake8-remove-e125
Flake8: remove E125
2020-05-06 21:36:20 +05:00
Andrey Rahmatullin 977ce9f7a8
Merge pull request #4538 from elacuesta/flake8-remove-e127
Flake8: remove E127
2020-05-06 21:34:24 +05:00
Eugenio Lacuesta 8643e8d355
Flake8: remove E123 (Closing bracket does not match indentation of opening bracket's line) 2020-05-06 12:26:04 -03:00
Michał Panek 628c4a5319
Add a warning/error in case of incorrect gcs permissions (#4508) 2020-05-06 17:09:20 +02:00
Adrián Chaves a79cfce57b
Merge branch 'master' into pylint 2020-05-06 16:24:13 +02:00
Eugenio Lacuesta 63600243e0
Flake8: remove E125 (Continuation line with same indent as next logical line)
Also remove E401 from pytest.ini - no occurrences in the codebase
2020-05-06 10:26:52 -03:00
Eugenio Lacuesta fe0c582ee0
Flake8: remove E127 in tests (continuation line over-indented for visual indent) 2020-05-06 09:49:10 -03:00
Eugenio Lacuesta 49e8a337f7
Flake8: remove E127 (continuation line over-indented for visual indent) 2020-05-06 09:37:01 -03:00
Adrián Chaves 98835a0d40
Merge branch 'master' into test-ubuntu-bionic 2020-05-06 13:59:01 +02:00
Adrián Chaves 418b9b5f52 Travis CI: do not run security and Flake8 on multiple jobs 2020-05-06 11:15:02 +02:00
Eugenio Lacuesta 17c0cf64ae
Flake8: remove W504 code (#4525)
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-05-06 00:14:48 +02:00
Mikhail Korobov 8f72b70f06
Merge pull request #4533 from scrapy/doc-old-twisted
Don't mention unsupported package versions in docs
2020-05-04 23:51:40 +05:00
Mikhail Korobov fe6154e4fa clarify DOWNLOADER_HTTPCLIENTFACTORY docs 2020-05-04 18:18:38 +05:00
Eugenio Lacuesta e1948b4923
Add example about bytes_received signal 2020-05-04 09:07:27 -03:00