Adrián Chaves
92fa657f9e
Merge pull request #3730 from ankostis/doc_logstats_delay
...
[MRG+1] doc: document LOGSTATS_INTERVAL setting
2019-04-11 17:34:45 +02:00
Mikhail Korobov
9280185054
Merge pull request #3520 from whalebot-helmsman/round-robin-scheduler-tested
...
[MRG+1] Downloader-aware Priority Queue for Scrapy
2019-04-07 00:06:08 +05:00
Maram Sumanth
aa46e1995c
[MRG+1] Show elapsed time in statscollector ( #3638 )
...
* Update corestats.py
* Update corestats.py
* corrected tests
* Update corestats.py
* Update scrapy/extensions/corestats.py
2019-04-07 00:03:40 +05:00
Mikhail Korobov
f816375df5
Merge pull request #3726 from ankostis/fixctrlc
...
[MRG+1] fix: do not catch system exceptions like KeyboardInterrupt
2019-04-06 23:54:15 +05:00
Kostis Anagnostopoulos
a8f83ab967
doc: document LOGSTATS_INTERVAL setting
2019-04-06 14:58:32 +02:00
Daniel Graña
2079e3c42a
Merge pull request #3728 from victor-torres/process_spider_exception
...
[MRG+1] fix typo on Spider Middleware template (Response -> Request)
2019-04-06 06:52:31 -03:00
Victor Torres
35ce92a419
fix typo (Response -> Request)
...
check docs for more information b5c552d17f/docs/topics/spider-middleware.rst
2019-04-05 14:31:15 -03:00
Kostis Anagnostopoulos
3a493b6066
fix: do not catch system exceptions like KeyboardInterrupt
2019-04-05 11:52:00 +02:00
Mikhail Korobov
d39feabae3
Merge pull request #3724 from float13/tutorial_grammar
...
[MRG+1] Docs - Tutorial - Minor grammar edits
2019-04-05 12:31:59 +05:00
float13
a101d5fe5c
text edit - delete 2 extra words
2019-04-05 01:12:20 -04:00
float13
77e3695686
grammar fix - add apostrophe-s to browser
2019-04-05 01:04:59 -04:00
float13
d711ecfc18
grammar fix - delete extra word "shell"
2019-04-05 00:56:51 -04:00
float13
6336e1d1f3
grammar fix - delete unneeded apostrophe in "lets"
2019-04-05 00:54:46 -04:00
Mikhail Korobov
c2d8f6f456
Merge pull request #3718 from Gallaecio/deprecate-is-gzipped
...
Deprecate the scrapy.utils.gz.is_gzipped function
2019-04-03 19:01:35 +05:00
Adrián Chaves
7acf4eec79
Deprecate the scrapy.utils.gz.is_gzipped function
2019-04-02 18:36:03 +02:00
Konstantin Lopuhin
b5c552d17f
Merge pull request #2061 from elacuesta/process_spider_exception_generator
...
[MRG+1] process_spider_exception on generators
2019-04-01 10:43:19 +03:00
Vostretsov Nikita
1c6733454e
added underlines
2019-03-29 10:44:55 +00:00
Vostretsov Nikita
ef743983a9
change wording
2019-03-29 10:38:13 +00:00
Vostretsov Nikita
f08f841d0b
remove small single use method
2019-03-29 10:35:49 +00:00
Vostretsov Nikita
539a08cb85
Merge branch 'round-robin-scheduler-tested' of github.com:whalebot-helmsman/scrapy into round-robin-scheduler-tested
2019-03-29 10:31:52 +00:00
Vostretsov Nikita
554d872822
remove spacing
2019-03-29 10:31:15 +00:00
Vostretsov Nikita
2b4bcfaf49
remove comment
2019-03-29 10:30:26 +00:00
Adrián Chaves
1ee99e1f42
Update docs/topics/settings.rst
...
Co-Authored-By: whalebot-helmsman <whalebot.helmsman@gmail.com>
2019-03-29 10:29:15 +00:00
Adrián Chaves
bd228f1d96
Update docs/topics/broad-crawls.rst
...
Co-Authored-By: whalebot-helmsman <whalebot.helmsman@gmail.com>
2019-03-29 10:29:04 +00:00
Adrián Chaves
e3df6be360
Update docs/topics/broad-crawls.rst
...
Co-Authored-By: whalebot-helmsman <whalebot.helmsman@gmail.com>
2019-03-29 10:28:52 +00:00
Adrián Chaves
46b9ab0c58
Update docs/topics/broad-crawls.rst
...
Co-Authored-By: whalebot-helmsman <whalebot.helmsman@gmail.com>
2019-03-29 10:28:36 +00:00
Mikhail Korobov
ec719f55e7
Merge pull request #3682 from elacuesta/rule_process_request_response_parameter
...
[MRG+1] Rule.process_request: access Response object
2019-03-28 01:39:54 +05:00
Mikhail Korobov
845bae6637
Update docs/topics/broad-crawls.rst
...
Co-Authored-By: whalebot-helmsman <whalebot.helmsman@gmail.com>
2019-03-27 08:49:19 +00:00
Mikhail Korobov
820adb69c0
Merge pull request #3701 from Gallaecio/documentation-policy-api
...
Update the documentation policies: Ask to use docstrings to document …
2019-03-27 12:25:38 +05:00
Adrián Chaves
ce837b0f74
Update the documentation policies: Ask to use docstrings to document API members
2019-03-27 07:09:18 +01:00
Maram Sumanth
2fd8b7c28c
[MRG+1] redirect_reasons in Request.meta ( #3687 )
2019-03-27 00:15:53 +05:00
Vostretsov Nikita
73e4ff5304
report warnings
2019-03-25 13:48:58 +00:00
Vostretsov Nikita
103fdc40c1
Merge remote-tracking branch 'upstream/master' into round-robin-scheduler-tested
2019-03-25 16:16:42 +03:00
Vostretsov Nikita
31b8a6b33a
report warnings
2019-03-25 16:08:40 +03:00
Lucy Wang
df574de8cc
improve tests and fix some lint warnings ( #6 )
...
* refactor downloader-aware test cases
* fix lint
* add doctest for _path_safe
* remove unused code
* better doctest
2019-03-25 16:08:40 +03:00
Vostretsov Nikita
8afffb7234
Tests Cleanup
...
add doctest for function
no need in this variables
move common assertion inside function
rename variable
rename variables
rename function
use function
this is not a method of public API
correct name for test
Update docs/topics/settings.rst
Co-Authored-By: whalebot-helmsman <whalebot.helmsman@gmail.com>
2019-03-25 16:08:40 +03:00
Vostretsov Nikita
989bba6cb3
Revert "new signal"
...
This reverts commit 646164fd7d6dd52061804d2df7424cff929bf739.
remove tests
Revert "emit new signal"
This reverts commit fcde0c6880678957a76af6083b6248f430a00fcf.
Revert "documentation for new signal"
This reverts commit 8aeb9f696ece95c16499a96767a7afa3d9c4abf4.
2019-03-25 16:08:40 +03:00
Vostretsov Nikita
443fb98a47
Use downloader directly
...
rename variable
remove old write function
remove unused imports
remove old read function
remove unused function
use mock methods
mock downloader
close downloader
add parse method
use new PQ class
create mock downloader
use downloader directly
remove mark/unmark mechanism
2019-03-25 16:08:40 +03:00
Mikhail Korobov
83eb537645
assorted cleanups: comments, docstrings, etc
...
scheduler cleanup
Scheduler no longer converts requests to dicts; PriorityQueue
instances always work with Request instances; converting Requests
to dicts is now Priority Queue responsibility.
minor cleanup
2019-03-25 16:08:40 +03:00
Vostretsov Nikita
3b1db71dac
New signal
...
update signature
documentation for new signal
utilize new signal
correct signal handler signature
emit new signal
test another signal
new signal
rename test file
faster test
rename test case
tests for signal emitting in bad cases
2019-03-25 16:08:40 +03:00
Vostretsov Nikita
757f53a324
Address Lucy's comments
...
add tests to check correctness of slot setermination
unmark requests after downloading
shorter
better exception message
2019-03-25 16:08:40 +03:00
Mikhail Korobov
90934959d0
actually apply __slots__ suggestion
...
[wip] refactoring
* SlotPriorityQueues doesn't care about objects inside, it is now just
a container for multiple priority queues
* assorted variable renames
* don't inherit DownloaderAwarePriorityQueue from SlotBasedPriorityQueue
* apply @whalebot-helmsman's suggestions for __slots__ and meta issues
more bike-shedding
* remove mutable default arguments
* more verbose variable names
remove unneeded code
* PriorityAsTupleQueue.is_empty does the same as len(self) == 0
* custom PriorityAsTupleQueue.close is not needed after a switch
to namedtuples
* is_new and is_empty return values are unused
* "url" local variable is unused
PrioritySlot.__str__ shouldn't return unicode in Python 2
also, do some bike-shedding: _pathable -> _path_safe
use namedtuple for PrioritySlot
cleanup: _get_from_request does the same here
Request.meta is always a dict
2019-03-25 16:08:40 +03:00
Eugenio Lacuesta
1b4385b7e3
Rule.process_request: move deprecation warnings and compiling code, update tests
2019-03-22 19:46:17 -03:00
Eugenio Lacuesta
174ba3cc56
Rule.process_request: update docs
2019-03-22 19:16:18 -03:00
Eugenio Lacuesta
56929e77d9
Rule.process_request: deprecate the use of functions taking only one argument
2019-03-22 18:34:55 -03:00
Eugenio Lacuesta
bbf24b7a1c
Rule.process_request: use scrapy.utils.python.get_func_args
2019-03-22 18:02:31 -03:00
Mikhail Korobov
8583c033ef
Merge pull request #3694 from noviluni/master
...
[MRG+1] Fix numeration
2019-03-23 00:23:06 +05:00
Adrián Chaves
c191a8e70c
Merge pull request #3698 from noviluni/_fix_gitignore
...
[MRG+1] remove duplicated entry in gitignore
2019-03-22 19:45:57 +01:00
Mikhail Korobov
729580dae2
Merge pull request #3671 from Gallaecio/item-deepcopy
...
Implement Item.deepcopy()
2019-03-22 22:56:39 +05:00
Marc Hernández Cabot
9a0fe8bf2d
remove duplicated entry in gitignore
2019-03-22 18:56:25 +01:00