Commit Graph

7909 Commits

Author SHA1 Message Date
Adrián Chaves bea154cecc Bump version: 2.0.0 → 2.0.1 2020-03-18 18:36:19 +01:00
Adrián Chaves 5d3ea9afb2
Cover 2.0.1 in the release notes (#4437) 2020-03-18 18:33:41 +01:00
Aditya Kumar b5e71221b8 Remove all top-level imports for twisted.internet.reactor (#4406) 2020-03-18 18:30:47 +01:00
Andrey Rahmatullin df536dab6a Merge pull request #4422 from Gallaecio/pin-working-pytest
Restrict pytest to versions prior to 5.4
2020-03-18 18:30:47 +01:00
Mikhail Korobov 4d6e34014d Merge pull request #4420 from elacuesta/response_follow_all_empty_generator
Response.follow_all: return empty generators for empty sequences
2020-03-18 18:30:47 +01:00
Adrián Chaves a4dbb7754b Bump version: 1.8.0 → 2.0.0 2020-03-03 09:13:00 +01:00
Adrián Chaves 6aa0ba4553
Write release notes for Scrapy 2.0.0 (#4329) 2020-03-03 09:11:11 +01:00
MaliCN ef00f8eb8e
updated with new macOS name (#4308) (#4323)
* changed for new name as "macOS"  (issue #4308)

* updated macOS name

* update macOS name

* updated macOS name

* update for new macOS name

* docs/intro/install.rst: fix macOS header symbols

Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>

Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: elacuesta <elacuesta@users.noreply.github.com>
2020-02-29 00:42:07 +05:00
sakshamb2113 c411a51f42
Fix random failures from test_fixed_delay in some machines (#4372) 2020-02-28 13:17:02 +01:00
Andrey Rahmatullin 09d9e75c08
Merge pull request #4375 from Gallaecio/env-warn-whitelist
Stop deprecation warnings on arbitrary SCRAPY-prefixed env vars
2020-02-28 13:26:17 +05:00
Adrián Chaves 9aae4c0be7 Add tests for envvar setting warnings 2020-02-27 16:31:43 +01:00
Adrián Chaves 2acaa86231 Do not warn about valid environment variables 2020-02-27 15:46:21 +01:00
HEndo12345 6109ad9aac
Clean up the deprecated settings list (#4378) 2020-02-27 15:15:30 +01:00
Mikhail Korobov 647cba0f10
Merge pull request #4373 from Gallaecio/fix-readthedocs
Fix the ReadTheDocs build
2020-02-26 02:27:02 +05:00
Adrián Chaves 778813717d Use ReadTheDocs install.path 2020-02-25 21:58:28 +01:00
Adrián Chaves a9d7d8f064 Add Scrapy dependencies back to docs/requirements.txt 2020-02-25 21:41:07 +01:00
Adrián Chaves 7291173f6b Have ReadTheDocs builds fail on warning 2020-02-25 21:35:21 +01:00
gunblues 034e2c31c7
Use a non-zero exit code when a pipeline's open_spider method throws an exception (#4207)
* fix issue 4175 - Scrapy does not use a non-zero exit code when pipeline's open_spider throws the exception

* remove extra blank lines

* remove redundant code

* remove blank line at end of file

* more suitable naming for response and make if-condition shorter

* avoid error - AttributeError: 'Deferred' object has no attribute 'result'

* use getattr to make code concisely

* add test

* remove useless file

* modify test class name

* remove unneccessary files

* Fix Flake8-reported issue

* fix these items which are suggested by Gallaecio
・Sort those imports at tests/test_cmdline_crawl_with_pipeline/__init__.py
・Remove the unused setUp method.
・Remove comments generated by Scrapy’s project generation tool.
・Remove the [deploy] section from the scrapy.cfg file (I don’t think it’s needed here)
・Remove BOT_NAME and NEWSPIDER_MODULE from settings.py (I think there are not needed either, although I’m less sure about NEWSPIDER_MODULE)

* have to reserve BOT_NAME, SPIDER_MODULES in settings.py

* Remove unneeded empty lines

* Empty __init__.py file with unneeded comments

* Remove an unneeded empty line at the end

* Remove unneeed empty line from __init__.py file

* Update __init__.py

* Update __init__.py

* Update exception.py

* Update normal.py

* Update __init__.py

* Update __init__.py

* fix W391 blank line at end of file

Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-02-26 00:46:05 +05:00
Mikhail Korobov ea6ab179d9
Merge pull request #4361 from nyov/linkfix
Documentation linkcheck run, fixing some links.
2020-02-25 22:30:44 +05:00
nyov a34c366fa4 DOC linkcheck run; https and 301 link updates.
Closes #4359
2020-02-25 16:51:33 +00:00
Mikhail Korobov caa1dea890
Merge pull request #4370 from Gallaecio/dont-fail-kw-only
Make BaseItemExporter’s dont_fail parameter keyword-only
2020-02-25 13:12:01 +05:00
Adrián Chaves 7417a9871c Make BaseItemExporter’s dont_fail parameter keyword-only 2020-02-24 13:28:15 +01:00
elacuesta 31f35c9c00
Remove unnecessary comma (#4369) 2020-02-24 12:02:00 +01:00
Mikhail Korobov 49480225d7
Merge pull request #4365 from noviluni/fix_flake8_E701_E271
Fix flake8 E131, E211, E251, E271, E701
2020-02-23 15:52:52 +05:00
elacuesta 9d983c1b99
Expose certificate for HTTPS responses (#4054)
* Expose certificate for HTTPS responses

* Fix test (missing inlineCallbacks decorator)

* Note about Response.certificate

* Explicitly cover None as the default value of Response.certificate

Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-02-22 17:20:31 +05:00
Vostretsov Nikita 67ee0b097f
Remove specifics of downstream request queues from scheduler (#3884)
* move serialization/deserialization logic to downstream queues

* make memory queues conform to common interface

* make ScrapyPriorityQueue conform common interface

* ScrapyPriorityQueue works with disk

* make key as string

* return list instead of dict as earlier

* downloader aware pq works with new interface

* we don`t need these methods anymore

* create directories for files

* remove dummy priority

* remove priority as parameter, let every queue decide for itself

* rename obj to request

* DownloaderAwarePriorityQueue is too thin wrapper around _SlotPriorityQueues, just remove second one

* remove priority as parameter, let every queue decide for itself

* rename argument

* more granular class separation

* python2 compatible

* one more argument for common interface

* more simple downstream queue interface

* single place for easier customization

* rename function

* shorter

* shorter

* use named arguments

* fix typo

* add docstring

* Update scrapy/pqueues.py

Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>

* Update scrapy/pqueues.py

Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>

* 4 spaces indentation

* we ok with existing directories

* remove unused import

* rename method

* remove unused imports

* it has no sense now

* relining

* note about queues

* add value

* Revert "it has no sense now"

This reverts commit b61604275b.

* pep8 E261

* pep8 E303

* pep8 E501

* pep8 E123

* pep8 E123

* use create instance

* remove excessive import

Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-02-22 17:02:57 +05:00
Marc Hernandez Cabot 6e8e117aee fix flake E211 2020-02-22 12:32:38 +01:00
Marc Hernandez Cabot 69a8648bef fix E251 2020-02-22 12:32:38 +01:00
Marc Hernandez Cabot 9ad10bb6f7 fix E131 2020-02-22 12:32:38 +01:00
Marc Hernandez Cabot b49ece0b87 fix E701 and E271 flake8 2020-02-22 12:32:38 +01:00
Mikhail Korobov e551bc5170
Merge pull request #4318 from wRAR/asyncio-parse-asyncgen
Support yield in async def callbacks.
2020-02-21 23:50:01 +05:00
Mikhail Korobov b0a7efb88f
Merge pull request #4360 from noviluni/fix_flake8_E22X
fix E22X flake8
2020-02-21 23:45:27 +05:00
Mikhail Korobov 1be1101fe4
Merge pull request #4362 from noviluni/delete_deprecated_functions
delete old deprecated functions from scrapy.utils.python
2020-02-21 23:44:44 +05:00
Marc Hernandez Cabot 03ed9e1786 delete old deprecated functions from scrapy.utils.python 2020-02-21 09:29:29 +01:00
Marc Hernandez Cabot 6fb85951ce fix E22X flake8 2020-02-21 08:39:14 +01:00
Marc Hernández 91bbc70bc1
fix E30X flake8 (#4355) 2020-02-21 06:05:31 +01:00
Mikhail Korobov c4ee4b6075
Merge pull request #4347 from noviluni/deprecate_sel_shortcut
Remove deprecated `sel` shortcut in scrapy shell
2020-02-20 02:56:34 +05:00
Adrián Chaves 0f78a591f8
Fix Flake8-reported “Too many blank lines” 2020-02-19 19:09:39 +01:00
Adrián Chaves 6972a19707
Remove unused imports 2020-02-19 18:59:09 +01:00
Andrey Rahmatullin 88179027de
Merge pull request #4331 from Gallaecio/response-cb-kwargs
Implement Response.cb_kwargs
2020-02-19 22:40:14 +05:00
Marc Hernandez Cabot eb21dae524 deprecare sel shortcut in scrapy shell 2020-02-19 17:49:42 +01:00
Andrey Rahmatullin f558df2558
Merge pull request #4188 from elacuesta/logformatter-error-formatting
LogFormatter error formatting
2020-02-19 19:05:08 +05:00
Andrey Rahmatullin 528b894f28
Merge pull request #4321 from Gallaecio/link-extractor-encoding
Use safe_url_string in link extraction
2020-02-19 18:19:21 +05:00
Akshay Sharma 182445f9d9
Fix a spelling error: ie. → i.e. (#4338) 2020-02-18 17:58:31 +01:00
Mikhail Korobov 320cea62ff
Merge pull request #4309 from Gallaecio/virtualenv-doc
Update installation instructions regarding Python 3 and virtual environments
2020-02-18 19:56:35 +05:00
Adrián Chaves a04dd13cd0
ie. → i.e. 2020-02-14 22:31:30 +01:00
Adrián Chaves 5ae3e1678f
ie. → i.e.
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
2020-02-14 22:30:36 +01:00
Adrián Chaves 43b43654a1 Add tests for meta and cb_kwargs not being available 2020-02-13 22:39:58 +01:00
Adrián Chaves 5ff9eb90ea Add a test for the copy of cb_kwargs from Request to Response 2020-02-13 22:36:18 +01:00
Adrián Chaves df937d8280 Implement Response.cb_kwargs 2020-02-13 22:33:36 +01:00