Andrey Rakhmatullin
922ff57384
Improve the backwards compatibility for RetryMiddleware.EXCEPTIONS_TO_RETRY.
2023-09-14 15:51:00 +04:00
Andrey Rakhmatullin
6428356584
Use twisted.python.log instead of failure.printTraceback().
2023-09-13 18:20:42 +04:00
Andrey Rakhmatullin
be0e33af92
Don't rely on unhandled exception logging in the expected to fail scripts.
2023-09-13 16:59:54 +04:00
Andrey Rakhmatullin
3756216339
Rename methods.
2023-09-13 15:47:22 +04:00
Andrey Rakhmatullin
619140717f
Fix the new addon test.
2023-09-13 15:33:51 +04:00
Andrey Rakhmatullin
028a56b9a2
Improve and simplify tests.
2023-09-13 14:17:41 +04:00
Andrey Rakhmatullin
62183dc25f
Merge branch 'master' into change-init-order
2023-09-12 22:16:21 +04:00
Andrey Rakhmatullin
77f39be407
Add integration tests for modifying settings via args.
2023-09-12 20:16:26 +04:00
Andrey Rakhmatullin
e26bf4f918
Pin brotli for PyPy tests ( #6045 )
2023-09-12 16:18:25 +02:00
Andrey Rakhmatullin
bb15c93a2b
Add Crawler._load_settings().
2023-09-12 14:44:16 +04:00
Andrey Rakhmatullin
6629a61dd9
Fix one more testcase.
2023-09-08 20:15:49 +04:00
Andrey Rakhmatullin
036d5836d0
Move more things from Crawler.__init__() to .crawl().
2023-09-08 19:29:05 +04:00
Andrey Rakhmatullin
97b98bf181
Roll back the update_settings() changes.
2023-09-07 17:02:37 +04:00
Maria Mitropoulou
721df895f9
Fix charset handling in MailSender #5096 ( #5118 )
2023-09-07 07:47:42 +02:00
Andrey Rakhmatullin
b4380995da
Merge remote-tracking branch 'origin/master' into change-init-order
2023-09-06 20:34:27 +04:00
Andrey Rakhmatullin
b39d2d4353
Add a test.
2023-09-06 19:44:22 +04:00
Andrey Rakhmatullin
d3b5c9be97
Deprecate running Crawler.crawl() twice.
2023-09-06 19:29:44 +04:00
Andrey Rakhmatullin
69282c5318
Merge branch 'master' into change-init-order
2023-09-05 19:23:36 +04:00
Víctor Ruiz
c1dd5493ac
Fix enabled addons not being logged ( #6036 )
2023-09-04 08:03:35 +02:00
Mikhail Korobov
0fcb0554d1
Merge pull request #6016 from jxlil/fix/response.json
...
Fix: response.json() call makes unnecessary memory allocation
2023-08-31 14:07:24 +05:00
Georgiy Zatserklianyi
1f03cb1419
Merge remote-tracking branch 'upstream/master' into periodic_log_2
2023-08-21 17:07:18 +03:00
Laerte Pereira
df2163ce6a
Remove datetime.utcnow() usage ( #6014 )
2023-08-21 15:51:49 +02:00
Jalil SA
fd4292b722
fix: test_cache_json_response
2023-08-17 10:24:34 -06:00
Laerte Pereira
b06936f111
Handle Tuple type on getdictorlist method, bump 3.12 python version
2023-08-14 10:33:48 -03:00
Andrey Rakhmatullin
34d050cfe5
Remove deprecated CrawlerRunner.spiders. ( #6010 )
2023-08-11 10:41:05 +02:00
Laerte Pereira
4a090d951a
Remove deprecated PythonItemExporter.binary ( #6007 )
2023-08-10 07:36:42 +02:00
Andrey Rakhmatullin
644a71bfd4
Use ftp:// URLs in FTP tests.
2023-08-07 00:17:52 +04:00
Andrey Rakhmatullin
471281d29e
Fixes for scrapy/utils/iterators.py typing.
2023-08-06 23:05:02 +04:00
Andrey Rakhmatullin
518e56046e
Check for async callbacks in contracts.
2023-08-06 17:28:34 +04:00
Andrey Rakhmatullin
d1f87e4f08
More typing for scrapy/utils/iterators.py.
2023-08-06 00:35:33 +04:00
Georgiy Zatserklianyi
e9b088f1fb
periodic_log: typing
2023-08-04 12:49:22 +03:00
Laerte Pereira
09c63a178b
Remove the deprecated spider parameter from the engine ( #5998 )
2023-08-04 07:53:04 +02:00
Laerte Pereira
b9c32a0cfd
Remove functions deprecated in 2.6.0 ( #5996 )
2023-08-03 17:06:55 +02:00
Andrey Rakhmatullin
9f9a2292e0
Deprecate the custom attribute of build_component_list(). ( #5993 )
2023-08-02 14:21:06 +02:00
Andrey Rakhmatullin
06ebdee35d
Merge pull request #5950 from wRAR/addons
...
Add-ons
2023-08-01 22:18:57 +04:00
Andrey Rakhmatullin
e58b8078f0
Improve NotConfigured handling when clspath is a class.
2023-08-01 20:20:15 +04:00
Andrey Rakhmatullin
41a4a163e3
Handle NotConfigured in add-ons.
2023-07-31 21:09:18 +04:00
Andrey Rakhmatullin
d8c5b41559
Add more addon tests.
2023-07-31 19:09:21 +04:00
Andrey Rakhmatullin
bddbbc522a
Merge pull request #5979 from BurnzZ/closespider-timeout-no-item
2023-07-28 12:56:44 +04:00
freddiewanah
c4f0aa4fdf
Refactor test cases to improve unit test quality ( #5986 )
2023-07-26 13:09:03 +02:00
Andrey Rakhmatullin
6e3e3c2172
Merge pull request #5977 from scrapy/typing-settings
...
Typing for scrapy.settings.BaseSettings
2023-07-24 21:40:52 +04:00
Kevin Lloyd Bernal
9a1bf40c2f
expose AWS_REGION_NAME in S3FeedStorage
2023-07-24 16:37:52 +08:00
Laerte Pereira
7522aeed35
fix: -O/-o option does not work with absolute paths on Windows ( #5971 )
2023-07-24 09:53:41 +02:00
Mikhail Korobov
af2aa4b421
Merge pull request #5847 from namelessGonbai/feat/FixFeedExport
...
Fix FeedExporter not to export empty file
2023-07-22 23:18:36 +05:00
Adnan Awan
5d91ea12d6
Fix JsonItemExporter puts lone comma in the output if encoder fails ( #5952 )
...
* Partial fix for #3090 - only addresses JSON feeds.
* Adding test case for #3090 to Json Exporter
* Changing the deliberate-fail JSON example to a complex
* Further tightening JsonItemExporter behaviour to prevent corruption.
Based on Mikhail's observation that to_bytes can fail also, leading
to the same dangling comma as the failure to encode to JSON.
Added a new test case to avoid reversion.
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Add initial changes from cathal's PR
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Handle exception not to add empty item.
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Add comment for handling the exception
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Remove unused import
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Fix invalid json issue
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Perform CR changes
- https://github.com/scrapy/scrapy/issues/3090
---------
Co-authored-by: Cathal Garvey <cathalgarvey@cathalgarvey.me>
2023-07-22 23:13:40 +05:00
Andrey Rakhmatullin
e058a05763
Skip tests that don't work on Python 3.12.
2023-07-22 17:51:13 +04:00
Andrey Rakhmatullin
583df9f7d0
Simplify skipping uvloop tests.
2023-07-22 17:44:37 +04:00
Andrey Rakhmatullin
5c34f34ecb
Make AddonManager.add() private.
2023-07-18 19:50:08 +04:00
Kevin Lloyd Bernal
368ab29ffc
improve tests by having SlowSpider
2023-07-18 22:29:15 +08:00
Kevin Lloyd Bernal
3f5bbe3a8f
introduce CLOSESPIDER_TIMEOUT_NO_ITEM in CloseSpider
2023-07-18 18:30:21 +08:00