tstauder
ef61fb5698
Fix flaky tests involving feed export batches ( #5898 )
...
Co-authored-by: jmannoop <jmannoop@umich.edu>
2023-04-19 08:33:32 +02:00
Jalil SA
88c58a8c9c
feat: added test_post_data_raw_with_string_prefix
2023-04-18 22:28:16 -05:00
guillermo-bondonno
441ac196e4
Implement a request_to_curl function ( #5892 )
2023-04-13 17:46:59 +02:00
Serhii A
c2a31974ff
Improve get_func_args ( #5885 )
2023-04-13 11:44:20 +02:00
Andrey Rakhmatullin
d911837389
Merge pull request #5881 from sbartlett97/LinkExtractor-Patch
...
Patched LxmlParserLinkExtractor
2023-04-12 12:28:21 +04:00
Adrián Chaves
3f0c2fae5e
Skip test_skip_bad_links based on the w3lib version
2023-04-12 09:28:28 +02:00
Kartik Kumar
d47c732ae9
base64-decode GCS checksums ( #5891 )
2023-04-11 18:25:42 +02:00
Andrey Rakhmatullin
1e20ba0a1b
Merge branch 'master' into feat/FixFeedExport
2023-04-11 19:48:19 +04:00
Felipe Boff Nunes
a0e2e36b52
adjustments
2023-04-06 14:23:19 -03:00
Felipe Boff Nunes
0ffd1667ba
adjustments
2023-04-06 14:17:35 -03:00
Samuel Bartlett
618e82dbe1
Exclude test for python versionbs less than 3.8
2023-03-31 15:12:47 +00:00
Samuel Bartlett
608b7de582
Skip new test if python version less than 3.8
2023-03-31 14:38:06 +00:00
Samuel Bartlett
4043560547
remove utf-8 encoding flag from test
2023-03-31 12:29:22 +00:00
Samuel Bartlett
00d93026c8
Fix bad test case
2023-03-31 08:30:19 +00:00
Samuel Bartlett
7cb7cf1ad1
Add link extractor back to test
2023-03-31 08:09:02 +00:00
Samuel Bartlett
9cbcf7724d
Add test to make sure spider doesn't crash on bad
2023-03-31 08:07:43 +00:00
jazzthief
4ebc08ef10
Switch from `is_boto3_available()` to `IS_BOTO3_AVAILABLE` var
2023-03-16 17:24:11 +01:00
kenshi kikuchi
c8ed793257
Fix test_export_no_items_multiple_feeds
2023-03-16 17:16:14 +09:00
Adrián Chaves
7e7b41c6b3
Fix test expectations for boto3
2023-03-15 16:38:13 +01:00
Adrián Chaves
39dbfa1d82
Minimize test reliance on S3; do not install botocore on the default test environments
2023-03-15 15:31:39 +01:00
auxsvr
d60b4edd11
Prevent an edge case that creates an extra event loop ( #5832 )
2023-03-14 09:31:13 +01:00
Alex
101a0c32d7
Support genspider with HTTPS ( #5808 )
2023-03-14 08:13:44 +01:00
Mohammadtaher Abbasi
afafc2781a
Fix parse command issues with asyncio ( #5824 )
2023-03-10 16:20:15 +01:00
Andrey Rakhmatullin
3659a8c8d9
Merge pull request #5328 from GeorgeA92/per_slot_settings
...
Per slot settings
2023-03-09 22:31:24 +05:00
kenshi kikuchi
d311779887
Fix FeedExporter
...
+ Fix FeedExporter not to export empty file
+ Change default value of FEED_STORE_EMPTY
2023-03-08 16:24:09 +09:00
Jalil SA
8aca47e25d
Add setdefault to BaseSettings ( #5821 )
2023-03-07 10:26:59 +01:00
Alex
78269f9a4f
Merge branch 'scrapy:master' into path_object_error_#5739
2023-02-25 20:49:04 -08:00
Georgiy Zatserklianyi
864eee66c7
per_slot_settings(docs): code style fix 3 (from previous pre-commit check)
2023-02-16 18:19:36 +02:00
Georgiy Zatserklianyi
dd5524eb98
per_slot_settings(docs): code style fix 2 (from previous pre-commit check)
2023-02-16 17:59:36 +02:00
Georgiy Zatserklianyi
045092e8d7
per_slot_settings(docs): code style fix (from previous pre-commit check)
2023-02-16 17:55:59 +02:00
Andrey Rakhmatullin
824641e349
Merge remote-tracking branch 'origin/master' into mypy-imports
2023-02-11 22:02:19 +04:00
Alex
f17d2e711d
Merge branch 'scrapy:master' into path_object_error_#5739
2023-02-10 00:56:51 -08:00
Georgiy Zatserklianyi
80a86de507
per_slot_settings: test delays increased
2023-02-08 22:40:22 +02:00
Georgiy Zatserklianyi
13d1f69c78
Merge remote-tracking branch 'upstream/master' into per_slot_settings
...
# Conflicts:
# scrapy/core/downloader/__init__.py
2023-02-08 22:23:13 +02:00
Alex
4692e0e16b
Merge branch 'master' into path_object_error_#5739
2023-02-02 11:10:01 -08:00
Adrián Chaves
b07d3f85a3
Upgrade CI tools
2023-02-02 06:37:40 +01:00
Adrián Chaves
426f3ebb7b
Fix typo: causes it be closed → causes it to be closed
2023-02-02 05:58:32 +01:00
Adrián Chaves
32bc8bd436
Merge remote-tracking branch 'scrapy/master' into issue5043-feed_export
2023-02-02 05:56:48 +01:00
Adrián Chaves
2f2bcb006d
Test stream detaching in CsvItemExporter
2023-02-02 05:55:59 +01:00
Alex
8c8894f4be
Apply black formatting to templates ( #5814 )
2023-02-02 04:42:47 +01:00
Andrey Rakhmatullin
ccd1385e11
Merge branch 'master' into no-callback
2023-01-30 15:43:05 +05:00
Andrey Rakhmatullin
da15d93d39
Merge pull request #5806 from jxlil/master
...
Use isort
2023-01-30 15:40:44 +05:00
Andrey Rakhmatullin
c0efb271a2
Ignore typing for twisted.internet.reactor globally.
2023-01-27 23:19:44 +04:00
Adrián Chaves
f03b47db05
Make NO_CALLBACK a callable
2023-01-27 17:35:32 +01:00
Alex
a1e2fbafdc
applied black to tests
2023-01-26 16:46:08 -08:00
Cj Malone
33b85a9e2a
Test local files aren't processed
2023-01-26 19:51:20 +00:00
Alex
5433015a25
Merge branch 'master' into path_object_error_#5739
2023-01-26 07:12:01 -08:00
Jalil SA
a5c1ef8276
sort imports with isort
2023-01-25 14:25:15 -06:00
Andrey Rakhmatullin
afd5d85320
Fix remaining issues in tests.
2023-01-25 22:15:10 +04:00
Andrey Rakhmatullin
2e33fb812b
Silence improper typing of twisted.internet.reactor in tests.
2023-01-25 22:15:07 +04:00
Andrey Rakhmatullin
c0ea7fd4fd
Remove obsolete top-level run code in tests.
2023-01-25 22:14:24 +04:00
Adrián Chaves
9272c4af0c
Merge remote-tracking branch 'scrapy/master' into no-callback
2023-01-25 17:41:41 +01:00
Alex
085b340e8a
Merge branch 'scrapy:master' into path_object_error_#5739
2023-01-22 21:46:28 -08:00
Emmanuel Rondan
f2c22aaabb
Merge remote-tracking branch 'upstream/master' into add-black-formatter
2023-01-20 17:08:07 -03:00
Emmanuel Rondan
8ee4817471
reaplying black, fixing conflicts and ignoring bandit checks on test directory
2023-01-20 10:55:46 -03:00
Alex
b1dd893fbb
Support Path Objects Issue #5739
2023-01-20 02:17:02 -08:00
Tobias Mayr
f449ee5377
Fix SMTP STARTTLS for Twisted >= 21.2.0 ( #5406 )
2023-01-19 19:44:55 +01:00
Adrián Chaves
50500a6b28
Implement a NO_CALLBACK value for Request.callback
2023-01-19 17:14:18 +01:00
Andrey Rakhmatullin
93ad6a4bc2
Simplify code for modern pyOpenSSL.
2023-01-13 20:39:44 +04:00
Andrey Rakhmatullin
74b8c34de6
Merge pull request #5458 from reidemeister94/fix/unique-list-link-extractors
...
fix: return unique_list only when link_extractor.unique is True
2023-01-13 01:13:45 +05:00
Andrey Rakhmatullin
604ddf82fc
Merge pull request #5758 from MattyMay/finish_exporting_for_each_start_exporting
...
Finish exporting for each start exporting
2023-01-13 00:17:17 +05:00
Andrey Rakhmatullin
2944894c4d
Merge pull request #5764 from jsoref/spelling
...
Spelling
2023-01-13 00:15:36 +05:00
spav
b386c64864
Fix tests for allowing duplicates in extract_links
2023-01-11 19:58:42 +01:00
Adrián Chaves
520be4ff0b
Merge remote-tracking branch 'scrapy/master' into fix/http2_cookies
2023-01-11 15:59:59 +01:00
Adrián Chaves
d9f6de6bf5
Add a test for receiving duplicate headers
2023-01-11 15:59:45 +01:00
Adrián Chaves
1ab900659e
Fix typo: finis → finish
2023-01-11 14:05:13 +01:00
Adrián Chaves
724b033287
Fix CI issues related to asyncio ( #5782 )
2023-01-06 19:51:07 +01:00
Adrián Chaves
fd6742e811
Fix tests for pygments 2.14 ( #5783 )
2023-01-02 19:13:31 +01:00
Emmanuel Rondan
c5cdd0d30c
reaplying black again and removing line length on pre-commit black config
2022-12-29 12:48:20 -03:00
Emmanuel Rondan
303f0a70fc
re applying black to the code with default line length
2022-12-29 11:26:06 -03:00
Emmanuel Rondan
12b556a352
Merge branch 'master' into add-black-formatter
2022-12-26 12:25:32 -03:00
Matt Mayfield
a0832081ba
Merge branch 'master' into finish_exporting_for_each_start_exporting
2022-12-19 18:12:02 -05:00
Matt Mayfield
0a84ce448c
Fix InstrumentedFeedSlot
...
I accidentally called the wrong super method in overriden
finish_exporting
2022-12-19 18:09:43 -05:00
Josh Soref
8a526d161c
spelling: user
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:46:11 -05:00
Josh Soref
860fbef608
spelling: unknown
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
1e44d4614e
spelling: straight
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
d27c611cc0
spelling: referrer
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
6aa5374bd3
spelling: received
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
826e0ee611
spelling: preexisting
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
66ab82f126
spelling: precedence
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
8ae77fdb34
spelling: pipeline
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
1a5cf00db7
spelling: overridden
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
a839b61147
spelling: nonexistent
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
e894db2f3f
spelling: laziness
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
a26b6b0607
spelling: indistinct
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
1300c1c881
spelling: children
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Alex
93ace91ace
Merge branch 'scrapy:master' into fix_shell_fetch_alt
2022-12-13 21:50:28 -08:00
Alex
c2de9372a2
added unittest for scrapy shell command and fixed flake8 error
2022-12-13 21:37:17 -08:00
Matt Mayfield
40f4b262d2
Fix style errors
2022-12-12 12:36:29 -05:00
Matt Mayfield
8d67a08155
Change test name and add additional tests
2022-12-12 11:55:42 -05:00
Matt Mayfield
66f127eb37
Make test cleaner and more reusable
2022-12-12 11:46:05 -05:00
Laerte Pereira
e099572cec
change xfail condition
2022-12-12 09:56:50 -03:00
Laerte Pereira
0dbd1d9b81
use xfail, switch to packaging to parse version
2022-12-12 08:58:40 -03:00
Matt Mayfield
087334009c
Call `finish_exporting` even when itemcount == 0
2022-12-11 23:12:41 -05:00
Laerte Pereira
6757973b61
fix test_follow_whitespace_* tests
2022-12-11 09:11:55 -03:00
Emmanuel Rondan
1a3db81492
ignoring E203 flake8 error
...
ignoring implicit-str-concat pylint error
fixing pylint comment on test_request_cb_kwargs.py
2022-11-29 15:06:54 -03:00
Emmanuel Rondan
e211ec0aa2
adding black formatter to all the code
2022-11-29 11:30:46 -03:00
Mark Mayo
f9a29f03d9
Address some issues reported by Pylint ( #5677 )
...
Co-authored-by: Felipe Boff Nunes <51033921+felipeboffnunes@users.noreply.github.com>
Co-authored-by: Andrey Rahmatullin <wrar@wrar.name>
2022-11-27 11:00:13 +01:00
Andrey Rahmatullin
d19a216e10
Merge branch 'master' into pathlib
2022-11-25 18:20:25 +05:00
Andrey Rakhmatullin
f85c3f3d68
Add a comment about `tmpname + '^'`.
2022-11-25 18:46:14 +06:00
Laerte Pereira
e769532644
Remove `noconnect` deprecate code
2022-11-23 08:30:11 -03:00
Laerte Pereira
1506479672
Remove deprecated test
2022-11-22 10:07:32 -03:00
Laerte Pereira
8e0025f53d
Remove support for override settings with `SCRAPY_` environment variables
2022-11-22 09:38:54 -03:00
Laerte Pereira
1a6408c3fa
Remove `FilteringLinkExtractor`
2022-11-21 07:30:20 -03:00
Laerte Pereira
d5b6c236a9
Remove deprecated code ( #5719 )
2022-11-21 09:32:26 +01:00
GeorgeA92
042012f6bd
per slot settings: error calculation metho updated
2022-11-18 14:56:29 +02:00
Andrey Rahmatullin
bbe24d79a5
Fix test issues
2022-11-07 17:08:54 +05:00
Andrey Rahmatullin
6c0890ff54
Simplify the changes after the merge
2022-11-07 16:36:54 +05:00
Andrey Rahmatullin
b03d84e9fb
Merge branch 'master' into 3689-update
2022-11-07 16:33:21 +05:00
Andrey Rahmatullin
77cd511a5e
Merge pull request #5489 from PluT00/deprecate-NoimagesDrop
...
Deprecate scrapy.pipelines.images.NoimagesDrop
2022-11-05 14:18:19 +05:00
Andrey Rahmatullin
8004075823
Merge pull request #5699 from elacuesta/crawlspider-callback-keyword-arguments
...
CrawlSpider: pass cb_kwargs from process_request
2022-11-02 17:35:03 +05:00
Andrey Rahmatullin
a95a338eea
Merge pull request #5599 from tonal/patch-1
...
Partial in is_generator_with_return_value
2022-10-31 20:08:16 +05:00
Eugenio Lacuesta
b18560315b
Add tests
2022-10-30 18:28:16 -03:00
Andrey Rakhmatullin
b71d0292d5
Add a test for processing partial callbacks.
2022-10-27 18:13:47 +06:00
Godson
3a34fa8399
Get the event loop from event_loop_policy to avoid a deprecation warning ( #5689 )
2022-10-27 14:02:12 +02:00
Andrey Rakhmatullin
ca50af6453
Remove an unused import.
2022-10-27 17:12:26 +06:00
Andrey Rahmatullin
5780ccba55
Merge branch 'master' into deprecate-NoimagesDrop
2022-10-27 15:46:32 +05:00
Adrián Chaves
46dd152b3e
Merge remote-tracking branch 'upstream/master' into more-lenient-proxying
2022-10-26 16:55:04 +02:00
Godson-Gnanaraj
830e1c5dd8
Add test for parsing decorated methods
2022-10-26 01:26:54 +05:30
Andrey Rahmatullin
b33244e2f0
Fix the flake8 per-file ignore syntax ( #5688 )
2022-10-21 16:17:04 +02:00
Matthew Donoughe
12a26755ae
improve render_templatefile
2022-10-20 20:14:43 -04:00
Matthew Donoughe
c85de90819
fix path to tox.ini
2022-10-20 19:44:35 -04:00
Matthew Donoughe
065db7b566
fix some mypy issues
2022-10-19 08:28:26 -04:00
Matthew Donoughe
93d82648e5
resolve this path too
2022-10-19 08:08:21 -04:00
Matthew Donoughe
fb26e6b650
resolve path to search in error
2022-10-18 20:21:11 -04:00
Matthew Donoughe
7daf735f45
downgrade type hint syntax
2022-10-18 20:07:29 -04:00
Matthew Donoughe
40d9ca3bdd
use pathlib
2022-10-17 17:40:10 -04:00
Adrián Chaves
06c8f673af
2.7 release notes ( #5680 )
...
* Fix the display name of documented fingerprinter class methods
* Initial draft for the Scrapy 2.7 release notes
* Update VERSION and PREVIOUS_VERSION references
* Clarify the restrictions lifted for item field output names
* Fix the description of the BOM bug fix
* Fix the note about changes in MIME sniffing
* Fix typo
* Extend highlights
* Fyx typo
2022-10-17 18:04:29 +05:00
Andrey Rahmatullin
ea6315b404
Merge pull request #5679 from wRAR/template-asyncio-reactor
...
Change TWISTED_REACTOR in the default template.
2022-10-15 14:54:59 +05:00
Adrián Chaves
960a7f68f6
Verify that the installed asyncio event loop matches ASYNCIO_EVENT_LOOP ( #5529 )
...
Co-authored-by: Laerte Pereira <5853172+Laerte@users.noreply.github.com>
2022-10-15 11:27:00 +02:00
Adrián Chaves
75bb516edb
Adapt tests to the new value of TWISTED_REACTOR for new projects
2022-10-15 10:26:38 +02:00
Mohammadtaher Abbasi
043575123c
Add async callback support to the parse command ( #5577 )
2022-10-15 10:11:05 +02:00
Andrey Rakhmatullin
5bf4260679
Update flake8.
2022-10-10 11:14:20 +06:00
Andrey Rakhmatullin
eeb199adda
Fix flake8 issues in previously ignored files.
2022-10-10 11:10:59 +06:00
Andrey Rahmatullin
d96c465dde
Merge pull request #5639 from Laerte/fix/test_batch_path_differ
...
fix: `batch_path_differ` test
2022-10-05 14:44:30 +05:00
Eugenio Lacuesta
da8f915091
Adapt for asyng generator callbacks
2022-10-02 17:37:10 -03:00
Eugenio Lacuesta
80194f1c03
CrawlSpider: add support for async def callbacks
2022-10-02 15:22:06 -03:00
Laerte Pereira
3ca7877781
chore: Skip `batch_path_differ` test on Windows
2022-09-29 11:51:50 -03:00
Gábor Lipták
385acd5598
Match pyOpenSSL and service_identity to Twisted
...
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
2022-09-24 21:33:02 -04:00
Adrián Chaves
77c055ee28
Relax Proxy-Authorization restrictions
2022-09-14 14:47:14 +02:00
Mikhail Korobov
90b8503789
Merge pull request #5611 from mtabbasi/issue-5601
...
BOM should take precedence over Content-Type header when detecting the encoding
Fixes GH-5601.
2022-09-13 15:07:50 +05:00
Laerte Pereira
582a6bf6db
refactor: Use `safe_url_string` to standardize url output
2022-09-06 10:03:18 -03:00
Laerte Pereira
1289422284
chore: Skip `test_ipv6_default_name_resolver` test if w3lib version >= 2.0.0
2022-09-06 08:17:58 -03:00
Laerte Pereira
f4bcc3e67d
fix: failed tests
2022-09-06 01:15:41 -03:00
Mohammadtaher Abbasi
a988c4b78b
add test
2022-08-29 17:08:30 +04:30
Adrián Chaves
d599fff2b9
Test the life cycle of a storage file
2022-07-29 19:12:20 +02:00
Mikhail Korobov
56e2eeac10
fix typing issues by upgrading mypy
2022-07-27 09:41:12 +05:00
Mikhail Korobov
4dde2f2c36
Merge branch 'master' into asyncio-parse-fixes
2022-07-27 09:32:54 +05:00
Adrián Chaves
00ccb02f1f
Merge remote-tracking branch 'upstream/2.6'
2022-07-25 14:13:22 +02:00
Adrián Chaves
af7dd16d8d
Merge pull request from GHSA-9x8m-2xpf-crp3
...
* Enforce matching proxy request meta and Proxy-Authorization header
* Cover proxy credential security fix in the release notes
* Remove extra empty line
* Reword the security issue description
* Address scenario where Proxy-Authorization is unexpectedly removed by a prior middleware
* Set the release date of Scrapy 2.6.2 and 1.8.3
2022-07-25 13:15:17 +02:00