scrapy/scrapy/commands
gunblues 034e2c31c7
Use a non-zero exit code when a pipeline's open_spider method throws an exception (#4207)
* fix issue 4175 - Scrapy does not use a non-zero exit code when pipeline's open_spider throws the exception

* remove extra blank lines

* remove redundant code

* remove blank line at end of file

* more suitable naming for response and make if-condition shorter

* avoid error - AttributeError: 'Deferred' object has no attribute 'result'

* use getattr to make code concisely

* add test

* remove useless file

* modify test class name

* remove unneccessary files

* Fix Flake8-reported issue

* fix these items which are suggested by Gallaecio
・Sort those imports at tests/test_cmdline_crawl_with_pipeline/__init__.py
・Remove the unused setUp method.
・Remove comments generated by Scrapy’s project generation tool.
・Remove the [deploy] section from the scrapy.cfg file (I don’t think it’s needed here)
・Remove BOT_NAME and NEWSPIDER_MODULE from settings.py (I think there are not needed either, although I’m less sure about NEWSPIDER_MODULE)

* have to reserve BOT_NAME, SPIDER_MODULES in settings.py

* Remove unneeded empty lines

* Empty __init__.py file with unneeded comments

* Remove an unneeded empty line at the end

* Remove unneeed empty line from __init__.py file

* Update __init__.py

* Update __init__.py

* Update exception.py

* Update normal.py

* Update __init__.py

* Update __init__.py

* fix W391 blank line at end of file

Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-02-26 00:46:05 +05:00
..
__init__.py fix typo in ScrapyCommand.help docstring (#4046) 2019-10-01 16:29:48 +02:00
bench.py Remove six.moves occurrences 2019-11-03 00:00:49 -03:00
check.py Remove unused imports 2019-11-21 14:21:17 +01:00
crawl.py Use a non-zero exit code when a pipeline's open_spider method throws an exception (#4207) 2020-02-26 00:46:05 +05:00
edit.py Separated import statements 2017-11-19 18:09:38 -04:00
fetch.py Fix E502: backslash is redundant between brackets (#4238) 2019-12-17 13:53:15 +01:00
genspider.py Remove __future__ imports 2019-11-02 23:26:38 -03:00
list.py Merge remote-tracking branch 'upstream/master' into remove-six-code 2019-11-20 12:41:38 -03:00
parse.py fix E22X flake8 2020-02-21 08:39:14 +01:00
runspider.py Move install_asyncio_reactor() from commands to CrawlerProcess. 2019-12-13 18:11:49 +05:00
settings.py Merge remote-tracking branch 'upstream/master' into remove-six-code 2019-11-20 12:41:38 -03:00
shell.py Move a bunch of "from twisted.internet import reactor" inside functions. 2019-12-13 18:07:55 +05:00
startproject.py Fix E502: backslash is redundant between brackets (#4238) 2019-12-17 13:53:15 +01:00
version.py Merge remote-tracking branch 'upstream/master' into remove-six-code 2019-11-08 12:29:15 -03:00
view.py Remove unused imports 2019-11-21 14:21:17 +01:00