remove now redundant add_thumbnail functionality

backend/appsettings/serializers.py

@@ -44,7 +44,6 @@ class AppConfigDownloadsSerializer(
     format = serializers.CharField(allow_null=True)
     format_sort = serializers.CharField(allow_null=True)
     add_metadata = serializers.BooleanField()
-    add_thumbnail = serializers.BooleanField()
     subtitle = serializers.CharField(allow_null=True)
     subtitle_source = serializers.ChoiceField(
         choices=["auto", "user"], allow_null=True

backend/appsettings/src/config.py

@@ -35,7 +35,6 @@ class DownloadsConfigType(TypedDict):
     format: str | None
     format_sort: str | None
     add_metadata: bool
-    add_thumbnail: bool
     subtitle: str | None
     subtitle_source: Literal["user", "auto"] | None
     subtitle_index: bool
@@ -85,7 +84,6 @@ class AppConfig:
             "format": None,
             "format_sort": None,
             "add_metadata": False,
-            "add_thumbnail": False,
             "subtitle": None,
             "subtitle_source": None,
             "subtitle_index": False,

backend/download/src/yt_dlp_handler.py

@@ -482,10 +482,7 @@ class DownloadPostProcess(DownloaderBase):
 
     def embed_metadata(self):
         """embed metadata in media file"""
-        meta = self.config["downloads"].get("add_metadata")
-        thumb = self.config["downloads"].get("add_thumbnail")
-
-        if not meta and not thumb:
+        if not self.config["downloads"].get("add_metadata"):
             return
 
         queue = RedisQueue(self.VIDEO_QUEUE)

backend/video/src/index.py

@@ -433,8 +433,6 @@ class YoutubeVideo(YouTubeItem, YoutubeSubtitle):
 
         if self.config["downloads"].get("add_metadata"):
             self._embed_text_data()
-
-        if self.config["downloads"].get("add_thumbnail"):
             self._embed_artwork()
 
     def _embed_text_data(self):

frontend/src/api/loader/loadAppsettingsConfig.ts

@@ -16,7 +16,6 @@ export type AppSettingsConfigType = {
     format: string | null;
     format_sort: string | null;
     add_metadata: boolean;
-    add_thumbnail: boolean;
     subtitle: string | null;
     subtitle_source: string | null;
     subtitle_index: boolean;

frontend/src/pages/Home.tsx

@@ -89,7 +89,6 @@ export type DownloadsType = {
   format: boolean;
   format_sort: boolean;
   add_metadata: boolean;
-  add_thumbnail: boolean;
   subtitle: boolean;
   subtitle_source: boolean;
   subtitle_index: boolean;

frontend/src/pages/SettingsApplication.tsx

@@ -58,7 +58,6 @@ const SettingsApplication = () => {
   const [downloadsFormatSort, setDownloadsFormatSort] = useState<string | null>(null);
   const [downloadsExtractorLang, setDownloadsExtractorLang] = useState<string | null>(null);
   const [embedMetadata, setEmbedMetadata] = useState(false);
-  const [embedThumbnail, setEmbedThumbnail] = useState(false);
 
   // Subtitles
   const [subtitleLang, setSubtitleLang] = useState<string | null>(null);
@@ -116,7 +115,6 @@ const SettingsApplication = () => {
     setDownloadsFormatSort(appSettingsConfigData?.downloads.format_sort || null);
     setDownloadsExtractorLang(appSettingsConfigData?.downloads.extractor_lang || null);
     setEmbedMetadata(appSettingsConfigData?.downloads.add_metadata || false);
-    setEmbedThumbnail(appSettingsConfigData?.downloads.add_thumbnail || false);
 
     // Subtitles
     setSubtitleLang(appSettingsConfigData?.downloads.subtitle || null);
@@ -476,9 +474,8 @@ const SettingsApplication = () => {
                         </li>
                       </ul>
                     </li>
-                    <li>Embedding metadata adds additional metadata directly to the mp4 file.</li>
                     <li>
-                      Embedding the thumbnail embeds the video thumbnail as a cover.jpg to the mp4
+                      Embedding metadata adds additional metadata and thumbnails directly to the mp4
                       file.
                     </li>
                   </ul>
@@ -533,16 +530,6 @@ const SettingsApplication = () => {
                   updateCallback={handleUpdateConfig}
                 />
               </div>
-              <div className="settings-box-wrapper">
-                <div>
-                  <p>Embed Thumbnail</p>
-                </div>
-                <ToggleConfig
-                  name="downloads.add_thumbnail"
-                  value={embedThumbnail}
-                  updateCallback={handleUpdateConfig}
-                />
-              </div>
             </div>
             <div className="info-box-item">
               <h2 id="subtitles">Subtitles</h2>

frontend/src/stores/AppSettingsStore.ts

@@ -23,7 +23,6 @@ export const useAppSettingsStore = create<AppSettingsState>(set => ({
       format: null,
       format_sort: null,
       add_metadata: false,
-      add_thumbnail: false,
       subtitle: null,
       subtitle_source: null,
       subtitle_index: false,