Adrian
1157b3e235
Add a middleware to detect response.meta copies ( #7588 )
2026-07-22 13:27:31 +02:00
Adrian
a54c438da1
Provide extras for optional dependencies ( #7596 )
2026-07-22 10:44:26 +02:00
Andrey Rakhmatullin
64358f547b
Replace import tests with find_spec() or importorskip(). ( #7755 )
2026-07-22 08:58:05 +02:00
Andrey Rakhmatullin
ca21306df7
Reactorless import hook improvements. ( #7747 )
...
* Reactorless import hook improvements.
* Replace prints with logging.
* More tests.
* Uninstall the import hook earlier.
* Add pragma: no branch.
2026-07-21 19:58:40 +05:00
Mridankan Mandal
1ddf024b89
Log ignored responses exceeding DOWNLOAD_MAXSIZE ( #7742 )
...
* Log ignored responses exceeding DOWNLOAD_MAXSIZE
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
* Use caplog in compression warning test
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
* Make compression warning test robust
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
---------
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
2026-07-21 18:15:30 +05:00
Andrey Rakhmatullin
394c2797f3
Remove non-Twisted uses of zope.interface ( #7731 )
2026-07-21 13:30:21 +02:00
Andrey Rakhmatullin
e322905255
Assorted test fixes, part 3. ( #7741 )
...
* Assorted test fixes, part 3.
* Fix asyncio_enabled_reactor_different_loop.py on 3.14.
2026-07-21 15:54:43 +05:00
Andrey Rakhmatullin
4ee3676464
Test restructuring ( #7736 )
2026-07-21 12:44:56 +02:00
Andrey Rakhmatullin
36bf1185e5
Modernize code examples, drop docs for nonexistent `MEMDEBUG_NOTIFY` ( #7737 )
2026-07-21 12:22:04 +02:00
Andrey Rakhmatullin
b1b9efb473
Rewrite GCSFilesStore tests to use mocking. ( #7727 )
2026-07-21 11:43:36 +02:00
Andrey Rakhmatullin
1c5404dce5
Add docs about running Scrapy from apps and notebooks. ( #7751 )
2026-07-21 11:23:52 +02:00
Andrey Rakhmatullin
4d4a04f318
Improve a flaky test_stacktracedump_dump_stacktrace(). ( #7753 )
2026-07-21 13:17:56 +05:00
Andrey Rakhmatullin
e80f94fe8a
Tests for extensions.debug and extensions.memdebug. ( #7749 )
...
* Tests for extensions.debug and extensions.memdebug.
* Use a unique class in test_crawl_sets_stats.
* Don't assume a single log message.
2026-07-20 15:21:28 +02:00
Madan kumar
7faf20c6b5
Merge repeated curl -d/--data options in Request.from_curl() ( #7728 )
...
curl merges repeated -d/--data/--data-raw options into a single request
body joined with "&" (e.g. `curl -d a=1 -d b=2` sends `a=1&b=2`). scrapy's
DataAction kept only the last value, silently dropping the earlier ones, so
`Request.from_curl("curl -d a=1 -d b=2 ...")` produced a body of just `b=2`.
Accumulate the values with "&" to match curl. -H/--header and -b/--cookie
already accumulate via action="append"; -d was the only repeatable data flag
that didn't.
2026-07-20 15:18:55 +02:00
Andrey Rakhmatullin
a591d15c04
Deprecate Spider.log(). ( #7739 )
2026-07-20 14:59:55 +02:00
Andrey Rakhmatullin
11d7a05a6f
Deprecate is_secure=False for s3://. ( #7738 )
2026-07-20 14:59:11 +02:00
Andrey Rakhmatullin
d8ba1571e7
Assorted docs fixes, part 2. ( #7725 )
...
* Assorted docs fixes, part 2.
* Second pass.
* Address feedback.
2026-07-14 00:49:44 +05:00
Adrian
b3670369b8
Solve the feed Path issue ( #7674 )
...
* Solve the feed Path issue
* Address additional, related issues
2026-07-13 22:46:41 +05:00
Andrey Rakhmatullin
c9446931a8
Use external mitmproxy. ( #7720 )
2026-07-09 17:02:05 +02:00
Shaquon Kelley
9d9950df69
Fix silent data loss in CsvItemExporter ( closes #4002 ) ( #7651 )
...
Adds state tracking to CsvItemExporter to detect when auto-detected fields drop data on items. Injects a warning instructing users to configure FEED_EXPORT_FIELDS. Includes unit tests. Corrects the false positive logic in stalled PR #7613 .
2026-07-08 17:49:29 +05:00
Andrey Rakhmatullin
61f99f2df1
More granular untyped defs checking in tests. ( #7712 )
2026-07-08 10:05:45 +02:00
Andrey Rakhmatullin
bdf3067935
Assorted docs fixes, part 1. ( #7710 )
2026-07-07 18:39:34 +05:00
Adrian
c5ec881f1d
Update tools ( #7724 )
2026-07-07 17:27:26 +05:00
Adrian Chaves
feb692f552
Bump version: 2.16.0 → 2.17.0
2026-07-07 12:26:52 +02:00
Adrian
9523e1ec8c
Merge commit from fork
2026-07-07 12:25:36 +02:00
Andrey Rakhmatullin
5ccc8dbe8a
Release notes for 2.17.0 ( #7723 )
...
* Cover 2.17.0 in the release notes up to dd10cb8 .
* Fix a copypasted issue number.
* Address minor issues
* Minor fixes
* Cover additional deprecations introduced while improving test coverage
* versionadded/versionchanged improvements
* Add a versionadded to the give_up_log_level docstring
---------
Co-authored-by: Adrian Chaves <adrian@zyte.com>
2026-07-07 14:57:42 +05:00
Adrian
dd10cb8e9a
LxmlLinkExtractor: add deny_attrs and deny_tags ( #7679 )
2026-07-05 16:46:22 +05:00
Fat-Coder-CN
870803b7fb
fix-utf16-response-test-on-big-endian-systems ( #7508 )
2026-07-01 12:16:01 +05:00
Adrian
361f689df7
Improve test coverage for crawler.py ( #7682 )
...
* Improve test coverage for crawler.py
* Silence mypy warnings
* Improve test coverage for crawler.py
2026-07-01 11:53:07 +05:00
Andrey Rakhmatullin
fc5216f156
Clarify/cleanup Selector.type ( #7704 )
2026-07-01 08:50:32 +02:00
Adrian
a6d6a48aa6
Keep Item fields in definition order ( #7694 )
2026-06-30 16:26:22 +02:00
Andrey Rakhmatullin
00098cb596
Assorted docstring fixes ( #7698 )
...
* Smaller fixes.
* Add more code blocks in docstrings.
* Queue stuff.
* Response stuff.
* Round 2.
* Address feedback.
2026-06-30 18:27:32 +05:00
Gaurav Yadav
deb7e2861e
Fix _get_tag_name() crash for non-string elem.tag ( #7686 ) ( #7687 )
...
* Fix _get_tag_name() crash for non-string elem.tag (#7686 )
* test: improve non-string tag test accuracy and add direct unit test
* test: use minimal payload for non-string tag test
* test: address Adrian+syncrain PR feedback
- remove first docstring line (Adrian: unnecessary)
- replace weak isinstance assert with no-op call
- keep Cython function mention (Adrian: wording is great)
* test: replace silent call with assert results == [] per Adrian
* chore: drop accidental pyproject.toml and uv.lock changes
2026-06-30 17:49:47 +05:00
Adrian
6ad8a043ca
Fix genspider --editor ( #7683 )
2026-06-30 12:05:42 +02:00
Andrey Rakhmatullin
52147017b4
Cleanup cookie handling in request_to_curl() ( #7684 )
...
* Adjust CookiesT.
* Drop list of plain cookie dicts support from request_to_curl().
* Extract _decode_cookie().
* Unify logging.
* Extract _to_verbose_cookies().
* Sync and type hint _cookie_to_set_cookie_value() in tests.
* Add tests for bytes in Request.cookies.
* Type hint assertCookieValEqual().
2026-06-29 21:49:09 +05:00
tanishqtayade
6591cb756c
Fix to LocalCache with limit=0 still stores items rather than disabling the cache ( #7663 )
...
* Fix cell-var-from-loop in _send_catch_log_deferred
Replace lambda capturing receiver by reference with a default
argument to capture it by value, fixing a potential bug where
all deferred callbacks could reference the last receiver in the
loop instead of their respective receivers.
Removes the pylint disable comment and TODO that were suppressing
this issue.
* chore: trigger CI rerun for mypy network error
* Fix mypy error: pass receiver via addBoth args instead of lambda default
* style: apply pre-commit ruff formatting
* fix: LocalCache with limit=0 incorrectly stores items
When limit=0 is passed to LocalCache (e.g. when DNSCACHE_ENABLED=False),
the condition 'if self.limit' evaluates to False due to Python's truthiness
rules, causing items to be stored despite the cache being disabled.
This leads to an unbounded memory leak during long crawls when DNS caching
is explicitly disabled.
Fix changes the condition to 'if self.limit is not None' and adds an early
return when limit=0 to correctly handle the disabled cache case.
* test: add resolver-level regression tests for DNSCACHE_ENABLED=False
Add two regression tests that verify DNS results are not stored in
dnscache when DNSCACHE_ENABLED=False (cache_size=0):
- test_caching_hostname_resolver_dnscache_disabled_rejects_storage:
verifies _CachingResolutionReceiver does not write to dnscache
when CachingHostnameResolver is initialized with cache_size=0
- test_caching_threaded_resolver_dnscache_disabled_rejects_storage:
verifies dnscache rejects storage at the LocalCache level
when limit=0
* test: drop misleading threaded resolver test
it was writing directly to dnscache, not actually going through
CachingThreadedResolver at all. the threaded resolver already has
its own if dnscache.limit: guard so the bug doesnt affect it anyway.
keeping only the hostname resolver test which covers the actual
bug path through _CachingResolutionReceiver
* test: clean up comments in resolver test
* test: remove unnecessary comment
2026-06-29 21:37:06 +05:00
Javier
4b2b56f384
Update on Request objects ( #7286 )
2026-06-29 15:34:12 +02:00
Adrian
9559cbee1e
Solve timing issues with HTTP cache tests? ( #7692 )
2026-06-29 17:21:20 +05:00
greymoth
185d6b9a20
Fix request_to_curl() corrupting dict cookies with bytes keys/values ( #7675 )
...
* Fix request_to_curl() corrupting dict cookies with bytes keys/values
PR #7603 made the list-cookie branch of request_to_curl() bytes-safe via
_cookie_value_to_unicode(), but left the sibling dict-cookie branch using
raw f-string interpolation. A dict cookie with bytes keys/values (a
supported and common form, e.g. Request(url, cookies={b"k": b"v"})) was
rendered as --cookie 'b'k'=b'v'' instead of --cookie 'k=v', producing a
broken curl command.
Route the dict branch through the same _cookie_value_to_unicode() helper,
mirroring the list branch. Add a regression test.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: apply _cookie_value_to_unicode to list-branch cookie key/value
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-27 00:53:32 +05:00
Andrey Rakhmatullin
4b40d2d06a
Close various garbage collectible resources (mostly in tests) ( #7644 )
...
* Set TELNETCONSOLE_ENABLED=False in get_crawler().
* Make _get_console_and_portal() a context manager.
* Allow PYTHONTRACEMALLOC in tox.
* Close the event loop in test_custom_asyncio_loop_enabled_false().
* Close the handler in _uninstall_scrapy_root_handler().
* Close queues in test_squeues.py.
* Close empty queues in init_prios().
* Close PopenSpawn stdin and stdout explicitly.
* Silence the unclosed socket warning.
* Implement more methods in CustomStatsCollector.
* Link the Twisted issue.
* Close the connection on download_maxsize.
* Fix typing.
* Add a comment about CustomStatsCollector.
* Restore the coverage.
* Properly close fixture queues.
* More robust file closing in feed storages.
* Close the file in TestMarshalItemExporter.test_nonstring_types_item().
* Cleanup temporary file handling in test_exporters.py.
* Close the file in test_stats_file_failed().
* Use an explicit TextIOWrapper in XmlItemExporter.
2026-06-26 23:05:08 +05:00
Adrian
cf5607f8bc
Undeprecated the basic FormRequest API ( #7671 )
2026-06-26 17:35:46 +02:00
Adrian
edc353c975
Improve test coverage for shell/ ( #7680 )
...
* Improve test coverage for shell/
* Address test issues
* Make the shell config test more reliable on Windows
2026-06-26 19:40:36 +05:00
Adrian
1b940a75ac
Improve the item pipeline docs ( #7676 )
2026-06-26 16:18:22 +05:00
Adrian
7ab404c725
Add a documentation page about security ( #7678 )
2026-06-26 11:58:37 +02:00
Adrian
0ccddb4f61
Improve test coverage for contracts ( #7677 )
2026-06-26 11:47:30 +02:00
Adrian
0007676e8d
Improve test coverage for http/ ( #7672 )
...
* Improve test coverage for http/
* Use isinstance() instead of type()
2026-06-26 12:21:12 +05:00
Sriniketh24
d8d7de2339
Fix FTPDownloadHandler not closing FTP connection after download ( #7667 )
2026-06-26 04:26:59 +02:00
Adrian
74e6b61071
Make DOWNLOADER_CLIENT_TLS_CIPHERS=None enable Twisted defaults ( #7665 )
...
* Make DOWNLOADER_CLIENT_TLS_CIPHERS=None enable Twisted defaults
* Remove pointless comment
* Remove unnecessary mypy comments
2026-06-25 16:44:51 +05:00
Adrian
c690eac770
Document “logging settings” as special settings ( #7668 )
2026-06-25 16:34:37 +05:00
Adrian
65e8954a06
Improve test coverage for spider middlewares ( #7664 )
2026-06-25 15:35:25 +05:00
Adrian
dd4549e6f9
Improve test coverage for downloader middlewares ( #7655 )
...
* Improve test coverage for downloader middlewares
* Improve coverage further
2026-06-25 01:48:28 +05:00
Adrian
b78ab3d6c8
Improve test coverage for settings/ ( #7654 )
2026-06-23 14:47:21 +05:00
smellslikeml
fb3455304d
Add content-based image filtering example ( #4954 )
2026-06-23 09:04:19 +02:00
tanishqtayade
f5a62a293f
Fix cell-var-from-loop bug in _send_catch_log_deferred ( #7649 )
2026-06-23 09:04:01 +02:00
Adrian
f605defefc
Document scrapy-lint, remove start_url check ( #7627 )
...
* Document scrapy-lint, remove start_url check
* Remove the offsite URL check in favor of scrapy-lint
2026-06-22 20:12:16 +05:00
Adrian
7499d17e28
Improve test coverage for responsetypes.py ( #7646 )
...
* Improve test coverage for responsetypes.py
* Solve typing issues
2026-06-22 20:10:38 +05:00
Adrian
b6596de317
Do not ignore CrawlerProcess settings ( #7647 )
...
* Do not ignore CrawlerProcess settings
* Update test_crawlerrunner_accepts_crawler
2026-06-22 20:10:10 +05:00
Shashank S. Khasare
75f05d4e80
Add test coverage for scrapy.utils.decorators ( #7645 )
2026-06-22 08:50:11 +02:00
Andrey Rakhmatullin
c9f952c258
Refactor and improve catching warnings in tests. ( #7643 )
2026-06-19 21:04:34 +02:00
Adrian
6393858c7e
Improve coverage resolver ( #7642 )
...
* Improve test coverage for resolver.py
* Make the Twisted code more readable
2026-06-19 23:26:54 +05:00
Adrian
d2842a205c
Improve coverage statscollectors ( #7641 )
2026-06-19 16:59:25 +02:00
Adrian
7b3f88f8ab
Improve test coverage for pqueues.py ( #7640 )
2026-06-19 18:28:32 +05:00
Adrian
699c93f6b2
Complete test coverage for linkextractors ( #7639 )
...
* Complete test coverage for linkextractors
* pylint: disable use-implicit-booleaness-not-comparison
2026-06-19 14:22:03 +05:00
Andrey Rakhmatullin
3f3cb885ed
Address warnings in tests. ( #7637 )
2026-06-19 06:55:02 +02:00
Vishal Gawade
e5e48883b5
Deprecate ScrapyCommand.help() ( #7633 )
...
Co-authored-by: Vishal Gawade <vishalgw@amazon.com>
2026-06-19 06:49:32 +02:00
Lions-1
abbf3b95fc
tests: integration coverage for memusage extension ( #7017 )
2026-06-19 06:41:26 +02:00
Andrey Rakhmatullin
fada8be1db
Fix Proxy-Authorization handling in BaseStreamingDownloadHandler ( #7630 )
2026-06-17 11:56:22 +02:00
JSap0914
b7824db573
Fix rel_has_nofollow to be case-insensitive per HTML spec ( #7632 )
...
The HTML specification states that link type keywords like 'nofollow'
are ASCII case-insensitive. Sites using rel="NoFollow" or rel="NOFOLLOW"
were incorrectly treated as follow links, causing Scrapy to crawl pages
it should skip.
Fix: add .lower() before the token split so all casing variants of
'nofollow' are correctly recognized.
Co-authored-by: JSap0914 <JSap0914@users.noreply.github.com>
2026-06-17 14:48:43 +05:00
Kushal Gupta
0a4a92e843
Fix image store ACL settings for S3 and GCS ( #7614 )
...
* Fix image store ACL settings for S3 and GCS
* Fix typing issues in ImagesPipeline ACL settings
* Fix typing issues in ImagesPipeline ACL settings
* Call parent _update_stores in ImagesPipeline
2026-06-16 00:24:44 +05:00
Adrian
e74647572d
Test SignalManager.disconnect_all() ( #7625 )
2026-06-15 14:18:29 +05:00
Syncrain
cfef12392a
Fix request_to_curl handling of verbose cookies dictionaries ( #7603 )
2026-06-15 08:46:30 +02:00
Andrey Rakhmatullin
4f241b73be
Fix deprecation warnings with pytest 9.1. ( #7621 )
2026-06-15 08:45:26 +02:00
Andrey Rakhmatullin
9893a7fac6
Fix deprecation warnings with pyOpenSSL 26.3.0. ( #7619 )
2026-06-15 08:44:33 +02:00
Nishita Matlani
f63a3aff25
Fix strip_url() removing default port from password. ( #7605 )
2026-06-15 08:41:55 +02:00
Andrey Rakhmatullin
3a36955261
Assorted test fixes ( #7616 )
2026-06-15 08:39:58 +02:00
Adrian
af30cfea12
Complete coverage for addons.py ( #7612 )
2026-06-12 16:15:36 +02:00
Adrian
983e6c1182
Link.__eq__: return NotImplemented instead of raising NotImplementedError ( #7611 )
2026-06-12 14:56:15 +02:00
Adrian
b08ed1cf05
Add coverage for DummySpiderLoader.find_by_request() ( #7608 )
2026-06-12 13:13:17 +02:00
Adrian
7afc875081
Add coverage for Item.__delitem__() ( #7610 )
2026-06-12 15:32:38 +05:00
Adrian
a8ffdcf851
Implement HTTP Auth settings and request metadata keys ( #7590 )
...
* Implement HTTP Auth settings and request metadata keys
* Fix doc-tests
* Require the domain to be set when using settings
2026-06-11 15:56:53 +05:00
Adrian
c99f6e2209
Document the SPIDER_MODULES hack to lower startup time and memory usage ( #7600 )
2026-06-11 12:10:49 +02:00
Labib Bin Salam
e0a7de7213
Document cb_kwargs/meta deep-copy when JOBDIR is set ( #7573 )
...
When JOBDIR is enabled, requests are serialized to disk with pickle, so
the objects stored in a request's cb_kwargs and meta are deep-copied on
the round trip. Callbacks then receive copies rather than the original
objects, which is easy to miss and can silently break code that relies on
sharing mutable state. Add a note to the request serialization section of
the jobs docs and a cross-referenced caution to the Request.cb_kwargs
attribute docs.
Closes #6120
2026-06-11 14:40:15 +05:00
Adrian
e7f229f5b2
Clarify the first-class-citizen nature of asyncio support ( #7599 )
2026-06-11 10:51:46 +02:00
Andrey Rakhmatullin
4cb049cb15
Small docs fixes. ( #7598 )
2026-06-11 10:51:03 +02:00
msn
ad4549673b
Remove set_asyncio_event_loop call from Shell._schedule ( #7594 )
...
Co-authored-by: Mayuresh <mayuresh@Mayureshs-MacBook-Air.local>
2026-06-11 10:45:25 +02:00
Syncrain
ba28630c98
Validate reversed telnet console port ranges ( #7593 )
2026-06-11 12:47:00 +05:00
Adrian
2d0a898e2d
tox.ini: pinned, typing → min, mypy ( #7595 )
2026-06-11 12:10:48 +05:00
msn
93a627ba1c
Prevent scrapy shell from starting spider requests ( #7557 )
...
* Prevent scrapy shell from starting spider requests
* Run pre-commit fixes
* Update shell architecture notes
---------
Co-authored-by: Mayuresh <mayuresh@Mayureshs-MacBook-Air.local>
2026-06-11 00:59:03 +05:00
Andrey Rakhmatullin
cd25ece58a
Fix the check for sync ITEM_PROCESSOR methods. ( #7589 )
...
* Fix the check for sync ITEM_PROCESSOR methods.
* Typo.
2026-06-11 00:22:30 +05:00
Andrey Rakhmatullin
beb6c51c17
Update default_settings, deprecate CRAWLSPIDER_FOLLOW_LINKS. ( #7592 )
2026-06-11 00:22:09 +05:00
Andrey Rakhmatullin
d59f9b644a
Replace _SettingsKeyT with str. ( #7586 )
2026-06-10 11:12:53 +02:00
Andrey Rakhmatullin
ddafb37a7c
Assorted test fixes ( #7585 )
...
* Fix the mitmproxy junitxml file name.
* Fix TestAsyncCrawlerRunnerHasSpider regression.
* Update split out file refs.
* Update the test_counter_handler() docstring.
2026-06-10 11:01:06 +02:00
Andrey Rakhmatullin
4e956bd2de
Add support for HTTP/2 and for SOCKS proxies to HttpxDownloadHandler, improve handler docs ( #7575 )
...
* Add support for HTTP/2 and SOCKS proxies to HttpxDownloadHandler.
* Update the docs.
* Trim the tables.
* Restore lost wording.
* Handlers docs improvements and fixes.
2026-06-09 01:10:44 +05:00
Adnan Awan
d2290c35c2
Allow configuring the log level of the retry give-up message ( #7567 )
...
* Allow configuring the log level of the retry give-up message
The "Gave up retrying ..." message was always logged at ERROR, which
inflates the log_count/ERROR stat even when giving up on a request is
expected (e.g. broad crawls hitting dead hosts).
Add a RETRY_GIVE_UP_LOG_LEVEL setting, a give_up_log_level argument to
get_retry_request(), and a give_up_log_level request meta key to override
it per request. The value accepts a level name ("WARNING") or number
(logging.WARNING). The default ("ERROR") preserves the previous behaviour.
Fixes #5297 , fixes #4622
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Address Adrian's review feedback: simplify and reorganize docs
- Move give_up_log_level reqmeta section before max_retry_times (alphabetical order)
- Simplify give_up_log_level section in request-response.rst (brief, links to setting)
- Simplify RETRY_GIVE_UP_LOG_LEVEL setting docs in downloader-middleware.rst
- Change 'When initialized' to 'When set' in max_retry_times section
- Docs now follow pattern of linking to complementary setting/meta key rather than duplicating information
Per Adrian's feedback: keep docs concise and cross-link setting ↔ meta key
* Address Adrian's code review feedback on RETRY_GIVE_UP_LOG_LEVEL feature
- Fix alphabetical ordering of give_up_log_level in request-response.rst
- Remove circular references: change 'see X for details' to 'see also X' pattern
- Simplify docstring for give_up_log_level parameter (4 lines → 2 lines)
- Update test domains from www.scrapytest.org to example.com
* Apply suggestion from @AdrianAtZyte
* Minor changes
* Fix example formatting.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Adrian <adrian@zyte.com>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2026-06-08 18:44:30 +05:00
Andrey Rakhmatullin
d9e2f5fbf7
Add settings for TLS min/max version as a replacement for the TLS method ( #6546 )
2026-06-08 11:54:10 +02:00
Omkar Kabde
5149e2c679
docs: switch `scrapy.Item` examples to dataclasses ( #7513 )
...
* docs: switch `scrapy.Item` examples to dataclasses
* make serializer doc generic
* use modern type hints
* docs/spiders: switch TestItem consumer snippets to attribute access
Since the TestItem migration to @dataclass, the existing
item["id"] = ... assignments would raise TypeError on copy-paste.
Switch to item.id = ... to match the new dataclass declaration.
The snippets sit under .. skip: next so docs-tests still pass either
way, but the change keeps the examples runnable for readers.
2026-06-08 12:40:28 +05:00
Andrey Rakhmatullin
58af57a3ea
Work around coverage slowness on Python 3.14. ( #7574 )
2026-06-05 15:34:02 +02:00
Adrian
b2d8b06be6
Support sending requests with "unsafe" URLs ( #7473 )
2026-06-05 11:51:03 +02:00
Ayush Singh
13c1c1faf8
Close GCS feed temp files after upload ( #7546 )
2026-06-04 20:11:50 +05:00
Ethan Kuo
df2f3d708e
fix open_in_browser() logic issue plus add new tests ( #7506 )
2026-06-04 16:24:50 +02:00
Andrey Rakhmatullin
fed75a6c76
Refactor test_crawl.py and test_crawler.py. ( #7566 )
2026-06-03 14:48:12 +02:00
Andrey Rakhmatullin
90deebe75e
Convert tests that fail with testfixtures 12.0.0 ( #7545 )
2026-06-03 09:16:24 +02:00
Fardin Alizadeh
44406806f8
fix typos ( #7564 )
2026-06-02 11:04:38 +02:00
SpiliosDmk
4a16550859
DOC -> Add missing documentation for CloseSpider & CoreStats ( #7421 )
...
* DOC -> Add missing documentation for CloseSpider & CoreStats
* Apply the suggestion from the PR review.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2026-05-20 13:27:24 +05:00
Andrey Rakhmatullin
abe9c63841
Bump version: 2.15.2 → 2.16.0
2026-05-19 17:27:16 +05:00
Andrey Rakhmatullin
a84b7850fc
Release notes for Scrapy 2.16.0. ( #7536 )
2026-05-19 17:26:21 +05:00
Andrey Rakhmatullin
55c17a8985
Disable mypy allow_any_generics. ( #7532 )
2026-05-18 15:54:06 +02:00
Andrey Rakhmatullin
f875af4a86
Add BaseStreamingDownloadHandler and migrate HttpxDownloadHandler to it. ( #7524 )
2026-05-18 15:52:13 +02:00
Andrey Rakhmatullin
a8a8f20d9c
Remove support for sync process_spider_output(). ( #7504 )
...
* Remove support for sync process_spider_output().
* Slight check fix.
* Don't expect exceptions from calling process_spider_output().
* Remove dead code.
* Fix test_deprecated_mw_spider_arg() to run all methods.
* Fix typing.
* Typos.
* Remove references to the removed section, move the universal section to the spider middleware docs and write it from a different perspective
* Fix indentation issue
* Minor rewordings
* older versions → lower versions
* Update news.rst
---------
Co-authored-by: Adrian Chaves <adrian@zyte.com>
2026-05-15 16:36:05 +05:00
Andrey Rakhmatullin
85c616c5c7
Fix certificate issuer verification on new Twisted. ( #7520 )
2026-05-14 19:56:05 +02:00
Olivia Choi
ae4a8e39e1
Document TLS method setting in avoiding bans guide ( #7518 )
...
* Document TLS method setting in avoiding bans guide
Mention DOWNLOADER_CLIENT_TLS_METHOD in the avoiding getting banned section.
* Update practices.rst
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2026-05-14 16:27:43 +05:00
Adrian
4cfe7a08cd
Add CITATION.cff ( #7519 )
2026-05-14 13:07:13 +02:00
Andrey Rakhmatullin
2d007bc450
Make more of the internal handler helpers private. ( #7510 )
2026-05-12 22:03:14 +02:00
Andrey Rakhmatullin
2798c03bb0
Add Python 3.14 to CI. ( #6604 )
...
* Add Python 3.14 (alpha3) to CI.
* Disable mitmproxy on 3.14 for now.
* 3.14.0-alpha.4.
* 3.14.0-alpha.5
* 3.14.0-beta2.
* 3.14 release.
* Fix test_non_pickable_object.
* Fix handling of file:/path feed URIs.
* Better mocking of streams for TextTestResult.
* Do not use .php in test_file_path() as it's now a known extension.
* Fix the URL in TestFeedExporterSignals.
* Fix typing.
* Bump more envs to 3.14.
* Silence pylint.
* Fix another test for .php handling change.
* Remove test_install_asyncio_reactor.
* More bumps to 3.14.
* Revert docs-tests to use 3.13.
* Debug options for Windows.
* Re-enable xdist.
* Revert Windows PYTEST_ADDOPTS.
* Silence loop policy deprecation warnings.
* Restore a lost pylint suppression.
* Update asyncio_enabled_reactor_same_loop.py to new Twisted.
* Fix RobotFileParser tests for Python 3.14.5.
2026-05-12 23:49:37 +05:00
Abhinav W
3b34ab88c0
docs: document daily log file rotation ( #7501 )
...
* docs: document daily log file rotation
* Skip the new snippet in doc tests
---------
Co-authored-by: Adrian <adrian@zyte.com>
2026-05-12 19:34:51 +05:00
Andrey Rakhmatullin
f7db039d1c
Update the TLS code to Twisted 26.4.0 ( #7347 )
...
* Unpin Twisted, add a twisted-trunk tox env (without http2 for now).
* Hide the _setAcceptableProtocols import.
* Silence ScrapyClientContextFactory HTTP/1.0 warnings.
* Update ScrapyClientTLSOptions for unreleased Twisted.
* Add twisted-trunk to CI.
* Update for new changes in Twisted trunk.
* Xfail a test failing with newer Twisted.
* Test Twisted trunk with extra-deps, update the ALPN code.
* Cleanup.
* Fix typing.
* Update relevant type hints for Twisted trunk.
* Update test_no_context_sharing().
* Silence a weird mypy error.
* Update Twisted versions, unpin pyOpenSSL.
* Update a comment.
* Silence pylint.
* Make a factory fixture.
* Improve the _setAcceptableProtocols comment.
* Set OP_LEGACY_SERVER_CONNECT on new Twisted too.
* Add Twisted[http2] to extra-deps-pinned.
2026-05-12 18:22:31 +05:00
Andrey Rakhmatullin
7fc84d372a
Cleanup/clarifications of proxy support and improvements for proxy tests ( #7496 )
...
* Run mitmproxy-based tests for every handler and improve them.
* Fixes for H2DownloadHandler.
* Revert "Fixes for H2DownloadHandler."
This reverts commit bcdbd097cd .
* Add TestHttpsProxy for HTTP11DownloadHandler.
* Use the configured context factory in ScrapyProxyAgent.
* Reword.
* Reword.
* pragma: no cover for H2DownloadHandler proxy code.
* Raise an exception for HTTPS proxies instead of using HTTP.
* Remove non-working proxy support and explicitly forbid HTTP.
* pragma: no cover
* Add a docs note about HTTPS proxies.
* Rename ScrapyProxyAgent.
2026-05-12 17:45:54 +05:00
Adrian
7f15ca92fc
sphinx-scrapy: 0.8.5 → 0.8.6 ( #7507 )
2026-05-12 12:49:23 +05:00
Andrey Rakhmatullin
5223dbe3fd
Pin pyOpenSSL to the versions allowing mutable contexts. ( #7494 )
2026-05-06 10:42:24 +02:00
Andrey Rakhmatullin
fc14a0ce59
Enable mypy warn_return_any. ( #7492 )
2026-05-04 22:24:47 +02:00
Andrey Rakhmatullin
33452f3aeb
Silence deprecation warnings in TestFormRequest. ( #7491 )
2026-05-04 22:20:21 +02:00
Albert Eduardovich N.
9776a72a6a
chore: simplify some code, get rid of nested fns where it's makes sence + pylint ( #7401 )
...
* chore: simplify some code, get rid of nested fns where it's makes sence
reasoning: https://wemake-python-styleguide.readthedocs.io/en/latest/pages/usage/violations/best_practices.html#wemake_python_styleguide.violations.best_practices.NestedFunctionViolation
* chore: address some pylint rules
* remove `pylint: disable=deprecated-class` from `reactor.py`
* fix typo
* fix another typo :)
* revert backward incompatible arg renames
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2026-05-04 23:32:46 +05:00
Adrián Chaves
8d69a7c865
Deprecate FormRequest in favor of form2request ( #6438 )
...
* WIP
* Add docs
* Remove FormRequest from tests
* Silence mypy issue
* Address docs-tests issues
---------
Co-authored-by: Adrian Chaves <adrian@zyte.com>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2026-05-04 22:38:29 +05:00
Andrey Rakhmatullin
f3868e11fb
Drop start_requests() support. ( #7490 )
2026-05-04 17:34:24 +05:00
Andrey Rakhmatullin
9ca206da64
Merge pull request #7487 from wRAR/deprecation-removals
...
Remove most of the 2.13.0 deprecations
2026-05-04 12:33:21 +05:00
Andrey Rakhmatullin
d05b241f64
Fix a code block in leaks.rst. ( #7489 )
2026-05-04 08:59:27 +02:00
Adrian
55c61646da
Merge branch 'master' into deprecation-removals
2026-05-04 08:52:12 +02:00
Andrey Rakhmatullin
c62a81d7dd
Drop HTTP/1.0 code. ( #7486 )
2026-05-04 08:50:41 +02:00
Sanjay M
a9324fbf76
Fix small documentation wording issues ( #7480 )
2026-05-04 08:43:21 +02:00
Andrey Rakhmatullin
9f02f6c16a
Drop spider args of Scraper methods.
2026-05-03 14:12:18 +05:00
Andrey Rakhmatullin
6cb2fe1fc3
Drop scrapy_components_versions().
2026-05-03 14:12:18 +05:00
Andrey Rakhmatullin
f24bc749ea
Require start_queue_cls.
2026-05-03 14:12:18 +05:00
Andrey Rakhmatullin
5fc40f07f3
Drop w3lib.url reexports.
2026-05-03 14:12:18 +05:00
Andrey Rakhmatullin
af7dcabebb
Drop AjaxCrawlMiddleware and escape_ajax().
2026-05-03 14:12:18 +05:00
Andrey Rakhmatullin
8ecfd20fcd
Remove InitSpider.
2026-05-03 14:12:16 +05:00
Andrey Rakhmatullin
14f49ab63c
Remove deprecated test utils.
2026-05-03 14:11:55 +05:00
Adrian
b9c2240040
sphinx-scrapy: 0.8.4 → 0.8.5 ( #7472 )
2026-04-29 14:17:26 +02:00
Albert Eduardovich N.
dd36fb7859
Improve handling of time deltas ( #7377 )
2026-04-29 09:53:40 +02:00
Andrey Rakhmatullin
30a54b72f0
Merge pull request #7470 from scrapy/2.15
...
Merge 2.15.2 into the main branch
2026-04-28 21:19:29 +05:00
Adrian Chaves
3d5ca9f433
Bump version: 2.15.1 → 2.15.2
2026-04-28 15:28:51 +02:00
Adrian
3a88cd0e2b
2.15.2 ( #7468 )
...
* sphinx-scrapy: 0.8.3 → 0.8.4 (#7467 )
* Release notes for 2.15.2
2026-04-28 15:26:42 +02:00
Andrey Rakhmatullin
988afe1454
Clarify dataloss/http2 tests. ( #7466 )
2026-04-28 14:35:41 +02:00
Adrian
528745b059
sphinx-scrapy: 0.8.3 → 0.8.4 ( #7467 )
2026-04-28 12:17:12 +02:00
Andrey Rakhmatullin
068aa69b35
Fixes for Python 3.14. ( #7460 )
2026-04-27 18:47:52 +05:00
Andrey Rakhmatullin
fc4c57e795
Fix the substitution pattern in open_in_browser(). ( #7459 )
...
* Fix the substitution pattern in open_in_browser().
* Formatting.
2026-04-24 13:54:37 +05:00
Andrey Rakhmatullin
4e25686b20
Merge branch '2.15'
2026-04-23 21:08:38 +05:00
Andrey Rakhmatullin
f3c5a6e75f
Bump version: 2.15.0 → 2.15.1
2026-04-23 19:57:44 +05:00
Andrey Rakhmatullin
416a454dc5
Release notes for 2.15.1. ( #7456 )
2026-04-23 19:51:00 +05:00
Adrian
3561748280
sphinx-scrapy: 0.7.1 → 0.8.3 ( #7454 )
2026-04-23 13:20:30 +05:00
Adrian
41f43f4649
sphinx-scrapy: 0.7.1 → 0.8.3 ( #7454 )
2026-04-23 10:03:09 +02:00
Andrey Rakhmatullin
b7cd42da39
Revert sharing of the SSL context in _ScrapyClientContextFactory. ( #7450 )
2026-04-22 19:02:01 +05:00
Adrian
da6dfae750
Restore 2.14 getwithbase, add a new method for class key deduplication ( #7449 )
...
* Restore 2.14 getwithbase, add a new method for class key deduplication
* Use the original getwithbase code, not some equivalent
* Fix mocking
* Test key exceptions
2026-04-22 19:01:59 +05:00
Andrey Rakhmatullin
320e40a044
Revert sharing of the SSL context in _ScrapyClientContextFactory. ( #7450 )
2026-04-22 19:01:01 +05:00
Adrian
294abed138
Restore 2.14 getwithbase, add a new method for class key deduplication ( #7449 )
...
* Restore 2.14 getwithbase, add a new method for class key deduplication
* Use the original getwithbase code, not some equivalent
* Fix mocking
* Test key exceptions
2026-04-22 19:00:39 +05:00
Andrey Rakhmatullin
27092b2cb7
Small download handler fixes and improvements ( #7441 )
...
* Popen cleanup.
* Improve the test for response headers.
* Fix default headers of Httpx and H2 handlers, add tests.
* Check Location in redirect tests.
* Simplify bindaddress tests.
* Add download_latency to HttpxDownloadHandler, add tests.
* Remove explicit method="GET".
* Don't expect a specific value in test_download_with_maxsize_very_large_file
* Use a non-existent scheme in test_unsupported_scheme.
* Remporarily rollback the test_download_latency test check.
* Better check in test_download_latency.
* Improve logic for StreamCloseReason.CANCELLED.
2026-04-21 18:27:16 +05:00
Hamzah Alshawwaf
9da14cdff1
Fix file extension extraction for URLs with query parameters ( #4225 ) ( #7414 )
...
* Fix file extension extraction for URLs with query parameters (#4225 )
* Prioritize parsed path for file extensions and add tests (#4225 )
2026-04-14 20:04:38 +05:00
NI283105
508367664f
Fix missing load_object import and grammar in docs ( #7417 )
...
Co-authored-by: NI <Nidotexe@gmail.com>
2026-04-09 15:31:01 +02:00
Andrey Rakhmatullin
47e25fbbb5
Bump version: 2.14.2 → 2.15.0
2026-04-09 17:00:40 +05:00
Andrey Rakhmatullin
1432455d35
Add a missing release notes change.
2026-04-09 16:59:18 +05:00
Andrey Rakhmatullin
7e881ce2d7
Release notes for 2.15.0 ( #7373 )
...
* Cover 2.15.0 in the release notes (up to 31bf7c3 ).
* Replace VERSION.
* Document unified download handler exceptions.
* Updates.
* Cover 2.15.0 in the release notes (up to 0c6ccf5 ).
* Cover 2.15.0 in the release notes (up to b68f267 ).
* Run linkcheck and fix issues.
* Cleanup unused link targets.
* Cleanup.
2026-04-09 16:56:30 +05:00
Adrian
b68f26726a
Fix DownloaderAwarePriorityQueue tie-breaking across slots ( #7351 )
2026-04-08 16:10:21 +02:00
Andrey Rakhmatullin
2b174e348d
Silence the CertificateOptions method warning. ( #7410 )
...
* Silence the CertificateOptions method warning.
* Fix typing.
2026-04-08 18:54:13 +05:00
Andrey Rakhmatullin
b9be5ce053
Reactorless shell and other small shell improvements ( #7395 )
...
* Use AsyncCrawlerProcess if TWISTED_REACTOR_ENABLED=False.
* defer.Deferred -> Deferred.
* Allow Shell with TWISTED_REACTOR_ENABLED=False.
* Shell workflow notes.
* Remove an unused argument.
* Shell.fetch_available.
* Shell._use_reactor.
* Some more comments.
* Simplify _schedule() and fix the spider shell var.
* More async def.
* Reactorless shell support.
* Add pragma: no cover.
* More notes.
* Remove a TODO.
2026-04-08 18:24:51 +05:00
Albert Eduardovich N.
5b37613618
Improve commands ( #7376 )
2026-04-08 14:59:00 +02:00
Albert Eduardovich N.
13a014d2e6
Response now uses less memory ( #7374 )
2026-04-08 14:25:11 +02:00
Albert Eduardovich N.
9fffcc1b82
Optimize SitemapSpider memory usage ( #7007 )
2026-04-08 13:59:16 +02:00
Kailesh
a4377f9a4f
Rename DNS_RESOLVER to TWISTED_DNS_RESOLVER ( #7361 )
2026-04-08 13:58:35 +02:00
Albert Eduardovich N.
8835a69f12
Use `dataclass` for the downloader `Slot` ( #7405 )
2026-04-08 13:26:01 +02:00
Ahmed Arshad
830eaeab5d
docs: fix typos in addons.rst ( #7408 )
...
Co-authored-by: Abdul Rahman <abdouls@hotmail.com>
2026-04-08 09:38:09 +02:00
Adrian
010faf1722
Use sphinx-scrapy 0.7.1 ( #7406 )
2026-04-06 15:29:59 +02:00
Andrey Rakhmatullin
8a26c3c2a0
Use a random port in MockFTPServer. ( #7402 )
2026-04-06 14:55:33 +02:00
Adrian
f8d103a65a
Add llms.txt and llms-full.txt generation ( #7380 )
2026-04-06 10:24:21 +02:00
Albert Eduardovich N.
58d85282cf
chore: more ruff rules and overall minor improvements ( #7386 )
...
* overall prettyfication
- don't create empty mutable containers (lists, dicts) where it is appropriate
- removed from ignore section and applied some rules from ruff (but keep them ignored in tests)
- use `deque` in `_AsyncCooperatorAdapter` instead of `list.pop(0)`
- remove `f` prefix from strings without any formatting
* return `SIM300` to ignore
* apply ruff rules to all files
* another one
* remove extra space in pyproject.toml
* simplify `__getattr__` in `scrapy.utils.url`
* lazy `url_is_from_any_domain` and `url_is_from_spider`
* improve typing
* specify `arg_to_iter` with None as arg
2026-04-03 19:00:13 +05:00
Albert Eduardovich N.
e3a8ff2b59
improve trackref ( #7375 )
...
* improve trackref
- use `NoneType` from `types` since python 3.9 is no longer supported
- use `monotonic` instead of `time` and fix flakiness of `get_oldest`
* tracing GC is no joke
* refine tests
* explain the tests
* add note for pypy in docs + ...
return empty tuple instead of list in `iter_all`
2026-04-03 15:15:30 +05:00
Andrey Rakhmatullin
b2b2d0b015
Rename TWISTED_ENABLED to TWISTED_REACTOR_ENABLED. ( #7394 )
2026-04-02 10:20:54 +02:00
Andrey Rakhmatullin
510f09a961
Deprecate ScrapyClientContextFactory. ( #7391 )
2026-04-02 09:29:47 +02:00
Albert Eduardovich N.
ed31dcbb10
deprecate `walk_modules` in favour of `walk_modules_iter` ( #7388 )
...
* deprecate `walk_modules` in favour of `walk_modules_iter`
* remove deprecation line from docstring
* addressing review
2026-04-01 22:11:35 +05:00
Andrey Rakhmatullin
0c6ccf50b3
Docs for the reactorless mode ( #7385 )
...
* Reactorless mode docs.
* Unset the ftp handler in the reactorless mode.
* Cleanup reactorless subprocess tests.
* Better handling of incompatible TWISTED_ENABLED cases.
* Improvements.
* Improve early error logging in test scripts.
* Address feedback.
* Address feedback.
2026-04-01 20:40:34 +05:00
Andrey Rakhmatullin
fa76ca52e9
Move TLS logging from _ScrapyClientTLSOptions to handlers. ( #7387 )
...
* Move TLS logging from _ScrapyClientTLSOptions to handlers.
* Update the docs.
* Fix typing.
* Update new docs.
* Add the comment back.
2026-04-01 16:02:55 +05:00
Andrey Rakhmatullin
eabb149f4b
Deprecate DOWNLOADER_CLIENTCONTEXTFACTORY, add DOWNLOAD_VERIFY_CERTIFICATES ( #7379 )
...
* Deprecate DOWNLOADER_CLIENTCONTEXTFACTORY.
* Deprecate BrowserLikeContextFactory.
* Add DOWNLOAD_VERIFY_CERTIFICATES.
* Cleanup, add acceptableCiphers to the verifying path.
2026-04-01 15:18:43 +05:00
Albert Eduardovich N.
72bcf8cb46
adjust httpx error mapping ( #7384 )
2026-03-31 19:02:38 +02:00
Adrian Chaves
c4c0555ccf
Enable parallel execution in the other internal Sphinx plugin
2026-03-30 18:01:29 +02:00
Adrian Chaves
299993b62a
Fix the docs build
2026-03-30 17:46:55 +02:00
Adrian Chaves
74c33e5172
Use the spam label when auto-closing PRs
2026-03-30 17:43:59 +02:00
Adrian
6cef717dad
Add a template for PRs ( #7381 )
2026-03-30 17:33:21 +02:00
Kailesh
86a7ceaa9f
Dynamic loading for S3 HTTPS handler ( #7370 )
2026-03-30 10:12:43 +02:00
Andrey Rakhmatullin
31bf7c3892
Docs for HttpxDownloadHandler, handle httpx not being installed ( #7368 )
...
* Add docs for HttpxDownloadHandler.
* Handle httpx not being installed.
* Revert test_not_configured_without_asyncio().
* Restore the comment.
* Cleanup.
2026-03-27 21:06:55 +05:00
Andrey Rakhmatullin
fee20b7858
AsyncCrawlerProcess._start_asyncio() improvements. ( #7366 )
2026-03-27 12:21:25 +01:00
Albert Eduardovich N.
5561aaec1d
fixing oversight from #7036 ( #7367 )
...
https://github.com/scrapy/scrapy/pull/7269#issuecomment-3958535816
2026-03-27 11:38:44 +01:00
Andrey Rakhmatullin
a8e99aeb2e
Fix botocore-pinned and pypy3-* ( #7363 )
2026-03-26 08:21:58 +01:00
Andrey Rakhmatullin
2ce02d417a
TLS code modernization ( #7353 )
...
* Import some stuff from service_identity directly.
* Extract _log_tls().
* Sync validating IP addresses.
* Introduce _deps_compat.
* Deprecate getCertificateOptions().
* Deprecate ScrapyClientTLSOptions.
* Add pragma: no cover.
* verify=False and trustRoot=platformTrust() are the defaults.
* Improve docstrings for TLS classes.
* Deprecate AcceptableProtocolsContextFactory.
* Switch from DefaultOpenSSLContextFactory to CertificateOptions.
* Deprecate load_context_factory_from_settings().
* Remove the outdated warning about incompatible factories.
* Simplify _load_context_factory_from_settings().
* Make CertificateOptions and Context once per factory.
* pragma: no cover
2026-03-25 15:42:43 +05:00
Andrey Rakhmatullin
03d105ac92
Add warnings to components not working without a reactor ( #7355 )
2026-03-25 09:21:08 +01:00
Kaileshwar R K
54a4c3af89
Deprecate the mail API ( #7263 )
2026-03-24 21:31:12 +01:00
Andrey Rakhmatullin
bfe34492fa
asyncio alternative to deferToThread() ( #7349 )
2026-03-24 15:41:15 +01:00
Andrey Rakhmatullin
6fe27ba33e
Add more no-reactor tests ( #7259 )
...
* Generic changes and scrapy bench.
* scrapy check.
* scrapy crawl.
* scrapy fetch.
* scrapy parse.
* scrapy runspider.
* scrapy shell.
* Skip httpx tests on default-reactor.
* Review requires_reactor marks.
* Make test functions that require an event loop async def.
* Improve test_pending_asyncio_tasks().
* Add Mac OS DNS error.
* Refactor most of test_scheduler.py.
* Finish refactoring DownloaderAwareSchedulerTestMixin.
* Refactor test_engine_loop.py.
* Add the no-reactor-extra-deps tox env, run no-reactor on macos.
* Skip unhandled CancelledError when shutting down the engine.
* Fix typing and pre-commit checks.
* Fix typing problems in master.
---------
Co-authored-by: Adrian <adrian@zyte.com>
2026-03-24 15:29:22 +05:00
Andrey Rakhmatullin
d42b23d78a
Await persist_file() in media pipelines. ( #7182 )
2026-03-24 10:52:56 +01:00
Andrey Rakhmatullin
9f4651151d
Deprecate ScrapyCommand.set_crawler(), remove/fix some dead code. ( #7276 )
2026-03-24 10:36:48 +01:00
Andrey Rakhmatullin
939db88b04
Disable mypy allow_untyped_calls. ( #7331 )
2026-03-24 10:31:17 +01:00
Julian Hamze
c148ec4433
Add a DOWNLOAD_BIND_ADDRESS setting for download handlers ( #7283 )
2026-03-19 09:16:40 +01:00
Andrey Rakhmatullin
584d99af30
Split long test files ( #7329 )
2026-03-13 10:30:25 +01:00
Adrian Chaves
4d2071f7b3
Use fancy kwarg typing
2026-03-12 16:49:29 +01:00
Adrian Chaves
9dfe449d13
Fix test issues with the no-reactor env
2026-03-12 16:46:32 +01:00
Adrian Chaves
4e3df249f2
Merge branch '2.14'
2026-03-12 16:02:37 +01:00
Adrian Chaves
498b4fc1a4
Bump version: 2.14.1 → 2.14.2
2026-03-12 15:45:16 +01:00
Adrian Chaves
378bb68039
Proofread the release notes
2026-03-12 15:44:54 +01:00
Adrian Chaves
8e28f938d2
Make test_no_warning_when_referer_middleware_present less brittle
2026-03-12 14:29:51 +01:00
Adrian Chaves
886131c7b2
Run pre-commit
2026-03-12 13:54:00 +01:00
Adrian Chaves
945b787a26
Merge remote-tracking branch 'cwxj-rr6w-m6w7/fix-referer-policy-handling' into 2.14
2026-03-12 13:37:24 +01:00
Andrey Rakhmatullin
e02ad08672
Move to mypy --strict with exceptions. ( #7300 )
...
* Move to mypy --strict with exceptions.
* Fix typing-tests.
2026-03-02 15:47:23 +05:00
Andrey Rakhmatullin
7010985e4f
Bump ruff, fix some of rules ( #7277 )
2026-02-23 11:48:38 +01:00
Andrey Rakhmatullin
abd025f78e
Pass correct env to PopenSpawn() in tests. ( #7279 )
2026-02-23 11:34:56 +01:00
Yuval Elbar
da1a6b7ebc
Add security warning about pickle files in JOBDIR ( #7274 )
...
* Add security warning about pickle files in JOBDIR
The job directory contains files serialized with pickle (spider.state,
request queues), which can execute arbitrary code when loaded. Add a
warning so users know to treat JOBDIR with the same trust level as
their project code.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Make JOBDIR security warning more concise and accurate
Simplify the warning to focus on treating the job directory
as trusted, without mentioning specific serialization details.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-20 19:36:26 +05:00
pierreeurope
3fe89a211b
Fix open_spider exception handling to set exit code 1 ( #7255 )
2026-02-19 11:21:59 +01:00
Andrey Rakhmatullin
ccfa052fa1
Enable in-process HTTP tests without a reactor. ( #7254 )
2026-02-13 19:08:06 +01:00
Andrey Rakhmatullin
6e0a0e476a
Fix running tests with -n auto, enable it on CI ( #7257 )
...
* Make test_start_deprecated_super() more robust.
* Work around the FTPFilesStore.FTP_* initialization.
* Enable xdist on CI.
* Add PYTEST_ADDOPTS to tox passenv.
2026-02-13 22:12:57 +05:00
Andrey Rakhmatullin
09bd8f4231
Properly close ftplib.FTP(). ( #7256 )
2026-02-13 19:12:13 +05:00
Andrey Rakhmatullin
0e1526ed30
Fix flaky test_download_with_proxy_https_timeout(). ( #7250 )
2026-02-13 09:45:09 +01:00
Anant Murmu
2c3ecbff71
fix: missing self argument in ScreenshotPipeline constructor ( #7248 )
...
added missing self argument in __init__ method constructor
2026-02-13 09:42:26 +01:00
Andrey Rakhmatullin
fc30c47f38
Add HttpxDownloader. ( #7239 )
2026-02-12 09:30:44 +01:00
Varun Chawla
0cfc4e4386
Improve dont_filter documentation ( #7245 )
2026-02-10 11:49:10 +03:00
Ryotaro
06fb87f7bb
Fix override behavior in getwithbase() issue #6912 ( #6993 )
...
* Fix test for getwithbase() to ensure class-keyed overrides with None are handled correctly
* Test actual import paths from default_settings
* Improvements
* Remove unused logger
* Run pre-commit
* Restore and improve duplicate key handling and warning
* type → object
---------
Co-authored-by: Adrian Chaves <adrian@zyte.com>
2026-02-07 00:17:55 +04:00
Martin Schimandl
66fe5de139
Add Jobdir documentation ( #5260 )
...
* Add Jobdir documentation
* Fix link format
* remove doubtful comments
* some more edits
* Keep the information in jobs.rst an example, and provide details in the reference docs of the corresponding components
* Minor edits
---------
Co-authored-by: Adrian Chaves <adrian@zyte.com>
2026-02-06 22:33:02 +04:00
Andrey Rakhmatullin
16929c0991
Exclude deprecated code from coverage. ( #7241 )
2026-02-06 09:15:07 +01:00
Michael
6a42bc6450
Item docs: mention Pydantic support ( #6966 )
...
* Add Pydantic support documentation
* Fix Sphinx references in Pydantic section for non-Sphinx docs
* Minor reformatting
---------
Co-authored-by: Adrian Chaves <adrian@zyte.com>
2026-02-05 22:18:01 +04:00
Albert Eduardovich N.
294ee051cc
Reducing memory footprint of `Request` object: __slots__ and lazy evaluation ( #7036 )
...
* reducing memory foorprint of `Request` object
* restore flow
* Test setters
---------
Co-authored-by: Adrian Chaves <adrian@zyte.com>
2026-02-05 22:15:53 +04:00
Adrian Chaves
8974580e43
Reword the release note entry to consider the 301 redirect fix a security bug fix
2026-02-03 20:38:11 +01:00
Andrey Rakhmatullin
2e53d90e4c
Refactor HTTP download handlers ( #7238 )
2026-02-03 20:13:30 +01:00
Andrey Rakhmatullin
11977afba5
Rename async test decorators. ( #7234 )
2026-02-02 20:39:43 +01:00
Andrey Rakhmatullin
c8aa429c9b
Reactorless tests 2: enable pytest-asyncio. ( #7233 )
...
* Move no-reactor to pytest-asyncio.
* Unify the style.
* Skip a test that installs a reactor in no-reactor.
* Fix pinned env deps.
* Strict pytest-asyncio mode.
2026-02-02 19:36:23 +01:00
Andrey Rakhmatullin
3186ccf5d5
Reactorless tests 1: the test env ( #6952 )
...
* Reactorless tests.
* Updates after merging master.
* Update a new import.
* Updates after merging master.
* Update testenv:no-reactor-pinned.
* Foundations for the reactorless mode.
* Fixes after merging master.
* Updates after merging reactorless-base.
* Add simple subprocess tests for reactorless AsyncCrawler*.
* More reactorless tests.
* Refactor AsyncCrawlerProcess.start().
* More checks.
* Fix test_reactorless_import_hook.
* More tests.
* Call install_reactor() before asyncio.run().
* Cleanup.
* Rephrase.
* Fix a test.
* Fixes.
* Rephrasing.
* Set TELNETCONSOLE_ENABLED=False in the reactorless mode.
* Fix a new import.
* Clarify --reactor marks.
* Cleanup.
* More docs/comments.
* Update test_fallback_workflow().
* Update TestDeferredFFromCoroF.
* Typing improvements.
2026-02-02 19:25:30 +05:00
Andrey Rakhmatullin
54d8562fb0
Assorted test improvements ( #7232 )
...
* Await some missed deferreds.
* Simplify test_engine_stop_download_*.
* Fix the header value.
* Extend TestHttpWithCrawlerBase.
* Make test_tls_logging more universal.
* Add more tests for header handling.
* Clarify certificate and ip_address integration tests.
* Make test_download_with_maxsize_very_large_file() more universal.
* Fix test_coroutine_asyncio().
* Typo.
2026-02-02 09:37:39 +01:00
Andrey Rakhmatullin
4e1faf883d
Foundations for the reactorless mode. ( #7199 )
...
* Foundations for the reactorless mode.
* Add simple subprocess tests for reactorless AsyncCrawler*.
* More reactorless tests.
* Refactor AsyncCrawlerProcess.start().
* More checks.
* Fix test_reactorless_import_hook.
* More tests.
* Call install_reactor() before asyncio.run().
* Cleanup.
* Rephrase.
* Rephrasing.
* Set TELNETCONSOLE_ENABLED=False in the reactorless mode.
2026-01-31 20:48:54 +05:00
Pádraic Slattery
49930dfec5
chore: Update outdated GitHub Actions versions ( #7223 )
2026-01-23 12:26:58 +01:00
Andrey Rakhmatullin
3ec6ae05c1
Fix omitting repeated dataloss warnings in HTTP11DownloadHandler. ( #7222 )
2026-01-22 00:41:27 +05:00
Andrey Rakhmatullin
2347138ba4
Unified download handler exceptions ( #7208 )
...
* Add DownloadTimeoutError.
* Don't expect ConnectionAborted in tests.
* Add DownloadCancelledError.
* Add ResponseDataLoss.
* Add more download handler tests.
* Add DownloadConnectionRefusedError.
* Add UnsupportedURLScheme.
* Add CannotResolveHostError.
* Add DownloadFailedError.
* Remove wrapped Twisted exceptions from lists.
* Update a test expectation.
* Extract wrap_twisted_exceptions().
* Wrap TxTimeoutError.
* Rename ResponseDataLoss and UnsupportedURLScheme.
2026-01-21 23:09:54 +05:00
Adrian Chaves
ba3d7bc7a8
Remove the non-standard 307/308 handling, and align other aspects with the standard
2026-01-21 18:46:05 +01:00
Andrey Rakhmatullin
9bae1ee21f
Lazy creation of Downloader._slot_gc_loop. ( #7210 )
2026-01-20 12:58:09 +01:00
Adrián Chaves
04db6a5424
Add a docstring to _load_policy_class()
2026-01-20 12:35:00 +01:00
Adrián Chaves
a39545195e
allow to override → allow overriding
2026-01-20 12:20:37 +01:00
Adrián Chaves
842d0becf0
Rename test function
2026-01-20 12:15:25 +01:00
Adrián Chaves
1b9c8b55da
not → now
2026-01-20 12:13:44 +01:00
Adrian Chaves
2651d48f20
Cover the 301 behavior change in the release notes
2026-01-19 19:25:00 +01:00
Adrian Chaves
99d5d58e20
Add a release notes entry
2026-01-19 19:19:02 +01:00
Adrian Chaves
f7f18123eb
Remove body on 307/308 redirects and switch to GET on 301
2026-01-19 19:15:20 +01:00
Adrian Chaves
6f03f3250b
Add versionadded
2026-01-19 16:46:53 +01:00
Adrian Chaves
b6e5c58ae7
Fix arbitrary callable execution from the Referrer-Policy response header
2026-01-19 16:44:03 +01:00
Eugenio Lacuesta
0b9d8da09d
Bump version: 2.14.0 → 2.14.1
2026-01-12 16:25:43 -03:00
Eugenio Lacuesta
c9fbf6c599
Release notes for 2.14.1 ( #7217 )
...
* Release notes for 2.14.1
* Update docs/news.rst
Co-authored-by: Adrián Chaves <adrian@chaves.gal>
* Update docs/news.rst
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
* Update docs/news.rst
Co-authored-by: Adrián Chaves <adrian@chaves.gal>
* Update message about github action change
---------
Co-authored-by: Adrián Chaves <adrian@chaves.gal>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2026-01-12 16:23:51 -03:00
Santiago Beltrán Ruiz
e30ba7d4ca
( #7180 ) Update codecov test results action to v5 on all CI workflows. ( #7215 )
2026-01-12 08:31:53 +01:00
Andrey Rakhmatullin
0f07b2e38c
Pass the spider arg to custom stat collectors {open,close}_spider(). ( #7213 )
2026-01-09 16:57:53 +01:00
Andrey Rakhmatullin
1af283387f
Deprecate maybeDeferred_coro(). ( #7212 )
2026-01-09 01:09:39 +05:00
Andrey Rakhmatullin
3ac1192f35
Bump version: 2.13.4 → 2.14.0
2026-01-05 15:06:13 +05:00
Andrey Rakhmatullin
7bef98b4f1
Release notes for 2.14.0 ( #7035 )
...
* Initial release notes for 2.14.0, up to ed63fa9 .
* Cover 2.14 in the release notes up to 393d715 .
* Cover 2.14 in the release notes up to eb49647 .
* Cover 2.14 in the release notes up to 426aafd .
* Cover 2.14 in the release notes up to 1e8de24 .
* Cover 2.14 in the release notes up to 5a7e132 .
* Bump sphinx-lint.
* Finalize the 2.14.0 release notes.
* Drop more of the old versionadded directives.
* Address feedback.
2026-01-05 14:51:05 +05:00
Andrey Rakhmatullin
d1bd8eb49f
Async API for download handlers. ( #7164 )
2025-12-31 19:03:16 +01:00
Andrey Rakhmatullin
a2463325db
Allow Crawler.crawl_async() without asyncio. ( #7202 )
2025-12-31 18:33:59 +01:00
Adham 3llam
9381ad893d
Remove outdated version marker directives (< 2.8.0) from documentation ( #7198 )
2025-12-22 10:00:39 +01:00
Andrey Rakhmatullin
180ca39b23
Deprecate returning Deferreds from pipeline methods ( #7179 )
...
* Add tests for exceptions in pipelines.
* Deprecate returning Deferreds from pipeline process_item().
* Deprecate returning Deferreds from pipeline {open,close}_spider().
* Update the custom pipeline docs.
2025-12-16 13:35:07 +05:00
Andrey Rakhmatullin
5a7e132486
Restore and deprecate the spider arg of Downloader._get_slot(). ( #7178 )
2025-12-15 11:42:24 +01:00
Andrey Rakhmatullin
c49ae2115a
Refactor MediaPipeline.process_item() to async def ( #7177 )
2025-12-15 10:02:04 +01:00
Andrey Rakhmatullin
588f3d4f65
Remove docs mentioning deprecated spider attrs. ( #7176 )
2025-12-15 09:51:56 +01:00
Thalison Fernandes
d8583a89c7
Change default priority queue to DownloaderAwarePriorityQueue ( #6940 )
...
* Change default priority queue to DownloaderAwarePriorityQueue
* Fix documentation building
* Simplify test_start_already_running_exception changes.
* Modernize the test.
* Fix TestEngineCloseSpider.
* Fix typing.
* Remove special slot=None handling.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-12-11 11:25:17 +01:00
DenisC
1a3e343dc4
Update conftest.py to refactor autouse pytest.skip() fixtures into pytest_runtest_setup() ( #7173 )
2025-12-11 09:48:25 +01:00
Andrey Rakhmatullin
6ba6b032ad
Fix handling meta["download_slot"] == None. ( #7172 )
2025-12-11 09:46:51 +01:00
Andrey Rakhmatullin
9bfa58e36c
Deprecate send_catch_log_deferred(). ( #7161 )
...
* Add a test for not having pending tasks.
* Refactor TestFeedExporterSignals.
* Refactor FeedExporter.close_spider().
* More engine start/stop robustness.
* Refactor send_catch_log_async(), deprecate send_catch_log_deferred().
* Add pragma: no cover.
* Warn on signal handlers returning a Deferred.
* Make _pending_close_coros an instance attribute.
* Remove an unused function.
* Remove the outdated TODO.
2025-12-10 14:42:49 +05:00
Andrey Rakhmatullin
5105f55a98
Add `DownloaderMiddlewareManager.download_async()`, deprecate returning Deferreds from downloader mws ( #7069 )
...
* Restore coverage in MiddlewareManager spider arg handling.
* Move MiddlewareManager._warn_spider_arg() tests.
* Add DownloaderMiddlewareManager.download_async().
* Make download_func async.
* Inline MiddlewareManager._warn_spider_arg().
* Deprecate returning deferreds from downloader middlewares.
* Update the downloader mw doc about async def.
* Use global_object_name() instead of repr().
* Update docs/topics/downloader-middleware.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* Update downloader-middleware.rst
---------
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2025-12-09 20:07:36 +05:00
Andrey Rakhmatullin
7ed20ee7f3
Limit the queue size in _parallel_asyncio(). ( #7159 )
2025-12-09 15:24:40 +01:00
Andrey Rakhmatullin
483e059d59
Deprecate returning Deferreds from spider callbacks and errbacks. ( #7151 )
2025-12-09 15:03:32 +01:00
Laerte Pereira
11073c8680
Deprecate spider attributes that can be replaced by settings, round 2 ( #7039 )
...
* Move duplicate code to utils
* move new function to end
* draft
* update docs
* Update tests
* Update test name
* rename test
* rollback signature
* leftover
* sort
* Rollback some changes
* Rollback download_delay warning
* Rollback
* fix checks
* Remove unused imports
* Add pragma: no cover.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-12-01 01:26:17 +05:00
Leonardo Tozzo
1e8de24380
Merge pull request #7145 from Icorebleidd/master
...
Fix duplicate assertion in test_utils_deprecate
2025-11-28 01:16:02 +05:00
Andrey Rakhmatullin
0adc561348
Add a list of remaining Deferred APIs. ( #7146 )
2025-11-27 20:13:04 +05:00
Rui Xi
813fd9f1ac
Restore brotlicffi support ( #7160 )
...
* restore brotlicffi dependency
* pre-commit
2025-11-25 12:06:55 +05:00
Andrey Rakhmatullin
4cb0144b39
Merge tag '2.13.4'
...
Bump version: 2.13.3 → 2.13.4
2025-11-17 16:47:54 +05:00
Andrey Rakhmatullin
2f62ab532d
Bump version: 2.13.3 → 2.13.4
2025-11-17 16:30:37 +05:00
Andrey Rakhmatullin
31a9c03c24
Release notes for 2.13.4. ( #7144 )
...
* Release notes for 2.13.4.
* Formatting.
2025-11-17 16:30:04 +05:00
Rui Xi
c44b8df6c7
Cherry-pick: Mitigate brotli and deflate decompression bombs DoS ( #7134 )
...
Co-authored-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-11-17 16:25:00 +05:00
Rui Xi
14737e91ed
Mitigate brotli and deflate decompression bombs DoS ( #7134 )
...
Co-authored-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-11-17 14:21:50 +05:00
Adrián Chaves
d091256c58
Remove the deprecated sphinx-hoverxref ( #6922 )
2025-11-14 15:39:21 +05:00
Andrey Rakhmatullin
c83ca70db3
Don't force the unavailable sysmon coverage core. ( #7137 )
2025-11-13 23:26:08 +05:00
Andrey Rakhmatullin
85e4e6c42b
Pin Twisted to <= 25.5.0 due to internal API changes.
2025-11-13 23:25:51 +05:00
Andrey Rakhmatullin
426aafddca
Don't force the unavailable sysmon coverage core. ( #7137 )
2025-11-13 23:22:52 +05:00
Mikhail Korobov
db37040a09
Merge pull request #7142 from wRAR/pin-twisted
...
Pin Twisted to <= 25.5.0 due to internal API changes.
2025-11-13 22:48:33 +05:00
Andrey Rakhmatullin
ba30e8b82c
Pin Twisted to <= 25.5.0 due to internal API changes.
2025-11-10 00:58:27 +05:00
Vasiliy Kiryanov
8c5fa6e6ae
Line buffering ( #7094 )
2025-10-27 15:42:43 +01:00
Andrey Rakhmatullin
804ae167df
Update tool versions ( #7127 )
2025-10-27 14:11:31 +01:00
Andrey Rakhmatullin
61b4befc60
Remove code deprecated in 2.12.0 ( #7126 )
...
* Remove smaller things.
* Remove from_settings().
* Remove old MediaPipeline init code.
* Cleanup.
* Typo.
2025-10-27 17:14:38 +05:00
Andrey Rakhmatullin
d414d393d4
Remove Python 3.9 support ( #7121 )
2025-10-27 12:37:49 +01:00
Andrey Rakhmatullin
e48a1bdde3
Speed up and refactor command tests ( #7118 )
2025-10-27 12:28:16 +01:00
Andrey Rakhmatullin
9cce6c30db
Undeprecate download_delay. ( #7117 )
2025-10-24 17:44:43 +05:00
Andrew Murray
5afc9b0221
Automatically transpose images using EXIF data ( #6975 )
...
* Automatically transpose images using EXIF data
* Added test
---------
Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
2025-10-24 16:08:23 +05:00
Adrián Chaves
eb496470f1
Add missing doc deps for new examples ( #7116 )
2025-10-24 11:58:18 +02:00
Michael
a5bbeb2586
Expanded documentation for issue #6676 ( #6957 )
2025-10-24 10:30:33 +02:00
sstegmanbsd
2d073a9c0d
Fix typo in logging documentation ( #7109 )
2025-10-20 15:52:46 +02:00
Wes Galbraith
e98c1644ce
Add unit tests that check download handlers behave like basic http clients ( #6946 ) ( #7059 )
2025-10-20 13:08:26 +02:00
Andrey Rakhmatullin
b49aa2fb0c
Deprecate scrapy.core.downloader.handlers.http. ( #7079 )
2025-10-16 13:15:07 +02:00
Vasiliy Kiryanov
7b215c6578
UTF-8 BOM at the beginning of the file ignored ( #7095 )
2025-10-15 18:15:07 +04:00
adglee
4865a500b6
resolves #6876 ( #6977 )
2025-10-09 22:14:34 +02:00
Sebastien Dionne
a02abdcf63
Fix typos in documentation ( #7076 )
2025-10-06 11:43:36 +02:00
Andrey Rakhmatullin
c577771838
Drop tests/upper-constraints.txt. ( #7073 )
2025-10-06 11:32:20 +02:00
Andrey Rakhmatullin
10850e7d29
Fix extra stdout output in tests ( #7070 )
2025-10-06 11:19:34 +02:00
Andrey Rakhmatullin
1c6ba00fd0
Move LogCounterHandler into a new extension ( #7046 )
...
* Move LogCounterHandler into Crawler.crawl().
* Add the LogCount extension.
* Update test_spider_custom_settings_log_level().
* Typo.
* Update docs.
2025-10-03 20:14:11 +05:00
Andrey Rakhmatullin
798390c096
Improve performance of deprecated spider arg checks. ( #7045 )
2025-10-03 14:17:46 +02:00
Andrey Rakhmatullin
dd0b071bcc
Deprecate sync methods of ItemPipelineManager/ITEM_PROCESSOR. ( #7043 )
2025-10-03 14:15:42 +02:00
Laerte Pereira
f2531808f3
docs: Add Edit on GitHub ( #7058 )
2025-09-28 13:16:47 +05:00
Andrey Rakhmatullin
393d715205
Drop PyPy 3.10 support, restore coverage for subprocesses ( #7050 )
2025-09-15 11:24:09 +02:00
Ashar Khan
d239fcf936
Fix get_meta_refresh to correctly resolve relative URLs using <base> tag ( #7047 )
2025-09-10 15:17:16 +02:00
Andrey Rakhmatullin
2ad81a0ef8
Deprecate the spider arg of downloader middleware methods. ( #7037 )
...
* Deprecate the spider arg of downloader middleware methods.
* Add a test for deprecated spider args in downloader mws.
2025-09-02 21:51:47 +05:00
Andrey Rakhmatullin
c097921c44
Extract @_warn_spider_arg. ( #7033 )
...
* Extract @_warn_spider_arg.
* Also deprecate passing spider=None.
2025-09-01 20:17:13 +05:00
Andrey Rakhmatullin
80beec41b5
Log when AsyncCrawlerProcess or CrawlerProcess is instantiated. ( #7034 )
2025-09-01 13:51:11 +02:00
M Ikram Ullah Khan
00b2be0943
Add unit tests for the StatsMailer extension ( #7013 )
2025-09-01 11:43:57 +02:00
M Ikram Ullah Khan
3ee4a52aa1
Raise NotConfigured when FILES_STORE or IMAGES_STORE is None or empty ( #6969 )
2025-09-01 11:39:39 +02:00
Andrey Rakhmatullin
ed63fa94d6
Deprecate spider args of middlewares and pipelines. ( #7006 )
...
* Deprecate spider args of spider middleware methods.
* Deprecate the spider arg of pipeline process_item().
* Fix a typing issue.
* Deprecate the spider arg of pipeline {open,close}_spider().
* Cleanup.
* Update docs.
* Add pragma: no cover to some deprecated code.
* More tests.
* More tests.
* More tests.
* Simplify _process_parallel().
2025-08-21 13:23:10 +05:00
Andrey Rakhmatullin
b68330811b
Deprecate spider arguments of StatsCollector methods ( #7011 )
2025-08-20 09:52:22 +02:00
Andrey Rakhmatullin
edba1ad572
Refactor RobotsTxtMiddleware to use async def process_request(). ( #6802 )
2025-08-18 18:40:46 +02:00
Andrey Rakhmatullin
15655ca834
Improve cleanup in TestEngineCloseSpider. ( #7012 )
2025-08-18 20:00:23 +05:00
Andrey Rakhmatullin
3c546bdb82
Refactor chainDeferred() usages ( #7008 )
2025-08-16 09:35:23 +02:00
Andrey Rakhmatullin
d3e15a10cf
Add ItemPipelineManager.process_item_async() and ensure_awaitable(). ( #7005 )
...
* Add ItemPipelineManager.process_item_async() and ensure_awaitable().
* Wording.
2025-08-12 19:57:37 +05:00
Andrey Rakhmatullin
57f539d7a5
Deprecate Crawler.stop(). ( #6999 )
2025-08-11 08:32:55 +02:00
Andrey Rakhmatullin
a0b766f9e1
More *_async APIs ( #6997 )
...
* Add ExecutionEngine.close_spider_async().
* Add Scraper.{open,close}_spider_async().
* Fix double engine stopping via Crawler.stop().
* Add ExecutionEngine.stop_async().
* Add versionadded to new async APIs.
* Add ExecutionEngine.close_async().
2025-08-08 22:15:41 +05:00
NavpreetSSidhu
d27d0a4ed9
Deprecate setting overrides through spider attributes ( #6994 )
2025-08-07 21:26:10 +02:00
Andrey Rakhmatullin
a3daa3612e
Rewrite ExecutionEngine.close_spider() to inlineCallbacks. ( #6986 )
2025-08-06 08:01:55 +02:00
Andrey Rakhmatullin
baa579df62
Deprecate various `spider` args in `MiddlewareManager` subclasses ( #6984 )
...
* Add a crawler argument to MiddlewareManager.__init__().
* Deprecate the spider argument in some MiddlewareManager subclasses.
* Remove the spider argument from ExecutionEngine.open_spider_async().
* Remove the spider argument from Scraper.open_spider().
* Fix the Scraper.close_spider() type hint.
* Remove the spider argument from Downloader internals.
* Deprecate the spider arg of download_func.
* Deprecate the spider arg of Downloader.fetch().
* Deprecate the spider arg of ItemPipelineManager.process_item().
* Fix pylint.
* Tests for MiddlewareManager spider code.
* Deprecated spider arg handling for custom pipeline managers.
* Add a test for the deprecated spider arg in a custom downloader.
* Remove TODO.
* Fix pylint.
2025-08-05 12:21:08 +05:00
Neeraj Palliyali
c47b5d049a
fix for formatting interactive shell ( #6980 )
2025-08-01 11:01:40 +02:00
Andrey Rakhmatullin
32f2aede82
Deprecate non-async counterparts of new async APIs. ( #6979 )
...
* Deprecate non-async counterparts of new async APIs.
* Deprecate Scraper.call_spider().
* Add _schedule_coro().
2025-08-01 00:58:48 +05:00
Andrey Rakhmatullin
605e7669a5
Improve the assumption in test_queue_push_pop_priorities(). ( #6974 )
2025-07-28 20:37:45 +02:00
Felipe Benevolo
89f53f0555
Added download_async() to ExecutionEngine and test cases for download() and download_async() ( #6842 )
...
* added async_download()
* add case tests for ExecutionEngine download() and async_download()
* change async_download() to download_async() in Engine class and subsequent tests
* fixed reactor import in test_engine.py
* Simplify TestEngineDownloadAsync.
* replaced tearDown by self.engine.downloader.close in test_engine.py and replace @defer.inlineCallbacks by @inlineCallbacks
* Simplify ExecutionEngine.download().
* Remove an unneeded import.
* Refactor ExecutionEngine.download{,_async}() tests.
* Deprecate ExecutionEngine.download().
* Update doc examples to use download_async().
* Replace uses of download() with download_async().
* Fix test_downloadermiddleware_robotstxt.py.
* Remove a stray file.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-07-27 23:17:51 +05:00
MarlonDev
6ce0c4c855
Fix small typo in middlewares.py.tmpl ( #6970 )
...
Changed "maching" to "matching"
2025-07-27 01:52:57 +02:00
Andrey Rakhmatullin
552f2fb91e
Generic improvements related to reactorless tests ( #6968 )
...
* Skip doctests that import the reactor.
* Extract FTPDownloadHandler tests.
* Skip TestHttps2ClientProtocol via pytestmark.
* Replace some explicit reactor.callLater() in tests.
* Simplify TestRequestSendOrder._test_request_order().
2025-07-25 13:35:00 +05:00
Andrey Rakhmatullin
8c8f4ff033
Extract in-process test HTTP servers into separate processes ( #6960 )
...
* Switch TestEngineBase to mockserver.
* Split mockserver.py.
* Stop using WrappingFactory.
* Remove keyfile/certfile fields from TestHttpBase.
* Move webclient-only resources to test_webclient.py.
* Refactor MockServer.url().
* Migrate TestHttpBase to mockserver.
* Migrate TestSimpleHttpsBase to a separate mockserver.
* Rename TestHttpMockServerBase.
* Migrate TestHttpProxyBase to a separate mockserver.
* Refactor HTTP mockservers.
2025-07-25 12:42:27 +05:00
M Ikram Ullah Khan
9e83a58643
Add type check in get_media_requests to enforce image / file urls as a list ( #6949 )
2025-07-19 11:54:35 +02:00
Andrey Rakhmatullin
e225d0dea4
Ban more imports that import twisted.internet.reactor. ( #6947 )
2025-07-10 21:19:50 +05:00
Andrey Rakhmatullin
6b2997af90
Migrate to pytest-twisted ( #6938 )
...
* Migrate to pytest-twisted (WIP)
* Some typing fixes.
* Make --reactor=asyncio the default again.
* Try installing the correct event loop policy in tests on Windows.
* Make reactor_pytest a normal fixture.
* Fix test warnings.
* Fix FTPDownloadHandler teardown.
* Cleanups, typing.
* More cleanup.
* Update only_asyncio/only_not_asyncio mark messages.
2025-07-06 21:27:17 +05:00
Andrey Rakhmatullin
14eace5d8f
Increase the command timeout in test_short_timeout(). ( #6945 )
2025-07-06 01:56:54 +05:00
Andrey Rakhmatullin
4279f2837c
Enable the flake8-builtins rules. ( #6942 )
2025-07-05 21:43:18 +05:00
Andrey Rakhmatullin
df342eee6e
Bump tool versions. ( #6941 )
2025-07-05 10:30:30 +02:00
Andrey Rakhmatullin
16f168b406
Deprecate mustbe_deferred() and defer_*(). ( #6937 )
2025-07-04 16:41:15 +05:00
Andrey Rakhmatullin
d9ef0350d8
Merge remote-tracking branch 'origin/2.13'
2025-07-02 20:46:02 +05:00
Andrey Rakhmatullin
155a504f24
Bump version: 2.13.2 → 2.13.3
2025-07-02 20:39:46 +05:00
Andrey Rakhmatullin
cf465bf644
Release notes for 2.13.3. ( #6934 )
...
* Release notes for 2.13.3.
* Address feedback.
2025-07-02 20:36:01 +05:00
Andrey Rakhmatullin
8d82e7bd27
Fix limiting subprocess run time in tests. ( #6933 )
...
* Fix limiting subprocess run time in tests.
* Make test_runspider_dnscache_disabled() faster.
2025-07-01 20:23:35 +05:00
Andrey Rakhmatullin
7842180b2f
Merge remote-tracking branch 'origin/2.13'
2025-07-01 17:28:12 +05:00
Andrey Rakhmatullin
c9cdf0af3c
Narrow down TestEngine::test_short_timeout() expectations. ( #6911 )
2025-07-01 13:47:43 +02:00
Laerte Pereira
dabdc7550e
Deprecate CONCURRENT_REQUESTS_PER_IP setting ( #6921 )
...
* Deprecate CONCURRENT_REQUESTS_PER_IP setting
* Typing fix
* PR review
* tests
* oops
* Update scrapy/settings/default_settings.py
Co-authored-by: Adrián Chaves <adrian@chaves.gal>
* update logic
---------
Co-authored-by: Adrián Chaves <adrian@chaves.gal>
2025-06-30 16:51:05 +05:00
Andrey Rakhmatullin
3843091c5f
Mark abstract base classes as such. ( #6930 )
...
* Mark abstract base classes as such.
* Remove an unneeded method.
* Fix exporter test coverage.
2025-06-30 15:14:34 +05:00
Andrey Rakhmatullin
8b3c3ea4ae
Refactor test functions that were returning a Deferred directly. ( #6889 )
2025-06-30 09:19:23 +02:00
Andrey Rakhmatullin
db0be1771c
Test refactoring, part 2. ( #6928 )
2025-06-29 23:10:38 +02:00
Andrey Rakhmatullin
03fe7a6424
Add a deprecation notice for the offsite spider middleware.
2025-06-29 02:35:48 +05:00
Andrey Rakhmatullin
2c1c10e923
Remove deprecated offsite spider middleware. ( #6926 )
...
* Remove deprecated offsite spider middleware.
* Add a deprecation notice for the offsite spider middleware.
2025-06-29 02:35:20 +05:00
Adrián Chaves
ba1cedee1b
Document the new defaults of throttling settings ( #6923 )
2025-06-28 18:13:54 +05:00
Andrey Rakhmatullin
076c01104a
Lower the concurrency settings in the default project template. ( #6918 )
...
* Lower the concurrency settings in the default project template.
* Simplify the concurrency settings template.
2025-06-28 18:13:44 +05:00
Adrián Chaves
3019393686
Document the new defaults of throttling settings ( #6923 )
2025-06-28 18:04:40 +05:00
Adrián Chaves
1473f4d347
Remove the deprecated sphinx-hoverxref ( #6922 )
2025-06-28 18:04:06 +05:00
Andrey Rakhmatullin
95172659af
Add sphinx-lint. ( #6920 )
2025-06-28 01:37:20 +02:00
Andrey Rakhmatullin
f454465b14
Lower the concurrency settings in the default project template. ( #6918 )
...
* Lower the concurrency settings in the default project template.
* Simplify the concurrency settings template.
2025-06-27 17:40:31 +05:00
Andrey Rakhmatullin
5fbab843bd
Fix invalid XML samples in tests that break with lxml 6. ( #6919 )
2025-06-27 16:24:09 +05:00
Andrey Rakhmatullin
eaae59fbef
Fix invalid XML samples in tests that break with lxml 6. ( #6919 )
2025-06-27 13:05:02 +02:00
Andrey Rakhmatullin
ef01a953b1
Fix setting ExecutionEngine._slot to None on close. ( #6910 )
...
* Fix setting ExecutionEngine._slot to None on close.
* Check self._slot in needs_backout().
2025-06-25 17:30:57 +05:00
Andrey Rakhmatullin
ff7795b159
Fix setting ExecutionEngine._slot to None on close. ( #6910 )
...
* Fix setting ExecutionEngine._slot to None on close.
* Check self._slot in needs_backout().
2025-06-25 17:29:29 +05:00
Andrey Rakhmatullin
d70f8a3f14
Refactoring of test_utils_*. ( #6905 )
2025-06-23 23:39:24 +05:00
Andrey Rakhmatullin
7fbd56bc9b
Handle exceptions in _start_request_processing(), cancel it on engine stop ( #6900 )
2025-06-23 22:38:38 +05:00
Andrey Rakhmatullin
0d75355b41
Handle exceptions in _start_request_processing(), cancel it on engine stop ( #6900 )
2025-06-23 19:36:54 +02:00
Andrey Rakhmatullin
b53faacfcd
Add .vscode to .gitignore. ( #6907 )
2025-06-23 22:26:13 +05:00
Thalison Fernandes
5e20b46e35
Fix FileFeedStorage handling of Windows paths without file:// scheme ( #6897 )
2025-06-23 22:26:04 +05:00
Andrey Rakhmatullin
843ad1afb1
Replace Black with Ruff in contributing.rst. ( #6903 )
2025-06-23 22:25:56 +05:00
Thalison Fernandes
020bfa7e5f
Add .venv folder to .gitignore ( #6901 )
2025-06-23 22:25:49 +05:00
Andrey Rakhmatullin
9149b6e7fc
Use new pytest for new Twisted. ( #6893 )
2025-06-23 22:25:34 +05:00
Andrey Rakhmatullin
9d324ebd13
Add .vscode to .gitignore. ( #6907 )
2025-06-23 18:58:54 +02:00
Thalison Fernandes
0d86fb69dc
Fix FileFeedStorage handling of Windows paths without file:// scheme ( #6897 )
2025-06-23 18:56:29 +02:00
Andrey Rakhmatullin
712e965dbd
Replace Black with Ruff in contributing.rst. ( #6903 )
2025-06-23 17:56:48 +02:00
Thalison Fernandes
d1575220ef
Add .venv folder to .gitignore ( #6901 )
2025-06-23 17:49:57 +02:00
Andrey Rakhmatullin
91b186cf18
Use new pytest for new Twisted. ( #6893 )
2025-06-23 17:42:11 +02:00
Adrián Chaves
85aeda365d
Clean up setting getter defaults ( #6892 )
2025-06-16 09:28:06 +02:00
Andrey Rakhmatullin
daa1a7d0b6
Remove the chdir fixture, re-enable fancy pytest asserts ( #6888 )
...
* Remove the chdir fixture.
* Re-enable fancy pytest asserts.
* Remove doc files from pytest ignores.
* Restore docs/_ext in test collection ignores.
* Skip a doctest that fails on Windows.
* Fix tests that were writing to the current dir.
2025-06-14 14:01:20 +05:00
Andrey Rakhmatullin
92c18d15b4
Remove ProcessTest and SiteTest. ( #6885 )
...
* Remove ProcessTest and SiteTest.
* Restore the support for Windows line endings in TestParseCommand.
* Add a test for running a scrapy command in a project subdir.
* Remove pywin32 from test deps.
2025-06-13 22:18:27 +05:00
Andrey Rakhmatullin
b4d11b8b25
Further reduce deps on unittest. ( #6884 )
2025-06-11 01:28:09 +02:00
Andrey Rakhmatullin
ac956f8595
Replace most of the @inlineCallbacks test helpers. ( #6883 )
2025-06-10 10:02:27 +02:00
Andrey Rakhmatullin
0390176ecd
Merge branch '2.13'
2025-06-09 15:54:35 +05:00
Andrey Rakhmatullin
c6740604a4
Bump version: 2.13.1 → 2.13.2
2025-06-09 15:21:06 +05:00
Andrey Rakhmatullin
7400868ad5
Release notes for 2.13.2. ( #6868 )
...
* Release notes for 2.13.2.
* Update release notes.
2025-06-09 15:19:02 +05:00
nakanoh
6b5a4a6417
Minor improvement in cmdline.py ( #6875 )
2025-06-09 12:07:01 +02:00
Andrey Rakhmatullin
24a827c72e
Pin older Twisted in tests, update type hints. ( #6882 )
2025-06-09 13:09:44 +05:00
Andrey Rakhmatullin
ba10dcfd1a
Pin older Twisted in tests, update type hints. ( #6882 )
2025-06-09 09:53:42 +02:00
Adrián Chaves
bb1c81ba6a
Remove the old artwork ( #6874 )
2025-06-09 12:43:15 +05:00
Adrián Chaves
0ae27b8fa1
Remove the old artwork ( #6874 )
2025-06-07 09:17:36 +02:00
Andrey Rakhmatullin
d825133284
Reduce deps on unittest, unify inlineCallbacks imports in tests. ( #6873 )
2025-06-06 22:59:09 +02:00
Adrián Chaves
744edb9ba9
Make scrapy fetch work with scrapy-poet ( #6872 )
2025-06-06 16:09:51 +02:00
Andrey Rakhmatullin
d329eedfef
Don't try to close ExecutionEngine.downloader when it doesn't exist. ( #6867 )
2025-06-06 16:26:38 +05:00
Andrey Rakhmatullin
657e6cb2b5
Don't try to close ExecutionEngine.downloader when it doesn't exist. ( #6867 )
2025-06-06 13:02:15 +02:00
Andrey Rakhmatullin
405d9bc8a2
More docs for the is_asyncio_reactor_installed() behavior change. ( #6866 )
2025-06-06 12:59:49 +02:00
Andrey Rakhmatullin
d99234a33f
Install the reactor explicitly in CrawlerRunner examples. ( #6865 )
2025-06-06 11:54:21 +02:00
Andrey Rakhmatullin
b20995c9d8
Silence a typing error.
2025-06-06 13:16:48 +05:00
Andrey Rakhmatullin
54474ceb0d
Fix a regression in errback result handling. ( #6863 )
2025-06-06 12:47:38 +05:00
Adrián Chaves
3d382aa650
Avoid raw HTML in the README ( #6839 )
2025-06-06 12:44:06 +05:00
Adrián Chaves
b8cd079014
Shorten the README and remove broken links to scrapy.org ( #6833 )
2025-06-06 12:44:02 +05:00
Adrián Chaves
105c0afb6e
Feature the new logo in the README ( #6831 )
2025-06-06 12:43:56 +05:00
Andrey Rakhmatullin
d602f13e8c
Fix a regression in errback result handling. ( #6863 )
2025-06-05 18:02:31 +05:00
Andrey Rakhmatullin
5902aab25c
Add the call_later() wrapper. ( #6858 )
2025-06-04 20:37:36 +05:00
Mehraz Hossain Rumman
c6698b9fe8
fixing settings order ( #6849 )
...
* fixing issue #6838
* Reorder some more settings.
* Clarify the header.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-06-04 16:02:29 +05:00
Andrey Rakhmatullin
8fb8d2c6b8
Add AsyncioLoopingCall. ( #6855 )
2025-06-03 20:21:33 +02:00
Andrey Rakhmatullin
3aa5e75787
Use AsyncCrawlerProcess in commands. ( #6845 )
...
* Use AsyncCrawlerProcess in commands.
* Ignore coverage of abstract methods.
* Address feedback.
2025-06-03 17:47:52 +05:00
Andrey Rakhmatullin
d400aa3e2d
Add _parallel_asyncio(). ( #6852 )
2025-06-03 11:19:15 +02:00
Rodrigosnrocha
9cc23641cc
Deprecate _parse_response and implement parse_with_rules ( #6804 )
2025-06-02 17:00:17 +02:00
Andrey Rakhmatullin
8ae418df44
Rewrite download handler tests to coroutines. ( #6846 )
2025-06-02 16:02:08 +02:00
Adrián Chaves
8f92a26636
Avoid raw HTML in the README ( #6839 )
2025-05-30 09:33:17 +02:00
Andrey Rakhmatullin
a724541a71
Split tests/test_commands.py. ( #6836 )
2025-05-28 21:46:04 +02:00
Andrey Rakhmatullin
e0b9f2d8f6
Don't use CrawlerProcess in the commands that don't need it. ( #6824 )
...
* Don't use CrawlerProcess in the commands that don't need it.
* Use a dummy spider loader in runspider.
2025-05-28 19:57:33 +05:00
Andrey Rakhmatullin
05b3b205ce
Add `AsyncCrawlerProcess` and `Crawler.crawl_async()` ( #6817 )
...
* Add a basic Crawler.crawl_async().
* Add custom loop tests for *CrawlerRunner.
* Add AsyncCrawlerProcess.
* Update related docs.
* Update practices.rst.
* Address test failures.
* Add a note about AsyncCrawler* to the docs about switching reactors.
* Address feedback.
* Update for TID253.
* Simplify test_crawler_crawl_async_twice_parallel_unsupported().
2025-05-28 18:55:44 +05:00
Andrey Rakhmatullin
916fe50974
Fix and ban the top-level twisted.internet.reactor imports. ( #6835 )
2025-05-28 15:53:52 +05:00
Andrey Rakhmatullin
dceb85bf3e
Add is_asyncio_available(). ( #6827 )
...
* Add is_asyncio_available().
* Print unexpected warnings in test_install_asyncio_reactor().
* Fix printing warnings.
* Fix printing warnings - 2.
* Skip TestDeferredToFuture on non-asyncio.
* Test the is_asyncio_available() exception.
2025-05-28 14:46:39 +05:00
Adrián Chaves
c480c77f54
Shorten the README and remove broken links to scrapy.org ( #6833 )
2025-05-28 11:35:18 +02:00
Adrián Chaves
f98ffc71d2
2.13.1 ( #6832 )
2025-05-28 10:58:34 +02:00
Adrián Chaves
7b4cf06b6e
Feature the new logo in the README ( #6831 )
2025-05-28 10:54:36 +02:00
Adrián Chaves
7fe7f1734a
Bump version: 2.13.0 → 2.13.1
2025-05-28 10:12:46 +02:00
Adrián Chaves
08ee88456f
bumpversion: set the release date automatically
2025-05-28 10:12:37 +02:00
Adrián Chaves
0cdb971f63
Complete the release notes
2025-05-28 10:06:04 +02:00
Mikhail Korobov
c6643c08ee
Merge pull request #6828 from scrapy/lower-start-priority
...
Scrapy 2.13.1: Prioritize other requests over start requests
2025-05-28 11:29:57 +05:00
Andrey Rakhmatullin
b41aea4873
Restructure download handler tests. ( #6821 )
...
* Restructure download handler tests.
* Typo.
* Use mixins to reduce boilerplate.
2025-05-27 18:19:47 +05:00
Adrián Chaves
e3f82afaf1
Add a test for ScrapyPriorityQueue pop order
2025-05-27 10:01:00 +02:00
Andrey Rakhmatullin
5973208567
Make the release notes work better on PyPI. ( #6826 )
2025-05-27 12:34:49 +05:00
Andrey Rakhmatullin
06dec08125
Fix a wrong versionadded usage. ( #6822 )
2025-05-27 12:34:40 +05:00
Keval Sakhiya
43087fe1df
Fix typo in documentation and code: 'needs_backoff' -> 'needs_backout' ( #6815 )
...
Corrected the typo in the code and documentation where 'needs_backoff' was incorrectly used instead of 'needs_backout'.
2025-05-27 12:34:33 +05:00
Andrey Rakhmatullin
f28be27423
Add a deepwiki badge, update other badges. ( #6793 )
2025-05-27 12:34:14 +05:00
Adrián Chaves
05529f3017
Release notes for Scrapy 2.13.1
2025-05-27 08:44:18 +02:00
Adrián Chaves
9d92d16510
Prioritize other requests over start requests
2025-05-27 08:32:24 +02:00
Andrey Rakhmatullin
816d23da30
Make the release notes work better on PyPI. ( #6826 )
2025-05-26 21:31:28 +02:00
Andrey Rakhmatullin
f2fc177f1f
Fix a wrong versionadded usage. ( #6822 )
2025-05-23 11:06:33 +02:00
Keval Sakhiya
ff7d29654a
Fix typo in documentation and code: 'needs_backoff' -> 'needs_backout' ( #6815 )
...
Corrected the typo in the code and documentation where 'needs_backoff' was incorrectly used instead of 'needs_backout'.
2025-05-20 07:51:31 +02:00
Andrey Rakhmatullin
4b9043b532
Merge pull request #6803 from wRAR/simplify-defer
...
Simplify deferred_from_coro(), add more tests.
2025-05-16 18:11:56 +04:00
Andrey Rakhmatullin
b9caaf8a63
Simplify deferred_from_coro(), add more tests.
2025-05-16 17:16:45 +05:00
Andrey Rakhmatullin
457ba39719
Merge pull request #6801 from wRAR/signals-async
...
Add `send_catch_log_async()`.
2025-05-15 21:51:26 +04:00
Andrey Rakhmatullin
3c2cd53abb
Skip the doctest.
2025-05-15 22:17:37 +05:00
Andrey Rakhmatullin
bf1bfaaa3e
Slight improvements for the signal docs.
2025-05-15 20:02:38 +05:00
Andrey Rakhmatullin
1ddcb568e2
Add send_catch_log_async().
2025-05-15 15:45:55 +05:00
Andrey Rakhmatullin
82acef3051
Add AsyncCrawlerRunner. ( #6796 )
2025-05-14 16:21:18 +02:00
Andrey Rakhmatullin
b86f00327a
Refactor more Deferred functions. ( #6795 )
2025-05-13 20:47:57 +02:00
Andrey Rakhmatullin
2442536d0f
Add a deepwiki badge, update other badges. ( #6793 )
2025-05-13 10:22:28 +02:00
Felipe Benevolo
128cb551eb
refactor tests/test_downloadermiddleware_httpcache.py ( #6769 )
2025-05-12 13:04:34 +02:00
Andrey Rakhmatullin
82a3245158
Bump version: 2.12.0 → 2.13.0
2025-05-08 14:43:34 +05:00
Andrey Rakhmatullin
0f8abd2cce
Merge pull request #6757 from wRAR/relnotes-2.13.0
...
Release notes for 2.13.0
2025-05-08 13:41:56 +04:00
Andrey Rakhmatullin
0ce693dfa9
Update VERSION strings.
2025-05-08 13:23:19 +05:00
Andrey Rakhmatullin
b07e6d4ea8
Merge remote-tracking branch 'origin/master' into relnotes-2.13.0
2025-05-08 13:17:47 +05:00
Andrey Rakhmatullin
e86b5051c2
Merge commit '373e501' into relnotes-2.13.0
2025-05-08 10:55:57 +05:00
Andrey Rakhmatullin
5f6d1b464b
Cover up to 373e501 in the release notes.
2025-05-08 10:55:40 +05:00
Adrián Chaves
036f3e5627
Support asynchronous start requests ( #6729 )
2025-05-07 19:04:03 +02:00
Adrián Chaves
373e501f78
Link to scrapy.org from the docs ( #6780 )
2025-05-07 16:11:22 +02:00
Andrey Rakhmatullin
4899d416e7
Add PyPy 3.11 to CI. ( #6697 )
2025-05-06 12:31:28 +02:00
Andrey Rakhmatullin
474f8312ff
Merge pull request #6776 from wRAR/deferred-apis
...
Add a list of Deferred-only APIs.
2025-05-05 21:28:50 +04:00
Andrey Rakhmatullin
acb5f895cd
Update docs/topics/coroutines.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2025-05-05 22:28:36 +05:00
Adrián Chaves
523fc25c4d
Document default values set by startproject ( #6775 )
2025-05-05 18:51:15 +02:00
Andrey Rakhmatullin
b93290f28a
Add a list of Deferred-only APIs.
2025-05-05 19:38:04 +05:00
Andrey Rakhmatullin
509b572efc
Migrate the build system to hatchling. ( #6771 )
2025-05-05 09:51:53 +02:00
Andrey Rakhmatullin
2a1edbd473
Remove usages of TestCase._wait(). ( #6773 )
2025-05-05 09:44:17 +02:00
Andrey Rakhmatullin
ff1ac75c9e
Fix shutdown tests. ( #6772 )
2025-05-05 09:37:38 +02:00
Andrey Rakhmatullin
5dfe7cd7b8
Improve tests for start items. ( #6770 )
2025-05-05 09:36:52 +02:00
Adrián Chaves
8f059d4095
Merge pull request #6766 from wRAR/errback-tests
...
Improve test coverage of Scraper.
2025-05-02 10:37:28 +02:00
Andrey Rakhmatullin
da9078c4bb
Add tests for raising CloseSpider in callbacks.
2025-05-01 23:12:39 +05:00
Andrey Rakhmatullin
23c206af35
Improve test coverage of Scraper.
2025-05-01 22:59:18 +05:00
Andrey Rakhmatullin
6deae473d9
Merge pull request #6764 from wRAR/spider-arg-scraper
...
Remove the unnecessary spider argument from Scraper and related code.
2025-04-30 18:33:35 +04:00
Andrey Rakhmatullin
eced5ca2d3
Remove the unnecessary spider argument from Scraper and related code.
2025-04-30 00:57:44 +05:00
Andrey Rakhmatullin
4aba7e5f66
Mention the deprecation of TestSpider.
2025-04-25 20:16:26 +05:00
Andrey Rakhmatullin
095140f134
Cover the current master in the release notes (up to daf9db7).
2025-04-25 19:43:29 +05:00
Andrey Rakhmatullin
b1f85b5a17
Release notes for 2.13.0, up to b4c2531021.
2025-04-24 20:03:36 +05:00
Andrey Rakhmatullin
daf9db72b2
Base class for universal spider middlewares ( #6693 )
...
* Initial BaseSpiderMiddleware.
* Rename the new methods.
* Remove the spider argument from new BaseSpiderMiddleware methods.
* Add docs for BaseSpiderMiddleware.
* Silence pylint.
* Add BaseSpiderMiddleware tests.
* Add a release note.
2025-04-23 19:29:04 +05:00
Andrey Rakhmatullin
9f99da8f86
Convert test_downloadermiddleware_robotstxt.py from callbacks to awaits. ( #6743 )
2025-03-24 09:26:25 +01:00
Suejung Shin
e50914e0f5
Codecov: Add test analytics ( #6741 )
2025-03-21 12:28:47 +01:00
Mehraz Hossain Rumman
3ca882fba8
Syntax Error Fixed ( #6738 )
...
* Syntax error fix issue #6731
* test case added
* extra logic removed
* mock spider fixture
* Update scrapy/utils/misc.py
Co-authored-by: Adrián Chaves <adrian@chaves.gal>
* settings.rst updated
* settings.rst updated
* settings.rst updated
---------
Co-authored-by: Adrián Chaves <adrian@chaves.gal>
2025-03-20 17:02:10 +05:00
Laerte Pereira
2ee01efe49
feat: Add count to spider_exceptions stats ( #6740 )
...
* feat: Add overall exception_count to spider_exceptions stats
* Remove variable
* Update test_closespider.py
* Update test_closespider.py
* Rename exception_count → count
2025-03-20 15:49:44 +05:00
Andrey Rakhmatullin
8729247213
Fix running simple tests with --reactor=default. ( #6735 )
2025-03-15 20:33:10 +01:00
Andrey Rakhmatullin
9057bf4e1e
More docs about Deferred<->Future interoperability. ( #6734 )
2025-03-15 11:47:16 +01:00
Andrey Rakhmatullin
fc566a7ff9
Don't install the reactor in is_asyncio_reactor_installed(). ( #6732 )
2025-03-14 20:46:17 +01:00
Andrey Rakhmatullin
d0dabbc097
Enable AsyncioSelectorReactor by default. ( #6713 )
...
* Enable AsyncioSelectorReactor by default.
* Improve get_crawler(), switch more tests to it.
* Fix the remaining default-reactor test failures.
* Address documentation feedback.
* Make pinned envs more consistent.
2025-03-12 01:18:30 +05:00
Andrey Rakhmatullin
eb654aa1a8
Convert remaining unittest assert* calls, use the tmp_path fixture. ( #6725 )
2025-03-11 18:00:36 +01:00
Adrián Chaves
803b4f258d
tox: move to posargs pytest parameters that can be too noisy when running specific tests ( #6724 )
2025-03-11 14:53:42 +01:00
Adrián Chaves
ba28d96d3e
Centralize from_crawler docs (and somewhat related changes) ( #6723 )
2025-03-11 14:53:04 +01:00
Adrián Chaves
5a0690c89d
Remove or post-pone the use of itemadapter.is_item, as a potentially expensive call ( #6719 )
2025-03-11 14:52:48 +01:00
Adrián Chaves
26ecc93228
Run CI only on the main branch, on release branches and on PRs ( #6720 )
2025-03-11 14:12:11 +01:00
Adrián Chaves
9b7db1a068
Move some reference docs of Request to the code ( #6721 )
2025-03-11 12:43:50 +01:00
Adrián Chaves
faab15c3f2
Merge pull request #6722 from scrapy/remove-trailing-whitespace
...
Remove trailing whitespace
2025-03-11 12:03:50 +01:00
Adrián Chaves
bee74fb753
Remove trailing whitespace
2025-03-11 11:56:44 +01:00
Andrey Rakhmatullin
2accaa4af4
Merge pull request #6716 from wRAR/better-queuelib-fix
...
Better fix for test_non_pickable_object on Windows.
2025-03-10 13:09:48 +04:00
Andrey Rakhmatullin
0bbfca6c1d
Better fix for test_non_pickable_object on Windows.
2025-03-10 13:15:28 +05:00
Andrey Rakhmatullin
7bbe775040
Converting tests to plain asserts, part 5. ( #6712 )
2025-03-09 20:24:45 +01:00
Andrey Rakhmatullin
d442227fa7
Converting tests to plain asserts, part 8. ( #6711 )
2025-03-09 20:24:12 +01:00
Andrey Rakhmatullin
380c2279b9
Converting tests to plain asserts, part 7. ( #6710 )
2025-03-09 20:23:51 +01:00
Andrey Rakhmatullin
02ed71d887
Converting tests to plain asserts, part 6. ( #6709 )
2025-03-09 20:20:24 +01:00
Mehraz Hossain Rumman
044c3f69ed
Deprecate InitSpider ( #6714 )
2025-03-09 20:18:57 +01:00
Andrey Rakhmatullin
1469b2739e
Drop tests/test_loader_deprecated.py. ( #6704 )
2025-03-08 17:50:54 +01:00
Andrey Rakhmatullin
40833afc86
Work around a queuelib test file close problem. ( #6703 )
2025-03-07 19:33:41 +01:00
Andrey Rakhmatullin
3ded1dfe31
Converting tests to plain asserts, part 4. ( #6702 )
2025-03-07 17:25:15 +01:00
Andrey Rakhmatullin
18f912b78f
Merge pull request #6701 from wRAR/cleanup-splash
...
Remove the Splash recommendation.
2025-03-07 13:58:02 +04:00
Andrey Rakhmatullin
d2e5486d5a
Remove the Splash recommendation.
2025-03-07 13:20:42 +05:00
Andrey Rakhmatullin
5a605969bd
Converting tests to plain asserts, part 2. ( #6699 )
2025-03-06 20:52:41 +01:00
Andrey Rakhmatullin
1843a4f753
Converting tests to plain asserts, part 3. ( #6700 )
2025-03-06 20:50:14 +01:00
Andrey Rakhmatullin
35212ec5b0
Merge pull request #6696 from wRAR/deprecate-test-utils
...
Move most of the test utils inside tests.
2025-03-05 22:07:15 +05:00
Adrián Chaves
0c9200094e
Extend BaseSettings with utils for add-ons ( #6614 )
2025-03-05 10:31:59 +01:00
Andrey Rakhmatullin
d161d1d47d
Convert tests/test_utils* to plain asserts. ( #6695 )
2025-03-04 09:31:26 +01:00
Andrey Rakhmatullin
93c076047b
Add scrapy/utils/testproc.py to collect_ignore to silence a warning.
2025-03-02 21:19:24 +05:00
Andrey Rakhmatullin
a5731c1944
Move most of the test utils inside tests.
2025-03-02 21:04:12 +05:00
Andrey Rakhmatullin
87db3f2fd6
Add SpiderLoaderProtocol. ( #6694 )
2025-02-28 11:18:55 +01:00
Andrey Rakhmatullin
8d92c28a16
Switch to pytest.raises(). ( #6680 )
...
* Switch to pytest.raises().
* Add matches= to broad pytest.raises().
* Adjust the test_nonserializable_object() regex for Python <= 3.11.
* Adjust the test_nonserializable_object() regex for PyPy.
* Adjust other test exception regexes for PyPy.
* Cleanup.
2025-02-27 23:13:04 +05:00
Andrey Rakhmatullin
391af6afcc
Unknown encoding handling in HttpCompressionMiddleware, restore x-gzip support ( #6618 )
...
* Unknown encoding handling in HttpCompressionMiddleware.
* Implement the changes for unknown encoding handling.
* Restore support for Content-Encoding: x-gzip.
* Simplify the decoding logic.
* Add tests for the unsupported encoding warning.
* Add a test for the "no zstandard" warning.
2025-02-27 22:37:01 +05:00
Andrey Rakhmatullin
c200458f24
Add more docs for updating sync spider middlewares. ( #6688 )
2025-02-25 00:16:23 +01:00
Matt Winter
8c34e6d9a4
curl: add support for parsing -b,--cookie ( #6684 )
2025-02-19 10:17:37 +01:00
Andrey Rakhmatullin
a898331d14
Preparations for switching to direct pytest. ( #6678 )
2025-02-16 20:28:58 +01:00
Andrey Rakhmatullin
7d5b189c11
Fix getting annotations for _parse_sitemap() at the runtime. ( #6671 )
...
* Fix getting annotations for _parse_sitemap() at the runtime.
* Split off the callback annotations test.
2025-02-14 20:40:06 +05:00
Andrey Rakhmatullin
00167edca0
Merge pull request #6664 from wRAR/downgrade-warnings
...
Improve diagnostics for sync-only spider middlewares.
2025-02-11 22:45:21 +04:00
Andrey Rakhmatullin
ede9e9c3c3
Use full method names in all spidermw log messages.
2025-02-11 23:07:25 +05:00
Andrey Rakhmatullin
d8978d405c
Improve diagnostics for sync-only spider middlewares.
2025-02-09 01:33:27 +05:00
anubhav
f041f26a6f
Support dark mode in the documentation ( #6653 )
2025-02-06 18:07:07 +01:00
Laerte Pereira
4e0a3087e4
fix: Reactor info logged twice ( #6657 )
...
* fix: Reactor info logged twice
* Change condition syntax
* Simplify logic
* Format
2025-02-06 15:47:39 +05:00
Andrey Rakhmatullin
02ad6bd1f6
Merge pull request #6656 from Laerte/master
...
docs: Remove AjaxCrawlMiddleware mention from built-in downloader middleware
2025-02-05 21:05:54 +04:00
Laerte Pereira
2eb3c75c69
Remove AjaxCrawlMiddleware mention from built-in downloader middleware
2025-02-05 13:16:51 -03:00
Andrey Rakhmatullin
9fd08a92a8
Merge pull request #6655 from Laerte/master
...
Remove deprecated signals
2025-02-05 16:49:56 +04:00
Laerte Pereira
9d35428770
Remove deprecated signals
2025-02-05 06:48:56 -03:00
Andrey Rakhmatullin
cc480680d7
Merge pull request #6650 from wRAR/cleanup-cache-tests
...
Remove a duplicate test.
2025-02-03 23:33:07 +04:00
Andrey Rakhmatullin
ba5df629a2
Refactor downloader tests ( #6647 )
...
* Make download handler test base classes abstract.
* Small cleanup.
* Don't run the full test suite for special HTTP cases.
* Don't run tests in imported base classes.
* Remove an obsolete service_identity check.
* Move FTP imports back to the top level.
* Simplify the H2DownloadHandler import.
* Forbig pytest 8.2.x.
* Revert "Simplify the H2DownloadHandler import."
This reverts commit ed187046ac .
2025-02-03 20:11:47 +05:00
Andrey Rakhmatullin
16e39661e9
Merge pull request #6651 from wRAR/deprecate-ajaxcrawl
...
Deprecate AjaxCrawlMiddleware and stop calling escape_ajax() by default
2025-02-03 13:57:46 +04:00
Andrey Rakhmatullin
76a8badd24
Add a deprecation notice to the AjaxCrawlMiddleware docs.
2025-02-03 14:55:10 +05:00
Andrey Rakhmatullin
4842bcbf1d
Deprecate and disable escape_ajax().
2025-02-03 14:08:05 +05:00
Andrey Rakhmatullin
393ff96e45
Deprecate AjaxCrawlMiddleware.
2025-02-03 14:08:05 +05:00
Mikhail Korobov
b4c2531021
Merge pull request #6648 from wRAR/mockserver-calls
...
Optimize mockserver calls
2025-02-03 14:06:35 +05:00
Mikhail Korobov
c727c6f201
Merge pull request #6646 from wRAR/engine-tests-cleanup
...
Refactor EngineTest tests.
2025-02-03 13:56:47 +05:00
Andrey Rakhmatullin
df688910e0
Remove a duplicate test.
2025-02-02 18:48:26 +05:00
Andrey Rakhmatullin
783b98deda
Make mockserver instances per-class.
2025-02-02 14:10:09 +05:00
Andrey Rakhmatullin
1a0dfbd32e
Reuse mockserver instances in test_feedexport.py.
2025-02-02 13:28:34 +05:00
Andrey Rakhmatullin
200d76afa9
Refactor EngineTest tests.
2025-02-01 16:07:55 +05:00
Andrey Rakhmatullin
340819eff0
Merge pull request #6635 from wRAR/webclient-cleanup
...
Remove scrapy.core.downloader.webclient._parse().
2025-01-28 23:08:06 +04:00
Andrey Rakhmatullin
0a80871c3a
Remove scrapy.core.downloader.webclient._parse().
2025-01-28 22:22:09 +05:00
Andrey Rakhmatullin
a8d9746f56
Merge pull request #6634 from wRAR/deprecate-http10
...
Deprecate HTTP/1.0 code.
2025-01-28 13:29:25 +04:00
Andrey Rakhmatullin
0d2d2892ba
Silence the readBody warning.
2025-01-28 02:08:49 +05:00
Andrey Rakhmatullin
bc1aeeefc9
Deprecate overriding ScrapyClientContextFactory.getContext().
2025-01-28 02:07:47 +05:00
Andrey Rakhmatullin
16b998f9ca
Sort out webclient tests.
2025-01-28 01:35:04 +05:00
Andrey Rakhmatullin
d27c6b46b1
Deprecate HTTP/1.0 support.
2025-01-27 21:25:47 +05:00
Lidiane T
98a57e2418
Fix error when running `scrapy bench` ( #6633 )
2025-01-27 11:21:30 +01:00
Andrey Rakhmatullin
cec0aeca58
Bump ruff, switch from black to ruff-format ( #6631 )
2025-01-27 11:07:09 +01:00
anubhav
c03fb2abb8
fix: added feed_options as a keyword argument to GCSFeedStorage. ( #6628 )
2025-01-23 21:06:45 +05:00
Andrey Rakhmatullin
d4b152bbf6
Drop PyPy 3.9, add a pypy3-extra-deps CI job. ( #6613 )
2025-01-23 09:22:18 +01:00
Rotzbua
7e61ff3524
Upgrade Sphinx ( #6624 )
2025-01-22 18:09:42 +01:00
Andrey Rakhmatullin
499b6c66b4
Merge pull request #6626 from Laerte/master
...
fix: test_s3_export fails with boto3 >= 1.36.0
2025-01-22 15:14:33 +04:00
guillermo-bondonno
9bc0029d27
Allow updating pre-crawler settings from add-ons ( #6568 )
2025-01-22 12:07:44 +01:00
Laerte Pereira
14219b1fca
fix: test_s3_export fails with boto3 >= 1.36.0
2025-01-22 07:16:22 -03:00
Rotzbua
e0c828b7f6
chore(docs): refactor config ( #6623 )
2025-01-20 12:18:30 +01:00
Andrey Rakhmatullin
8bc8f752e6
Merge pull request #6622 from Rotzbua/fix_docs_broken_link
...
fix(docs): pillow domain is shut down permanently
2025-01-19 20:33:00 +04:00
Rotzbua
ee4f527f47
fix(docs): pillow domain is shut down permanently
...
See https://github.com/python-pillow/Pillow/issues/8585
2025-01-19 14:58:02 +01:00
Andrey Rakhmatullin
782e286ccf
Merge pull request #6621 from Rotzbua/chore_docs_rtd_template
...
chore(docs): migrate to RTD template v3
2025-01-19 17:35:43 +04:00
Rotzbua
d7168577b8
chore(docs): migrate to RTD template v3
...
notable change: Drop support for all versions of Internet Explorer.
2025-01-19 13:50:53 +01:00
anubhav
ca345a3b73
Flexible severity of logging level when items are dropped ( #6608 )
2025-01-15 11:08:18 +01:00
anubhav
1c1e83895c
Fix _pop_command_name ( #6606 )
2025-01-14 16:40:24 +01:00
Adrián Chaves
98ba61256d
Deprecate BaseDupeFilter.log() and improve dupefilter docs ( #4151 )
...
* Remove BaseDupeFilter.log()
It is never called because request_seen() always returns False
* Document the interface of DUPEFILTER_CLASS classes
* Remove unnecessary BaseDupeFilter comments and add a short class description
* Improve the documentation related to the DUPEFILTER_CLASS setting
* Deprecate BaseDupeFilter.log
* Update the docs
* Fix the new code example
* Remove typing to keep the example short
Otherwise, it would have required yet another import line (from __future__ or typing).
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-01-14 19:36:56 +05:00
Ionut-Cezar Ciubotariu
402500b164
Change unknown cmd message when outside project ( #3426 )
...
* Change unknown cmd message when outside project
* Simplification.
* Move the import to the top level.
* Reword the message.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-01-10 23:08:27 +05:00
Kevin Lloyd Bernal
1fc91bb462
new `allow_offsite` parameter in OffsiteMiddleware ( #6151 )
...
* new 'allow_offsite' parameter in OffsiteMiddleware
* document deprecated dont_filter flag in OffsiteMiddleware
* avoid deprecating dont_filter in OffsiteMiddleware
* Copy the code to the downloader mw.
* Add tests for allow_offsite in the downloader mw.
* Mark allow_offsite with reqmeta.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2025-01-08 21:28:51 +05:00
Adrián Chaves
b6d69e3895
Merge pull request #6610 from wRAR/coverage-subprocess
...
Fix and speed up subprocess coverage tracking
2025-01-07 18:29:31 +01:00
Andrey Rakhmatullin
3154b08e90
Improve coverage speed on Python 3.12+.
2025-01-07 20:42:03 +05:00
Andrey Rakhmatullin
7dfbecd392
Fix tracking of coverage in subprocesses.
2025-01-07 20:41:48 +05:00
Andrey Rakhmatullin
59fcb9b93c
Improve internal refs to scrapy.Request and scrapy.Selector ( #6526 )
...
* Improve internal refs to scrapy.Selector.
* Improve internal refs to scrapy.Request.
* More scrapy.http fixes.
* Fix FormRequest refs.
* More fixes.
* Simplifications.
* Last fixes.
* Add the parsel intersphinx.
2025-01-07 16:18:18 +05:00
Andrey Rakhmatullin
5d3aa80ad1
Switch CI to codecov/codecov-action and enable it on Windows. ( #6609 )
2025-01-07 10:52:26 +01:00
Andrey Rakhmatullin
4869315d10
Install libjpeg-dev on pinned envs to be able to install Pillow. ( #6607 )
2025-01-07 10:46:12 +01:00
Laerte Pereira
f2234c5b96
Fix Crawler.request_fingerprinter typing ( #6605 )
2025-01-07 10:40:49 +01:00
Andrey Rakhmatullin
4d31277bc6
Explicitly mark re-exports. ( #6579 )
2025-01-02 23:48:14 +01:00
Andrey Rakhmatullin
c330a399dc
Merge pull request #6601 from wRAR/ruff-rules-5
...
Add more Ruff rules, do some pylint cleanups
2025-01-02 17:38:15 +04:00
Andrey Rakhmatullin
176ae348c5
Reformat long REFERRER_POLICY.
2025-01-02 18:14:18 +05:00
Andrey Rakhmatullin
6ae5b92671
Drop the remaining unittest.main() blocks. ( #6602 )
2025-01-02 12:45:04 +01:00
Arthur
b10d46d280
Fix the calculate_final_stats method ( #6599 )
2025-01-02 12:36:28 +01:00
Andrey Rakhmatullin
dc706d4fc3
Remove useless pylint: disable lines.
2025-01-02 12:32:25 +05:00
Andrey Rakhmatullin
b70443f2d0
Split ruff and pylint ignores into two categories, some pylint cleanup.
2025-01-02 01:03:42 +05:00
Andrey Rakhmatullin
c87354cd46
Enable SIM Ruff rules.
2025-01-02 01:03:36 +05:00
Andrey Rakhmatullin
273620488c
Enable PTH Ruff rules.
2025-01-01 22:21:51 +05:00
Andrey Rakhmatullin
f44ca39fa2
Enable FLY Ruff rules.
2025-01-01 21:50:02 +05:00
Andrey Rakhmatullin
838ff99f37
Enable RUF Ruff rules.
2025-01-01 21:41:08 +05:00
Adrián Chaves
ee239d2451
Merge pull request #6595 from wRAR/update-tools
...
Update tool versions
2024-12-30 09:56:08 +01:00
Andrey Rakhmatullin
f7af7b282d
Bump mypy and stubs.
2024-12-29 16:45:26 +05:00
Andrey Rakhmatullin
4a0c05749c
Bump tool versions.
2024-12-29 14:29:27 +05:00
Andrey Rakhmatullin
cc484efd43
Replace isort with the ruff isort rules.
2024-12-29 14:15:16 +05:00
Mikhail Korobov
ba33a40365
Merge pull request #6587 from Gallaecio/settings-addons
...
Add ADDONS to the settings template for new projects
2024-12-18 23:05:14 +05:00
Adrián Chaves
c5ed0fd45c
Add ADDONS to the settings template for new projects
2024-12-18 17:05:51 +01:00
Laerte Pereira
a195af304d
Deprecate w3lib objects importable from scrapy.utils.url ( #6586 )
2024-12-18 11:50:44 +05:00
Adrián Chaves
21b9ba717c
Allow customizing logged software versions ( #6582 )
...
Co-authored-by: Grammy Jiang <grammy.jiang@gmail.com>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-12-16 14:46:23 +01:00
Andrey Rakhmatullin
7dd92e6e43
Add pylint rules to ruff, refresh the ignore list of pylint itself ( #6584 )
2024-12-16 09:44:36 +01:00
Andrey Rakhmatullin
57a5460529
Merge pull request #6581 from wRAR/ruff-rules-3
...
Ruff: enable other useful rules, turn on autofixing
2024-12-13 13:14:19 +04:00
Andrey Rakhmatullin
c003fc0841
Add flake8 warning rules to ruff.
2024-12-12 21:07:01 +05:00
Andrey Rakhmatullin
1e4c81e9dc
Add Perflint rules to ruff.
2024-12-12 21:03:34 +05:00
Andrey Rakhmatullin
c2832ed131
Add flake8-pyi rules to ruff.
2024-12-12 20:44:28 +05:00
Andrey Rakhmatullin
93644f2c30
Add flake8-pie rules to ruff.
2024-12-12 20:33:35 +05:00
Andrey Rakhmatullin
e7595837a6
Add flake8-raise rules to ruff.
2024-12-12 20:33:35 +05:00
Andrey Rakhmatullin
897e124a27
Add flake8-return rules to ruff.
2024-12-12 20:32:25 +05:00
Andrey Rakhmatullin
802c67072c
Enable ruff --fix.
2024-12-12 20:12:55 +05:00
Adrián Chaves
5c2df5cf2a
Contributing: add a section on finding work ( #6575 )
2024-12-12 11:38:30 +01:00
Andrey Rakhmatullin
cde0845ab2
Ruff: migrate pyupgrade and bandit, enable some other rules ( #6577 )
2024-12-10 19:53:27 +01:00
Andrey Rakhmatullin
b423e971ae
Merge pull request #6576 from wRAR/ruff-rules-1
...
Add flake8 plugin rules to ruff
2024-12-10 14:34:06 +04:00
Andrey Rakhmatullin
f4d8d6d8ac
Tidy up noqa comments.
2024-12-10 14:58:45 +05:00
Andrey Rakhmatullin
ba30f64268
Remove flake8.
2024-12-10 14:52:16 +05:00
Andrey Rakhmatullin
0d7a5e760d
Fix building docs.
2024-12-10 01:42:03 +05:00
Andrey Rakhmatullin
d47f142d0f
Add flake8-type-checking rules to ruff.
2024-12-10 01:28:20 +05:00
Andrey Rakhmatullin
d6bf1464b8
Add pydocstyle/flake8-docstrings rules to ruff.
2024-12-10 01:28:20 +05:00
Andrey Rakhmatullin
e53d6f09bc
Add flake8-comprehensions and flake8-debugger rules to ruff.
2024-12-10 01:28:20 +05:00
Andrey Rakhmatullin
c184f12ab5
Add flake8-bugbear rules to ruff.
2024-12-10 01:27:49 +05:00
Emery Berger
5680bee968
Made path absolute to enable running pytest from a different directory. ( #6567 )
2024-12-09 11:01:00 +01:00
Andrey Rakhmatullin
cc146b9df7
Add ruff with basic rules. ( #6565 )
2024-12-09 10:47:47 +01:00
Andrey Rakhmatullin
37be9da4e4
Merge pull request #6560 from wRAR/tls-method-tests
...
Add tests for DOWNLOADER_CLIENT_TLS_METHOD, remove dead code.
2024-11-25 19:13:36 +04:00
Andrey Rakhmatullin
4dcc04be48
Add tests for DOWNLOADER_CLIENT_TLS_METHOD, remove dead code.
2024-11-24 12:44:48 +04:00
Swayam Gupta
8c23da943c
Integrating configs into pyproject.toml ( #6547 )
2024-11-19 19:21:15 +05:00
Andrey Rakhmatullin
efb53aafdc
Fix a typo that broke PDF builds.
2024-11-18 15:44:52 +05:00
Andrey Rakhmatullin
b1f9e56693
Bump version: 2.11.2 → 2.12.0
2024-11-18 13:08:05 +05:00
Adrián Chaves
10089c6fe2
2.12 release notes ( #6226 )
...
* Cover 2.12 in the release notes up to 9bb973dc54
* Add one more highlight
* Better merge of the news entries.
* Cover 2.12 in the release notes up to 642af40 .
* Cover 2.12 in the release notes up to 7a0a34b .
* Cover 2.12 in the release notes up to b4bad97 .
* Add not yet merged PRs #6463 , #6507 , #6511 to the 2.12 release notes.
* Cover 2.12 in the release notes up to d85c39f , small fixes.
* Cover 2.12 in the release notes up to d215669 .
* Cover #6527 in the release notes.
* Address PR feedback.
* Cover recent PRs.
* Finalize the 2.12.0 release notes, small additional fixes.
---------
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-11-18 13:07:32 +05:00
Andrey Rakhmatullin
212e848402
Merge pull request #6545 from wRAR/mitmproxy-dhparam
...
Commit mitmproxy-dhparam.pem.
2024-11-15 22:24:46 +05:00
Andrey Rakhmatullin
feea3a0f67
Commit mitmproxy-dhparam.pem.
2024-11-15 21:08:18 +05:00
Andrey Rakhmatullin
87b2300831
Merge pull request #6543 from scrapy/pep740-attestations
...
Verified PyPI releases (a.k.a. PEP740)
2024-11-15 12:41:43 +05:00
Daniel Graña
dc4d6d16ea
Verified PyPI releases (a.k.a. PEP740)
2024-11-15 00:09:00 -03:00
Andrey Rakhmatullin
30fb54f47e
Merge pull request #6542 from nicklaustrup/Tests-contracts-swallowed-exceptions
...
Fix - return in finally can swallow exception (#6505 )
2024-11-15 00:48:06 +05:00
Nicholas Laustrup
bfcee452b0
Added failing test cases to tests/test_contracts.py and fixed corresponding methods + removed pylint comments
2024-11-14 10:40:12 -08:00
Andrey Rakhmatullin
ab5cb7c7d9
Merge pull request #6540 from wRAR/build_from_settings
...
Remove build_from_settings() and deprecate from_settings() code
2024-11-14 20:40:54 +05:00
Andrey Rakhmatullin
929d665a74
Address PR feedback.
2024-11-14 19:35:56 +05:00
Andrey Rakhmatullin
2ad5f0c12b
Extract duplicated code.
2024-11-14 13:03:04 +05:00
Andrey Rakhmatullin
6aa4d2b4ab
Prefer crawler.settings over settings in media pipelines.
2024-11-14 02:03:43 +05:00
Andrey Rakhmatullin
28fafbb8c5
Modernize the media pipeline initialization API.
2024-11-14 01:29:51 +05:00
Robert Palmer
261c4b61dc
Enhancement: Update docs to include IgnoreRequest details ( #6506 )
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2024-11-13 22:47:39 +05:00
Andrey Rakhmatullin
8700a5b7a9
Deprecate build_from_crawler() calling from_settings().
2024-11-13 00:20:10 +05:00
Andrey Rakhmatullin
eda1a8a7c5
Deprecate MiddlewareManager.from_settings().
2024-11-12 22:57:39 +05:00
Andrey Rakhmatullin
499e7e8aa6
Add from_crawler() to components that only had from_settings().
2024-11-12 21:12:32 +05:00
Andrey Rakhmatullin
f796d8780c
Add tests for MediaPipeline.from_crawler() and related code.
2024-11-12 21:08:04 +05:00
Andrey Rakhmatullin
83d4939d41
Deprecate scrapy.extensions.feedexport.build_storage() and simplify _get_storage().
2024-11-11 22:15:08 +05:00
Andrey Rakhmatullin
eda3a89b3f
Remove build_from_settings().
2024-11-11 16:44:47 +05:00
Andrey Rakhmatullin
b042ad255d
Address some previously ignored pylint messages. ( #6531 )
2024-11-11 11:49:52 +01:00
Mikhail Korobov
bcef96570b
Merge pull request #6527 from Gallaecio/dont-throttle-meta
...
Replace Slot.throttle with Request.meta['dont_throttle']
2024-11-08 14:25:37 +05:00
Adrián Chaves
dc3ebb6cf7
Refactor the docs
2024-11-07 16:38:48 +01:00
Adrián Chaves
2a4b7fe0f8
dont_throttle → autothrottle_dont_adjust_delay
2024-11-07 16:17:16 +01:00
Adrián Chaves
b244ea7ac0
Add the missing import to the docs example
2024-11-05 20:05:58 +01:00
Adrián Chaves
5862216bb1
Fix docs example
2024-11-05 19:55:28 +01:00
Adrián Chaves
f57fc454be
Replace Slot.throttle with Request.meta['dont_throttle']
2024-11-05 19:44:30 +01:00
Rohit Kumar Singh
d2156696c4
Deprecate unused scrapy utils ( #6519 )
...
* Added deprecation warnings for unused Scrapy.utils
* Grammatical corrections
* Exceptions class connected
* Deprecation of ScrapyJSONDecoder
* request_authenticate function deprecation
* Making all warning similar
* Added ignore statements for deprecation warning in tests
* Missing stacklevel attr. added
* Added Deprecation message
2024-11-04 21:09:45 +05:00
Andrey Rakhmatullin
e7f5ae0b34
Update the outdated Item docstring. ( #6427 )
...
* Update the outdated Item doscstring.
* Fix the reference links in items.html.
2024-11-04 16:17:56 +05:00
Andrey Rakhmatullin
ce5a132f12
Run and fix linkcheck. ( #6524 )
2024-11-04 11:40:07 +01:00
Rohit Kumar Singh
7701e590fb
Documentation added for Spider State in extensions.rst ( #6522 )
...
* Documentation added for Spider State in extensions.rst
* Made correction in documentation for Spiderstate
* Added appropriate intro for Spider state extension
* Added reference for spiderstate extension
* Added Spiderstate extension hyperlink refrence in jobs.rst
2024-11-02 10:45:27 +05:00
Andrey Rakhmatullin
d85c39f5bc
Deprecation removals. ( #6500 )
...
* Deprecation removals.
* Clean up the default pytest filterwarnings.
* Remove test_get_images_old().
* Redo boto-requiring test filtering.
* Remove an unused function.
* Improve the Crawler.crawl() error message.
* Fix the test.
2024-10-31 18:06:22 +05:00
Laerte Pereira
d2bdbad8c8
Deprecate `scrapy.twisted_version` ( #6512 )
...
* Deprecate scrapy.twisted_version
* fix: typing
* remove typing
* raise default exception if attribute is not found
* remove redudant ()
* add tests
* rollback exception raised
* add filterwarnings again
* change order
* lint
2024-10-30 00:28:35 +05:00
Rohitkr117
12b087b0f2
Added ignore statements for Windows specific typing issues ( #6516 )
2024-10-29 19:30:32 +01:00
Rohitkr117
65ecd5d528
Fixes for Twisted Version Check and Typing Issues ( #6511 )
2024-10-29 19:08:38 +01:00
ThunderMind
5bbf8124ac
Updated deprecated ast.NameConstant with ast.Constant #6305 ( #6463 )
2024-10-29 10:28:00 +01:00
Andrey Rakhmatullin
fcb5ab6cff
Remove code for unsupported Twisted. ( #6510 )
2024-10-29 10:21:07 +01:00
Andrey Rakhmatullin
0523e1616d
Explictly set html_baseurl on RTD. ( #6507 )
2024-10-29 10:16:03 +01:00
Andrey Rakhmatullin
b4bad97eae
Merge pull request #6166 from Gallaecio/py313
...
Add Python 3.13 to CI
2024-10-22 20:05:56 +05:00
Andrey Rakhmatullin
d10c58ff38
Bump pyftpdlib to the version supporting Python 3.13 on Windows.
2024-10-22 19:07:21 +05:00
Andrey Rakhmatullin
fffacb9dac
Merge remote-tracking branch 'origin/master' into py313
2024-10-22 19:07:10 +05:00
Andrey Rakhmatullin
04d0411bf7
Filter test-time warnings. ( #6501 )
2024-10-21 12:30:49 +02:00
Andrey Rakhmatullin
6d65708cb7
Merge pull request #6499 from wRAR/3.8-cleanup
...
Additional Python 3.7 and 3.8 cleanup, including Reppy support.
2024-10-18 00:08:11 +05:00
Andrey Rakhmatullin
677e977207
Remove dead links to the Reppy doc from the release notes.
2024-10-18 00:03:32 +05:00
Andrey Rakhmatullin
5759b3f0f2
Drop Reppy.
2024-10-17 23:41:23 +05:00
Andrey Rakhmatullin
7e07d48cc5
Small 3.7 and 3.8 cleanup.
2024-10-17 23:22:37 +05:00
Andrey Rakhmatullin
1138a5cf99
Merge pull request #6498 from wRAR/remove-runtime-typing
...
Remove --keep-runtime-typing from pyupgrade.
2024-10-17 23:18:22 +05:00
Andrey Rakhmatullin
7196a11f53
Reorder unions with None.
2024-10-17 21:52:03 +05:00
Andrey Rakhmatullin
c9095ef927
Remove --keep-runtime-typing from pyupgrade.
2024-10-17 21:26:02 +05:00
Julian Ste
c8e87ab21a
Fixed typos ( #6497 )
2024-10-17 17:03:16 +02:00
Andrey Rakhmatullin
f65e64a724
Misc typing improvements. ( #6494 )
2024-10-16 18:38:43 +02:00
Andrey Rakhmatullin
9bd5e5bcdb
Revert uvloop restrictions.
2024-10-16 14:50:57 +05:00
Andrey Rakhmatullin
845b1ffd44
Merge remote-tracking branch 'origin/master' into py313
2024-10-16 14:50:12 +05:00
Vsevolod Breus
5391663072
Drop Python 3.8 Support ( #6472 )
2024-10-16 10:03:16 +02:00
Andrey Rakhmatullin
9736e49b52
Merge pull request #6489 from rettinghaus/pypa_action
...
update gh-action-pypi-publish
2024-10-11 00:24:31 +05:00
Klaus Rettinghaus
5ef5474172
update gh-action-pypi-publish
2024-10-09 20:38:50 +02:00
Andrey Rakhmatullin
7ec6b7e65b
Merge pull request #6487 from wRAR/drop-setuptools-dep
...
Remove the installation dependency on setuptools.
2024-10-08 16:34:11 +05:00
Andrey Rakhmatullin
87651fdf47
Don't use types-setuptools.
2024-10-08 16:04:26 +05:00
Andrey Rakhmatullin
29bb869284
Remove the beta block.
2024-10-08 15:43:17 +05:00
Andrey Rakhmatullin
df6c51af0f
Use the 3.13 release.
2024-10-08 15:37:49 +05:00
Andrey Rakhmatullin
8c133fcf7e
Remove the installation dependency on setuptools.
2024-10-07 23:04:48 +05:00
mmoriniere
46cddc6ecf
Ignore SyntaxError as well when SPIDER_LOADER_WARN_ONLY is set to True ( #6484 )
2024-10-02 10:04:03 +02:00
Andrey Rakhmatullin
e139d22db9
Fix expectations for get_func_args() on 3.13.
2024-09-20 19:28:28 +05:00
Andrey Rakhmatullin
ee9ee2d12d
Revert bpython restrictions.
2024-09-12 14:32:32 +05:00
Andrey Rakhmatullin
b3f562d6a5
Revert "Revert uvloop restrictions."
...
This reverts commit c21c4a1850 .
2024-09-12 14:31:50 +05:00
Andrey Rakhmatullin
ae967d1c06
Merge pull request #6475 from LucasSD/remove-debug-log-message
...
Remove log pollution from core.engine signal handler (#6433 )
2024-09-10 12:01:37 +05:00
LucasSD
f260f819e0
Remove debug log message from _schedule_request method
2024-09-09 20:26:02 +01:00
Daniel O'Connor
67ab8d4650
Refactor genspider slightly so template variables can be overridden ( #6470 )
2024-08-28 21:07:49 +02:00
Andrey Rakhmatullin
c9d85faaf2
Merge pull request #6469 from Laerte/master
...
Add support for meta in Spider Contracts
2024-08-28 14:53:39 +05:00
Laerte Pereira
ddbdfeb699
Update scrapy/contracts/default.py
2024-08-27 07:24:57 -03:00
Laerte Pereira
4f9b2343c0
Merge branch 'master' of github.com:Laerte/scrapy
2024-08-27 07:16:10 -03:00
Laerte Pereira
3c2a9fa262
update docs
2024-08-27 07:16:01 -03:00
Laerte Pereira
f68f29dd13
Update docs/topics/contracts.rst
2024-08-26 23:37:57 -03:00
Laerte Pereira
b85e5a66ed
Add support for meta in Spider Contracts
2024-08-26 23:21:09 -03:00
Georgiy Zatserklianyi
6ce0342beb
Allow yielding items from start_requests ( #6417 )
...
Co-authored-by: Georgiy Zatserklianyi <george.zatseklyany@gmail.com>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-08-26 20:53:06 +02:00
Andrey Rakhmatullin
5794071f96
Typing fixes and updates. ( #6460 )
2024-08-23 12:48:01 +02:00
Andrey Rakhmatullin
c21c4a1850
Revert uvloop restrictions.
2024-08-21 01:06:05 +05:00
mlmsmith
af15bd1dad
minor changes to items section of docs ( #6462 )
2024-08-19 13:55:09 +02:00
Andrey Rakhmatullin
70756fd57c
Revert cffi and Pillow restrictions.
2024-08-11 13:57:13 +05:00
Andrey Rakhmatullin
1e68d3c0bf
Merge branch 'master' into py313
2024-08-11 13:46:51 +05:00
mlmsmith
b9ef1326a5
Proofread the commands documentation ( #6449 )
2024-08-01 09:29:11 +02:00
Adrián Chaves
03a15ced4f
Do not suggest logging dropped items twice ( #6448 )
...
Co-authored-by: Kevin Lloyd Bernal <kevinoxy@gmail.com>
2024-07-31 11:37:19 +02:00
mlmsmith
e376c0b31a
Tutorial edits ( #6440 )
2024-07-24 06:40:01 +02:00
Andrey Rakhmatullin
06f9c289d1
Merge pull request #6434 from guillermo-bondonno/feature/closespider_pagecount_no_item
...
Feature/closespider pagecount no item
2024-07-12 16:31:05 +05:00
guillermo-bondonno
026d606528
clean closespider_pagecount_no_item docs section
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-07-12 08:09:03 -03:00
guillermo-bondonno
9cdbcb4f63
add test_closespider_pagecount_no_item_with_pagecount
2024-07-11 14:02:24 -03:00
guillermo-bondonno
5f0fad16f5
improve test_closespider_pagecount_no_item and corresponding test spider
2024-07-11 13:26:22 -03:00
guillermo-bondonno
a40d5281cf
improve test_closespider_pagecount_no_item and MaxItemsSpider
2024-07-11 11:14:30 -03:00
Adrián Chaves
7a0a34b136
Merge pull request #6435 from wRAR/update-tools
...
Update tool versions
2024-07-11 10:26:04 +02:00
Andrey Rakhmatullin
3c9c1a31bc
Bump pylint.
2024-07-11 12:30:12 +05:00
Andrey Rakhmatullin
435686830c
Bump the Python version for RTD.
2024-07-11 12:25:13 +05:00
Andrey Rakhmatullin
129dbfa0bf
Bump tool versions.
2024-07-11 12:23:43 +05:00
guillermo-bondonno
8646d2ec7b
fix docs detail
2024-07-10 11:44:44 -03:00
guillermo-bondonno
59782d7308
update docs
2024-07-10 11:08:22 -03:00
guillermo-bondonno
d6352f9f66
refactor changes on closespider.py and improve test
2024-07-10 11:03:01 -03:00
guillermo-bondonno
a44818afea
restore mitmproxy-dhparam
2024-07-09 16:07:55 -03:00
guillermo-bondonno
0b8604bb5d
add CLOSESPIDER_PAGECOUNT_NO_ITEM to CloseSpider extension
2024-07-09 15:52:49 -03:00
Andrey Rakhmatullin
ceedb026f8
Remove top-level imports that install the reactor from scrapy.extensions.telnet. ( #6432 )
2024-07-09 08:34:58 +02:00
mlmsmith
d8ecd28c55
Documentation improvements ( #6429 )
2024-07-04 12:16:26 +02:00
Andrey Rakhmatullin
558b1d11d2
Use CallbackT for Request.callback. ( #6422 )
2024-07-01 09:30:49 +02:00
Andrey Rakhmatullin
41e15e93e7
Remove an obsolete import. ( #6415 )
2024-06-26 14:44:12 +02:00
Andrey Rakhmatullin
96d6519b25
Bump twine in twinecheck. ( #6416 )
2024-06-26 14:43:59 +02:00
Andrey Rakhmatullin
e47110f9a5
Add parameteres to most Deferred instances. ( #6414 )
2024-06-26 10:01:43 +02:00
Andrey Rakhmatullin
d08f559600
Add flake8-type-checking. ( #6413 )
2024-06-25 10:20:59 +02:00
mlmsmith
326e323e11
Apply grammar fixes ( #6411 )
2024-06-21 12:24:10 +02:00
Andrey Rakhmatullin
0e78ac609d
Merge pull request #6406 from wRAR/more-flake8
...
Add some flake8 plugins
2024-06-20 14:34:25 +05:00
Andrey Rakhmatullin
13d3b1af47
Split ignores into blocks.
2024-06-20 00:42:43 +05:00
Andrey Rakhmatullin
3d8dbd5648
flake8-bugbear
2024-06-20 00:27:38 +05:00
Andrey Rakhmatullin
1ef9c337ca
flake8-docstrings
2024-06-19 23:57:40 +05:00
Andrey Rakhmatullin
1c70d3e605
flake8-comprehensions
2024-06-19 23:36:36 +05:00
Andrey Rakhmatullin
a617e04d2e
flake8-string-format
2024-06-19 23:28:58 +05:00
Andrey Rakhmatullin
d132190625
flake8-debugger
2024-06-19 23:26:25 +05:00
Andrey Rakhmatullin
a364560fad
Unpin markupsafe in extra-deps. ( #6403 )
2024-06-17 11:38:10 +02:00
Andrey Rakhmatullin
365c9e62ad
Removing empty example reference ( #6402 )
...
Co-authored-by: Michael Duane Mooring <mikeumus@gmail.com>
2024-06-17 11:37:11 +02:00
Andrey Rakhmatullin
1282ddf8f7
Add parameters to most Deferred in scrapy/core. ( #6395 )
2024-06-10 10:27:50 +02:00
Andrey Rakhmatullin
ddc98fe91b
Deprecate scrapy.utils.defer.process_chain_both(). ( #6397 )
2024-06-10 10:16:26 +02:00
Andrey Rakhmatullin
163e7d925e
Merge pull request #6392 from wRAR/pyupgrade
...
Add pyupgrade.
2024-06-07 11:16:46 +04:00
Andrey Rakhmatullin
5850b8f3e6
Merge branch 'master' into pyupgrade
2024-06-07 11:20:31 +05:00
Andrey Rakhmatullin
ed3a7acaf3
Remove the Python version check from scrapy/__init__.py.
2024-06-07 11:19:37 +05:00
Andrey Rakhmatullin
a4778d2bdf
Merge pull request #6143 from wRAR/typing-request-response-cls
...
Improve type hints for copy() and replace() in Request and Response.
2024-06-06 22:58:14 +04:00
Andrey Rakhmatullin
1268b23304
Merge branch 'master' into typing-request-response-cls
2024-06-06 21:57:53 +05:00
Andrey Rakhmatullin
b24ecca4d0
Merge pull request #6391 from wRAR/typing-generics-iterables
...
Add parameters to iterable generics, replace generators with iterables.
2024-06-06 20:54:16 +04:00
Andrey Rakhmatullin
23b1214e90
Add a comment about pyupgrade and scrapy/__init__.py.
2024-06-06 21:44:07 +05:00
Andrey Rakhmatullin
d9d7bd170b
Merge pull request #6394 from Laerte/master
...
Document missing parts of response.json method
2024-06-06 09:55:56 +04:00
Laerte Pereira
144ff6c756
Document missing parts of response.json method
2024-06-05 21:09:10 -03:00
Andrey Rakhmatullin
feb0b8f7dc
Add pyupgrade.
2024-06-05 22:57:18 +05:00
Andrey Rakhmatullin
480a11b68b
Add mssing __future__ imports.
2024-06-05 22:48:16 +05:00
Andrey Rakhmatullin
262c10d85b
Use typing.Coroutine instead of types.CoroutineType.
2024-06-05 22:11:34 +05:00
Andrey Rakhmatullin
de146ad7ce
Bump typing deps.
2024-06-05 22:09:19 +05:00
Andrey Rakhmatullin
2e214210f6
Add parameters to iterable generics, replace generators with iterables.
2024-06-05 21:44:04 +05:00
Suvan Banerjee
3f76853bd2
Handle AttributeError: 'NoneType' in contract parsing ( #6388 )
2024-06-05 06:34:46 +02:00
Andrey Rakhmatullin
e56b425198
Full typing for scrapy/pipelines. ( #6387 )
2024-06-05 06:33:45 +02:00
Adrián Chaves
2b9e32f1ca
Merge pull request #6385 from wRAR/typing-generics-collections
...
Add parameters to various generics.
2024-06-03 13:29:38 +02:00
Andrey Rakhmatullin
492c3bce9d
Don't run callbacks of requests from get_media_requests(). ( #6386 )
2024-06-03 13:28:20 +02:00
Andrey Rakhmatullin
019f23e3b7
Add parameters to some of typing.Callable.
2024-06-02 18:42:01 +05:00
Andrey Rakhmatullin
859a77ee42
Use a TypedDict for the verbose cookie form.
2024-05-31 22:23:26 +05:00
Andrey Rakhmatullin
751c91e614
Add parameters to misc generics.
2024-05-31 21:57:14 +05:00
Andrey Rakhmatullin
70c56faf48
Add parameters to typing.IO.
2024-05-31 21:41:27 +05:00
Andrey Rakhmatullin
4164e63725
Add parameters to typing.Tuple.
2024-05-31 21:23:55 +05:00
Andrey Rakhmatullin
98c755e5fb
Add parameters to typing.List.
2024-05-31 21:20:22 +05:00
Andrey Rakhmatullin
da42e8f124
Add parameters to typing.Dict.
2024-05-31 21:11:50 +05:00
Andrey Rakhmatullin
b950ed77b6
Merge branch 'master' into typing-request-response-cls
2024-05-31 13:07:55 +04:00
Andrey Rakhmatullin
b4293e8f9e
Misc typing improvements. ( #6384 )
2024-05-31 08:50:36 +02:00
Andrey Rakhmatullin
a011fa6f78
Merge pull request #6371 from wRAR/typing-contracts
...
Full typing for scrapy/contracts.
2024-05-30 20:59:50 +04:00
Andrey Rakhmatullin
469e8a23f8
Merge pull request #6381 from 0xdeb/referer-policy-tokens
...
Add support for multiple referer policy tokens.
2024-05-29 17:13:09 +04:00
Fabian Schneebauer
62a028b99d
Add spec link to scrapy/spidermiddlewares/referer.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2024-05-29 13:19:27 +02:00
Fabian Schneebauer
0d58af8697
Add support for multiple referer policy tokens.
2024-05-29 10:59:32 +02:00
Andrey Rakhmatullin
1be8aee09c
Skip uvloop and bpython on 3.13.
2024-05-28 14:56:23 +05:00
Andrey Rakhmatullin
5755e224d5
Help with building lxml on 3.13beta1 for checks too.
2024-05-28 14:50:09 +05:00
Andrey Rakhmatullin
e6e9fd75db
Skip mitmproxy and Pillow on 3.13.
2024-05-28 14:37:05 +05:00
Andrey Rakhmatullin
42347de53f
Install pre-release cffi on 3.13.
2024-05-28 14:37:05 +05:00
Andrey Rakhmatullin
d9b5538e3c
Bump twinecheck deps.
2024-05-28 14:04:58 +05:00
Sanchay Kumar
cadb0dd707
Fix overridable methods in MediaPipeline ( #6368 )
2024-05-28 10:42:58 +02:00
Andrey Rakhmatullin
986d1ee1dd
Move CI from the decommissioned macos-11 to macos-latest. ( #6372 )
2024-05-28 10:37:19 +02:00
Andrey Rakhmatullin
9ba4dd311d
Install typing stubs for boto3 and botocore. ( #6370 )
2024-05-28 10:27:49 +02:00
Andrey Rakhmatullin
f9a9860306
Merge pull request #6374 from Laerte/master
...
docs: Remove top-level reactor imports from CrawlerProces/CrawlerRunner examples
2024-05-27 14:36:34 +04:00
Laerte Pereira
6cd0857850
Move path
2024-05-26 19:57:16 -03:00
Laerte Pereira
2facdd4fb0
Add change reactor test to CrawlerRunner
2024-05-26 19:55:54 -03:00
Laerte Pereira
62c89aaf05
Update docs/topics/practices.rst
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-05-23 07:00:45 -03:00
Laerte Pereira
8ec67ca230
Update docs/topics/practices.rst
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-05-23 07:00:35 -03:00
Laerte Pereira
17e623cf0c
Update docs/topics/practices.rst
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-05-23 07:00:24 -03:00
Laerte Pereira
9d5a0d287b
Retrigger CI
2024-05-22 22:27:07 -03:00
Laerte Pereira
e143dc7952
Update tests-macos.yml
2024-05-22 22:26:31 -03:00
Laerte Pereira
3f66b66e3f
fix: checks
2024-05-22 22:01:55 -03:00
Laerte Pereira
dc6a495fee
Update docs/topics/practices.rst
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-05-22 18:51:02 -03:00
Laerte Pereira
8210fae25a
Update docs/topics/practices.rst
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-05-22 18:50:50 -03:00
Laerte Pereira
e676cd3ce0
docs: Remove top-level reactor imports from CrawlerProces/CrawlerRunner examples
2024-05-22 07:55:53 -03:00
Andrey Rakhmatullin
04bc1e6e2a
Skip zstandard on 3.13.
2024-05-22 13:24:35 +05:00
Andrey Rakhmatullin
b6d3d9076f
Help with building lxml on 3.13beta1.
2024-05-22 13:20:48 +05:00
Andrey Rakhmatullin
534a66e954
Bump 3.13 to beta1.
2024-05-22 13:16:00 +05:00
Andrey Rakhmatullin
85d7458651
Merge branch 'master' into py313
2024-05-22 13:14:59 +05:00
Andrey Rakhmatullin
b99526b740
Full typing for scrapy/contracts.
2024-05-19 15:45:51 +05:00
Andrey Rakhmatullin
631fc65fad
Update expectations of cookies after redirects. ( #6367 )
2024-05-16 16:42:09 +02:00
Adrián Chaves
812fd2368f
Allow user-defined secure cookies ( #6357 )
2024-05-15 11:48:43 +02:00
Adrián Chaves
d2f1e00a6a
Merge 2.11.2 changes ( #6363 )
2024-05-14 18:54:11 +02:00
Andrey Rakhmatullin
d97d32c48e
Merge branch 'master' into typing-request-response-cls
2024-05-13 19:58:17 +05:00
Bagaudin Magomedov
b88f22c6c5
Add SpiderLoggerAdapter, change Spider.logger to return SpiderLoggerAdapter ( #6324 )
2024-05-13 14:33:24 +02:00
Andrey Rakhmatullin
b8e333c8ce
Full typing for scrapy/spiders. ( #6356 )
2024-05-13 12:07:51 +02:00
Andrey Rakhmatullin
4ed5c5ae91
Use ParamSpec for callables. ( #6353 )
2024-05-13 12:01:52 +02:00
Andrey Rakhmatullin
93f0628530
Improve typing for Spider.parse(). ( #6274 )
2024-05-13 11:55:45 +02:00
Sanchay Kumar
c9ef520936
Add Downloader.get_slot_key() without a spider parameter ( #6352 )
2024-05-10 14:26:45 +02:00
Sanchay Kumar
ae7bb849f5
Make certain args of ScrapyAgent and TunnelingAgent required ( #6349 )
2024-05-10 11:43:49 +02:00
Andrey Rakhmatullin
10a843ac1d
Merge pull request #6347 from aisha-partha/master
...
Closes #6342 . Setting METAREFRESH_IGNORE_TAGS to [‘noscript’] by default
2024-05-10 11:47:40 +04:00
Adrián Chaves
fe163d98ea
Fix typo
2024-05-08 20:41:20 +02:00
aisha-partha
2e13a9b8e1
Update METAREFRESH_IGNORE_TAGS default value in documentation
2024-05-08 23:33:13 +05:30
aisha-partha
3590a1f66b
Closes #6342 . Update documentation on METAREFRESH_IGNORE_TAGS default value change
2024-05-08 23:23:17 +05:30
aisha-partha
180bc9bad7
Closes #6342 . Setting METAREFRESH_IGNORE_TAGS to [‘noscript’] by default
2024-05-08 22:06:46 +05:30
Andrey Rakhmatullin
4300a1d240
Merge pull request #6344 from wRAR/fix-twinecheck
...
Update MANIFEST.in.
2024-05-08 08:46:28 +04:00
Andrey Rakhmatullin
6bbfb537f9
Update MANIFEST.in.
2024-05-08 00:39:05 +05:00
Andrey Rakhmatullin
c9bac7a657
Merge pull request #6341 from wRAR/typing-downloader
...
More typing for scrapy/core/downloader
2024-05-07 12:24:25 +04:00
Andrey Rakhmatullin
a828da98c3
Re-run pre-commit.
2024-05-06 22:34:36 +05:00
Andrey Rakhmatullin
045387e07f
More typing for scrapy/core/downloader/handlers/http11.py.
2024-05-06 15:07:38 +05:00
Andrey Rakhmatullin
af3e38ab1f
Full typing for scrapy/core/downloader/handlers/http10.py.
2024-05-06 15:07:16 +05:00
Andrey Rakhmatullin
e8e13ebb78
Full typing for scrapy/core/downloader/handlers/ftp.py.
2024-05-06 15:06:57 +05:00
Andrey Rakhmatullin
ec4d407022
Full typing for smaller download handlers.
2024-05-06 15:06:33 +05:00
Andrey Rakhmatullin
c4d2748ff5
Small typing improvements in scrapy/core/downloader/contextfactory.py.
2024-05-06 15:05:38 +05:00
Andrey Rakhmatullin
563ecbe966
Merge pull request #6333 from wRAR/typing-scrapy
...
Full typing for scrapy/*.py
2024-05-06 14:04:16 +04:00
Andrey Rakhmatullin
d338982580
Merge pull request #6335 from wRAR/typing-self
...
Use the Self type hint in from_crawler/from_settings.
2024-05-06 14:02:10 +04:00
Andrey Rakhmatullin
8a083fb684
Merge pull request #6337 from wRAR/typing-linkextractors
...
Full typing for scrapy/linkextractors.
2024-05-06 14:02:03 +04:00
Andrey Rakhmatullin
07e31b9c93
Merge pull request #6336 from wRAR/typing-cookies
...
Full typing for scrapy/http/cookies.py.
2024-05-06 13:56:34 +04:00
Andrey Rakhmatullin
2cba7896d2
Small fix for _get_slot_key().
2024-05-06 14:31:24 +05:00
Sanchay Kumar
aa025d7eac
Indicate that Selector.type can be json ( #6334 )
2024-05-06 11:29:35 +02:00
Andrey Rakhmatullin
40e4a59604
Fix Python 3.8.
2024-05-05 23:00:16 +05:00
Andrey Rakhmatullin
4b47a5dc32
Skip coverage checks for TYPE_CHECKING blocks.
2024-05-05 22:55:21 +05:00
Andrey Rakhmatullin
c76dfc383f
Full typing for scrapy/linkextractors.
2024-05-05 22:52:15 +05:00
Andrey Rakhmatullin
8a08283580
Full typing for scrapy/http/cookies.py.
2024-05-05 22:32:46 +05:00
Andrey Rakhmatullin
1f394306e1
Use the Self type hint in from_crawler/from_settings.
2024-05-05 22:05:11 +05:00
Andrey Rakhmatullin
bd0d4cee88
Fixes for queuelib.
2024-05-04 16:29:23 +05:00
Andrey Rakhmatullin
203fa9667f
Add queue typing to scrapy/core/scheduler.py.
2024-05-04 14:00:59 +05:00
Andrey Rakhmatullin
5f7fd2a653
Full typing for scrapy/squeues.py.
2024-05-04 14:00:59 +05:00
Andrey Rakhmatullin
b749db92e5
Full typing for scrapy/robotstxt.py.
2024-05-04 14:00:59 +05:00
Andrey Rakhmatullin
ad35ffdb0d
Full typing for scrapy/resolver.py.
2024-05-04 14:00:59 +05:00
Andrey Rakhmatullin
21fa076181
Fix MutableMapping import for Python 3.8.
2024-05-04 14:00:59 +05:00
Andrey Rakhmatullin
0c8e21b8ac
Full typing for scrapy/pqueues.py.
2024-05-04 14:00:33 +05:00
Andrey Rakhmatullin
38020e0b04
Full typing for scrapy/mail.py.
2024-04-29 20:12:30 +05:00
Andrey Rakhmatullin
08a265b6ff
Full typing for scrapy/extension.py.
2024-04-29 19:17:29 +05:00
Andrey Rakhmatullin
fc1a83e7c4
Full typing for scrapy/item.py.
2024-04-29 19:17:29 +05:00
Andrey Rakhmatullin
9eea22fb0c
Full typing for scrapy/cmdline.py.
2024-04-29 19:17:29 +05:00
Andrey Rakhmatullin
d7da298e06
Typing for build_from_*. ( #6326 )
2024-04-29 16:14:59 +02:00
Andrey Rakhmatullin
57acad3c38
Full typing for scrapy/extensions, part 3. ( #6325 )
2024-04-29 09:43:45 +02:00
Andrey Rakhmatullin
a166e97399
Remove the auto-generated copyright years from the docs footer. ( #6322 )
2024-04-29 09:39:22 +02:00
Andrey Rakhmatullin
a5da77d01d
Merge pull request #6221 from jxlil/fix/LxmlLinkExtractor
...
fix: LxmlLinkExtractor unique_list missing key
2024-04-19 19:57:11 +05:00
kokobhara
b1fe97dc6c
Fix test expectations ( #6316 )
2024-04-17 13:14:57 +02:00
TechVest
5f67c01d1d
chore: fix some typos in comments ( #6317 )
...
Signed-off-by: TechVest <techdashen@qq.com>
2024-04-17 10:56:26 +02:00
Adrián Chaves
1d11ea3a54
Update practices.rst
2024-04-11 12:19:32 +02:00
Víctor Ruiz
48c5a8c98f
Fix WrappedRequest.get_header raising TypeError if default is None ( #6310 )
2024-04-08 11:47:53 +02:00
Andrey Rakhmatullin
5d31e89262
Merge pull request #6298 from lorenzoverardo/bug-6292/robots.txt-non-UTF-8
...
Handle robots.txt files not UTF-8 encoded
2024-04-05 13:49:10 +05:00
Lorenzo Verardo
7b37dcd80d
Handle robots.txt files not UTF-8 encoded
2024-04-04 12:22:50 +02:00
igeni
f7bf3f726e
modified string's concat to f-strings ( #6296 )
2024-04-01 15:37:23 +02:00
Andrey Rakhmatullin
02b97f98e7
Merge pull request #6242 from cankupeli/master
...
implemented tests for branch coverage for function printSummary
2024-03-14 18:20:14 +05:00
Andrey Rakhmatullin
8d917c0b55
Run black.
2024-03-14 17:44:57 +05:00
Andrey Rakhmatullin
5bf0e1d1db
Merge branch 'master' into master
2024-03-14 17:38:30 +05:00
Andrey Rakhmatullin
7255dfd41f
Merge pull request #6231 from elramen/check_command_tests
...
Added tests for check command
2024-03-14 15:28:19 +05:00
Lucas Belo
4460d3ed96
Remove tests/requirements.txt and refactor extra deps ( #6272 )
...
Co-authored-by: lucasbelo777 <lucas.belo@cialdnb.com>
2024-03-13 07:22:48 +01:00
Andrey Rakhmatullin
95a70d3fa0
Merge pull request #6290 from Gallaecio/fix-skips
...
Fix WindowsRunSpiderCommandTest skip outside Windows for older Twisted
2024-03-12 14:17:10 +05:00
Adrián Chaves
d7581c6b41
Allow disabling the AutoThrottle extension for a given slot ( #6246 )
2024-03-12 09:44:29 +01:00
Adrián Chaves
e72de11f55
Add super
2024-03-12 09:29:10 +01:00
Adrián Chaves
188d9a8bb3
Remove unnecessary comment
2024-03-11 23:28:57 +01:00
Adrián Chaves
ab5ea32ffd
Fix WindowsRunSpiderCommandTest skip outside Windows for older Twisted.
2024-03-11 23:26:19 +01:00
Andrey Rakhmatullin
642af40704
Full typing for scrapy/extensions, part 2. ( #6279 )
2024-03-11 10:09:09 +01:00
pengqiseven
6e84648c07
Fix some comments ( #6285 )
...
Signed-off-by: pengqiseven <i@sohu.com>
Co-authored-by: pengqiseven <i@sohu.com>
2024-03-11 10:03:06 +01:00
Andrey Rakhmatullin
421e08dd4a
Full typing for scrapy/extensions, part 1. ( #6276 )
2024-03-08 06:59:56 +01:00
Andrey Rakhmatullin
8985a04bd1
Full typing for scrapy/exporters.py. ( #6275 )
2024-03-08 06:57:03 +01:00
Andrey Rakhmatullin
861646fbb3
Merge pull request #6269 from Laerte/master
...
Add brotlicffi support
2024-03-06 19:04:42 +05:00
Andrey Rakhmatullin
6ecc9e0a34
Add typing for scrapy/commands ( #6268 )
2024-03-06 13:21:08 +01:00
Laerte Pereira
99f7165c63
Update scrapy/utils/_compression.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2024-03-06 09:02:01 -03:00
Laerte Pereira
7be919138d
Update scrapy/utils/_compression.py
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2024-03-06 05:49:31 -03:00
Laerte Pereira
7f1fbdba3c
Check brotlicffi for ACCEPTED_ENCODINGS
2024-03-05 22:11:11 -03:00
Laerte Pereira
532cd2eabd
Use brotlicffi for PyPy
2024-03-05 21:30:20 -03:00
Laerte Pereira
16864ea602
Remove PyPy condition
2024-03-05 21:18:24 -03:00
Laerte Pereira
a52429ae08
Update disclaimer
2024-03-05 21:12:25 -03:00
Laerte Pereira
3421823dce
Nested try-except block
2024-03-05 20:26:23 -03:00
Laerte Pereira
cab1016bb6
Add brotlicffi support
2024-03-05 20:24:17 -03:00
Andrey Rakhmatullin
6b75d8f3b3
Bump pytest-mypy-testing.
2024-03-05 22:23:48 +05:00
Adrián Chaves
bf149356fc
Bandit: allow-list lxml usages ( #6265 )
2024-03-01 16:02:03 +01:00
Adrián Chaves
aa1bf69079
Mark hashlib usages as not intended for security ( #6264 )
2024-03-01 12:48:00 +01:00
Yuri H. Galvao
4cd94aa668
Restore brotlipy support ( #6261 )
2024-03-01 11:07:38 +01:00
Andrey Rakhmatullin
ee51958e19
Merge pull request #6259 from Laerte/master
...
fix: Proxy tests don't use custom certificate authority
2024-02-29 17:12:01 +05:00
Andrey Rakhmatullin
b80128fc7c
Merge pull request #6260 from Gallaecio/bandit
...
bandit: allow-list false positives
2024-02-29 17:03:23 +05:00
Andrey Rakhmatullin
1311e7db05
Regenerate the expired mitmproxy-ca.pem.
2024-02-29 16:31:06 +05:00
Andrey Rakhmatullin
032e6a091a
Reformat the new changes with new black.
2024-02-29 16:24:52 +05:00
Adrián Chaves
31cbbb5758
bandit: ignore md5 usage for download slot names
2024-02-29 11:31:39 +01:00
Adrián Chaves
2bfd9a2257
bandit: allow-list false positives
2024-02-29 11:11:42 +01:00
Laerte Pereira
2169810414
fix: Proxy tests don't use custom certificate authority
2024-02-29 06:41:14 -03:00
Andrey Rakhmatullin
706eb8d427
Fix a merge error.
2024-02-29 14:33:55 +05:00
Andrey Rakhmatullin
b6587575a1
Merge branch 'master' into typing-request-response-cls
2024-02-29 12:43:30 +05:00
Andrey Rakhmatullin
198f5cf0d4
Merge pull request #6257 from Laerte/master
...
Fix and re-enable `unnecessary-comprehension` and `use-dict-literal` pylint tags
2024-02-29 12:36:34 +05:00
Laerte Pereira
26a16f2c43
Fix tests
2024-02-28 16:36:19 -03:00
Laerte Pereira
63acd07209
Fix and re-enable unnecessary-comprehension and use-dict-literal pylint tags
2024-02-28 16:14:08 -03:00
Andrey Rakhmatullin
532cc8a517
Merge pull request #6253 from wRAR/update-tools
...
Update tool versions, fix some of the pylint problems
2024-02-28 16:17:42 +05:00
Andrey Rakhmatullin
4f9dd998dc
Bump pylint, cleanup the ignored tags.
2024-02-28 14:31:21 +05:00
Andrey Rakhmatullin
d2c05d9d96
Bump mypy and type stubs.
2024-02-28 14:31:21 +05:00
Andrey Rakhmatullin
68104b9f48
Update .bandit.yml, add problem names.
2024-02-28 14:31:16 +05:00
Andrey Rakhmatullin
6e5918345b
Bump bandit, flake8 and isort.
2024-02-28 14:30:38 +05:00
Andrey Rakhmatullin
282767f23b
Bump black.
2024-02-28 14:30:38 +05:00
Andrey Rakhmatullin
415c47479f
Merge pull request #6251 from Laerte/master
...
Use defusedxml.xmlrpc
2024-02-28 14:29:20 +05:00
Laerte Pereira
008ebb65fc
Change immport style
2024-02-27 18:10:28 -03:00
Laerte Pereira
7f945ad6db
Import defusedxml.xmlrpc using alias
2024-02-27 17:39:29 -03:00
Laerte Pereira
d87f949526
Use defusedxml.xmlrpc
2024-02-27 17:08:13 -03:00
Adrián Chaves
2d46b4acf5
Complete coverage for the AutoThrottle extension ( #6245 )
2024-02-27 09:28:02 +01:00
Jon
b0ef9a89a1
Remove usage of deprecated mktemp ( #5285 )
2024-02-26 19:53:06 +01:00
vishesh10
e208f82076
Add support for multiple-compressed responses ( #6063 )
2024-02-22 12:16:24 +01:00
Andrey Rakhmatullin
ebd7e199f0
Merge pull request #6235 from elramen/http_request_tests
...
Added tests for form.py
2024-02-22 12:17:11 +05:00
Andrey Rakhmatullin
edd7ba1c06
Merge pull request #6236 from elramen/json_request_tests_main
...
Improve json_request.py coverage
2024-02-22 12:16:47 +05:00
Can Kupeli
c513e7d6e5
implemented tests for branch coverage for function printSummary
2024-02-21 23:52:35 +01:00
noon
877398a3de
refactor #3 Remove inner class in form test
2024-02-21 21:13:57 +01:00
noon
b7a7ae7dbb
refactor #22 Change comment and warning catching
2024-02-21 21:04:45 +01:00
Andrey Rakhmatullin
f798118ac2
Merge pull request #6232 from elramen/linkextractor_tests
...
Added tests for LxmlLinkExtractor
2024-02-21 23:03:20 +05:00
Elias Ram
f19045403a
test #8 made tests cleaner
2024-02-21 16:03:51 +01:00
Adrián Chaves
6fc7827042
Do not close the underlying file from compression plugins ( #6239 )
2024-02-21 14:27:42 +01:00
noon
bc036542a8
refactor #3 Moved tests to FormRequestTest
2024-02-21 02:35:45 +01:00
noon
12b4417c56
test #22 Improve json_request.py coverage
2024-02-21 02:30:50 +01:00
noon
e2a0c85f11
doc #3 Clarified test comments
2024-02-21 02:21:24 +01:00
noon
e27d320c3c
test #3 Increased branch coverage for form.py
2024-02-20 23:58:39 +01:00
Elias Ram
e8e6d28479
test #8 added tests for LxmlLinkExtractor
2024-02-20 20:41:18 +01:00
Elias Ram
f096f17fa4
test #6 added tests for check command
2024-02-20 20:32:02 +01:00
Laerte Pereira
ee1189512f
Replace urlparse with urlparse_cached where possible ( #6229 )
2024-02-20 12:47:29 +01:00
Mikhail Korobov
c4e4b9b56e
Add a SECURITY.md file ( #6051 )
2024-02-20 10:50:16 +01:00
Andrey Rakhmatullin
ba8993ec09
Merge pull request #6223 from jxlil/docs/remove_external_docs
...
Fix: Remove docs for other projects from the Scrapy docs
2024-02-16 23:59:10 +04:00
Adrián Chaves
5e51417a48
Add tests, fix canonicalize passing
2024-02-16 20:10:52 +01:00
Jalil SA
36f72877ba
update: docs/topics/selectors.rst
2024-02-16 10:39:16 -06:00
Kevin Lloyd Bernal
9bb973dc54
Refactor LogStats extension to log IPM and RPM to stats on spider_close ( #4111 )
2024-02-16 12:25:38 +01:00
Jalil SA
3e7b704c08
update: docs/topics/selectors.rst
2024-02-15 16:59:32 -06:00
Jalil SA
660e3b1953
update: docs/topics/items.rst
2024-02-15 16:59:31 -06:00
Mikhail Korobov
c5fdba9b31
Merge pull request #6222 from Gallaecio/2.11-port
...
2.11 port
2024-02-15 19:26:40 +05:00
Adrián Chaves
6bd45bb6d9
Merge remote-tracking branch 'scrapy/2.11' into 2.11-port
2024-02-15 06:39:50 +01:00
Jalil SA
bccb4cf18b
fix: LxmlLinkExtractor unique_list missing key
2024-02-14 12:29:29 -06:00
Adrián Chaves
2f1d345e74
Solve test issues
2024-02-14 18:59:01 +01:00
Adrián Chaves
502addc717
Bump version: 2.11.0 → 2.11.1
2024-02-14 18:17:48 +01:00
Adrián Chaves
6b88b3346c
Set the release date of versions 2.11.1 and 1.8.4
2024-02-14 18:16:40 +01:00
Adrián Chaves
479619b340
Merge branch '2.11-redos' into 2.11
2024-02-14 17:18:26 +01:00
Adrián Chaves
809bfac489
Merge branch '2.11-compression-bomb' into 2.11
2024-02-14 17:16:25 +01:00
Adrián Chaves
5bcb8fd501
Merge branch '2.11-authorization' into 2.11
2024-02-14 17:14:29 +01:00
Andrey Rakhmatullin
a55e933c11
Release notes for 2.11.1 ( #6150 )
2024-02-14 17:08:40 +01:00
Andy
1c9d308acc
Cover the deprecation and removal of response_httprepr in the release notes ( #6216 )
2024-02-05 12:52:01 +01:00
Adrián Chaves
5e5a92026e
Remove slow leftovers
2024-02-02 14:06:45 +01:00
Adrián Chaves
810aaa637d
Undo an unintended change
2024-02-02 14:04:28 +01:00
Adrián Chaves
c5dad41190
Speed up tests, remove comments without regexps
2024-02-02 14:03:16 +01:00
Andrey Rakhmatullin
6f73dc0e67
Merge pull request #6213 from Laerte/master
...
Cleanup deprecated fingerprint code in scrapy.utils.request
2024-01-31 21:00:48 +04:00
Laerte Pereira
53ccf0016d
Remove empty statement
2024-01-31 13:18:10 -03:00
Laerte Pereira
7001193c80
Simplify the logic
2024-01-31 12:53:08 -03:00
Laerte Pereira
24634f1bb2
Attend PR comments
2024-01-31 12:29:43 -03:00
Laerte Pereira
bacaf0db7a
Update documentation
2024-01-31 10:14:48 -03:00
Laerte Pereira
019443dd57
Remove settings from default implementation test
2024-01-31 10:08:07 -03:00
Laerte Pereira
2487e3cc03
Cleanup deprecated fingerprint code in scrapy.utils.request
2024-01-31 10:05:50 -03:00
Andrey Rakhmatullin
4229048255
Merge pull request #6208 from kevintomsgithub/add-faq
...
Add FAQ on making a blank request
2024-01-18 21:56:12 +04:00
Kevin Toms
9074c16497
make suggestion
2024-01-18 09:36:25 -05:00
Kevin Toms
46f94ec9cb
Fix test
...
Wrap the yield line in a function to prevent throwing error when the code snippet is executed
2024-01-17 15:49:51 -05:00
Kevin Toms
88285e75b6
Add FAQ on making a blank request
2024-01-17 10:05:22 -05:00
Andrey Rakhmatullin
09a7efef7c
Remove a defer.returnValue call.
2024-01-15 18:19:29 +04:00
Rotzbua
d5233bb57f
chore(docs): update `sphinx` dependencies ( #6200 )
2024-01-15 14:11:33 +01:00
Adrián Chaves
e8dadb9592
scrapy parse: fix the signature of callbacks from the CLI ( #6182 )
2024-01-15 13:37:03 +01:00
Adrián Chaves
fa0c598096
Add component getters to Crawler ( #6181 )
2024-01-15 13:14:02 +01:00
Mikhail Korobov
8ad17f7476
Merge pull request #6199 from Rotzbua/fix_flake8
...
fix(flake8): lint errors
2024-01-12 22:52:22 +05:00
Mikhail Korobov
b7cf30a48e
Merge pull request #6205 from wRAR/fix-pypy-tests
...
Remove a defer.returnValue call.
2024-01-12 22:50:41 +05:00
Andrey Rakhmatullin
c2baf4d0da
Remove a defer.returnValue call.
2024-01-12 18:30:41 +04:00
Andrey Rakhmatullin
becff65ccb
Merge pull request #6201 from wRAR/more-mitmproxy
...
Fix and re-enable newer mitmproxy usage in tests.
2024-01-12 14:26:39 +04:00
Mikhail Korobov
32fda2dc53
Merge pull request #6196 from Rotzbua/fix_typo
...
fix(typo): correct `successfully`
2024-01-12 00:36:16 +05:00
Mikhail Korobov
7eeca55c70
Merge pull request #6197 from Rotzbua/refactor_yield
...
refactor(yield): use `yield from` syntax
2024-01-12 00:35:56 +05:00
Mikhail Korobov
825137399d
Merge pull request #6198 from Rotzbua/refactor_exception
...
refactor(): use `OSError` exception
2024-01-12 00:32:51 +05:00
Andrey Rakhmatullin
68fccb1d58
Fix and re-enable newer mitmproxy usage in tests.
2024-01-06 01:35:56 +04:00
Rotzbua
745b8412f6
fix(flake8): lint errors
...
E226 missing whitespace around arithmetic operator
E201 whitespace after '{'
2024-01-05 14:54:00 +01:00
Rotzbua
42c481cb4a
refactor(): use `OSError` exception
...
https://docs.astral.sh/ruff/rules/os-error-alias/
2024-01-05 12:36:36 +01:00
Rotzbua
0d445a3224
refactor(yield): use `yield from` syntax
2024-01-05 12:30:10 +01:00
Rotzbua
c7b2b097b1
fix(typo): correct `successfully`
2024-01-05 10:50:45 +01:00
Adrián Chaves
6127f7d278
Update quotes.toscrape.com page copies ( #6190 )
2024-01-01 22:58:34 +04:00
Chan Sau Yee
badc7c5be9
Update black reference in docs ( #6192 )
2024-01-01 22:58:21 +04:00
Chan Sau Yee
40e623b276
Add type hints ( #6191 )
2023-12-29 12:33:37 +01:00
Chan Sau Yee
1902284942
Update black reference in docs ( #6192 )
2023-12-29 12:32:51 +01:00
Adrián Chaves
34e01a8a93
Update quotes.toscrape.com page copies ( #6190 )
2023-12-28 12:25:01 +01:00
Andrey Rakhmatullin
2534a28ef0
Bump mypy.
2023-12-25 15:03:08 +04:00
Adrián Chaves
0e78acb657
MediaPipeline: log media_to_download errors before stripping them ( #5068 )
2023-12-21 21:01:07 +01:00
Jalil SA
d25cfe5315
Add JsonResponse ( #6174 )
2023-12-21 10:36:21 +01:00
Adrián Chaves
48a9a58ff2
Link to Zyte’s export guides
2023-12-20 21:43:21 +04:00
Adrián Chaves
369712ee50
SPM → Zyte API ( #6163 )
2023-12-20 21:43:13 +04:00
Adrián Chaves
b095dd218f
Extend Request.meta documentation ( #5565 )
2023-12-20 21:43:03 +04:00
Mikhail Korobov
b498f1376d
Merge pull request #6183 from Gallaecio/zyte-guides
...
Link to Zyte’s export guides
2023-12-20 22:22:22 +05:00
Andrey Rakhmatullin
f56b5fc39e
Bump typing deps.
2023-12-20 16:19:11 +04:00
Andrey Rakhmatullin
a72394a388
Add tests for replace() with kwargs.
2023-12-20 16:14:53 +04:00
Andrey Rakhmatullin
1fab844f7d
Pin the Python version for typing-tests.
2023-12-20 15:57:51 +04:00
Adrián Chaves
1864f48e9e
Link to Zyte’s export guides
2023-12-20 12:47:34 +01:00
Swati Anshu
c67f730695
create_instance → build_from_crawler, build_from_settings ( #6169 )
2023-12-18 11:51:02 +01:00
Adrián Chaves
27781a85e7
Fix bad closing tags in XMLFeedSpider tests
2023-12-15 13:52:12 +01:00
Adrián Chaves
c7c7a488b9
Fix typing issues
2023-12-15 13:18:23 +01:00
Adrián Chaves
bc138ef8e9
Minor release notes fix
2023-12-15 12:24:04 +01:00
Adrián Chaves
ce9d290eff
Remove the lxml version check for huge_tree on xmliter_lxml
...
iterparse supports the option since lxml 2.2.1, it was the HTML parser that only got it in 4.2
2023-12-15 12:23:26 +01:00
Adrián Chaves
a49c8762dd
Avoid calling iterparse twice
2023-12-15 12:14:53 +01:00
Adrián Chaves
cd6846b763
Merge remote-tracking branch 'scrapy/2.11' into 2.11-redos
2023-12-15 11:52:35 +01:00
Adrián Chaves
b0dbd0e9af
Minor naming changes
2023-12-15 11:49:22 +01:00
Adrián Chaves
150d96764b
Deprecate xmliter in favor of xmliter_lxml
2023-12-15 11:42:55 +01:00
Adrián Chaves
2538c0e862
Restore the implementation of xmliter
2023-12-15 10:23:24 +01:00
Adrián Chaves
9655b0b8eb
Mark slow tests, with their own tox env and CI job
2023-12-15 10:19:47 +01:00
Adrián Chaves
d50f436a73
Enable huge_tree for xmliter_lxml
2023-12-15 10:08:45 +01:00
Adrián Chaves
4f72b49f97
Fix namespaces nodename support for xmliter_lxml
2023-12-15 10:06:13 +01:00
Adrián Chaves
12b10a7a64
Cover scrapy.downloadermiddlewares.decompression in the release notes
2023-12-13 13:35:05 +01:00
Laerte Pereira
b9c4ee26d7
Remove deprecated scrapy.downloadermiddlewares.decompression
2023-12-13 13:28:30 +01:00
Adrián Chaves
1533b69032
Test and address ReDoS attack vectors for open_in_browser
2023-12-13 12:01:35 +01:00
Adrián Chaves
bb74badd1b
spider → mw
2023-12-11 17:39:55 +01:00
Adrián Chaves
c66b517706
Add Python 3.13 alpha to CI
2023-12-01 10:36:27 +01:00
Adrián Chaves
70ba3a0868
SPM → Zyte API ( #6163 )
2023-11-30 11:01:22 +01:00
Adrián Chaves
731f749556
Extend Request.meta documentation ( #5565 )
2023-11-30 10:54:09 +01:00
Adrián Chaves
40b3efbbee
Remove open_in_browser from the 1.8.4 release notes
2023-11-29 12:47:04 +01:00
Adrián Chaves
eb8b2c5197
Mention open_in_browser in the release notes
2023-11-29 12:13:04 +01:00
Adrián Chaves
c947f51077
Set an arbitrary upper limit on ReDoS-vulnerable regexps
2023-11-29 11:54:08 +01:00
Adrián Chaves
a113208a06
Fix BytesIO non-emptiness check
2023-11-24 11:35:15 +01:00
Adrián Chaves
8a73c6c90c
Fix HttpCompressionMiddleware backward compatibility
2023-11-24 10:25:01 +01:00
Adrián Chaves
62398e424c
CHUNK_SIZE: 8 KiB → 32 KiB
2023-11-24 10:20:14 +01:00
Adrián Chaves
6c278e1862
List[bytes] → BytesIO
2023-11-24 10:15:38 +01:00
Adrián Chaves
5f2827efe7
Make HttpCompressionMiddleware changes backward-comaptible
2023-11-24 10:15:38 +01:00
Andrey Rakhmatullin
fa690fbe03
Merge pull request #6154 from Laerte/master
...
Remove test_download_gzip_response test
2023-11-23 20:56:50 +04:00
Laerte Pereira
09ce0ef526
Remove test_download_gzip_response test
2023-11-23 10:50:46 -03:00
Adrián Chaves
8e25f8c157
Fix bad message
2023-11-23 14:12:59 +01:00
Adrián Chaves
cf80e5670e
Solve linting and typing issues
2023-11-23 12:07:15 +01:00
Adrián Chaves
b53ed52a22
Update the release notes
2023-11-23 11:36:45 +01:00
Adrián Chaves
03d9866518
Also use DOWNLOAD_WARNSIZE for decompressions
2023-11-23 10:26:47 +01:00
Adrián Chaves
1087bb7b2e
Update the docs
2023-11-23 09:11:14 +01:00
Adrián Chaves
e0b66c021a
Mind Spider.download_maxsize and Request.meta['download_maxsize']
2023-11-22 19:03:24 +01:00
Adrián Chaves
3fda2fe103
Protect against gzip bomb sitemaps
2023-11-22 18:34:37 +01:00
Adrián Chaves
9cc8703877
Protect against zstandard bombs
2023-11-22 17:53:00 +01:00
Adrián Chaves
fba167c5e1
Protect against brotli bombs
2023-11-22 17:32:09 +01:00
Adrián Chaves
0c4a98f8e0
Protect against deflate bombs
2023-11-22 17:12:43 +01:00
Adrián Chaves
0bf29a7b1b
Update test expectations
2023-11-22 16:10:50 +01:00
Adrián Chaves
6969041c5f
Protect against gzip bombs
2023-11-22 15:52:00 +01:00
Adrián Chaves
1c4e93293a
Merge remote-tracking branch 'scrapy/2.11' into 2.11-authorization
2023-11-17 15:42:08 +01:00
Kiran
49b284ab85
Updated README.rst ( #6144 )
2023-11-16 19:17:52 +04:00
Jessica Allman-LaPorte
150f9d6d88
Make shell switching more clear in the tutorial ( #6128 )
2023-11-16 19:17:29 +04:00
Adrián Chaves
1045856a50
Merge pull request #6112 from wRAR/test-shutdown-forced
...
Make shutdown tests more robust.
2023-11-16 19:16:52 +04:00
Andrey Rakhmatullin
5e4fb0bc5f
Re-enable uvloop tests on 3.12 ( #6098 )
2023-11-16 19:16:31 +04:00
Andrey Rakhmatullin
538192916f
Merge pull request #6064 from wRAR/signals-proper
...
Refactor installing signals.
2023-11-16 19:15:30 +04:00
Andrey Rakhmatullin
59cfdeaa5c
Merge pull request #6083 from wRAR/py3.12-release
...
Adapt to the Python 3.12 final release
2023-11-16 19:14:47 +04:00
Andrey Rakhmatullin
ffbf943e9d
Merge pull request #6077 from 11-aryan/11-aryan
2023-11-16 19:13:02 +04:00
Andrey Rakhmatullin
75e99c75b3
Improve the docs about Crawler attributes and settings initialization.
2023-11-16 12:36:57 +04:00
Andrey Rakhmatullin
42b3a3a23b
Merge pull request #6147 from wRAR/crawler-init-docs
...
Improve the docs about Crawler attributes and settings initialization.
2023-11-16 12:35:43 +04:00
Andrey Rakhmatullin
603aa4924a
Improve the docs about Crawler attributes and settings initialization.
2023-11-15 19:51:04 +04:00
Adrián Chaves
080fecd890
Drop the Authorization header on cross-domain redirect
2023-11-15 15:39:30 +01:00
Andrey Rakhmatullin
5fccf370b8
Update the RTD URL for coverage
2023-11-15 15:38:13 +01:00
Andrey Rakhmatullin
ebdea4037a
Update another output line.
2023-11-15 12:31:31 +04:00
Andrey Rakhmatullin
db5a73f7bb
Update the expected mypy output to match the old Python one.
2023-11-15 12:02:39 +04:00
Kiran
492584ec07
Updated README.rst ( #6144 )
2023-11-13 20:13:10 +01:00
Andrey Rakhmatullin
8776b4a6fb
Fix env deps for typing-tests.
2023-11-12 20:52:29 +04:00
Andrey Rakhmatullin
204d6e180a
Enable typing-tests in CI.
2023-11-12 20:47:52 +04:00
Andrey Rakhmatullin
5d55e4f56b
Add mypy tests.
2023-11-12 20:15:06 +04:00
Andrey Rakhmatullin
a6cee787dd
Improve type hints for copy() and replace() in Request and Response.
2023-11-11 20:00:12 +04:00
Andrey Rakhmatullin
b4acf5c827
Fix and remove most of the entries from the mypy ignore list ( #6137 )
2023-11-07 09:34:35 +01:00
Andrey Rakhmatullin
c31e09d709
Merge pull request #6134 from wRAR/obsolete-setter
...
Remove obsolete setters for body and url on Request and Response.
2023-11-06 18:24:13 +04:00
Andrey Rakhmatullin
7c27c22a98
Full typing for scrapy/downloadermiddlewares ( #6129 )
2023-11-06 08:52:14 +01:00
cakemd
eafe828484
scrapy.utils.data_path type hint change ( #6133 )
2023-11-06 08:37:18 +01:00
Andrey Rakhmatullin
2ac3ef73e6
Remove obsolete setters for body and url on Request and Response.
2023-11-03 20:12:18 +04:00
Jessica Allman-LaPorte
6587556af9
Make shell switching more clear in the tutorial ( #6128 )
2023-11-03 10:02:18 +01:00
Andrey Rakhmatullin
f3561807a6
Merge pull request #6130 from wRAR/typing-spider-mw
...
Full typing for scrapy/spidermiddlewares.
2023-11-03 12:31:19 +04:00
Jeesang Kim
dda6feb935
Improve assert readability ( #6132 )
2023-11-03 09:24:25 +01:00
Andrey Rakhmatullin
e54dc59899
Full typing for scrapy/spidermiddlewares.
2023-11-02 23:40:14 +04:00
Andrey Rakhmatullin
593bfd895a
Merge pull request #6127 from wRAR/typing-response
...
Full typing for Request and Response
2023-11-02 17:46:42 +04:00
Andrey Rakhmatullin
24f21e96b9
Full typing for scrapy/http/response/text.py.
2023-11-01 01:53:25 +04:00
Andrey Rakhmatullin
01d9d28324
Full typing for scrapy/http/response/__init__.py.
2023-11-01 01:10:32 +04:00
Andrey Rakhmatullin
4cb2fc2c3b
Update typing package versions.
2023-10-31 22:55:39 +04:00
Andrey Rakhmatullin
732557e698
Full typing for scrapy/http/request.
2023-10-31 22:48:22 +04:00
nihilisticneuralnet
04024f1e79
[Solved] JOBDIR= None for when Scheduler initializes disk queue even if JOBDIR is empty string ( #6124 )
...
Co-authored-by: John Doe <johndoe@email.com>
2023-10-31 17:37:26 +04:00
Andrey Rakhmatullin
7e6da37170
Merge pull request #6125 from Andy53/additional_ignored_extensions
...
added_extensions
2023-10-31 12:33:55 +04:00
andy53
8dff9633d0
added_extensions
2023-10-30 21:40:26 -06:00
Chenwei Niu
1f797d0fdb
Removed some deprecated functions and functionalities ( #6116 )
2023-10-30 09:59:11 +01:00
Adrián Chaves
1d81585612
Merge pull request #6112 from wRAR/test-shutdown-forced
...
Make shutdown tests more robust.
2023-10-30 09:35:29 +01:00
Andrey Rakhmatullin
6b0c18e921
Improve signal sending in test_shutdown_forced.
2023-10-19 23:13:47 +04:00
Andrey Rakhmatullin
cc9c415bf3
Disable ipython for InteractiveShellTest.
2023-10-18 19:30:57 +04:00
Adrián Chaves
9b06f6b316
Merge pull request #6113 from Laerte/master
...
Remove some deprecated code
2023-10-18 12:52:27 +02:00
Laerte Pereira
38dbd43993
Remove tests not necessary anymore
2023-10-18 06:29:47 -03:00
Andrey Rakhmatullin
39ee8d1ee2
Deprecate ReppyRobotParser ( #6099 )
2023-10-18 09:10:21 +02:00
Laerte Pereira
0956b76465
Remove support for dupefilters without a fingerprinter
2023-10-17 22:44:15 -03:00
Laerte Pereira
644ab3af48
Remove support for feed storage backends without feed_options
2023-10-17 22:39:09 -03:00
Laerte Pereira
3db438127c
Remove support for HttpCompressionMiddleware subclasses without stats
2023-10-17 21:38:38 -03:00
Laerte Pereira
a2b9351f04
Remove support for using HttpAuthMiddleware without http_auth_domain
2023-10-17 20:20:38 -03:00
Laerte Pereira
4ad727f0b5
Remove _check_signature
2023-10-17 19:47:01 -03:00
Laerte Pereira
2de95f1fc0
Remove leftover from _make_compatible removal
2023-10-17 19:44:12 -03:00
Laerte Pereira
ad4e8b64d4
fix test_spider_manager_verify_interface test
2023-10-17 18:58:27 -03:00
Laerte Pereira
aa0a425826
Remove deprecated code moved to itemloaders
2023-10-17 18:20:12 -03:00
Laerte Pereira
85c57778b5
Remove deprecated JSONRequest
2023-10-17 18:15:20 -03:00
Laerte Pereira
83f500a352
Remove scrapy.pipelines.media.MediaPipeline._make_compatible
2023-10-17 18:14:08 -03:00
Laerte Pereira
bdb4abcc7a
Remove the deprecation warning from CrawlerRunner._get_spider_loader()
2023-10-17 17:52:18 -03:00
Laerte Pereira
7a5cefbcfa
Remove deprecated scrapy.downloadermiddlewares.decompression
2023-10-17 17:49:22 -03:00
Andrey Rakhmatullin
2cb1e10c76
Make shutdown tests more robust.
2023-10-17 23:56:54 +04:00
Andrey Rakhmatullin
991121fa91
Re-enable uvloop tests on 3.12 ( #6098 )
2023-10-17 19:24:44 +02:00
Andrey Rakhmatullin
5807970a22
Add typing hints to CaselessDict and Headers. ( #6097 )
2023-10-17 19:07:13 +02:00
Sandesh Pyakurel
064256b059
Typo fixed in news.rst file ( #6094 )
2023-10-17 18:39:39 +02:00
Andrey Rakhmatullin
aa95ada42c
Merge pull request #6064 from wRAR/signals-proper
...
Refactor installing signals.
2023-10-17 17:08:23 +04:00
Andrey Rakhmatullin
029a56384d
Increase the timeout.
2023-10-09 00:16:41 +04:00
Andrey Rakhmatullin
9910ccf3ae
Merge remote-tracking branch 'origin/master' into signals-proper
2023-10-08 23:02:11 +04:00
Andrey Rakhmatullin
2f436c05e0
Use SIGBREAK in Windows tests.
2023-10-08 22:55:05 +04:00
Andrey Rakhmatullin
c65567988d
Change supported PyPy versions to 3.9 and 3.10. ( #6087 )
...
* Change support PyPy versions to 3.9 and 3.10.
* Update the RTD URL for coverage.
* Move pypy3-pinned back to pypy3.8.
2023-10-06 11:27:02 +02:00
Andrey Rakhmatullin
5b0b00212e
Merge pull request #6083 from wRAR/py3.12-release
...
Adapt to the Python 3.12 final release
2023-10-03 20:20:12 +04:00
Andrey Rakhmatullin
a338873e3a
Re-enable bpython on Python 3.12.
2023-10-03 16:50:52 +04:00
Andrey Rakhmatullin
fb4debda04
Use path_to_file_uri to fix the test on Windows.
2023-10-03 16:47:03 +04:00
Klaus Rettinghaus
9ae8d97d81
Update GitHub Actions checkout action to version 4 ( #6084 )
2023-10-03 13:04:18 +02:00
Andrey Rakhmatullin
60d5f391c4
Use the 3.12 release, enable it for all OSes.
2023-10-02 21:35:45 +04:00
Andrey Rakhmatullin
1ed9ed4f92
Require pyftpdlib that supports Python 3.12.
2023-10-02 21:33:02 +04:00
Andrey Rakhmatullin
a96989c6f3
Merge pull request #6077 from 11-aryan/11-aryan
2023-10-02 20:40:25 +04:00
Andrey Rakhmatullin
01f164d331
Merge pull request #6078 from AndrewADev/ci-concurrency-groups
2023-10-02 20:38:49 +04:00
Adrián Chaves
42adbb2104
Update docs/topics/request-response.rst
2023-10-02 14:43:30 +02:00
kokobhara
8dc72dfc4d
Cover PythonItemExporter backwaird-incompatible changes in 2.11 ( #6081 )
2023-10-02 14:48:44 +04:00
kokobhara
ef1ed4fab7
Cover PythonItemExporter backwaird-incompatible changes in 2.11 ( #6081 )
2023-10-02 12:14:05 +02:00
Aryan
e146c3a2fc
removed the entire example for dont_merge_cookies
2023-10-02 15:36:29 +05:30
Andrew Armbruster
884840e3a3
Use concurrency groups to limit duplicate jobs
...
Leverage concurrency groups along with cancel-in-progress to favor running the most recent job.
Concurrency groups are on a per workflow, per branch/tag basis. So, pushing newer updates to a branch, e.g. as part of a PR, should cancel any in progress runs of workflows that have been retriggered.
See:
- https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
- https://docs.github.com/en/enterprise-cloud@latest/actions/learn-github-actions/contexts#github-context
2023-10-01 12:12:24 +02:00
Aryan
fe5ef0a80a
Fixed the dont_merge_cookies example in docs
2023-10-01 11:47:51 +05:30
Andrey Rakhmatullin
0e64dec5dd
Merge pull request #6074 from mikkeschiren/master
...
Add more common MS Office file extensions to exclude for documents
2023-09-29 16:28:19 +04:00
Mikael Schirén
da6e75d00a
Added more common MS Office file extensions
2023-09-29 09:44:04 +02:00
Mikael Schirén
83fff6c951
Add dotx to exclude for documents
2023-09-28 23:50:14 +02:00
Andrey Rakhmatullin
4abc54f0ec
Merge pull request #6066 from Gallaecio/questions
...
Add a template for question/help issues
2023-09-25 19:13:56 +04:00
Adrián Chaves
4c98d6068a
Add a template for question/help issues
2023-09-25 10:18:35 +02:00
Andrey Rakhmatullin
eb5e2e79ba
Use SIGINT instead of SIGTERM to support Windows.
2023-09-24 23:31:46 +04:00
Andrey Rakhmatullin
4b5fb9b5a6
Add a test for SIGTERM handling.
2023-09-24 22:52:17 +04:00
Andrey Rakhmatullin
d19e315b0b
Add an interactive test for `scrapy shell`.
2023-09-24 21:51:19 +04:00
Andrey Rakhmatullin
0630e4aaa1
Fix `scrapy shell`.
2023-09-24 19:36:29 +04:00
Andrey Rakhmatullin
0c6440a427
Fix additional typing errors with new Twisted.
2023-09-24 19:25:59 +04:00
Yash nagarkar
197781e3af
Cover the removal of is_botocore on the release notes ( #6061 )
2023-09-24 18:32:35 +04:00
Andrey Rakhmatullin
4b14215f83
Remove the Twisted version restriction.
2023-09-24 18:17:43 +04:00
Andrey Rakhmatullin
720f351a3e
Refactor installing signals.
2023-09-24 18:12:52 +04:00
Yash nagarkar
908da8ba82
Cover the removal of is_botocore on the release notes ( #6061 )
2023-09-22 10:12:20 +02:00
Andrey Rakhmatullin
9bfe0def59
Merge pull request #6059 from Gallaecio/typing
...
Add py.typed
2023-09-21 17:30:04 +04:00
Adrián Chaves
11bdc3df59
Revert "Add package_data={"scrapy": "py.typed"} to setup.py"
...
This reverts commit e84fb6d5cb .
2023-09-21 13:40:40 +02:00
Adrián Chaves
e84fb6d5cb
Add package_data={"scrapy": "py.typed"} to setup.py
2023-09-21 13:39:39 +02:00
Adrián Chaves
d5cc469ca9
Add py.typed
2023-09-21 13:06:12 +02:00
Andrey Rakhmatullin
f2fb4760d2
Bump version: 2.10.1 → 2.11.0
2023-09-18 15:24:28 +04:00
Andrey Rakhmatullin
efc594b53f
Merge pull request #6048 from wRAR/relnotes-2.11
...
Release notes for 2.11.0
2023-09-18 15:15:52 +04:00
Andrey Rakhmatullin
528911da85
Fix/reword the release notes.
2023-09-18 14:35:28 +04:00
Andrey Rakhmatullin
2fa768399a
Replace the VERSION vars.
2023-09-15 19:19:42 +04:00
Andrey Rakhmatullin
c2346b4a95
Update the release notes up to current master.
2023-09-15 19:15:05 +04:00
Andrey Rakhmatullin
3f34a5b151
Merge pull request #6050 from wRAR/retrymw-fix
...
Improve the backwards compatibility for RetryMiddleware.EXCEPTIONS_TO_RETRY
2023-09-15 17:51:04 +04:00
Andrey Rakhmatullin
800c1f112e
Remove the constant.
2023-09-15 13:13:06 +04:00
Andrey Rakhmatullin
14c27d2215
Merge branch 'master' into relnotes-2.11
2023-09-14 16:38:15 +04:00
Andrey Rakhmatullin
922ff57384
Improve the backwards compatibility for RetryMiddleware.EXCEPTIONS_TO_RETRY.
2023-09-14 15:51:00 +04:00
Andrey Rakhmatullin
dba37674e6
Merge pull request #6038 from wRAR/change-init-order
...
Change extensions/spiders/settings initialisation order, v2
2023-09-14 11:44:34 +04:00
Andrey Rakhmatullin
f96a3ed5f0
Cover up to cddb8c15d in the release notes.
2023-09-13 20:46:55 +04:00
Andrey Rakhmatullin
8dd48a08e4
Move PeriodicLog docs from Debugging to General purpose.
2023-09-13 20:46:32 +04:00
Andrey Rakhmatullin
6428356584
Use twisted.python.log instead of failure.printTraceback().
2023-09-13 18:20:42 +04:00
Andrey Rakhmatullin
be0e33af92
Don't rely on unhandled exception logging in the expected to fail scripts.
2023-09-13 16:59:54 +04:00
Andrey Rakhmatullin
ac201d310b
Small improvements,
2023-09-13 16:17:52 +04:00
Andrey Rakhmatullin
61ef37a594
Docs improvements.
2023-09-13 15:47:41 +04:00
Andrey Rakhmatullin
3756216339
Rename methods.
2023-09-13 15:47:22 +04:00
Andrey Rakhmatullin
619140717f
Fix the new addon test.
2023-09-13 15:33:51 +04:00
Andrey Rakhmatullin
028a56b9a2
Improve and simplify tests.
2023-09-13 14:17:41 +04:00
Andrey Rakhmatullin
61e6bfc023
Docs improvements.
2023-09-13 12:35:15 +04:00
Andrey Rakhmatullin
62183dc25f
Merge branch 'master' into change-init-order
2023-09-12 22:16:21 +04:00
Andrey Rakhmatullin
da39fbd270
Update tool versions ( #6046 )
2023-09-12 20:07:10 +02:00
Andrey Rakhmatullin
a3f22046ef
Document changing settings in Spider.from_crawler().
2023-09-12 20:41:36 +04:00
Andrey Rakhmatullin
77f39be407
Add integration tests for modifying settings via args.
2023-09-12 20:16:26 +04:00
Andrey Rakhmatullin
e26bf4f918
Pin brotli for PyPy tests ( #6045 )
2023-09-12 16:18:25 +02:00
Andrey Rakhmatullin
1a0572ad02
Reinstall the log handler after loading per-spider settings.
2023-09-12 16:46:35 +04:00
Andrey Rakhmatullin
bb15c93a2b
Add Crawler._load_settings().
2023-09-12 14:44:16 +04:00
Andrey Rakhmatullin
6629a61dd9
Fix one more testcase.
2023-09-08 20:15:49 +04:00
Andrey Rakhmatullin
036d5836d0
Move more things from Crawler.__init__() to .crawl().
2023-09-08 19:29:05 +04:00
Andrey Rakhmatullin
97b98bf181
Roll back the update_settings() changes.
2023-09-07 17:02:37 +04:00
Maria Mitropoulou
721df895f9
Fix charset handling in MailSender #5096 ( #5118 )
2023-09-07 07:47:42 +02:00
Andrey Rakhmatullin
b4380995da
Merge remote-tracking branch 'origin/master' into change-init-order
2023-09-06 20:34:27 +04:00
Andrey Rakhmatullin
00527fdcbe
Merge pull request #6040 from wRAR/deprecate-double-crawl
...
Deprecate running Crawler.crawl() twice.
2023-09-06 20:32:14 +04:00
Andrey Rakhmatullin
b39d2d4353
Add a test.
2023-09-06 19:44:22 +04:00
Andrey Rakhmatullin
d3b5c9be97
Deprecate running Crawler.crawl() twice.
2023-09-06 19:29:44 +04:00
Andrey Rakhmatullin
df112a3996
Move reactor installation into Crawler.crawl().
2023-09-05 19:43:08 +04:00
Andrey Rakhmatullin
69282c5318
Merge branch 'master' into change-init-order
2023-09-05 19:23:36 +04:00
Víctor Ruiz
c1dd5493ac
Fix enabled addons not being logged ( #6036 )
2023-09-04 08:03:35 +02:00
Andrey Rakhmatullin
276bce0641
Update type hints for Twisted 23.8.0. ( #6034 )
2023-09-01 08:47:23 +02:00
Andrey Rakhmatullin
d9efb94b61
Merge branch '2.10'
2023-08-31 13:21:22 +04:00
Mikhail Korobov
0fcb0554d1
Merge pull request #6016 from jxlil/fix/response.json
...
Fix: response.json() call makes unnecessary memory allocation
2023-08-31 14:07:24 +05:00
Andrey Rakhmatullin
cddb8c15d6
Merge pull request #5926 from GeorgeA92/periodic_log_2
...
periodic_log: implemented as separate extension
2023-08-30 22:29:54 +04:00
Andrey Rakhmatullin
a320e5f6a4
Bump version: 2.10.0 → 2.10.1
2023-08-30 12:08:36 +04:00
Andrey Rakhmatullin
99c826ce4d
Merge pull request #6027 from wRAR/relnotes-2.10.1
...
Release notes for 2.10.1.
2023-08-30 12:04:48 +04:00
Andrey Rakhmatullin
3fc7726e65
Merge pull request #6026 from wRAR/restrict-twisted
...
Forbid Twisted 23.8.0+
2023-08-29 18:26:19 +04:00
Andrey Rakhmatullin
f8f550120b
Release notes for 2.10.1.
2023-08-29 18:07:15 +04:00
Andrey Rakhmatullin
9a72a2550c
Forbid Twisted 23.8.0+.
2023-08-29 17:00:28 +04:00
Andrey Rakhmatullin
0e7fc60b89
Merge pull request #6021 from dveselov/master-1
...
Add .webp to link extractor IGNORED_EXTENSIONS list
2023-08-21 22:04:03 +04:00
Jalil SA
4dd32672ed
added entry to Backward-incompatible changes
2023-08-21 08:28:08 -06:00
Georgiy Zatserklianyi
fe02642980
Merge remote-tracking branch 'origin/periodic_log_2' into periodic_log_2
2023-08-21 17:15:42 +03:00
Georgiy Zatserklianyi
7e542846e4
periodic_log: `datetime.utcnow()` changed to `datetime.now(tz=timezone.utc)`
2023-08-21 17:13:18 +03:00
Georgiy Zatserklianyi
1f03cb1419
Merge remote-tracking branch 'upstream/master' into periodic_log_2
2023-08-21 17:07:18 +03:00
Laerte Pereira
df2163ce6a
Remove datetime.utcnow() usage ( #6014 )
2023-08-21 15:51:49 +02:00
Dima Veselov
7355741c7d
Add .webp to IGNORED_EXTENSIONS
2023-08-20 22:38:56 +03:00
Jalil SA
fd4292b722
fix: test_cache_json_response
2023-08-17 10:24:34 -06:00
Jalil SA
19867659f3
fix: response.json() call makes unnecessary memory allocation
2023-08-17 10:22:17 -06:00
Andrey Rakhmatullin
3318971512
Merge pull request #6013 from Laerte/master
...
Handle Tuple type on getdictorlist method, bump 3.12 python version
2023-08-14 19:55:38 +04:00
Laerte Pereira
b06936f111
Handle Tuple type on getdictorlist method, bump 3.12 python version
2023-08-14 10:33:48 -03:00
Georgiy Zatserklianyi
ac1694a9ad
Update docs/topics/extensions.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-11 18:49:09 +03:00
Georgiy Zatserklianyi
d67be20b2d
Update docs/topics/extensions.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-11 18:48:58 +03:00
Georgiy Zatserklianyi
3a4a949f9d
Update docs/topics/extensions.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-11 18:48:48 +03:00
Georgiy Zatserklianyi
e6bd9829bd
Update docs/topics/extensions.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-11 18:48:31 +03:00
Georgiy Zatserklianyi
2f094a7a5c
Update docs/topics/extensions.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-11 18:48:14 +03:00
Andrey Rakhmatullin
7c497688f8
Merge pull request #6005 from wRAR/typing-crawler
...
More typing for scrapy/*.py
2023-08-11 14:41:47 +04:00
Adrián Chaves
8a0108b19c
Merge branch 'master' into typing-crawler
2023-08-11 10:42:45 +02:00
Andrey Rakhmatullin
34d050cfe5
Remove deprecated CrawlerRunner.spiders. ( #6010 )
2023-08-11 10:41:05 +02:00
Andrey Rakhmatullin
44b15c3004
Remove typing for CrawlerRunner.spider_loader.
2023-08-10 23:17:06 +04:00
Andrey Rakhmatullin
9df67a554e
Add RequestFingerprinterProtocol.
2023-08-10 22:53:22 +04:00
Georgiy Zatserklianyi
736a4b615c
Update scrapy/settings/default_settings.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-10 21:34:35 +03:00
Georgiy Zatserklianyi
f05657e542
periodic_log: interval check moved
2023-08-10 21:31:10 +03:00
Laerte Pereira
9e74748fca
Remove extra spider parameter in item pipeline docs ( #6009 )
2023-08-10 13:48:43 +02:00
Laerte Pereira
4a090d951a
Remove deprecated PythonItemExporter.binary ( #6007 )
2023-08-10 07:36:42 +02:00
Andrey Rakhmatullin
b50268c100
Full typing for scrapy/link.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
e6d919497d
More typing for scrapy/core/scheduler.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
7dca18e2e7
Full typing for scrapy/responsetypes.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
c5885fc13b
Full typing for scrapy/exceptions.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
9960c62b87
Full typing for scrapy/logformatter.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
89503ae3f1
Full typing for scrapy/dupefilters.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
dc6e142096
Full typing for scrapy/spiderloader.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
084a9ba076
Full typing for scrapy/crawler.py and scrapy/spiders/__init__.py.
2023-08-09 23:56:16 +04:00
Andrey Rakhmatullin
85696d7bab
Merge pull request #6003 from wRAR/typing-utils-2
...
Typing for scrapy/utils, second pass
2023-08-09 23:56:03 +04:00
Andrey Rakhmatullin
8050257c14
Small cleanup.
2023-08-09 23:17:32 +04:00
Andrey Rakhmatullin
53539483c3
Refactor _StreamReader.read().
2023-08-07 15:13:20 +04:00
Andrey Rakhmatullin
2c7484d433
Merge remote-tracking branch 'origin/master' into typing-utils-2
2023-08-07 14:55:38 +04:00
Andrey Rakhmatullin
110d5fffb4
Update tool versions. ( #6002 )
2023-08-07 10:57:48 +02:00
Andrey Rakhmatullin
23af21491d
Move definitions around to woark around a pypy3.8 bug.
2023-08-07 00:21:06 +04:00
Andrey Rakhmatullin
644a71bfd4
Use ftp:// URLs in FTP tests.
2023-08-07 00:17:52 +04:00
Andrey Rakhmatullin
471281d29e
Fixes for scrapy/utils/iterators.py typing.
2023-08-06 23:05:02 +04:00
Andrey Rakhmatullin
f5f593e5f5
Remove a workaround for a w3lib typing bug.
2023-08-06 17:46:28 +04:00
Andrey Rakhmatullin
e2adec629b
Fix regressions in typing.
2023-08-06 17:44:24 +04:00
Andrey Rakhmatullin
518e56046e
Check for async callbacks in contracts.
2023-08-06 17:28:34 +04:00
Andrey Rakhmatullin
66bad1150c
Add more typing for scrapy/utils/signal.py.
2023-08-06 00:35:33 +04:00
Andrey Rakhmatullin
9fe662d856
Add typing for scrapy/utils/testproc.py.
2023-08-06 00:35:33 +04:00
Andrey Rakhmatullin
d1f87e4f08
More typing for scrapy/utils/iterators.py.
2023-08-06 00:35:33 +04:00
Andrey Rakhmatullin
c43798cb9b
More typing for scrapy/utils/defer.py and scrapy/utils/spider.py.
2023-08-06 00:35:33 +04:00
Andrey Rakhmatullin
d015329d75
Add more typing for scrapy/utils/log.py.
2023-08-06 00:35:33 +04:00
Andrey Rakhmatullin
d31829b72f
More typing for scrapy/utils.
2023-08-06 00:35:33 +04:00
Andrey Rakhmatullin
88327c7c58
Bump version: 2.9.0 → 2.10.0
2023-08-04 17:23:30 +04:00
Andrey Rakhmatullin
4d288c8bf3
Merge pull request #6001 from scrapy/relnotes-2.10
...
Add release notes for 2.10.0.
2023-08-04 17:22:16 +04:00
Andrey Rakhmatullin
022ef0f86b
Apply suggestions from code review
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-04 17:05:09 +04:00
Andrey Rakhmatullin
7fe4c0c9f7
Update docs/news.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-04 16:56:39 +04:00
Andrey Rakhmatullin
c14a0a9d5d
Add release notes for 2.10.0.
2023-08-04 16:36:27 +04:00
Andrey Rakhmatullin
12638386dc
Merge pull request #6000 from Gallaecio/asyncio-module-level-twisted-imports-issue
...
asyncio docs: cover accidental bad reactor installation
2023-08-04 15:26:50 +04:00
Georgiy Zatserklianyi
e9b088f1fb
periodic_log: typing
2023-08-04 12:49:22 +03:00
Georgiy Zatserklianyi
8b6a50a935
periodic_log: docs added
2023-08-04 11:12:07 +03:00
Adrián Chaves
72de48be6d
asyncio: cover accidental bad reactor installation, sort sections, reword the Windows section
2023-08-04 09:56:30 +02:00
Laerte Pereira
09c63a178b
Remove the deprecated spider parameter from the engine ( #5998 )
2023-08-04 07:53:04 +02:00
Andrey Rakhmatullin
e58c8ca638
Merge pull request #5999 from Laerte/chore/enable-python3.11-on-ci
...
Enable Python 3.11 on Windows CI
2023-08-04 02:18:05 +04:00
Laerte Pereira
8a0a9e6d3e
Enable Python 3.11 on Windows CI
2023-08-03 18:31:12 -03:00
Laerte Pereira
b9c32a0cfd
Remove functions deprecated in 2.6.0 ( #5996 )
2023-08-03 17:06:55 +02:00
Andrey Rakhmatullin
7c6aaedda2
Merge pull request #5846 from jxlil/docs/spiders
...
Added documentation for Spider.update_settings
2023-08-02 21:09:44 +04:00
Andrey Rakhmatullin
af1be835e4
Apply suggestions from code review
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-08-02 19:46:16 +04:00
Andrey Rakhmatullin
9f9a2292e0
Deprecate the custom attribute of build_component_list(). ( #5993 )
2023-08-02 14:21:06 +02:00
Andrey Rakhmatullin
72462a53e2
Add more docs for update_settings().
2023-08-02 12:32:53 +04:00
Andrey Rakhmatullin
06ebdee35d
Merge pull request #5950 from wRAR/addons
...
Add-ons
2023-08-01 22:18:57 +04:00
Andrey Rakhmatullin
e58b8078f0
Improve NotConfigured handling when clspath is a class.
2023-08-01 20:20:15 +04:00
Andrey Rakhmatullin
f803ad63f3
Fix a typing issue.
2023-08-01 17:23:09 +04:00
Andrey Rakhmatullin
7fdeb5c5c1
Improve NotConfigured handling in add-ons.
2023-08-01 16:58:18 +04:00
Andrey Rakhmatullin
cf55eb05f5
Fix a typo.
2023-08-01 13:30:56 +04:00
Andrey Rakhmatullin
41a4a163e3
Handle NotConfigured in add-ons.
2023-07-31 21:09:18 +04:00
Andrey Rakhmatullin
b67a81b81d
Use the MyHandler class directly.
2023-07-31 20:25:56 +04:00
Andrey Rakhmatullin
d8c5b41559
Add more addon tests.
2023-07-31 19:09:21 +04:00
Andrey Rakhmatullin
bddbbc522a
Merge pull request #5979 from BurnzZ/closespider-timeout-no-item
2023-07-28 12:56:44 +04:00
freddiewanah
c4f0aa4fdf
Refactor test cases to improve unit test quality ( #5986 )
2023-07-26 13:09:03 +02:00
Andrey Rakhmatullin
6e3e3c2172
Merge pull request #5977 from scrapy/typing-settings
...
Typing for scrapy.settings.BaseSettings
2023-07-24 21:40:52 +04:00
Andrey Rakhmatullin
7a1afff655
Merge pull request #5980 from BurnzZ/s3-region
...
expose AWS_REGION_NAME in S3FeedStorage
2023-07-24 21:40:37 +04:00
Andrey Rakhmatullin
3ba2dc4d68
Fixes for addon docs.
2023-07-24 17:49:04 +04:00
Kevin Lloyd Bernal
a689fe5baf
move region_name param as kwargs
2023-07-24 16:37:52 +08:00
Kevin Lloyd Bernal
9a1bf40c2f
expose AWS_REGION_NAME in S3FeedStorage
2023-07-24 16:37:52 +08:00
Laerte Pereira
7522aeed35
fix: -O/-o option does not work with absolute paths on Windows ( #5971 )
2023-07-24 09:53:41 +02:00
Andrey Rakhmatullin
5e1582491b
mypy --show-error-codes is the default now.
2023-07-22 23:19:25 +04:00
Mikhail Korobov
af2aa4b421
Merge pull request #5847 from namelessGonbai/feat/FixFeedExport
...
Fix FeedExporter not to export empty file
2023-07-22 23:18:36 +05:00
Adnan Awan
5d91ea12d6
Fix JsonItemExporter puts lone comma in the output if encoder fails ( #5952 )
...
* Partial fix for #3090 - only addresses JSON feeds.
* Adding test case for #3090 to Json Exporter
* Changing the deliberate-fail JSON example to a complex
* Further tightening JsonItemExporter behaviour to prevent corruption.
Based on Mikhail's observation that to_bytes can fail also, leading
to the same dangling comma as the failure to encode to JSON.
Added a new test case to avoid reversion.
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Add initial changes from cathal's PR
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Handle exception not to add empty item.
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Add comment for handling the exception
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Remove unused import
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Fix invalid json issue
- https://github.com/scrapy/scrapy/issues/3090
* [scrapy] JsonItemExporter puts lone comma in the output if encoder fails
- Perform CR changes
- https://github.com/scrapy/scrapy/issues/3090
---------
Co-authored-by: Cathal Garvey <cathalgarvey@cathalgarvey.me>
2023-07-22 23:13:40 +05:00
Mikhail Korobov
1a0eb60c87
Merge pull request #5984 from wRAR/ci-3.12
...
Python 3.12 support
2023-07-22 22:51:39 +05:00
Andrey Rakhmatullin
53f8570786
Add support for the new entry_points() interface.
2023-07-22 18:46:44 +04:00
Andrey Rakhmatullin
21b6dc5f9f
Add 3.12 CI jobs.
2023-07-22 17:55:32 +04:00
Andrey Rakhmatullin
a346732275
Skip more non-test files during discovery.
2023-07-22 17:54:55 +04:00
Andrey Rakhmatullin
e058a05763
Skip tests that don't work on Python 3.12.
2023-07-22 17:51:13 +04:00
Andrey Rakhmatullin
583df9f7d0
Simplify skipping uvloop tests.
2023-07-22 17:44:37 +04:00
Andrey Rakhmatullin
005c8cc5f0
Unify the "add-on" spelling.
2023-07-19 13:15:35 +04:00
Andrey Rakhmatullin
0a25a300cf
Fix docs.
2023-07-18 20:29:42 +04:00
Andrey Rakhmatullin
90dae3ee60
Doc fixes.
2023-07-18 19:55:46 +04:00
Andrey Rakhmatullin
5c34f34ecb
Make AddonManager.add() private.
2023-07-18 19:50:08 +04:00
Kevin Lloyd Bernal
368ab29ffc
improve tests by having SlowSpider
2023-07-18 22:29:15 +08:00
Kevin Lloyd Bernal
2f787a27dc
fix conditional on task_no_item
2023-07-18 20:49:33 +08:00
Kevin Lloyd Bernal
3f5bbe3a8f
introduce CLOSESPIDER_TIMEOUT_NO_ITEM in CloseSpider
2023-07-18 18:30:21 +08:00
Andrey Rakhmatullin
db86f91789
Unbreak isort breakage.
2023-07-17 23:17:11 +04:00
Andrey Rakhmatullin
cdda8ad46d
Add docs about fallbacks in addons.
2023-07-17 21:05:58 +04:00
Andrey Rakhmatullin
043a24410b
Disable pylint for broken code.
2023-07-17 00:13:49 +04:00
Andrey Rakhmatullin
187e8f9a2d
Typing for scrapy/settings/__init__.py.
2023-07-17 00:01:36 +04:00
Andrey Rakhmatullin
93962ebefc
Bump typing package versions.
2023-07-14 23:20:35 +04:00
Andrey Rakhmatullin
a2264d3b8b
Improve docs about setting settings in addons.
2023-07-14 18:57:27 +04:00
Andrey Rakhmatullin
8055a948dc
Merge pull request #5965 from andersoncarlosfs/patch-1
...
Removing hard code entries
2023-07-05 12:51:06 +04:00
Anderson Carlos Ferreira da Silva
7ce3d8f98a
removing hard code entries
2023-07-05 16:56:34 +09:00
Andrey Rakhmatullin
d5f74c7224
Log the enabled addons.
2023-06-29 20:43:46 +04:00
Andrey Rakhmatullin
c92c9af075
Add create_instance support to addons.
2023-06-29 15:04:46 +04:00
Georgiy Zatserklianyi
6fd94fdcb3
periodic_log: tests updated (errors fixed)
2023-06-28 19:55:33 +03:00
Andrey Rakhmatullin
f1ed5598f4
Remove the check_configuration call.
2023-06-28 19:13:46 +04:00
Andrey Rakhmatullin
9612ae3e93
Remove more code.
2023-06-28 18:44:30 +04:00
Laerte Pereira
b6196309cb
fix: Return value instead of `SettingsAttribute` object when using `pop` method ( #5963 )
2023-06-28 08:28:49 +02:00
Georgiy Zatserklianyi
56c38231b4
periodic_log: tests for logging stats added
2023-06-27 11:48:51 +03:00
Georgiy Zatserklianyi
315861c31d
periodic_log: stats filtering updated
2023-06-27 09:24:03 +03:00
Georgiy Zatserklianyi
ebce5b4bcb
periodic_log: tests for logging deltas added
2023-06-27 09:22:50 +03:00
Andrey Rakhmatullin
760c0db094
Fix typing on 3.8.
2023-06-26 17:15:13 +04:00
Andrey Rakhmatullin
e7124447f7
Remove unneeded code.
2023-06-26 16:57:46 +04:00
Andrey Rakhmatullin
4e21e3e59d
Merge remote-tracking branch 'origin/master' into addons
2023-06-26 14:25:35 +04:00
Georgiy Zatserklianyi
2ce4856508
periodic_log: Exception handling on init updated
2023-06-25 12:16:59 +03:00
Andrey Rakhmatullin
510574216d
Merge pull request #5925 from wRAR/typing-utils
...
Typing for scrapy/utils
2023-06-24 20:08:41 +04:00
Andrey Rakhmatullin
712ee98848
Merge branch 'master' into typing-utils
2023-06-24 18:31:56 +04:00
Andrey Rakhmatullin
85f5122965
Merge pull request #5960 from Laerte/master
...
chore: Implement `pop` method on `BaseSettings` class
2023-06-24 18:23:17 +04:00
Laerte Pereira
a3f8912d69
chore: Rename test
2023-06-23 00:15:32 -03:00
Laerte Pereira
876feaf339
chore: Use dunder to delete item instead of del keyword to handle immutable settings
2023-06-23 00:14:31 -03:00
Laerte Pereira
080b9bd0b8
chore: Implement `pop` method on `BaseSettings` class
2023-06-22 23:58:03 -03:00
Andrey Rakhmatullin
e71d6d67e5
Apply suggestions from code review
2023-06-22 21:10:50 +04:00
Alex
04ee3303e4
Adding support for Windows of absolute pathlib.Path objects in FeedExporter ( #5939 )
2023-06-22 07:04:06 +02:00
Andrey Rakhmatullin
1b78e48944
Merge pull request #5146 from elacuesta/case-insensitive-dict
...
CaseInsensitiveDict (deprecate CaselessDict)
2023-06-21 23:48:40 +04:00
Andrey Rakhmatullin
39282d7bd0
Merge branch 'master' into case-insensitive-dict
2023-06-21 22:12:44 +04:00
Marc Hernández
5360ba34bc
IOError and other cleanup ( #4716 )
2023-06-21 20:08:53 +02:00
Aaron Smith
ee215a2970
Change redirect text from Response.request docs ( #5937 )
2023-06-21 20:05:39 +02:00
Andrey Rakhmatullin
e9e1034af3
Merge pull request #5958 from Laerte/master
...
Remove `pkg_resources` usage
2023-06-21 12:47:01 +04:00
Laerte Pereira
82cf00bbc9
fix: default value
2023-06-20 18:27:03 -03:00
Laerte Pereira
0b1da44a05
chore: Remove deprecated code
2023-06-20 17:14:21 -03:00
Laerte Pereira
a93a63c208
fix: move import to inside function
2023-06-20 17:05:49 -03:00
Laerte Pereira
6e1af20ac4
fix: add `build-system`
2023-06-20 17:00:01 -03:00
Laerte Pereira
6afb31b82b
chore: Add `packaging` to tests deps
2023-06-20 16:48:07 -03:00
Laerte Pereira
0097b4c0bb
cleanup: Remove `pkg_resources` usage
2023-06-20 16:40:38 -03:00
Andrey Rakhmatullin
fae5538910
Merge pull request #5953 from wRAR/drop-3.7
...
Drop Python 3.7 support
2023-06-19 13:59:13 +04:00
Andrey Rakhmatullin
075b89eab5
Bump lxml and cryptography to versions with 3.8 wheels available.
2023-06-18 19:08:41 +04:00
Andrey Rakhmatullin
1b2c9a3e0a
Bump isort and flake8 versions.
2023-06-18 18:38:56 +04:00
Andrey Rakhmatullin
2122278d4b
Drop Python 3.7 support.
2023-06-18 18:37:50 +04:00
Serhii A
777a6ea412
Make the retry middleware exception list configurable ( #5929 )
2023-06-16 15:46:06 +02:00
Georgiy Zatserklianyi
6e65eeb07b
periodic_log: tests [wip] added
2023-06-16 14:30:50 +03:00
Georgiy Zatserklianyi
639c2bcc47
periodic_log: TypeError except added
2023-06-16 13:37:26 +03:00
Andrey Rakhmatullin
54287f7339
Docs cleanup.
2023-06-15 19:53:34 +04:00
Andrey Rakhmatullin
79bf8b1f2e
Test cleanup.
2023-06-15 19:28:14 +04:00
Andrey Rakhmatullin
f582246d7b
More doc fixes.
2023-06-15 18:49:08 +04:00
Andrey Rakhmatullin
0258c87dab
Add typing for Crawler.addons.
2023-06-15 18:40:59 +04:00
Andrey Rakhmatullin
2f9ebb66c3
Remove some dead code/docs.
2023-06-15 17:00:38 +04:00
Andrey Rakhmatullin
58300e066f
Merge pull request #5949 from wRAR/tests-as-installed
...
Allow running tests against the installed version
2023-06-14 23:15:04 +04:00
Andrey Rakhmatullin
c7f78a8305
Revert "Remove load_module_or_object."
...
This reverts commit 815af43120 .
2023-06-14 20:43:18 +04:00
Andrey Rakhmatullin
bc09c9e74a
Merge pull request #5951 from wRAR/fix-asyncio-loop-test
...
Actually run test_set_asyncio_event_loop().
2023-06-14 20:01:26 +04:00
Andrey Rakhmatullin
27f5f35134
More quick doc fixes.
2023-06-14 18:30:33 +04:00
Andrey Rakhmatullin
7cfdca8f9b
Actually run test_set_asyncio_event_loop().
2023-06-14 18:23:29 +04:00
Andrey Rakhmatullin
815af43120
Remove load_module_or_object.
2023-06-14 18:11:14 +04:00
Andrey Rakhmatullin
5e76464fbf
Fix a merge error.
2023-06-14 18:01:50 +04:00
Andrey Rakhmatullin
fdfab17438
Fix docs for the renamed ADDONS setting.
2023-06-14 18:00:18 +04:00
Andrey Rakhmatullin
22bd0d9a79
Fix docs build.
2023-06-14 17:58:11 +04:00
Andrey Rakhmatullin
282fe3dd4f
Drop the SEP as we decided we don't want to update it.
2023-06-14 17:52:25 +04:00
Andrey Rakhmatullin
7ebb8256f0
Some cleanup.
2023-06-14 17:52:11 +04:00
Andrey Rakhmatullin
fdbc141b23
Replace pkg_resources with packaging.
2023-06-14 17:23:50 +04:00
Andrey Rakhmatullin
55ac26228b
Remove builtin addons.
2023-06-14 16:50:43 +04:00
Andrey Rakhmatullin
075ad6f196
Test, linter etc. fixes.
2023-06-14 16:34:18 +04:00
Andrey Rakhmatullin
898e3045a1
Merge branch 'master' into addons
2023-06-14 15:37:08 +04:00
Andrey Rakhmatullin
d2e7f6e209
Merge pull request #5948 from scrapy/fix-extra-deps-pinned
...
Fix extra-deps-pinned tests.
2023-06-13 21:00:31 +04:00
Andrey Rakhmatullin
0adbd210ac
Fix extra-deps-pinned tests.
2023-06-13 19:34:26 +04:00
Andrey Rakhmatullin
3f92882be4
Fix a wrong merge.
2023-06-13 19:13:58 +04:00
Andrey Rakhmatullin
85fe88f80f
Merge pull request #5833 from GodelTech/issue_960_s3_feed_export
...
Fix #960 : S3 Feed Export throws boto error
2023-06-13 18:44:06 +04:00
Andrey Rakhmatullin
8a64f3e8de
Merge branch 'master' into feat/FixFeedExport
2023-06-13 18:21:06 +04:00
Andrey Rakhmatullin
9e0bfc4a3d
Merge pull request #5705 from srki24/issue5043-feed_export
...
S3 CsvItemExporter read of closed file error #5043
2023-06-13 18:14:27 +04:00
Andrey Rakhmatullin
493ea43538
Improve finding tests.test_cmdline.settings.
2023-06-12 21:50:29 +04:00
Andrey Rakhmatullin
49839d6071
Don't rely on get_testenv() for running mockserver.
2023-06-04 19:59:58 +04:00
Georgiy Zatserklianyi
b60e0faf22
periodic_log: fixed naming
2023-05-24 23:10:30 +03:00
Georgiy Zatserklianyi
a0c84903b7
periodic_log: codestyle fix (from pre-commit)
2023-05-23 23:07:12 +03:00
Georgiy Zatserklianyi
5c91f1bb43
periodic_log: added settings to default settings
2023-05-23 23:00:26 +03:00
Georgiy Zatserklianyi
db794d351c
periodic_log: not used code deleted
2023-05-22 23:30:00 +03:00
Georgiy Zatserklianyi
a2f238d927
periodic_log: settings input in extension updated
2023-05-22 23:24:53 +03:00
Georgiy Zatserklianyi
84fb0edd5f
periodic_log: extension updated
2023-05-21 20:22:35 +03:00
Andrey Rakhmatullin
33b418dc84
Merge pull request #5927 from bulatbulat48/master
...
Add additional requests examples.
2023-05-16 19:13:02 +04:00
Adrián Chaves
d362699fa3
Move inline request examples to the coroutines documentation
2023-05-16 13:39:02 +02:00
Adrián Chaves
e4cf8fc121
Update asyncio.rst
2023-05-15 18:51:58 +02:00
Andrey Rakhmatullin
43afd38813
Merge pull request #5931 from belaeifert/improve_overwrite_feed_option
...
Improve the overwrite feed option documentation
2023-05-12 15:46:23 +04:00
isabela_catanante
5adada5d19
Improve the overwrite feed option documentation
2023-05-12 12:55:24 +02:00
bulat
8de2064ba3
add import.
2023-05-11 13:22:33 +05:00
bulat
4878cc7ef0
Add proper imports.
2023-05-11 13:19:40 +05:00
bulat
b62c1263de
add import to the example.
2023-05-11 13:15:30 +05:00
bulat
fc2d1b2171
make example reachable.
2023-05-11 12:56:29 +05:00
bulat
6a0bbad677
Merge branch 'master' of https://github.com/bulatbulat48/scrapy
2023-05-11 12:54:04 +05:00
bulat
6194db1335
Update title.
2023-05-11 12:54:01 +05:00
Bulat Khabibullin
85103b4932
add proper example
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-05-11 12:53:43 +05:00
Bulat Khabibullin
26374e21f8
Update docs/topics/asyncio.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-05-10 18:32:36 +05:00
Bulat Khabibullin
57f3140daa
Update docs/topics/asyncio.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-05-10 18:31:54 +05:00
bulat
87d10161cd
Add selector as class.
2023-05-10 15:35:48 +05:00
bulat
b1f4017788
Refactor batch sample.
2023-05-10 15:34:58 +05:00
Andrey Rakhmatullin
6998e1c905
Fix typing-related issued on Python < 3.9.
2023-05-10 14:21:18 +04:00
bulat
99b0ece165
remove extra line.
2023-05-09 20:27:46 +05:00
bulat
d32c678234
Update description.
2023-05-09 19:02:34 +05:00
bulat
2c6a772145
Merge branch 'master' of https://github.com/bulatbulat48/scrapy
2023-05-09 18:57:45 +05:00
bulat
a75231a1ec
fix underline.
2023-05-09 18:57:43 +05:00
Bulat Khabibullin
75cd4958fe
Merge branch 'scrapy:master' into master
2023-05-09 18:05:40 +05:00
bulat
c327a92e97
add additional requests examples.
2023-05-09 18:04:18 +05:00
Andrey Rakhmatullin
52c072640a
Bump version: 2.8.0 → 2.9.0
2023-05-08 14:30:06 +04:00
Andrey Rakhmatullin
5bb6dfbc25
Merge pull request #5909 from scrapy/relnotes-2.9
...
Release notes for 2.9.0
2023-05-08 14:27:21 +04:00
Andrey Rakhmatullin
caa66fa15a
Mention deprecating _FeedSlot.
2023-05-08 13:27:01 +04:00
Georgiy Zatserklianyi
33153855ea
periodic_log: implemented as separate extension
2023-05-07 22:29:23 +03:00
Andrey Rakhmatullin
e03c6bb70a
Fix pylint issues.
2023-05-07 23:03:35 +04:00
Andrey Rakhmatullin
0ec79e3166
Fix compatibility with Python 3.8.
2023-05-07 23:01:27 +04:00
Andrey Rakhmatullin
048812ba35
Bump types-* versions.
2023-05-07 22:40:29 +04:00
Andrey Rakhmatullin
54fa04aa0a
Add typing to scrapy/utils/test.py, fix a FTP test.
2023-05-07 22:39:27 +04:00
Andrey Rakhmatullin
f38cea9c8c
Add typing to scrapy/utils/display.py.
2023-05-07 19:22:57 +04:00
Andrey Rakhmatullin
36507ddb7b
Add typing to scrapy/utils/engine.py.
2023-05-07 19:16:57 +04:00
Andrey Rakhmatullin
c04b9ba19d
Add typing to scrapy/utils/template.py.
2023-05-07 19:10:42 +04:00
Andrey Rakhmatullin
b8277f4cab
Add more typing to scrapy/utils/defer.py.
2023-05-07 19:08:46 +04:00
Andrey Rakhmatullin
9661a5c491
Add typing to scrapy/utils/deprecate.py.
2023-05-07 18:50:23 +04:00
Andrey Rakhmatullin
d400f1ac06
Add more typing to scrapy/utils/python.py.
2023-05-07 18:35:24 +04:00
Andrey Rakhmatullin
4da8691510
Add typing to scrapy/utils/gz.py and remove dead code.
2023-05-07 02:02:33 +04:00
Andrey Rakhmatullin
43ee483a0d
Add typing to scrapy/utils/reactor.py.
2023-05-07 01:48:09 +04:00
Andrey Rakhmatullin
ea299dfd7c
Add typing to scrapy/utils/misc.py.
2023-05-07 01:48:09 +04:00
Andrey Rakhmatullin
7347d02145
Add typing to scrapy/utils/datatypes.py.
2023-05-07 01:48:09 +04:00
Andrey Rakhmatullin
f64a7dedca
Add typing to scrapy/utils/url.py.
2023-05-07 01:48:02 +04:00
Andrey Rakhmatullin
e0dbc83bd2
More typing for scrapy/utils/request.py.
2023-05-07 00:54:23 +04:00
Andrey Rakhmatullin
4596a58a13
Typing for smaller scrapy/utils/ modules.
2023-05-07 00:54:23 +04:00
Andrey Rakhmatullin
636559f1cc
Add newer changes.
2023-05-04 17:55:07 +04:00
Andrey Rakhmatullin
92f86fab06
Merge pull request #5919 from scrapy/docs-parsel-fixes
...
Enable doc tests for selectors.rst, fix issues
2023-05-04 17:30:33 +04:00
Andrey Rakhmatullin
d1d6465ef4
Address feedback.
2023-05-04 17:19:01 +04:00
Andrey Rakhmatullin
cba891a66c
Enable doc tests for selectors.rst, fix issues.
2023-05-04 15:04:33 +04:00
Andrey Rakhmatullin
776cf59990
Merge pull request #5918 from Laerte/master
...
fix: Handle Parsel > 1.7.0 warning
2023-05-04 13:52:08 +04:00
Laerte Pereira
7317ff1101
refactor: use kwargs strategy
2023-05-04 05:55:25 -03:00
Laerte Pereira
d907f9e092
fix: Handle Parsel > 1.7.0 warning
2023-05-03 22:12:21 -03:00
Andrey Rakhmatullin
ea15ff1d32
Merge pull request #5915 from jxlil/feature/support-parsel-jmespath
...
Added support for the Parsel JMESPath feature
2023-05-03 13:18:39 +04:00
Jalil SA
a038faf11c
fix: tests/tes_selector.py
2023-05-02 19:40:04 -06:00
Jalil SA
4bb99fd2f3
fix: pylint
2023-05-02 19:26:20 -06:00
Jalil SA
a604dfae5c
update tests
2023-05-02 19:19:00 -06:00
Jalil SA
1eb4460485
fix: jmespath
2023-05-02 18:49:05 -06:00
Andrey Rakhmatullin
6a169d4462
Merge pull request #5917 from Laerte/master
...
fix: non-UTF-8 content-type headers
2023-05-02 22:15:21 +04:00
Laerte Pereira
7b49aa1b01
chore: add tests
2023-05-02 12:53:04 -03:00
Laerte Pereira
8acde511a9
fix: non-UTF-8 content-type headers
2023-05-02 12:11:23 -03:00
Jalil SA
578606779d
update tests
2023-04-29 00:52:39 -06:00
Jalil SA
3d29f20fc2
added tests for jmespath
2023-04-28 23:54:09 -06:00
Jalil SA
865c36bdbb
update docs
2023-04-28 08:56:11 -06:00
guillermo-bondonno
b50c032ee9
Add feed_slot_closed and feed_exporter_closed signals ( #5876 )
2023-04-26 08:20:37 +02:00
Jalil SA
9af596a6b8
feat: Add support for the Parsel JMESPath
2023-04-25 10:24:14 -05:00
Andrey Rakhmatullin
8c8fb67057
Update tool versions ( #5908 )
2023-04-24 09:34:34 +02:00
Andrey Rakhmatullin
67bfb304cd
Release notes for the current master.
2023-04-21 20:49:51 +04:00
Jalil SA
5a37af146f
Update documentation expectations for Parsel 1.8.0 ( #5902 )
2023-04-21 09:29:57 +02:00
DeflateAwning
87c8c51999
Fix a typo in the FAQ ( #5904 )
2023-04-20 08:23:02 +02:00
Andrey Rakhmatullin
abc9c1ac6f
Merge pull request #5901 from jxlil/fix/5899
...
Fix: Request.from_curl() with $-prefixed string literals
2023-04-19 13:35:01 +04:00
Jalil SA
f69ba43f8e
fix: import re
2023-04-19 02:06:00 -05:00
Jalil SA
b7ecec1809
Update scrapy/utils/curl.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-04-19 01:04:03 -06:00
tstauder
ef61fb5698
Fix flaky tests involving feed export batches ( #5898 )
...
Co-authored-by: jmannoop <jmannoop@umich.edu>
2023-04-19 08:33:32 +02:00
Jalil SA
7e1814faf8
fix: regex
2023-04-18 23:36:51 -05:00
Jalil SA
3209eac14f
fix: checks
2023-04-18 22:35:15 -05:00
Jalil SA
69f96b9e96
fix: regex
2023-04-18 22:28:16 -05:00
Jalil SA
88c58a8c9c
feat: added test_post_data_raw_with_string_prefix
2023-04-18 22:28:16 -05:00
Jalil SA
f5447f3b4c
fix: Request.from_curl() with prefixed string literals
2023-04-18 22:27:52 -05:00
Andrey Rakhmatullin
02f3e8d413
Typing for scrapy/core/downloader ( #5896 )
2023-04-17 08:37:52 +02:00
Andrey Rakhmatullin
e1f66620ec
Fix typo on tutorial.rst ( #5893 ) ( #5895 )
...
Co-authored-by: Seth Herr <seth.william.herr@gmail.com>
2023-04-14 16:13:21 +02:00
guillermo-bondonno
441ac196e4
Implement a request_to_curl function ( #5892 )
2023-04-13 17:46:59 +02:00
Serhii A
c2a31974ff
Improve get_func_args ( #5885 )
2023-04-13 11:44:20 +02:00
Andrey Rakhmatullin
d911837389
Merge pull request #5881 from sbartlett97/LinkExtractor-Patch
...
Patched LxmlParserLinkExtractor
2023-04-12 12:28:21 +04:00
Adrián Chaves
3f0c2fae5e
Skip test_skip_bad_links based on the w3lib version
2023-04-12 09:28:28 +02:00
Kartik Kumar
d47c732ae9
base64-decode GCS checksums ( #5891 )
2023-04-11 18:25:42 +02:00
Andrey Rakhmatullin
1e20ba0a1b
Merge branch 'master' into feat/FixFeedExport
2023-04-11 19:48:19 +04:00
Andrey Rakhmatullin
283e1eb302
Merge pull request #5880 from Prathm-s/Prathms/#1611
...
return failure added to _sent_failed
2023-04-11 17:38:06 +04:00
Andrey Rakhmatullin
c7730627a0
Typing improvements for some core components ( #5889 )
2023-04-11 13:47:41 +02:00
Andrey Rakhmatullin
bdb78b9aa5
Merge pull request #5581 from felipeboffnunes/fix_post_processing_with_s3
...
Fix Feed Exporter issue with Post Processing
2023-04-11 15:06:11 +04:00
Felipe Boff Nunes
23017e6e92
adjust
2023-04-10 12:30:00 -03:00
Mojtaba Dashtinejad
98571eb946
Add missing slash in selecting dynamically-loaded content documentation ( #5890 )
2023-04-10 14:14:49 +02:00
Felipe Boff Nunes
a0e2e36b52
adjustments
2023-04-06 14:23:19 -03:00
Felipe Boff Nunes
0ffd1667ba
adjustments
2023-04-06 14:17:35 -03:00
Felipe Boff Nunes
dead39fd5f
Merge pull request #1 from Gallaecio/fix_post_processing_with_s3
...
Test the life cycle of a storage file
2023-04-06 13:47:34 -03:00
Samuel Bartlett
618e82dbe1
Exclude test for python versionbs less than 3.8
2023-03-31 15:12:47 +00:00
Samuel Bartlett
608b7de582
Skip new test if python version less than 3.8
2023-03-31 14:38:06 +00:00
Samuel Bartlett
c9a5934494
Reduce logging level of bad URL
2023-03-31 12:29:49 +00:00
Samuel Bartlett
4043560547
remove utf-8 encoding flag from test
2023-03-31 12:29:22 +00:00
Andrey Rakhmatullin
96033ce5a7
Merge pull request #5883 from sdidier-dev/patch-1
...
Add missing 'crawl' command in crawl examples ✏️
2023-03-31 14:47:52 +04:00
Sébastien DIDIER
6d94aa061c
Add missing 'crawl' command in crawl examples
2023-03-31 11:05:20 +02:00
Samuel Bartlett
00d93026c8
Fix bad test case
2023-03-31 08:30:19 +00:00
Samuel Bartlett
7cb7cf1ad1
Add link extractor back to test
2023-03-31 08:09:02 +00:00
Samuel Bartlett
9cbcf7724d
Add test to make sure spider doesn't crash on bad
2023-03-31 08:07:43 +00:00
Samuel Bartlett
9ef00c5c0b
Add logging Lines
...
Adds an error loggign line to the LinkExtractor to detail encountered
bad links
2023-03-31 08:01:54 +00:00
Samuel Bartlett
90ce6589ee
Add try/except to safe_url_string()
...
Added a try catch condition to the safe_url_string() processing
in the LxmlParserLinkExtractor class to avoid scrapers crashing
unneccessarily
2023-03-30 13:07:51 +00:00
Prathm-s
b83fa60a0a
return added to _sent_failed
2023-03-30 16:57:56 +05:30
Andrey Rakhmatullin
8045d7eaa5
Merge pull request #5851 from felipeboffnunes/extend_contributing
...
#5109 extend contributing.rst
2023-03-29 16:27:41 +04:00
Andrey Rakhmatullin
4249fc64d1
Merge pull request #5879 from xt1033/bugfix/updated-Makefile-to-enable-string-concatenation
...
Fixed Docs Makefile to open build/html/index.html in browser(#5878 )
2023-03-29 12:06:07 +04:00
karza_abhishek
46bb7b31d1
Fixed Docs Makefile to open build/html/index.html in browser( #5878 )
2023-03-28 23:23:32 +05:30
Andrey Rakhmatullin
4dacad0d8f
Merge pull request #5877 from jxlil/master
...
Fix: `Uncaught ReferenceError: analytics is not defined`
2023-03-28 14:05:47 +04:00
Jalil SA
2c31aa6c85
delete _template/layout.html
2023-03-28 01:12:19 -06:00
Jalil SA
c22c7bd82b
fix: rollback GA code
2023-03-27 20:41:19 -06:00
Felipe Boff Nunes
af730df83c
adjustments
2023-03-27 08:40:17 -03:00
Andrey Rakhmatullin
ada9173078
Don't call SSL_get_server_tmp_key() if not available ( #5858 )
2023-03-27 12:44:44 +02:00
Jalil SA
44cdaa442b
Update docs/topics/spiders.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-03-17 13:19:03 -06:00
Jalil SA
24f28c415c
fix: docs update_settings()
2023-03-17 12:16:08 -06:00
Jalil SA
a1fc37cbff
Update docs/topics/spiders.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-03-17 12:13:05 -06:00
Jalil SA
495372648c
fix: docs update_settings()
2023-03-16 23:14:57 -06:00
jazzthief
cb67bc17b7
Remove `botocore` from docs
2023-03-16 17:25:05 +01:00
jazzthief
4ebc08ef10
Switch from `is_boto3_available()` to `IS_BOTO3_AVAILABLE` var
2023-03-16 17:24:11 +01:00
jazzthief
a17d996da2
Change `boto3` version to 1.20.0 for `extra-deps-pinned` env
2023-03-16 17:20:22 +01:00
felipeboffnunes
7bcbfabdbc
forgot header bind
2023-03-16 10:28:12 -03:00
felipeboffnunes
a81fb5002b
adjustments, lean approach
2023-03-16 10:23:06 -03:00
felipeboffnunes
3e59b0805e
#5109 extend contributing.rst
2023-03-16 10:02:30 -03:00
namelessGonbai
6ab49e954f
Update docs/topics/feed-exports.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-03-16 18:03:06 +09:00
kenshi kikuchi
50801c7207
Fix Docs
2023-03-16 17:17:20 +09:00
kenshi kikuchi
c8ed793257
Fix test_export_no_items_multiple_feeds
2023-03-16 17:16:14 +09:00
Yegor Statkevich
ffef837a1f
Merge pull request #1 from Gallaecio/issue_960_s3_feed_export
...
Adapt tests for a switch to boto3 with botocore support for backward compatibility
2023-03-15 18:51:37 +03:00
Adrián Chaves
7e7b41c6b3
Fix test expectations for boto3
2023-03-15 16:38:13 +01:00
Adrián Chaves
590955fac8
Provide separate test environments for botocore and boto3 extras; add extra-deps-pinned and remote extras from pinned
2023-03-15 16:03:44 +01:00
Adrián Chaves
39dbfa1d82
Minimize test reliance on S3; do not install botocore on the default test environments
2023-03-15 15:31:39 +01:00
Adrián Chaves
dfbb63a2f1
Merge remote-tracking branch 'scrapy/master' into issue_960_s3_feed_export
2023-03-15 14:07:54 +01:00
auxsvr
d60b4edd11
Prevent an edge case that creates an extra event loop ( #5832 )
2023-03-14 09:31:13 +01:00
Alex
101a0c32d7
Support genspider with HTTPS ( #5808 )
2023-03-14 08:13:44 +01:00
Hugo van Kemenade
9411cf4e70
Replace deprecated BadZipfile with BadZipFile ( #5849 )
2023-03-13 19:03:41 +01:00
Mohammadtaher Abbasi
afafc2781a
Fix parse command issues with asyncio ( #5824 )
2023-03-10 16:20:15 +01:00
Andrey Rakhmatullin
3659a8c8d9
Merge pull request #5328 from GeorgeA92/per_slot_settings
...
Per slot settings
2023-03-09 22:31:24 +05:00
Jalil SA
96d51c3afa
docs: update
2023-03-08 04:21:21 -06:00
Jalil SA
1d862d0831
fix: remove line breaks
2023-03-08 03:26:38 -06:00
Jalil SA
05893e1796
docs: Spider.update_settings
2023-03-08 02:59:47 -06:00
kenshi kikuchi
d311779887
Fix FeedExporter
...
+ Fix FeedExporter not to export empty file
+ Change default value of FEED_STORE_EMPTY
2023-03-08 16:24:09 +09:00
Jalil SA
8aca47e25d
Add setdefault to BaseSettings ( #5821 )
2023-03-07 10:26:59 +01:00
Georgiy Zatserklianyi
218829b1db
per slot settings: typo fixed
2023-03-06 16:25:49 +02:00
Georgiy Zatserklianyi
be52fe4f67
Revert "periodic log stats: typo in docs fixed"
...
This reverts commit 68ba25cb69 .
2023-03-06 16:24:28 +02:00
Georgiy Zatserklianyi
68ba25cb69
periodic log stats: typo in docs fixed
2023-03-04 22:15:06 +02:00
Andrey Rakhmatullin
88eec7a417
Merge pull request #5801 from alexpdev/path_object_error_#5739
...
Support Path Objects Issue #5739
2023-03-04 22:01:24 +05:00
Alex
59f5250e59
Merge branch 'scrapy:master' into path_object_error_#5739
2023-03-03 16:47:08 -08:00
Oleg
2b3a8f0d69
Fix a typo in the LOG_FORMAT description ( #5839 )
2023-03-02 10:19:41 +01:00
Alex
78269f9a4f
Merge branch 'scrapy:master' into path_object_error_#5739
2023-02-25 20:49:04 -08:00
Andrey Rakhmatullin
8fbebfa943
Merge pull request #5805 from scrapy/mypy-imports
...
Handle typing issues hidden by follow_imports=skip
2023-02-24 14:57:59 +05:00
Andrey Rakhmatullin
2970b35cff
Merge remote-tracking branch 'origin/master' into mypy-imports
2023-02-24 02:35:09 +04:00
Andrey Rakhmatullin
3dd9d71c32
Correctly wrap connection errors into ResponseFailed.
2023-02-24 01:13:48 +04:00
Andrey Rakhmatullin
d20f278882
Add a link to the w3lib typing fix.
2023-02-24 00:28:24 +04:00
Andrey Rakhmatullin
d7bf39ee78
Fix a merge problem.
2023-02-24 00:28:06 +04:00
Andrey Rakhmatullin
3a40c06ed9
Bump mypy and types-*.
2023-02-24 00:16:49 +04:00
Andrey Rakhmatullin
733309affa
Don't assume formnumber can be None.
2023-02-24 00:05:59 +04:00
jazzthief
45b9dbae40
Fix a typo
2023-02-22 13:28:34 +01:00
Alex
7764184f4b
Merge branch 'scrapy:master' into path_object_error_#5739
2023-02-20 00:15:34 -08:00
Georgiy Zatserklianyi
864eee66c7
per_slot_settings(docs): code style fix 3 (from previous pre-commit check)
2023-02-16 18:19:36 +02:00
Georgiy Zatserklianyi
dd5524eb98
per_slot_settings(docs): code style fix 2 (from previous pre-commit check)
2023-02-16 17:59:36 +02:00
Georgiy Zatserklianyi
045092e8d7
per_slot_settings(docs): code style fix (from previous pre-commit check)
2023-02-16 17:55:59 +02:00
jazzthief
eb0cca471d
Apply pre-commit changes
2023-02-16 16:53:49 +01:00
Georgiy Zatserklianyi
07e1429877
per_slot_settings(docs): docs `:setting` bindings added
2023-02-16 15:14:01 +02:00
Georgiy Zatserklianyi
98a5958687
per_slot_settings(docs): per slot settings - the highest priority
2023-02-16 14:52:31 +02:00
Yegor
f45a7d3f3c
Remove `stacklevel` from warning
2023-02-15 17:07:55 +01:00
Yegor
29c2477f0a
Document the need to install boto3
2023-02-15 16:40:05 +01:00
Yegor
59ba3c4e4c
Use boto3's `upload_fileobj`
2023-02-15 16:29:06 +01:00
Yegor
c1a8baa1fa
Add forgotten import
2023-02-15 12:20:01 +01:00
Yegor
01ad49515d
Use boto3 session and client
2023-02-15 12:18:28 +01:00
Yegor
60bf56b715
Add boto3 availability util method
2023-02-15 12:15:24 +01:00
Andrey Rakhmatullin
c8547b0370
Merge pull request #5820 from alexpdev/coveragerc_disable_warnings
...
added disable_warnings instruction to .coveragerc
2023-02-15 03:28:35 +05:00
Alex
d366782187
Merge branch 'scrapy:master' into coveragerc_disable_warnings
2023-02-14 05:17:10 -08:00
Alex
c5fc4bbb1e
Merge branch 'scrapy:master' into path_object_error_#5739
2023-02-14 05:16:23 -08:00
Mark Brooks
874a879768
artwork/README.rst: add missing articles ( #5827 )
2023-02-14 09:42:43 +01:00
Andrey Rakhmatullin
76eba9977b
Skip or fix failing code block tests ( #5826 )
2023-02-14 09:40:38 +01:00
Andrey Rakhmatullin
a1717aa48c
Fix most of FormRequest typing issues.
2023-02-12 00:42:39 +04:00
Andrey Rakhmatullin
b7daa2624d
Remove a workaround for old lxml.
2023-02-11 23:46:33 +04:00
Andrey Rakhmatullin
fa9897282f
Add a cast to deferred_from_coro, that code path has different typing.
2023-02-11 22:12:16 +04:00
Andrey Rakhmatullin
824641e349
Merge remote-tracking branch 'origin/master' into mypy-imports
2023-02-11 22:02:19 +04:00
Andrey Rakhmatullin
b1f33a68ac
Bump mypy and types-*.
2023-02-11 21:39:27 +04:00
Alex
95c5ebbf38
Merge branch 'scrapy:master' into coveragerc_disable_warnings
2023-02-10 00:58:31 -08:00
Alex
f17d2e711d
Merge branch 'scrapy:master' into path_object_error_#5739
2023-02-10 00:56:51 -08:00
Georgiy Zatserklianyi
474087be6f
per_slot_settings(docs): settings 3
2023-02-09 14:52:28 +02:00
Georgiy Zatserklianyi
5208d436ae
per_slot_settings(docs): settings 2
2023-02-09 00:33:21 +02:00
Georgiy Zatserklianyi
c3033a54b1
per_slot_settings(docs): settings 1
2023-02-08 23:55:07 +02:00
Georgiy Zatserklianyi
80a86de507
per_slot_settings: test delays increased
2023-02-08 22:40:22 +02:00
Georgiy Zatserklianyi
13d1f69c78
Merge remote-tracking branch 'upstream/master' into per_slot_settings
...
# Conflicts:
# scrapy/core/downloader/__init__.py
2023-02-08 22:23:13 +02:00
Andrey Rakhmatullin
b9f52feaa7
Merge pull request #5816 from pankaj1707k/blacken-docs
...
Add pre-commit hook for 'blacken-docs'
2023-02-03 14:33:22 +05:00
pankaj1707k
03f32c018f
Update black version and fix minor typos and punctuations
2023-02-03 11:52:20 +05:30
Pankaj Kumar
280cd6ce71
Merge branch 'scrapy:master' into blacken-docs
2023-02-03 11:38:26 +05:30
Alex
eecc035f4c
correcting type hints
2023-02-02 11:27:40 -08:00
Alex
4692e0e16b
Merge branch 'master' into path_object_error_#5739
2023-02-02 11:10:01 -08:00
Mikhail Korobov
a08d722ae8
Merge pull request #5802 from Laerte/chore/deprecate-set-output
...
Simplify Publish workflow
2023-02-02 19:59:57 +05:00
Mikhail Korobov
1e01f29ac0
Merge pull request #5823 from Gallaecio/upgrade-ci
...
Upgrade CI tools
2023-02-02 19:37:33 +05:00
Laerte Pereira
4a424adfff
fix: action version
2023-02-02 09:21:53 -03:00
Laerte Pereira
12559ed21e
refactor: Publish workflow
2023-02-02 08:59:35 -03:00
pankaj1707k
7fdbbd3ccb
Fix for python 3.11 (docs) check on pull request
2023-02-02 15:52:22 +05:30
Adrián Chaves
32a01e32f3
Update pylint exceptions, and run pylint by default with tox
2023-02-02 06:52:01 +01:00
Adrián Chaves
b07d3f85a3
Upgrade CI tools
2023-02-02 06:37:40 +01:00
Adrián Chaves
426f3ebb7b
Fix typo: causes it be closed → causes it to be closed
2023-02-02 05:58:32 +01:00
Adrián Chaves
32bc8bd436
Merge remote-tracking branch 'scrapy/master' into issue5043-feed_export
2023-02-02 05:56:48 +01:00
Adrián Chaves
2f2bcb006d
Test stream detaching in CsvItemExporter
2023-02-02 05:55:59 +01:00
Adrián Chaves
c34ca4aef5
Bump version: 2.7.1 → 2.8.0
2023-02-02 04:55:31 +01:00
Adrián Chaves
068af85722
Add release notes for Scrapy 2.8 ( #5799 )
2023-02-02 04:54:02 +01:00
Alex
8c8894f4be
Apply black formatting to templates ( #5814 )
2023-02-02 04:42:47 +01:00
pankaj1707k
cc9eb3fa79
Format python console blocks using blacken-docs
...
Prepend '.. code-block:: pycon' to make python console blocks detectable by blacken-docs
2023-02-01 20:37:39 +05:30
pankaj1707k
c1bbb299d7
Add and run pre-commit hook 'blacken-docs'
...
Change python code snippets to begin with '.. code-block:: python' to be recognized by the hook for formatting. All snippets under '::' (rst literal blocks) are ignored.
2023-02-01 16:30:57 +05:30
Alex
349fc33cc7
added disable_warnings instruction to .coveragerc
2023-01-31 14:28:08 -08:00
Mikhail Korobov
b337c986ca
Merge pull request #5798 from Gallaecio/no-callback
...
Implement a NO_CALLBACK value for Request.callback
2023-01-31 01:06:49 +05:00
Adrián Chaves
78eaf0671b
Remove typing-extensions from tox.ini
2023-01-30 14:33:11 +01:00
Adrián Chaves
4239f7e12b
Merge remote-tracking branch 'Gallaecio/no-callback' into no-callback
2023-01-30 12:39:56 +01:00
Adrián Chaves
389fd99e79
get_media_requests: support and encourage callback=NO_CALLBACK
2023-01-30 12:37:34 +01:00
Adrián Chaves
e1699479f6
Fix typo: download middleware → downloader middleware
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2023-01-30 11:54:31 +01:00
Andrey Rakhmatullin
ccd1385e11
Merge branch 'master' into no-callback
2023-01-30 15:43:05 +05:00
Andrey Rakhmatullin
da15d93d39
Merge pull request #5806 from jxlil/master
...
Use isort
2023-01-30 15:40:44 +05:00
Adrián Chaves
17354a61b1
Avoid duplicities in CI; remove pylint from pre-commit
2023-01-30 10:04:27 +01:00
Jalil SA
5dcf8b9015
fix isort version
2023-01-29 00:22:56 -06:00
Andrey Rakhmatullin
80453d53b1
Type DeferredLists as Deferreds.
2023-01-28 01:29:09 +04:00
Jalil SA
4bd48d2613
added pre-commit action
2023-01-27 15:06:54 -06:00
Jalil SA
ef794251f6
fix scrapy/__init__.py
2023-01-27 15:00:19 -06:00
Jalil SA
e9ee9454f9
fix .isort.cfg
2023-01-27 14:59:08 -06:00
Andrey Rakhmatullin
5fa0f64db5
Ru typing on 3.8 as types-lxml isn't available for 3.7.
2023-01-27 23:29:23 +04:00
Andrey Rakhmatullin
c0efb271a2
Ignore typing for twisted.internet.reactor globally.
2023-01-27 23:19:44 +04:00
Andrey Rakhmatullin
30c0dc7ac5
Merge pull request #5807 from Cj-Malone/patch-1
...
Don't check robots.txt for local files
2023-01-28 00:03:15 +05:00
Adrián Chaves
f03b47db05
Make NO_CALLBACK a callable
2023-01-27 17:35:32 +01:00
Alex
a1e2fbafdc
applied black to tests
2023-01-26 16:46:08 -08:00
Alex
42af2bf1ad
updating branch
2023-01-26 16:43:23 -08:00
Alex
94161d101c
update
2023-01-26 16:41:06 -08:00
Cj Malone
33b85a9e2a
Test local files aren't processed
2023-01-26 19:51:20 +00:00
Cj Malone
3054235dc0
Don't check robotstxt for local files
2023-01-26 16:10:57 +00:00
Alex
5433015a25
Merge branch 'master' into path_object_error_#5739
2023-01-26 07:12:01 -08:00
Alex
0a21a9457b
fixed mypy typing error
2023-01-26 00:50:29 -08:00
Jalil SA
7f01e1f0ce
added isort to pre-commit-config
2023-01-25 14:43:25 -06:00
Jalil SA
a5c1ef8276
sort imports with isort
2023-01-25 14:25:15 -06:00
Jalil SA
6d0f9df8c1
added isort.cfg
2023-01-25 14:22:42 -06:00
Andrey Rakhmatullin
69bb9a7859
Install types-Pillow and types-Pygments.
2023-01-25 23:52:46 +04:00
Andrey Rakhmatullin
a4edff31b9
Replace lxml-stubs with types-lxml.
2023-01-25 23:30:21 +04:00
Andrey Rakhmatullin
e9094d1f38
Address remaining typing issues in scrapy.core.
2023-01-25 23:22:18 +04:00
Andrey Rakhmatullin
5fde6d5339
Don't type-check Twisted interfaces.
2023-01-25 22:54:46 +04:00
Andrey Rakhmatullin
764a9d47bb
Fix typing of inlineCallbacks-decorated functions.
2023-01-25 22:31:12 +04:00
Andrey Rakhmatullin
232aab53b3
Fix most of the new typing issues in utils.
2023-01-25 22:28:15 +04:00
Andrey Rakhmatullin
afd5d85320
Fix remaining issues in tests.
2023-01-25 22:15:10 +04:00
Andrey Rakhmatullin
2e33fb812b
Silence improper typing of twisted.internet.reactor in tests.
2023-01-25 22:15:07 +04:00
Andrey Rakhmatullin
c0ea7fd4fd
Remove obsolete top-level run code in tests.
2023-01-25 22:14:24 +04:00
Andrey Rakhmatullin
73f697f1db
Re-enable follow_imports.
2023-01-25 22:11:26 +04:00
Adrián Chaves
1f3e42897a
_NoCallback → NoCallbackType
2023-01-25 18:30:29 +01:00
Adrián Chaves
9d07be61b4
Merge remote-tracking branch 'Gallaecio/no-callback' into no-callback
2023-01-25 17:49:36 +01:00
Adrián Chaves
c883a13006
Make the _set_xback condition more readable
2023-01-25 17:43:10 +01:00
Adrián Chaves
9272c4af0c
Merge remote-tracking branch 'scrapy/master' into no-callback
2023-01-25 17:41:41 +01:00
Adrián Chaves
e71eab6932
Use black ( #5734 )
2023-01-25 12:03:46 +01:00
Alex
42e8d5a615
fixing type declerations
2023-01-25 01:03:27 -08:00
Alex
7c753adbe5
revert mypy fix didn't work
2023-01-24 23:05:17 -08:00
Alex
44512bebc8
fixed mypy warnings with type declaration for os.PathLike
2023-01-24 22:57:25 -08:00
Alex
84fb234cae
fixed additional trigger in FilesPipeline
2023-01-24 22:47:38 -08:00
Emmanuel Rondan
72a853c751
fixing contributing page with suggestions
2023-01-23 14:56:48 -03:00
Alex
085b340e8a
Merge branch 'scrapy:master' into path_object_error_#5739
2023-01-22 21:46:28 -08:00
Laerte Pereira
0cfe81d1d3
`set-output` command is deprecated
2023-01-21 16:57:31 -03:00
Emmanuel Rondan
f2c22aaabb
Merge remote-tracking branch 'upstream/master' into add-black-formatter
2023-01-20 17:08:07 -03:00
Emmanuel Rondan
8ee4817471
reaplying black, fixing conflicts and ignoring bandit checks on test directory
2023-01-20 10:55:46 -03:00
Andrey Rakhmatullin
9cb757d239
Merge pull request #5800 from Laerte/chore/feed-export-encoding
...
Set `FEED_EXPORT_ENCODING='utf-8'` in the default template
2023-01-20 17:47:43 +05:00
Adrián Chaves
818d69fa00
Fix typo: it → is
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2023-01-20 12:38:07 +01:00
Laerte Pereira
b611848029
fix(docs): Change `versionchanged` value
2023-01-20 08:35:17 -03:00
Laerte Pereira
973f0cf567
fix: line break
2023-01-20 08:23:05 -03:00
Laerte Pereira
8270df754d
Set `FEED_EXPORT_ENCODING='utf-8'` in the default template
2023-01-20 07:55:16 -03:00
Alex
b1dd893fbb
Support Path Objects Issue #5739
2023-01-20 02:17:02 -08:00
Adrián Chaves
4242ae405d
Restore Python 3.7 support
2023-01-19 20:37:24 +01:00
Adrián Chaves
5c1559f60e
Address typing issues
2023-01-19 20:30:22 +01:00
Adrián Chaves
a493464942
Update the screenshot pipeline code example
2023-01-19 19:53:53 +01:00
Tobias Mayr
f449ee5377
Fix SMTP STARTTLS for Twisted >= 21.2.0 ( #5406 )
2023-01-19 19:44:55 +01:00
Adrián Chaves
50500a6b28
Implement a NO_CALLBACK value for Request.callback
2023-01-19 17:14:18 +01:00
Emmanuel Rondan
23e8b553b4
fixing docs with suggestions
2023-01-18 11:46:12 -03:00
Emmanuel Rondan
482a0b79e3
explaining pre-commit on documentation
2023-01-17 14:26:12 -03:00
Serhii A
caaeb235a0
scrapy.utils.console.DEFAULT_PYTHON_SHELLS: OrderedDict → dict ( #5795 )
2023-01-17 12:52:41 +01:00
Andrey Rakhmatullin
2f12f5c259
Merge pull request #5790 from scrapy/ssl-legacy-reneg
...
Enable unsafe legacy renegotiation
2023-01-17 16:47:23 +05:00
Andrey Rakhmatullin
43ab8bd16a
Roll back the get_openssl_version() type change.
2023-01-13 20:51:07 +04:00
Andrey Rakhmatullin
fb52918d23
Set OP_LEGACY_SERVER_CONNECT to support some old servers when using OpenSSL 3.
2023-01-13 20:46:55 +04:00
Andrey Rakhmatullin
93ad6a4bc2
Simplify code for modern pyOpenSSL.
2023-01-13 20:39:44 +04:00
Andrey Rakhmatullin
4af5a06842
Merge pull request #5540 from Gallaecio/download-delay-documentation
...
Document how DOWNLOAD_DELAY affects per-domain concurrency
2023-01-13 13:00:15 +05:00
Andrey Rakhmatullin
74b8c34de6
Merge pull request #5458 from reidemeister94/fix/unique-list-link-extractors
...
fix: return unique_list only when link_extractor.unique is True
2023-01-13 01:13:45 +05:00
Andrey Rakhmatullin
f87d061069
Merge branch 'master' into download-delay-documentation
2023-01-13 00:22:48 +05:00
Andrey Rakhmatullin
604ddf82fc
Merge pull request #5758 from MattyMay/finish_exporting_for_each_start_exporting
...
Finish exporting for each start exporting
2023-01-13 00:17:17 +05:00
Andrey Rakhmatullin
2944894c4d
Merge pull request #5764 from jsoref/spelling
...
Spelling
2023-01-13 00:15:36 +05:00
Adrián Chaves
36b89a4b20
Remove trailing whitespace
2023-01-12 08:36:31 +01:00
silviopavanetto
faa5bd0f6b
Update scrapy/linkextractors/lxmlhtml.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2023-01-11 20:30:57 +01:00
spav
b386c64864
Fix tests for allowing duplicates in extract_links
2023-01-11 19:58:42 +01:00
spav
b0ec38876d
Fix docstring for extract_links specifying duplicates case
2023-01-11 19:32:33 +01:00
silviopavanetto
a70cbfe838
Merge branch 'scrapy:master' into fix/unique-list-link-extractors
2023-01-11 18:15:39 +01:00
Andrey Rakhmatullin
4a5ef81604
Merge pull request #5777 from Malkiz223/fix/http2_cookies
...
Fix overwriting repeated headers in HTTP2
2023-01-11 21:05:48 +05:00
Adrián Chaves
520be4ff0b
Merge remote-tracking branch 'scrapy/master' into fix/http2_cookies
2023-01-11 15:59:59 +01:00
Adrián Chaves
d9f6de6bf5
Add a test for receiving duplicate headers
2023-01-11 15:59:45 +01:00
Adrián Chaves
1ab900659e
Fix typo: finis → finish
2023-01-11 14:05:13 +01:00
Mikhail Korobov
3252097b37
Merge pull request #2918 from HarrisonGregg/fix/inspect-response-signal-handling
...
Fix SIGINT handling when using inspect_response
2023-01-11 17:24:04 +05:00
Andrey Rakhmatullin
90a52957e6
Merge pull request #5786 from Gallaecio/ci-pypy
...
Minimum cryptography: 3.3 → 3.4.6
2023-01-08 00:48:40 +05:00
Adrián Chaves
16546564f6
Minimum cryptography: 3.3 → 3.4.6
2023-01-06 20:16:54 +01:00
Adrián Chaves
724b033287
Fix CI issues related to asyncio ( #5782 )
2023-01-06 19:51:07 +01:00
Adrián Chaves
fd6742e811
Fix tests for pygments 2.14 ( #5783 )
2023-01-02 19:13:31 +01:00
Andrey Rakhmatullin
3e03004b3c
Merge pull request #5781 from Gallaecio/ci-clang
...
Remove Reppy from CI
2023-01-02 20:13:45 +05:00
Andrey Rakhmatullin
80d35a777d
Merge pull request #5780 from Gallaecio/ci
...
Fix test_pinned_twisted_version
2023-01-02 20:12:52 +05:00
Adrián Chaves
016d1de64e
Remove Reppy from CI
2023-01-02 14:13:04 +01:00
Adrián Chaves
6084e8f627
Do not use -U for pip in Tox
2023-01-02 14:00:37 +01:00
Adrián Chaves
e47ada2c7c
Add CC to tox.ini:[testenv]passenv
2023-01-02 13:49:25 +01:00
Adrián Chaves
c4d7f5e7a9
Use CLang to build Reppy
2023-01-02 13:41:08 +01:00
Laerte Pereira
deaf1fb6cf
Stop using setup.py ( #5776 )
2022-12-31 20:11:45 +01:00
Malkiz223
517ed0749b
Fix overwriting repeated headers
2022-12-31 00:51:43 +03:00
Emmanuel Rondan
1ebcd86c04
ignoring last changes made by black for blame
2022-12-29 12:51:05 -03:00
Emmanuel Rondan
c5cdd0d30c
reaplying black again and removing line length on pre-commit black config
2022-12-29 12:48:20 -03:00
Emmanuel Rondan
ef6eb48b2d
ignoring changes made by black
2022-12-29 11:27:41 -03:00
Emmanuel Rondan
303f0a70fc
re applying black to the code with default line length
2022-12-29 11:26:06 -03:00
Emmanuel Rondan
4ee09861cf
adding black check for tox on github workflow
2022-12-29 08:20:48 -03:00
Emmanuel Rondan
c48accf7ca
adding pre-commit with config
2022-12-26 13:51:27 -03:00
Emmanuel Rondan
12b556a352
Merge branch 'master' into add-black-formatter
2022-12-26 12:25:32 -03:00
Emmanuel Rondan
f5f2fc0ccd
returning to black default line length
2022-12-26 12:12:21 -03:00
Emmanuel Rondan
09dc4cf308
adding black to tox and defining line length on pyproject.toml
2022-12-22 16:11:21 -03:00
Steve Niafas
7ae32ea38d
Fix transparency for processed webp images ( #5767 )
2022-12-22 14:33:14 +01:00
Andrey Rahmatullin
8eb8b23b10
Merge pull request #5768 from KDreynolds/patch-1
...
Update setup.py
2022-12-21 23:41:42 +05:00
Kyle Reynolds
3b5ce4c182
Update setup.py
...
Sorry about the goof up.
2022-12-21 10:51:50 -07:00
Kyle Reynolds
2e54237649
Update setup.py
...
adding author_email to match_maintainer email for thoroughness' sake
2022-12-20 17:54:06 -07:00
Matt Mayfield
a0832081ba
Merge branch 'master' into finish_exporting_for_each_start_exporting
2022-12-19 18:12:02 -05:00
Matt Mayfield
0a84ce448c
Fix InstrumentedFeedSlot
...
I accidentally called the wrong super method in overriden
finish_exporting
2022-12-19 18:09:43 -05:00
Josh Soref
41734bb5c1
spelling: unencodeable
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:46:49 -05:00
Josh Soref
8a526d161c
spelling: user
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:46:11 -05:00
Josh Soref
2cb1e6668a
spelling: workaround
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
860fbef608
spelling: unknown
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
1e44d4614e
spelling: straight
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
010cf9d420
spelling: refresh
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
d27c611cc0
spelling: referrer
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
6aa5374bd3
spelling: received
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
826e0ee611
spelling: preexisting
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
66ab82f126
spelling: precedence
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
8ae77fdb34
spelling: pipeline
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
f5d024f16c
spelling: parsley
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
1a5cf00db7
spelling: overridden
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
a839b61147
spelling: nonexistent
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
5f33a64a02
spelling: middleware
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
fff2f2db20
spelling: measure
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
e894db2f3f
spelling: laziness
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
b62aacfee3
spelling: initializing
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
a26b6b0607
spelling: indistinct
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
b6426b8e03
spelling: heavily
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
e6ebadcd54
spelling: freshness
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
581eb2d1b4
spelling: downloader
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
87fc92441f
spelling: crawlable
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
1300c1c881
spelling: children
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 21:33:21 -05:00
Josh Soref
226c42ad14
spelling: canonicalize
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 20:26:42 -05:00
Josh Soref
334f844e58
spelling: and
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 20:26:42 -05:00
Josh Soref
f3c6bfdebe
spelling: accounting
...
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-12-18 20:26:42 -05:00
Andrey Rahmatullin
034dc8f10b
Merge pull request #5761 from yolile/patch-1
...
docs: change DOWNLOAD_DELAY description format
2022-12-16 01:03:53 +05:00
Yohanna Lisnichuk
b63ca6f834
docs: use the right notes directive
2022-12-15 13:20:45 -03:00
Yohanna Lisnichuk
96e526aad8
docs: change DOWNLOAD_DELAY description format
...
To be consistent with the other settings' descriptions
2022-12-15 10:01:55 -03:00
Andrey Rahmatullin
75450e75d2
Merge pull request #5760 from alexpdev/fix_shell_fetch_alt
...
set asyncio event loop at start of new thread
2022-12-15 10:22:01 +05:00
Alex
93ace91ace
Merge branch 'scrapy:master' into fix_shell_fetch_alt
2022-12-13 21:50:28 -08:00
Alex
c2de9372a2
added unittest for scrapy shell command and fixed flake8 error
2022-12-13 21:37:17 -08:00
Alex
8b09b0e0d7
set asyncio event loop at start of new thread
2022-12-13 20:41:48 -08:00
Andrey Rahmatullin
26ebdbf4ef
Merge pull request #5756 from Laerte/fix-test_follow_whitespace-tests
...
fix test_follow_whitespace_* tests
2022-12-12 23:49:23 +05:00
Matt Mayfield
40f4b262d2
Fix style errors
2022-12-12 12:36:29 -05:00
Matt Mayfield
0c1e547697
Merge branch 'master' into finish_exporting_for_each_start_exporting
2022-12-12 11:56:58 -05:00
Matt Mayfield
8d67a08155
Change test name and add additional tests
2022-12-12 11:55:42 -05:00
Matt Mayfield
66f127eb37
Make test cleaner and more reusable
2022-12-12 11:46:05 -05:00
Laerte Pereira
e099572cec
change xfail condition
2022-12-12 09:56:50 -03:00
Laerte Pereira
0dbd1d9b81
use xfail, switch to packaging to parse version
2022-12-12 08:58:40 -03:00
Laerte Pereira
e92e201b19
Silence `filelock` logger ( #5754 )
2022-12-12 11:55:15 +01:00
Matt Mayfield
087334009c
Call `finish_exporting` even when itemcount == 0
2022-12-11 23:12:41 -05:00
Laerte Pereira
6757973b61
fix test_follow_whitespace_* tests
2022-12-11 09:11:55 -03:00
Andrey Rahmatullin
fe60c1224e
Fix the name of the Proxy-Authorization header in release notes ( #5744 )
2022-12-05 11:44:39 +01:00
Emmanuel Rondan
1a3db81492
ignoring E203 flake8 error
...
ignoring implicit-str-concat pylint error
fixing pylint comment on test_request_cb_kwargs.py
2022-11-29 15:06:54 -03:00
Emmanuel Rondan
44160552ef
adding .git-blame-ignore-revs file to skip code changes made by black formatter on blame
2022-11-29 11:40:14 -03:00
Emmanuel Rondan
e211ec0aa2
adding black formatter to all the code
2022-11-29 11:30:46 -03:00
Andrey Rahmatullin
5bd27191a2
Bump mypy, flake8, and pylint ( #5738 )
2022-11-28 19:37:57 +01:00
Mark Mayo
f9a29f03d9
Address some issues reported by Pylint ( #5677 )
...
Co-authored-by: Felipe Boff Nunes <51033921+felipeboffnunes@users.noreply.github.com>
Co-authored-by: Andrey Rahmatullin <wrar@wrar.name>
2022-11-27 11:00:13 +01:00
Mikhail Korobov
e2db624204
Merge pull request #5682 from mdonoughe/pathlib
...
use pathlib
2022-11-26 13:42:36 +05:00
Andrey Rahmatullin
d19a216e10
Merge branch 'master' into pathlib
2022-11-25 18:20:25 +05:00
Andrey Rahmatullin
3be7aa9a0f
Merge pull request #5736 from wRAR/test-char-comment
...
Add a comment about `tmpname + '^'`.
2022-11-25 18:19:51 +05:00
Andrey Rakhmatullin
f85c3f3d68
Add a comment about `tmpname + '^'`.
2022-11-25 18:46:14 +06:00
Hanzallah Burney
b6e98ce6b6
Remove unnecessary backwards compatibility comments ( #5732 )
2022-11-24 15:01:15 +01:00
Andrey Rahmatullin
0417e3ede2
Merge pull request #5727 from JazzGlobal/Better-Language-Surrounding-Logging
...
Better language surrounding logging
2022-11-23 22:29:17 +05:00
Hanzallah Burney
f6e9e6592a
Cleanup settings._DictProxy and scrapy.telnet ( #5730 )
2022-11-23 15:48:34 +01:00
Andrey Rahmatullin
04a1a4b730
Merge pull request #5731 from Laerte/remove-noconnect-deprecate-code
...
Remove `noconnect` deprecate code
2022-11-23 18:19:01 +05:00
Laerte Pereira
e769532644
Remove `noconnect` deprecate code
2022-11-23 08:30:11 -03:00
Andrey Rahmatullin
45c2bd7d9c
Merge pull request #5150 from gustavo-bordin/master
...
changing dunder-str to dunder-repr
2022-11-23 13:12:06 +05:00
Andrey Rahmatullin
c3b1700774
Restore lost typing
2022-11-23 12:17:30 +05:00
Andrey Rahmatullin
1fdd0a70a0
Restore lost typing
2022-11-23 12:16:48 +05:00
Andrey Rahmatullin
b9c8db13c2
Merge pull request #5724 from Laerte/remove-scrapy_-env-variables-override
...
Remove support for override settings with `SCRAPY_` environment variables
2022-11-22 22:19:02 +05:00
Christopher Gambrell
bdc0bca5b1
Replace M occurrences with MiB for accuracy.
2022-11-22 12:10:49 -05:00
Christopher Gambrell
fc8968672a
renamed variables to clarify that we are using peak memory and not current memory utilization.
2022-11-22 11:49:28 -05:00
Laerte Pereira
1506479672
Remove deprecated test
2022-11-22 10:07:32 -03:00
Laerte Pereira
8e0025f53d
Remove support for override settings with `SCRAPY_` environment variables
2022-11-22 09:38:54 -03:00
Andrey Rahmatullin
aac6103179
Merge pull request #5722 from JazzGlobal/5717-memusage-logging-extension
...
Adds get_virtual_size to _check_limit Logging
2022-11-22 16:08:20 +05:00
Andrey Rahmatullin
603e42bc26
Merge pull request #5720 from Laerte/remove-filteringlinkextractor
...
Remove `FilteringLinkExtractor`
2022-11-22 13:54:43 +05:00
Christopher Gambrell
eb159c78f1
Use variable and convert to megabytes.
2022-11-22 03:36:00 -05:00
Christopher Gambrell
8f2adad7a7
Log self.get_virtual_size() on every call of _check_limit
2022-11-22 00:48:24 -05:00
Christopher Gambrell
24a18e9af1
Adds virtualsize property to _check_limit error log.
2022-11-21 17:41:06 -05:00
Andrey Rahmatullin
a60c120192
Merge pull request #5721 from pablohoffman/debug-vscode
...
doc: add instructions to debug Scrapy spiders in Visual Studio Code
2022-11-22 00:36:13 +05:00
Pablo Hoffman
c04ccbceb9
doc: add instructions to debug Scrapy spiders in Visual Studio Code
2022-11-21 15:49:33 +01:00
Laerte Pereira
1a6408c3fa
Remove `FilteringLinkExtractor`
2022-11-21 07:30:20 -03:00
Laerte Pereira
d5b6c236a9
Remove deprecated code ( #5719 )
2022-11-21 09:32:26 +01:00
GeorgeA92
042012f6bd
per slot settings: error calculation metho updated
2022-11-18 14:56:29 +02:00
GeorgeA92
12d52a4f08
per slot settings: code optimized
2022-11-18 14:16:18 +02:00
Andrey Rahmatullin
8f01a60c73
Merge pull request #5715 from islem-esi/main
...
minor fix for readability
2022-11-16 13:47:54 +05:00
islem-esi
1200a54543
minor fix for readability
2022-11-15 16:28:45 +01:00
Hassan Shoayb
29bf7f5a6c
broad-crawls.rst: fix a typo ( #5714 )
2022-11-14 09:45:00 +01:00
Laerte Pereira
ae3fd01729
Fix stray “commands” ( #5712 )
2022-11-10 15:38:46 +01:00
Andrey Rahmatullin
c56caaf0b7
Merge pull request #4753 from drs-11/3689-update
...
Do not recode JPEG files in imagepipelines
2022-11-07 20:36:22 +05:00
Andrey Rahmatullin
bbe24d79a5
Fix test issues
2022-11-07 17:08:54 +05:00
Andrey Rahmatullin
6c0890ff54
Simplify the changes after the merge
2022-11-07 16:36:54 +05:00
Andrey Rahmatullin
b03d84e9fb
Merge branch 'master' into 3689-update
2022-11-07 16:33:21 +05:00
Andrey Rahmatullin
77cd511a5e
Merge pull request #5489 from PluT00/deprecate-NoimagesDrop
...
Deprecate scrapy.pipelines.images.NoimagesDrop
2022-11-05 14:18:19 +05:00
srki24
a34b929a40
issues/5043 Detaching the stream
2022-11-04 18:00:17 +01:00
Andrey Rahmatullin
8004075823
Merge pull request #5699 from elacuesta/crawlspider-callback-keyword-arguments
...
CrawlSpider: pass cb_kwargs from process_request
2022-11-02 17:35:03 +05:00
Andrey Rakhmatullin
6ded3cf4cd
Bump version: 2.7.0 → 2.7.1
2022-11-02 17:00:47 +06:00
Andrey Rahmatullin
95880c5de1
Merge pull request #5701 from scrapy/relnotes-2.7.1
2022-11-02 15:42:52 +05:00
Andrey Rakhmatullin
5ec175b8bb
Small relnotes fixes.
2022-11-02 13:54:00 +06:00
Andrey Rakhmatullin
940a73863b
Release notes for 2.7.1.
2022-11-01 19:00:33 +06:00
Andrey Rahmatullin
a95a338eea
Merge pull request #5599 from tonal/patch-1
...
Partial in is_generator_with_return_value
2022-10-31 20:08:16 +05:00
Eugenio Lacuesta
b18560315b
Add tests
2022-10-30 18:28:16 -03:00
Eugenio Lacuesta
3259a42525
CrawlSpider: pass cb_kwargs from process_request
2022-10-30 13:17:37 -03:00
Andrey Rahmatullin
9077d0f9b4
Merge pull request #5698 from pankali/patch-1
...
Update Code of Conduct to Contributor Covenant v2.1
2022-10-28 12:51:38 +05:00
Andrey Rahmatullin
76c2cb070e
Merge pull request #5697 from iamkaushal/#5686_fix
...
added typing.io and typing.re in pytest warning filter to ignore
2022-10-28 11:38:55 +05:00
എതിരാളിക്കൊരു പോരാളി
9f45be439d
Update Code of Conduct to Contributor Covenant v2.1
2022-10-28 02:13:37 +02:00
iamkaushal
bd9e482c2f
added typing.io and typing.re in pytest warning filter to ignore
2022-10-27 23:21:55 +05:30
Magnus Offermanns
fd692f3091
Prevent running the -O and -t command-line options together ( #5605 )
...
Co-authored-by: Andrey Rakhmatullin <wrar@wrar.name>
2022-10-27 14:43:31 +02:00
Andrey Rakhmatullin
b71d0292d5
Add a test for processing partial callbacks.
2022-10-27 18:13:47 +06:00
Godson
3a34fa8399
Get the event loop from event_loop_policy to avoid a deprecation warning ( #5689 )
2022-10-27 14:02:12 +02:00
Andrey Rahmatullin
b654183084
Use Python 3.11 as the default in CI ( #5696 )
2022-10-27 14:00:36 +02:00
Andrey Rakhmatullin
ca50af6453
Remove an unused import.
2022-10-27 17:12:26 +06:00
Andrey Rahmatullin
5780ccba55
Merge branch 'master' into deprecate-NoimagesDrop
2022-10-27 15:46:32 +05:00
Mikhail Korobov
9fbd819b0e
Merge pull request #5695 from jidicula/patch-2
...
ci: Update macos runner
2022-10-27 12:45:43 +05:00
Andrey Rahmatullin
c20b76d98f
Merge branch 'master' into patch-1
2022-10-27 12:04:00 +05:00
Johanan Idicula
a214147359
ci: Update macos runner
...
The GitHub Actions macos-10.15 runner image is now deprecated, and GitHub
Actions has begun to temporarily fail jobs referencing it during brownout
periods. The image will be fully unsupported by 2022-12-01, which is just about
a month away.
This change updates the macOS runner image to the latest generally-available
version, to help reduce spurious CI failures during the brownout periods, and to
stay abreast of the sunsetting of the macos-10.15 image.
See also: actions/runner-images#5583
2022-10-26 21:44:47 -04:00
Andrei Andrukhovich
b394f2165a
Fix typo: [they] depends → depend ( #5694 )
2022-10-26 22:11:28 +02:00
Laerte Pereira
2464939b7e
Fixed deprecation warning in scrapy.core.engine ( #5589 )
...
* Change `download` function logic
* Fix CI error in 3.7 checks
* Make `spider` parameter optional in `_download` function, assign spider value from self if `None`
2022-10-26 23:58:20 +05:00
Mikhail Korobov
a1075b8979
Merge pull request #5626 from Gallaecio/more-lenient-proxying
...
Relax Proxy-Authorization restrictions
2022-10-26 23:36:29 +05:00
Adrián Chaves
46dd152b3e
Merge remote-tracking branch 'upstream/master' into more-lenient-proxying
2022-10-26 16:55:04 +02:00
Andrey Rahmatullin
92be5ba257
Merge pull request #5691 from Godson-Gnanaraj/5323-fix-unable-to-parse-decorated-method
...
Replace indentation of source before parsing with ast.
2022-10-26 12:47:08 +05:00
Godson-Gnanaraj
b0ddffc47b
Misc. changes:
...
- compile regex
- readability improvements
2022-10-26 06:53:43 +05:30
Godson-Gnanaraj
830e1c5dd8
Add test for parsing decorated methods
2022-10-26 01:26:54 +05:30
Kaushal Sharma
f4e2a10ed6
Image.ANTIALIAS → Image.Resampling.LANCZOS ( #5692 )
2022-10-25 11:45:46 +02:00
Godson-Gnanaraj
b61b71c6f0
Replace indentation of source before parsing with ast.
...
closes #5323
2022-10-25 08:54:16 +05:30
Matthew Donoughe
726680c712
change crawler_process to optional
2022-10-21 20:32:13 -04:00
Matthew Donoughe
28396c3497
convert _get_request_path back to str
2022-10-21 20:23:07 -04:00
Matthew Donoughe
69d1b8fc08
dirname cannot be falsey
2022-10-21 20:21:08 -04:00
Andrey Rahmatullin
b33244e2f0
Fix the flake8 per-file ignore syntax ( #5688 )
2022-10-21 16:17:04 +02:00
Matthew Donoughe
607eece72a
move to after check
2022-10-20 20:18:06 -04:00
Matthew Donoughe
12a26755ae
improve render_templatefile
2022-10-20 20:14:43 -04:00
Matthew Donoughe
24d6ac1f52
downgrade the last 3.9 type hints
2022-10-20 20:03:38 -04:00
Matthew Donoughe
c85de90819
fix path to tox.ini
2022-10-20 19:44:35 -04:00
Matthew Donoughe
065db7b566
fix some mypy issues
2022-10-19 08:28:26 -04:00
Matthew Donoughe
93d82648e5
resolve this path too
2022-10-19 08:08:21 -04:00
Matthew Donoughe
fb26e6b650
resolve path to search in error
2022-10-18 20:21:11 -04:00
Matthew Donoughe
7daf735f45
downgrade type hint syntax
2022-10-18 20:07:29 -04:00
Mikhail Korobov
82f25bc44a
Merge pull request #5681 from mattkohl-flex/master
...
Documentation: typo fixes
2022-10-18 15:27:52 +05:00
Matthew Donoughe
40d9ca3bdd
use pathlib
2022-10-17 17:40:10 -04:00
Andrey Rakhmatullin
20b79a0f2e
Bump version: 2.6.2 → 2.7.0
2022-10-17 19:09:22 +06:00
Adrián Chaves
06c8f673af
2.7 release notes ( #5680 )
...
* Fix the display name of documented fingerprinter class methods
* Initial draft for the Scrapy 2.7 release notes
* Update VERSION and PREVIOUS_VERSION references
* Clarify the restrictions lifted for item field output names
* Fix the description of the BOM bug fix
* Fix the note about changes in MIME sniffing
* Fix typo
* Extend highlights
* Fyx typo
2022-10-17 18:04:29 +05:00
mattkohl-flex
c49764ffd7
typo fixes
2022-10-17 11:15:17 +01:00
Andrey Rahmatullin
ea6315b404
Merge pull request #5679 from wRAR/template-asyncio-reactor
...
Change TWISTED_REACTOR in the default template.
2022-10-15 14:54:59 +05:00
Adrián Chaves
960a7f68f6
Verify that the installed asyncio event loop matches ASYNCIO_EVENT_LOOP ( #5529 )
...
Co-authored-by: Laerte Pereira <5853172+Laerte@users.noreply.github.com>
2022-10-15 11:27:00 +02:00
Adrián Chaves
75bb516edb
Adapt tests to the new value of TWISTED_REACTOR for new projects
2022-10-15 10:26:38 +02:00
Mohammadtaher Abbasi
043575123c
Add async callback support to the parse command ( #5577 )
2022-10-15 10:11:05 +02:00
Nirjas Jakilim
22a59d0005
CI: use the latest version of Ubuntu ( #5675 )
2022-10-14 19:41:50 +02:00
Andrey Rakhmatullin
62cc26e209
Change TWISTED_REACTOR in the default template.
2022-10-14 22:03:54 +06:00
gabrielztk
715c05d504
transport.producer.loseConnection() → transport.loseConnection() ( #4995 )
2022-10-13 12:22:10 +02:00
Laerte Pereira
da9a2f8a94
Remove mention of minimum PyPy versions from the documentation ( #5678 )
2022-10-12 16:10:39 +02:00
Mikhail Korobov
e4f6545fe9
Merge pull request #5665 from Abinashbunty/master
...
Update and rename INSTALL to INSTALL.md
2022-10-12 00:14:03 +05:00
Abdul Rauf
96fb663ae1
README: set Bash highlighting for pip install ( #5648 )
2022-10-11 19:34:18 +02:00
Derek
d12fcc555b
Link to the Code of Conduct ( #5659 )
2022-10-11 19:32:45 +02:00
Mikhail Korobov
1c7f3ebd75
Merge pull request #5674 from Nirzak/master
...
Updated setup-python and checkout actions workflow
2022-10-10 20:18:04 +05:00
Mikhail Korobov
f36d054a80
Merge pull request #5670 from scrapy/classifier-3.11
...
Add a classifier for Python 3.11.
2022-10-10 12:09:01 +05:00
Mikhail Korobov
767b4be508
Merge pull request #5668 from scrapy/update-tools
...
Update tool versions
2022-10-10 11:58:05 +05:00
Nirjas Jakilim
b792632046
updated setup-python and checkout workflow
2022-10-10 11:47:02 +06:00
Andrey Rakhmatullin
5bf4260679
Update flake8.
2022-10-10 11:14:20 +06:00
Andrey Rakhmatullin
eeb199adda
Fix flake8 issues in previously ignored files.
2022-10-10 11:10:59 +06:00
Andrey Rakhmatullin
5fa613b419
Run flake8 directly.
2022-10-10 11:04:00 +06:00
Mikhail Korobov
1197a94557
Merge pull request #5672 from wRAR/ci-libxml
...
Remove a pin on libxml2-dev.
2022-10-10 01:54:13 +05:00
Andrey Rakhmatullin
92f2d75ed3
Add a classifier for Python 3.11.
2022-10-08 19:12:32 +06:00
Andrey Rakhmatullin
ed9bc84d55
Remove a pin on libxml2-dev.
2022-10-08 19:11:16 +06:00
Mikhail Korobov
1b11f70cc0
Merge pull request #5667 from wRAR/ci-pypy
...
Simplify the PyPy installation in CI
2022-10-08 02:21:49 +05:00
Andrey Rakhmatullin
d1515cc075
Update pylint.
2022-10-07 15:30:44 +06:00
Andrey Rakhmatullin
ccb6a8c098
Add a note about flake8.
2022-10-07 15:27:14 +06:00
Andrey Rakhmatullin
424849b275
Update mypy.
2022-10-07 15:17:55 +06:00
Andrey Rakhmatullin
4aea925714
Update action versions.
2022-10-07 15:01:50 +06:00
Andrey Rakhmatullin
300c42bfdf
Install PyPy using actions/setup-python.
2022-10-07 14:53:19 +06:00
Andrey Rahmatullin
2f6e8e26d6
Merge pull request #5664 from wRAR/ci-3.11
...
Python 3.11 support
2022-10-07 12:05:11 +05:00
Abinash Satapathy
e60e8224a2
Update and rename INSTALL to INSTALL.md
2022-10-06 19:58:48 +02:00
Andrey Rakhmatullin
fa58ab21e4
Replace _getargspec_py23() with inspect.getfullargspec().
2022-10-06 20:59:06 +06:00
Andrey Rakhmatullin
82d10f0914
Add Ubuntu tests for Python 3.11rc2.
2022-10-06 20:27:06 +06:00
Andrey Rahmatullin
d96c465dde
Merge pull request #5639 from Laerte/fix/test_batch_path_differ
...
fix: `batch_path_differ` test
2022-10-05 14:44:30 +05:00
Andrey Rahmatullin
28d65c88b1
Merge pull request #5662 from gliptak/pyopenssl1
...
Match pyOpenSSL and types-pyOpenSSL versions
2022-10-04 12:54:30 +05:00
Mikhail Korobov
019e1c3c5e
Merge pull request #5645 from gliptak/version1
...
Correct distutils deprecation warning
2022-10-04 11:12:04 +05:00
Andrey Rahmatullin
125d0fcb8b
Merge pull request #5649 from oscard0m/patch-1
...
ci(tests-windows): upgrade actions/setup-python to v4
2022-10-03 17:13:05 +05:00
Andrey Rahmatullin
94f5737169
Merge pull request #5650 from oscard0m/patch-2
...
ci(tests-windows): upgrade actions/checkout to v3
2022-10-03 17:12:47 +05:00
Andrey Rahmatullin
029591616c
Merge pull request #5651 from oscard0m/patch-3
...
ci(test-macos): upgrade actions/checkout to v3
2022-10-03 17:12:35 +05:00
Andrey Rahmatullin
c962dae420
Merge pull request #5652 from oscard0m/patch-4
...
ci(test-macos): upgrade actions/setup-python to v4
2022-10-03 17:11:52 +05:00
Andrey Rahmatullin
a193d14af2
Merge pull request #5657 from elacuesta/crawlspider-support-async-def-callback
...
CrawlSpider: add support for async callbacks
2022-10-03 17:09:53 +05:00
Andrey Rahmatullin
2d1c0552f5
Merge pull request #5656 from armujahid/twinecheck
...
CI: add Twine check in check workflow
2022-10-03 17:00:35 +05:00
Andrey Rahmatullin
a7f916b96f
Merge pull request #5661 from felipeands/refact/improve-code-base
...
refact: add Osx DS_Store file to gitignore
2022-10-03 16:54:16 +05:00
Felipe A
41041ae740
refact: add Osx DS_Store file to gitignore
2022-10-03 00:48:12 -03:00
Eugenio Lacuesta
da8f915091
Adapt for asyng generator callbacks
2022-10-02 17:37:10 -03:00
Mikhail Korobov
4f296b61b0
Merge pull request #5608 from zaid-ismail031/master
...
Changed incorrect info in documentation regarding the return type of parse method.
2022-10-03 00:19:08 +05:00
Eugenio Lacuesta
80194f1c03
CrawlSpider: add support for async def callbacks
2022-10-02 15:22:06 -03:00
Abdul Rauf
69bf5c6625
CI: move twinecheck to tox env
2022-10-02 20:27:24 +05:00
Abdul Rauf
c7d800ab22
CI: add Twine check in check workflow
2022-10-02 19:12:48 +05:00
Gábor Lipták
759ad5dee4
Require packaging
2022-10-02 09:09:04 -04:00
Oscar Dominguez
af95331296
ci(test-macos): upgrade actions/setup-python to v4
2022-10-01 20:27:23 +02:00
Oscar Dominguez
1a2cb61e22
ci(test-macos): upgrade actions/checkout to v3
2022-10-01 20:27:10 +02:00
Oscar Dominguez
9fcbf3bcbc
ci(tests-windows): upgrade actions/checkout to v3
2022-10-01 19:38:16 +02:00
Oscar Dominguez
c3f35d2ad7
ci(tests-windows): upgrade actions/setup-python to v4
2022-10-01 19:37:51 +02:00
Gábor Lipták
116d9a9748
Correct distutils deprecation warning
...
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
2022-09-30 22:58:17 -04:00
Gábor Lipták
9f006e3aa5
Match pyOpenSSL and types-pyOpenSSL versions
...
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
2022-09-30 22:27:57 -04:00
Laerte Pereira
3ca7877781
chore: Skip `batch_path_differ` test on Windows
2022-09-29 11:51:50 -03:00
Mikhail Korobov
1445ebd229
Merge pull request #5641 from Gallaecio/2.6.3-release-notes-for-master
...
Copy 2.6.3 release notes from the 2.6 branch
2022-09-27 20:53:56 +05:00
Adrián Chaves
1d79994dcc
Copy 2.6.3 release notes from the 2.6 branch
2022-09-27 17:01:33 +02:00
Mikhail Korobov
07b079defd
Merge pull request #5634 from gliptak/tls1
...
Cleanup METHOD_SSLv3
2022-09-26 18:19:05 +05:00
Gábor Lipták
79a4bc3da0
Cleanup METHOD_SSLv3
...
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
2022-09-25 17:01:43 -04:00
Mikhail Korobov
14b1565285
Merge pull request #5632 from gliptak/ssl1
...
Match pyOpenSSL and service_identity to Twisted
2022-09-25 23:06:45 +05:00
Gábor Lipták
385acd5598
Match pyOpenSSL and service_identity to Twisted
...
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
2022-09-24 21:33:02 -04:00
Tim B
5f19420211
Documented how settings must be picklable ( #5629 )
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Laerte Pereira <5853172+Laerte@users.noreply.github.com>
2022-09-21 08:27:27 +02:00
Gábor Lipták
1429aa011c
Update test-standard link in contributing docs ( #5631 )
2022-09-20 18:47:20 +02:00
Mikhail Korobov
681d114e21
Merge pull request #5624 from magsen/master
...
fix: typo in tutorial
2022-09-14 20:40:49 +05:00
Adrián Chaves
77c055ee28
Relax Proxy-Authorization restrictions
2022-09-14 14:47:14 +02:00
Magsen (CD)
ce0ca51485
fix: typo in tutorial
...
fix: typo in tutorial
2022-09-13 12:07:58 +02:00
Mikhail Korobov
90b8503789
Merge pull request #5611 from mtabbasi/issue-5601
...
BOM should take precedence over Content-Type header when detecting the encoding
Fixes GH-5601.
2022-09-13 15:07:50 +05:00
zaid-ismail031
3cf97e4e20
Merge branch 'master' of https://github.com/scrapy/scrapy
2022-09-11 22:44:28 +02:00
Andrey Rahmatullin
3f060aeb56
Merge pull request #5617 from Laerte/fix/tests-w3lib
...
Fix failed tests related to w3lib
2022-09-07 12:52:41 +05:00
Laerte Pereira
582a6bf6db
refactor: Use `safe_url_string` to standardize url output
2022-09-06 10:03:18 -03:00
Laerte Pereira
1289422284
chore: Skip `test_ipv6_default_name_resolver` test if w3lib version >= 2.0.0
2022-09-06 08:17:58 -03:00
Laerte Pereira
f4bcc3e67d
fix: failed tests
2022-09-06 01:15:41 -03:00
Mohammadtaher Abbasi
a988c4b78b
add test
2022-08-29 17:08:30 +04:30
Mohammadtaher Abbasi
e411ea94eb
BOM should take precedence over Content-Type header when detecting the encoding closes #5601
2022-08-28 20:28:13 +04:30
zaid-ismail031
c49b5aaf77
Changed incorrect information regarding the return type of parse/request callback method.
2022-08-26 21:17:31 +02:00
Alexandr N. Zamaraev
13c5ad7e68
Partial in is_generator_with_return_value
...
See path in #5592
2022-08-16 11:03:37 +07:00
GeorgeA92
aabdd0b657
per slot settings: logger deleted as not used (step 2)
2022-08-12 15:34:48 +03:00
Mikhail Korobov
52d93490f5
Merge pull request #4978 from wRAR/asyncio-parse-asyncgen-proper-rebased
...
Support for async callbacks
2022-07-30 00:34:37 +05:00
Adrián Chaves
d599fff2b9
Test the life cycle of a storage file
2022-07-29 19:12:20 +02:00
GeorgeA92
4be9c969fd
per slot settings: logger deleted as not used
2022-07-29 12:15:39 +03:00
felipeboffnunes
5735e93541
fix_post_processing_feed_export
2022-07-28 18:37:21 -03:00
Andrey Rakhmatullin
c7b90c6e1e
Extract more common code.
2022-07-28 13:44:36 +05:00
Andrey Rahmatullin
0f1112f3e2
Update docs/index.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2022-07-27 23:12:43 +05:00
Andrey Rahmatullin
83ecdf1bca
Update docs/topics/components.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2022-07-27 23:12:31 +05:00
Andrey Rahmatullin
faa12d1fbe
Merge pull request #2 from scrapy/asyncio-parse-fixes
...
Asyncio parse fixes
2022-07-27 12:30:09 +05:00
Aftab Alam
67011cd957
updated README.rst , added hyperlink to banner ( #5284 )
...
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2022-07-27 09:50:26 +05:00
Mikhail Korobov
56e2eeac10
fix typing issues by upgrading mypy
2022-07-27 09:41:12 +05:00
Mikhail Korobov
4dde2f2c36
Merge branch 'master' into asyncio-parse-fixes
2022-07-27 09:32:54 +05:00
Adrián Chaves
5862f6b8e1
Update frozen CI packages ( #5574 )
2022-07-25 17:25:10 +02:00
Adrián Chaves
737f39613c
Merge pull request #5573 from Gallaecio/2.6-into-master
...
Merge 2.6 into the main branch
2022-07-25 14:52:39 +02:00
Adrián Chaves
00ccb02f1f
Merge remote-tracking branch 'upstream/2.6'
2022-07-25 14:13:22 +02:00
Adrián Chaves
aecbccbaa5
Bump version: 2.6.1 → 2.6.2
2022-07-25 13:33:23 +02:00
Adrián Chaves
af7dd16d8d
Merge pull request from GHSA-9x8m-2xpf-crp3
...
* Enforce matching proxy request meta and Proxy-Authorization header
* Cover proxy credential security fix in the release notes
* Remove extra empty line
* Reword the security issue description
* Address scenario where Proxy-Authorization is unexpectedly removed by a prior middleware
* Set the release date of Scrapy 2.6.2 and 1.8.3
2022-07-25 13:15:17 +02:00
Andrey Rakhmatullin
b21c16099e
Fix flake8 issues.
2022-07-22 19:18:33 +05:00
Andrey Rahmatullin
a0681fb811
Merge branch 'master' into asyncio-parse-asyncgen-proper-rebased
2022-07-22 18:30:38 +05:00
Andrey Rahmatullin
dc67100a8f
Merge pull request #1 from Gallaecio/asyncio-parse-asyncgen-proper-rebased
...
Refactor the asynchronous process_spider_output documentation
2022-07-22 18:28:56 +05:00
Mikhail Korobov
4205609051
Fixed intersphinx references
2022-07-21 18:02:56 +02:00
Mikhail Korobov
f60c7ae768
Fixed heading levels in downloader middleware docs ( #5567 )
2022-07-20 11:01:22 +02:00
Mikhail Korobov
d78f505f3d
Merge pull request #5450 from kinoute/master
...
fixed detection of extensions like ".tar.gz" in URL
2022-07-20 01:06:11 +05:00
Mikhail Korobov
b103664bf4
Address 2/3 of warnings from tests ( #5561 )
2022-07-19 17:39:26 +02:00
Andrey Rahmatullin
44580851ff
Merge pull request #5560 from scrapy/non-existing-resolvable
...
make Scrapy testing suite more robust in environments where non-existing hosts are resolvable
2022-07-19 11:28:38 +05:00
Andrey Rahmatullin
bb61b03b49
Merge pull request #5563 from scrapy/dataclasses-ftw
...
remove compatibility code from tests for the case dataclasses module is not available
2022-07-19 10:37:20 +05:00
Mikhail Korobov
1054689593
remove unused imports
...
thanks flake8!
2022-07-18 23:53:30 +05:00
Mikhail Korobov
e248360e6e
remove compatibility code from tests for the case dataclasses module is not available
...
It was Python 3.6 compat code, and Python 3.6 support is dropped.
2022-07-18 23:49:08 +05:00
Andrey Rahmatullin
3ef432156c
Merge pull request #5559 from scrapy/fix-intersphinx
...
Fixed intersphinx references
2022-07-17 22:15:10 +05:00
Mikhail Korobov
26c70318cb
make Scrapy testing suite more robust in environments where non-existing hosts are resolvable
2022-07-17 16:47:20 +05:00
Mikhail Korobov
9b33b82a8b
Fixed intersphinx references
2022-07-17 15:50:40 +05:00
Andrey Rahmatullin
ebc6f9c4eb
Merge pull request #5558 from eltociear/patch-1
...
Fix typo in sep-014.rst
2022-07-17 01:12:16 +05:00
Mikhail Korobov
77a3b02523
Merge pull request #5553 from Rotzbua/fix-doc-typo
...
Fix doc: `scrapy.exporter` to `scrapy.exporters`
2022-07-17 00:21:50 +05:00
Mikhail Korobov
94a0324570
Merge pull request #5554 from Rotzbua/doc-remove-outdated
...
[doc] Remove incompatible web service project
2022-07-17 00:20:32 +05:00
Ikko Ashimine
2f13f23d92
Fix typo in sep-014.rst
...
requets -> requests
2022-07-15 18:16:23 +09:00
silviopavanetto
a6c339edf5
Merge branch 'scrapy:master' into fix/unique-list-link-extractors
2022-07-13 10:10:25 +02:00
Rotzbua
1c7ed4f2e5
[doc] Remove incompatible web service project
...
* Abandoned since 2017
* Not compatible with Python3
2022-07-12 13:09:20 +02:00
Rotzbua
09c3a4ad08
Fix doc: `scrapy.exporter` to `scrapy.exporters`
2022-07-12 12:45:15 +02:00
Mikhail Korobov
49942026d8
Merge pull request #5547 from Laerte/master
...
Deprecate the `scrapy.downloadermiddlewares.decompression` module
2022-07-05 12:44:25 +05:00
Laerte Pereira
fe08a119d9
chore: import only used function
2022-06-30 10:46:00 -03:00
Laerte Pereira
c4c816624f
chore: Deprecate the `scrapy.downloadermiddlewares.decompression` module
2022-06-30 10:42:01 -03:00
Mikhail Korobov
b51b52ff37
Merge pull request #5526 from mtabbasi/headers-multiple-values
...
Merge values of multiple headers with same name
2022-06-27 23:03:01 +05:00
Mikhail Korobov
500dae82e2
Merge pull request #3696 from Gallaecio/allow-customizing-export-column-names
...
Allow customizing export column names
2022-06-27 00:26:05 +05:00
Mikhail Korobov
7120c3df33
Merge pull request #5542 from cyai/cyai-patch-2
...
MAINT: Updated f-string format
2022-06-26 23:46:26 +05:00
Vardhaman
387326fad4
MAINT: Updated f-string format
...
Updated the code with the f-string method for better and cleaner understanding.
2022-06-23 14:40:49 +05:30
Adrián Chaves
34e4ed72ea
Document how DOWNLOAD_DELAY affects per-domain concurrency
2022-06-21 12:46:54 +02:00
Emanuele
d8223adfac
Typo: cleanup (verb) → clean up ( #5538 )
2022-06-20 11:54:05 +02:00
Adrián Chaves
e3e69d1209
Pin documentation requirements ( #5536 )
2022-06-20 11:46:13 +02:00
Adrián Chaves
54bfb9649b
Cover #5525 in the 2.6.2 release notes ( #5535 )
2022-06-17 11:51:02 +02:00
Adrián Chaves
4ef71829b2
If TWISTED_REACTOR is None, reuse any pre-installed reactor ( #5528 )
2022-06-17 10:37:27 +02:00
Adrián Chaves
ec5cf3e9ce
test_feedexport: solve ordered comparison issues
2022-06-17 09:10:18 +02:00
Adrián Chaves
bc285f393c
Revert "Revert "test_feedexport: remove ordered=False""
...
This reverts commit 516e2d6ec0 .
2022-06-17 09:00:39 +02:00
Adrián Chaves
516e2d6ec0
Revert "test_feedexport: remove ordered=False"
...
This reverts commit 24f382fa45 .
2022-06-17 08:55:45 +02:00
Michel Ace
6e878490e8
Support and prefer the .jsonl file extension ( #4848 )
2022-06-17 08:37:14 +02:00
Adrián Chaves
3729c6d266
Remove unused import and redundant import
2022-06-17 08:33:34 +02:00
Adrián Chaves
24f382fa45
test_feedexport: remove ordered=False
2022-06-17 08:31:45 +02:00
Adrián Chaves
1b9ed22bec
Remove Python < 3.7 leftover
2022-06-17 08:27:17 +02:00
Adrián Chaves
3e994bda45
Update for Python 3.7+
2022-06-16 20:53:14 +02:00
Kromitvs
9e265a2c1f
Mind body to choose response class in cache, FTP and HTTP/1.0 ( #4873 )
2022-06-16 20:52:19 +02:00
Adrián Chaves
e8503217fb
Merge remote-tracking branch 'upstream/master' into allow-customizing-export-column-names
2022-06-16 20:19:52 +02:00
Mohammadtaher Abbasi
892c2a4655
delete unnecessary test
2022-06-13 23:46:42 +04:30
Mohammadtaher Abbasi
a135d6caf0
Move Mapping import line up
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2022-06-13 15:24:30 +04:30
Mikhail Korobov
de0e2ccd7b
Merge pull request #5451 from FJMonteroInformatica/master
...
make test files follow HTML conventions
2022-06-12 00:46:45 +05:00
Mohammadtaher Abbasi
6a0bcf97cc
Merge values of multiple headers with same name ( #5515 )
2022-06-11 23:52:21 +04:30
Mohammadtaher Abbasi
ddfd192b70
add tests for multiple headers with same name
2022-06-11 23:51:34 +04:30
Mikhail Korobov
e2769cfe48
Merge pull request #5524 from Laerte/master
...
Remove minimal versions that Scrapy is tested against, cleanup
2022-06-09 22:07:46 +05:00
Laerte Pereira
197aca2c94
docs: Remove leftover
2022-06-09 10:11:49 -03:00
Laerte Pereira
c4c5c9f258
docs: Remove minimal versions paragraphs
2022-06-09 10:00:44 -03:00
Laerte Pereira
6770d1ec62
chore(tests): Remove validations for unsupported modules versions
2022-06-09 09:08:09 -03:00
Laerte Pereira
2e6721fd86
docs: Update minimal versions that Scrapy is tested against
2022-06-09 08:37:01 -03:00
Laerte Pereira
407562b38b
Drop Python 3.6 support ( #5514 )
...
* chore: Drop Python 3.6 support
* Attend PR comments
* Tweak versions
* Update dependencies version
* fix: Ubuntu workflow
* fix windows workflow
* chore: Remove comment
* update `install_requires` dependencies versions
* move lxml to main pinned requirements
* Attend code-review comments
* remove non-pinned 3.7 from windows workflow
* simplify condition
* lint
* remove paragraph
* refactor
* remove leftover
2022-06-09 00:25:03 -03:00
Adrián Chaves
c5627af15b
Centralize request fingerprints ( #4524 )
...
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2022-06-07 18:44:54 +02:00
Mikhail Korobov
517cbc8d71
Merge pull request #5508 from mtabbasi/thumb_path-access-item
...
pass on item to thumb_path function as additional argument
2022-06-05 03:42:45 +05:00
Mikhail Korobov
bafe874ecc
Merge pull request #5358 from burakcank/signal_coroutine
...
Document coroutines for signals.
2022-05-28 13:38:05 +05:00
Mikhail Korobov
99cddecd28
Merge pull request #5497 from AngelikiBoura/issue_3264/command_parser_unhandled_error
...
Issue #3264 , fix error handling when spider is not matched
2022-05-28 13:26:23 +05:00
Eugenio Lacuesta
2c65066ad9
Avoid exceptions on copy
2022-05-27 19:56:42 -03:00
Eugenio Lacuesta
1b1d518e2b
Merge remote-tracking branch 'upstream/master' into case-insensitive-dict
2022-05-27 18:45:10 -03:00
Mohammadtaher Abbasi
896f16f2de
make thumb_path method backwards compatible
2022-05-25 23:59:25 +04:30
Mohammadtaher Abbasi
5c586d78f0
add tests
2022-05-25 23:58:09 +04:30
Mohammadtaher Abbasi
f39def4492
add docs
2022-05-25 23:57:38 +04:30
Mohammadtaher Abbasi
8633190012
pass on item to thumb_path function as additional argument resolves #5504
2022-05-24 14:51:17 +04:30
Andreas Tziortziortziopoulos
b5c15d87ff
[issue3264] Separate test for not matched spider to a url
2022-05-22 12:19:20 +03:00
Maxime Nannan
078622cfb0
Fix file expiration issue with GCS ( #5318 )
2022-05-20 08:30:06 +02:00
Andrey Rahmatullin
965fde24a4
Pin mitmproxy to < 8 for now ( #5459 )
2022-05-20 07:17:09 +02:00
Adrián Chaves
1c1cd5d8ea
Update the 2.6.2 release notes
2022-05-20 07:05:26 +02:00
Adrián Chaves
84c29a286f
Unset the release date of still-unreleased 2.6.2 ( #5503 )
2022-05-20 06:45:38 +02:00
Eugenio Lacuesta
1c031b8a8d
Underscore CaseInsensitiveDict normkey/normvalue
2022-05-12 13:10:08 -03:00
Eugenio Lacuesta
7297ae566f
Merge remote-tracking branch 'upstream/master' into case-insensitive-dict
2022-05-12 12:43:41 -03:00
GeorgeA92
0ffc52a491
per slot settings: test added (delays for each download slots)
2022-05-11 10:40:12 +03:00
GeorgeA92
2006060688
per slot settings: codestyle(flake8) fix, code line length
2022-05-11 10:29:53 +03:00
Andreas Tziortziortziopoulos
83c1939281
Issue #3264 , fix error handling when spider is not matched
...
Changes
Implementation:
- Check whether Spider exists or is None, and if it's None skip execution of start_requests() with non existing Spider
Testing:
- Add a test case with invalid url inside test_command_parse
Test proves that non-matched Spider does not throw an AttributeError
2022-05-06 03:59:30 +03:00
AngelikiBoura
b2afcbfe2b
Fix typos in three files for Flake8 check ( #5487 )
...
* Fix typos in extensions files
Made some fixes in files memusage.py and statsmailer.py
in order to pass the flake8 check.
* Fix typos in twisted_reactor_custom_settings_same.py
A small change was needed in order for flake8 check
to pass.
2022-05-05 15:49:52 +02:00
PluT00
cc16af35af
Add deprecation warning test for scrapy.pipelines.images.NoimagesDrop
2022-05-03 11:29:21 +03:00
PluT00
9f659bd63c
Fix deprecation of scrapy.pipelines.images.NoimagesDrop
2022-05-01 14:26:03 +03:00
PluT00
7de9ed5bd4
Deprecate scrapy.pipelines.images.NoimagesDrop
2022-05-01 01:34:35 +03:00
Andrey Rahmatullin
b9b9422bb1
Merge pull request #5482 from alexpdev/parse_help_msg
...
Fix TypeError in parse command
2022-04-29 11:10:15 +05:00
Alex
915c288205
edit
2022-04-24 15:17:48 -07:00
Alex
56c9098d6a
changed default depth to 1
2022-04-24 15:17:48 -07:00
Alex
b0f5503cb8
Fixes Issue #5481
2022-04-24 15:17:48 -07:00
Alex
636127ec1e
tests that all CLI help messages don't throw errors
2022-04-22 16:32:58 -07:00
Andrey Rahmatullin
ded28f7bb9
Merge pull request #5461 from yash-fn/patch-1
...
documentation update for multiple spiders
2022-04-15 14:39:26 +05:00
Adrián Chaves
aead27bcbd
Add release notes for 2.6.2 ( #5448 )
2022-04-14 15:06:22 +02:00
Yash
319e67f779
documentation update for multiple spiders
...
i noticed passing settings to configure logging function made weird output go away. checked documentation and it says first parameter is settings file. Is this correct?
2022-04-12 11:42:22 -05:00
Andrey Rahmatullin
fa4c85f4ec
Merge pull request #5471 from Gallaecio/2.6-release-notes-request-serialization
...
2.6 release notes request serialization
2022-04-08 18:14:50 +05:00
Adrián Chaves
bae3f87455
Cover a backward-incompatible Request serialization change in the 2.6 release notes
2022-04-08 12:04:02 +02:00
Andrey Rahmatullin
4af22bf157
Pin mitmproxy to < 8 for now ( #5459 )
2022-04-08 11:26:23 +02:00
Andrey Rahmatullin
35b44f3b98
Merge pull request #5436 from Gallaecio/fix-crawlerprocess-regression
...
CrawlerProcess: initialize the reactor only once
2022-03-25 13:21:21 +05:00
Andrey Rahmatullin
1e1bf353bf
Merge pull request #5440 from Gallaecio/fix-closespider-exception
...
engine: prevent slot method call after unsetting the slot
2022-03-24 19:43:31 +05:00
Silvio Pavanetto
0beed7055c
fix: return unique_list only when link_extractor.unique is True
2022-03-23 17:28:55 +01:00
Andrey Rahmatullin
8c3e5a2421
Merge pull request #5457 from d00399830/typo_fixes_sm
...
Fix capitalization of JavaScript within the Developer Tools documentation
2022-03-23 11:06:54 +05:00
Víctor Ruiz
2227be7af6
Fix a typo in the HTTP cache documentation ( #5455 )
2022-03-22 15:21:16 +01:00
D00399830
fcf3d8e0a0
Updated the documentation for developer tools to have JavaScript instead of Javascript, as JavaScript is the more correct way to write it
2022-03-21 14:09:31 -06:00
Adrián Chaves
b95c634b86
Document how to enforce Scrapy versions on Scrapy components
2022-03-17 22:23:25 +01:00
FJMonteroInformatica
6a3f2ee687
HTML Conventions
2022-03-17 20:09:56 +01:00
Yann Defretin
0905d42e33
refactored url_has_any_extension function
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2022-03-17 11:19:09 +01:00
Eugene
9a28eb0bad
Suggest installing the brotli package instead of brotlipy ( #4267 )
2022-03-17 05:39:54 +01:00
Yann Defretin
5b4b8b6fb1
added test for new url_has_any_extension function
2022-03-16 22:32:05 +01:00
Adrián Chaves
b78e6915c6
Clarify that without async-to-sync conversions items yielded before an exception are processed
2022-03-16 20:17:25 +01:00
Adrián Chaves
c961438d5d
tests: cover scenarios of bad results from process_spider_output
2022-03-16 18:45:56 +01:00
Adrián Chaves
fd08bb6cd9
Refactor the asynchronous process_spider_output documentation
2022-03-16 18:10:57 +01:00
Adrián Chaves
cb3afcf0e7
Merge remote-tracking branch 'upstream/master' into wrar-asyncio-parse-asyncgen-proper-rebased
2022-03-16 18:08:47 +01:00
Yann Defretin
78ba4b033b
fixed detection of extension like ".tar.gz" in URL
2022-03-16 15:14:24 +01:00
Adrián Chaves
b59a69be17
Test that a low CLOSEPIDER_TIMEOUT does not raise an exception
2022-03-15 12:10:41 +01:00
Laerte Pereira
c1d4be8cb5
Restore ‘-o -’ support ( #5445 )
2022-03-15 11:30:30 +01:00
Andrey Rahmatullin
2d6042b108
Merge pull request #5432 from Farsene1/master
...
Recommend Common Crawl instead of Google Cache
2022-03-11 20:05:43 +05:00
NaincyKumariKnoldus
e264cc30d1
removed the pywin32 docs section ( #5370 )
2022-03-10 14:54:33 +01:00
Ali Rastegar
d469214fe7
Update tutorial.rst ( #5442 )
...
Fixed typo
2022-03-08 10:29:22 +01:00
Adrián Chaves
62a0081266
engine: prevent slot method call after unsetting the slot
2022-03-07 12:00:44 +01:00
Adrián Chaves
3bf6baeaa7
initiated → initialized
2022-03-02 17:30:05 +01:00
Adrián Chaves
96fc4dae15
CrawlerProcess: test a multi-spider scenario
2022-03-02 17:30:05 +01:00
Adrián Chaves
3ecbea4b87
CrawlerProcess: initiate the reactor only once
2022-03-02 17:30:05 +01:00
Florentin
ccdbb795ff
Recommend Common Crawl instead of Google Cache
2022-03-01 22:01:55 +01:00
Adrián Chaves
50c8becbe0
Freeze and upgrade CI packages ( #5429 )
2022-03-01 17:29:08 +01:00
Adrián Chaves
23537a0f95
Bump version: 2.6.0 → 2.6.1
2022-03-01 13:48:40 +01:00
Adrián Chaves
fab3e90729
Cover 2.6.1 in the release notes
2022-03-01 13:41:20 +01:00
Adrián Chaves
d60636d0de
Fix redirect handling regression
2022-03-01 13:06:58 +01:00
Adrián Chaves
84853c4fa6
bandit: allow-list B324 for the time being
2022-03-01 13:01:20 +01:00
Adrián Chaves
6b63e7c147
Bump version: 2.5.0 → 2.6.0
2022-03-01 12:43:11 +01:00
Adrián Chaves
e865c4430e
Merge pull request from GHSA-mfjm-vh54-3f96
...
* Ignore cookies with a public suffix as domain unless it matches the request domain
* Fix the merge of 1.8.2 release notes
* Re-apply removal of tldextract restriction
2022-03-01 12:38:19 +01:00
Adrián Chaves
8ce01b3b76
Merge pull request from GHSA-cjvr-mfj7-j4j8
...
* Do not carry over cookies to a different domain on redirect
* Cover the cookie-domain redirect fix in the release notes
* Cover 1.8.2 in the release notes
* Fix redirect Cookie handling when the cookie middleware is disabled
* Update the 1.8.2 release date
2022-03-01 12:26:05 +01:00
Adrián Chaves
aa0306a167
Cover 2.6.0 in the release notes ( #5399 )
2022-03-01 12:16:37 +01:00
Andrey Rahmatullin
08557e09db
Pin old markupsafe when we pin old mitmproxy ( #5427 )
2022-02-23 19:52:18 +01:00
Gowtham Chowdary
3b42ccfeba
Add a link to Discord ( #5422 )
2022-02-16 21:33:56 +01:00
Andrey Rahmatullin
8840403b70
Merge pull request #5412 from Laerte/master
2022-02-15 18:15:39 +05:00
Andrey Rahmatullin
0b0eea3601
Merge pull request #5419 from PendalF89/patch-2
...
Update downloader-middleware.rst
2022-02-15 10:57:35 +05:00
Abhishek K M
187b5c8876
Update the documentation link for robots.txt ( #5415 )
2022-02-14 19:16:53 +01:00
Boris Zabolotskikh
bbb693d046
Update downloader-middleware.rst
...
Added a link to the method
2022-02-14 12:07:45 +03:00
Laerte Pereira
befb6df119
Remove Python 2 code from WrappedRequest
2022-02-11 06:19:27 -03:00
GeorgeA92
be97402e46
per slot settings: log notifications (debug) removed
2022-02-11 01:22:27 +02:00
GeorgeA92
115d352706
per slot settings: setting renamed from `PER_SLOT_SETTINGS` to `DOWNLOAD_SLOTS`
2022-02-11 01:21:31 +02:00
GeorgeA92
ac55a933b8
Merge remote-tracking branch 'upstream/master' into per_slot_settings
2022-02-11 01:18:42 +02:00
Andrey Rahmatullin
5d7c0a5f86
Use toscrape.com instead of example.com in test_command_check. ( #5407 )
2022-02-10 10:50:12 +01:00
Alex
e2e2ffd0d1
Move from optparse to argparse ( #5374 )
2022-02-09 20:52:07 +01:00
Andrey Rahmatullin
1356836e7e
Merge pull request #5405 from wRAR/tests-twisted-22.1-fix
...
Fix running tests with Twisted 22.1.0
2022-02-09 00:06:25 +05:00
Andrey Rakhmatullin
77547a1ab5
Revert "Temporarily pin Twisted to an older version in CI ( #5401 )"
...
This reverts commit b282a7af01 .
2022-02-08 21:06:02 +05:00
Andrey Rakhmatullin
1e1cfc26db
Copy resource classes from twisted.web.test.test_webclient.
2022-02-08 21:01:16 +05:00
Raihan Nismara
fd55f62207
Update Logo in README.rst ( #5258 )
2022-02-08 15:36:25 +01:00
Laerte
4bda0976b2
Fix csviter call, add parse_rows test ( #5394 )
2022-02-08 14:57:19 +01:00
Andrey Rahmatullin
840362496c
Merge pull request #5396 from peter-gy/master
...
docs: use https scheme for each quotes.toscrape.com url occurrence
2022-02-08 11:05:52 +05:00
Andrey Rahmatullin
b282a7af01
Temporarily pin Twisted to an older version in CI ( #5401 )
2022-02-07 21:25:08 +01:00
Andrey Rahmatullin
f7bf7414f0
Merge pull request #5398 from elacuesta/remove-deprecated-item-classes
...
Remove deprecated DictItem/BaseItem classes
2022-02-07 12:34:35 +05:00
Eugenio Lacuesta
fca49cca92
Remove deprecated DictItem class
2022-02-06 18:31:55 -03:00
Eugenio Lacuesta
c8c1edd43b
Flake8 adjustments
2022-02-06 18:27:41 -03:00
Eugenio Lacuesta
bbfa185664
Remove deprecated BaseItem class
2022-02-06 18:12:28 -03:00
Péter Ferenc Gyarmati
38d2a154ec
docs: use https scheme for each quotes.toscrape.com url occurrence
2022-02-06 18:52:15 +01:00
Andrey Rahmatullin
3533717488
Merge pull request #5393 from elacuesta/remove-textresponse-body-as-unicode
...
Remove deprecated TextResponse.body_as_unicode
2022-02-06 19:36:55 +05:00
Eugenio Lacuesta
55ae2109c9
Remove deprecated TextResponse.body_as_unicode
2022-02-05 13:11:13 -03:00
Adrián Chaves
9be878fc09
CI: stop using tox-pip-version ( #5389 )
2022-02-04 12:27:39 +01:00
Laerte
fe43411bc4
Fix TypeError on using pathlib.Path as key on FEEDS settings ( #5384 )
2022-02-04 09:57:57 +01:00
Sixuan (Cherie) Wu
30d5779ea9
Fix FEED_URI_PARAMS: custom params throws KeyError ( #4966 )
...
* fix FEED_URI_PARAMS: custom params throws KeyError closes #4962
* another try FEED_URI_PARAMS
* add warning message and change default function
* Add tests for FEED_URI_PARAMS
* FEED_URI_PARAMS: warn if the params dict has been modified in-place
* [Doc] FEED_URI_PARAMS: modifying params in-place is deprecated
* Remove whileline
* Rename parameters for lambda function
* Type hints for FeedExporter._get_uri_params
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
2022-01-28 14:30:30 -03:00
Georgiy Zatserklianyi
4bdaa54af4
response_httprepr memory issue fixed ( #4972 )
...
* response_httprepr replaced by response.body
* unused import deleted
* get_header_size function added
* response size calculation updated
* flake8 codestyle fix
* added counting status code, line breaks to response size
* get_status size: list to tuple, comments added
* test added: comparing new response size counting method with old `len(response_httprepr)`
* downloader stats : unreachable code deleted
* `get_status_size` optimized
* comment added
* tests.test_downloadermiddleware_stats: statement formatting updated
* scrapy.utils.response: `response_httprepr` -> deprecated
* tests.test_downloadermiddleware_stats: flake8 fix
2022-01-28 18:39:32 +05:00
Mikhail Korobov
9dd77b42b5
Merge pull request #1582 from starrify/add_doc_textresponse_urljoin
...
added: Doc for `scrapy.http.TextResponse.urljoin`
2022-01-23 21:40:21 +05:00
Andrey Rahmatullin
92764d68e2
Merge pull request #3155 from aprasanna/doc-fix
...
A few typo fixes and some grammatical enhancements
2022-01-21 13:59:03 +05:00
Andrey Rahmatullin
5059b8c493
Merge branch 'master' into doc-fix
2022-01-21 13:58:43 +05:00
Andrey Rahmatullin
169bc8866e
Merge pull request #4335 from leobalestri/patch-1
...
Update install.rst
2022-01-21 13:26:11 +05:00
Andrey Rahmatullin
1608b1a7fa
Merge branch 'master' into patch-1
2022-01-21 13:24:51 +05:00
Andrey Rakhmatullin
e079bffdab
Disable logging-fstring-interpolation in pylint.
2022-01-11 19:21:07 +05:00
Andrey Rakhmatullin
f789547551
Implement spider middleware iterable upgrade/downgrade.
2022-01-11 18:28:32 +05:00
Andrey Rakhmatullin
8864407c4d
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2022-01-10 19:37:46 +05:00
Andrey Rahmatullin
9b8285d98a
Merge pull request #5334 from wRAR/mw-manager-typing-fix
...
Fix typing of middleware methods.
2022-01-10 11:33:12 +05:00
Andrey Rahmatullin
b04cfa4832
Merge pull request #5352 from wRAR/crawler-process-reactor-later
2022-01-06 11:31:59 +05:00
Andrey Rakhmatullin
3577c00569
Merge remote-tracking branch 'origin/master' into crawler-process-reactor-later
2022-01-03 13:59:26 +05:00
Andrey Rahmatullin
c5ab58056c
Set WindowsSelectorEventLoopPolicy on Windows ( #5315 )
2021-12-31 20:38:10 +01:00
Andrey Rakhmatullin
6eaceec735
Implement docs suggestions.
2021-12-31 20:14:24 +05:00
Andrey Rakhmatullin
60800ee5f2
Merge remote-tracking branch 'origin/master' into crawler-process-reactor-later
2021-12-31 20:12:30 +05:00
Andrey Rakhmatullin
a2763c608d
Remove unused MiddlewareManager._process_chain_both().
2021-12-31 18:35:19 +05:00
Andrey Rakhmatullin
a7846d2398
Merge remote-tracking branch 'origin/master' into mw-manager-typing-fix
2021-12-31 18:34:29 +05:00
Andrey Rahmatullin
57dc58123b
Remove the experimental note about asyncio ( #5332 )
2021-12-31 13:15:08 +01:00
Paweł Miech
e4bdd1cb95
downloader.webclient: make reactor import local ( #5357 )
2021-12-31 11:57:12 +01:00
Andrey Oskin
b81938684b
Docs: correct process repetition start step ( #5356 )
...
The process repeats from step 3, the scheduler feeds request to the engine. Steps 1 and 2 are not parts of the loop as their incarnations steps 7 and 8 are parts of the loop.
2021-12-31 11:49:18 +01:00
Andrey Rakhmatullin
0e78b68650
Merge remote-tracking branch 'origin/master' into crawler-process-reactor-later
2021-12-31 15:46:25 +05:00
Andrey Rakhmatullin
64261d9e38
Slight refactoring.
2021-12-31 15:45:59 +05:00
Andrey Rahmatullin
7380888cad
Fix a warning message. ( #5359 )
2021-12-30 10:55:16 -03:00
Burak Can Kahraman
a9dfd85ea6
Document coroutines for signals.
2021-12-30 15:48:53 +03:00
Andrey Rakhmatullin
a986792def
Add more docs for TWISTED_REACTOR.
2021-12-24 19:43:14 +05:00
Andrey Rakhmatullin
940cc0776f
Add docs about TWISTED_REACTOR and other per-process settings.
2021-12-24 17:12:50 +05:00
Andrey Rakhmatullin
d4565318c7
Fix a reactor test on Windows.
2021-12-23 17:40:31 +05:00
Andrey Rakhmatullin
df04e934e6
Merge remote-tracking branch 'origin/master' into crawler-process-reactor-later
2021-12-23 17:25:56 +05:00
Andrey Rakhmatullin
9c4bfb4836
Remove an unused import.
2021-12-23 17:17:36 +05:00
Andrey Rakhmatullin
0025134382
Completely skip WindowsRunSpiderCommandTest outside Windows.
2021-12-23 16:45:17 +05:00
Andrey Rakhmatullin
ebcafdf4a9
Add tests for TWISTED_REACTOR in custom_settings.
2021-12-23 16:35:26 +05:00
Andrey Rakhmatullin
041699b54c
Remove tests that want to modify the test process reactor.
2021-12-23 16:14:47 +05:00
Andrey Rakhmatullin
60c8838554
Move installing the reactor from CrawlerProcess to Crawler.
2021-12-23 16:07:18 +05:00
Andrey Rakhmatullin
46ef9cf771
Don't install non-working shutdown handlers in `scrapy shell`.
2021-12-23 16:05:17 +05:00
yogender26
d6a384b3cf
corrrection of coma ( #5347 )
2021-12-22 23:39:05 +01:00
Andrey Rahmatullin
9ec60e8e4a
Merge pull request #5320 from zessx/5319-oib-base-tag
2021-12-21 17:49:31 +05:00
Andrey Rahmatullin
0862b179e3
Merge pull request #5333 from wRAR/pylint-2.12
...
Fix and pin pylint.
2021-12-16 18:54:27 +05:00
Andrey Rakhmatullin
6483dfdbe1
Move install_shutdown_handlers() from __init__() to start().
2021-12-01 19:53:39 +05:00
Andrey Rakhmatullin
eb62906c3e
Extract utils.log.log_reactor_info().
2021-12-01 17:40:41 +05:00
Andrey Rakhmatullin
4cc039628e
Fix typing of middleware methods.
2021-11-26 19:52:03 +05:00
Andrey Rakhmatullin
6ec66c96fb
Fix and pin pylint.
2021-11-26 12:25:45 +05:00
GeorgeA92
8185aa5265
per slot settings: codestyle fix
2021-11-20 21:06:08 +02:00
GeorgeA92
1b7d7ecfcd
per slot settings: logging updated (create/close Slot)
2021-11-20 21:05:24 +02:00
GeorgeA92
d5acf88ca5
per slot settings: logging added (create Slot)
2021-11-20 20:14:28 +02:00
GeorgeA92
eea56c4912
per slot settings: creation of Downloader.Slot objects from per slot settings added
2021-11-20 20:13:54 +02:00
Alex
c316ca45a5
Use augmented assignment statements ( #5322 )
2021-11-16 10:20:56 +01:00
Samuel Marchal
75ed765476
Test coverage for open_in_browser base tag injection ( #5319 )
2021-11-15 16:44:56 +01:00
Samuel Marchal
f2c800c5c9
Improve open_in_browser base tag injection ( #5319 )
2021-11-15 16:44:56 +01:00
Andrey Rahmatullin
28eba610e2
Re-enable Windows tests for Python 3.9 and 3.10. ( #5316 )
2021-11-15 08:24:54 +01:00
Andrey Rahmatullin
9828cb3f0b
Merge pull request #5310 from azzamsa/more-test
...
test: `test_format_engine_status`
2021-11-08 20:13:00 +05:00
azzamsa
55cce25a79
test: `test_format_engine_status`
2021-11-05 03:02:02 +07:00
Andrey Rahmatullin
ed50a81f50
Merge pull request #5299 from azzamsa/fix-tests
...
fix: `CodeBlockParser` has been renamed to `PythonCodeBlockParser`
2021-11-04 19:00:14 +05:00
azzamsa
67994d1ddd
fix: `CodeBlockParser` has been renamed to `PythonCodeBlockParser`
2021-10-27 22:19:07 +07:00
Andrey Rahmatullin
3225de7257
Merge pull request #5292 from azzamsa/tox-patch
...
refactor: use `pytest` command as the recommended entry point
2021-10-25 11:34:59 +05:00
azzamsa
51adf71b1b
refactor: use `pytest` command as the recommended entry point
...
`pytest` is recommended command since pytest 3.0.
There is a possibility for `py.test` to be deprecated or even removed.
https://github.com/pytest-dev/pytest/issues/1629
2021-10-24 10:52:56 +07:00
Andrey Rakhmatullin
c105a7a85f
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-10-22 21:52:47 +05:00
Andrey Rahmatullin
144d1eb834
Add Deferred-to-Future helpers ( #5288 )
2021-10-22 18:46:01 +02:00
Eugenio Lacuesta
cfff79cee6
Make Python 3.10 support official ( #5265 )
2021-10-18 22:09:17 +02:00
Andrey Rahmatullin
afa5881ada
Merge pull request #5279 from erikkemperman/option-logfile-truncate
...
Add LOG_FILE_APPEND to settings
2021-10-18 11:51:42 +05:00
Andrey Rahmatullin
975f15003e
Merge pull request #5281 from raphaelts3/add-pronounced-docs
...
Add how Scrapy is pronounced to the docs
2021-10-18 11:49:55 +05:00
raphaelts3
027ecd8686
Update docs/intro/overview.rst
...
Co-authored-by: azzamsa <17734314+azzamsa@users.noreply.github.com>
2021-10-16 10:52:54 -03:00
Raphael Tomé Santana
aec7146e2f
Add how Scrapy is pronounced to the docs
2021-10-15 20:38:53 -03:00
Adrián Chaves
d774d6a9c4
Remove unused variable
2021-10-15 17:25:22 +02:00
Adrián Chaves
98ee3ddffe
Freeze flake8
2021-10-15 17:18:46 +02:00
Erik Kemperman
ca320feb2a
Add LOG_FILE_APPEND to settings
2021-10-15 16:36:41 +02:00
Andrey Rahmatullin
5b13bfd14a
Merge pull request #5269 from Ankur19/allow-non-text-response-types-in-ItemLoader
...
Fix bug #5145 - Removing Selector for Response's that are not Http or Xml
2021-10-14 16:19:54 +05:00
Andrey Rahmatullin
808fb63273
Merge pull request #5276 from imba-tjd/patch-1
...
docs: fix typo
2021-10-14 12:51:30 +05:00
谭九鼎
3243aa2cd5
docs: fix typo
2021-10-14 10:18:26 +08:00
Andrey Rakhmatullin
a642b73e1a
Remove an unused import.
2021-10-13 19:22:22 +05:00
Andrey Rakhmatullin
e5b057cfd4
Don't use a HTTP request in a case that will not be awaited.
2021-10-13 19:07:53 +05:00
Jake Herbst
d08199f631
Removing unnecessary line from docs to prevent test failure ( #5274 )
2021-10-12 19:20:09 +02:00
Andrey Rahmatullin
1ae53a9d7c
Merge pull request #5256 from rydwhelchel/documentation-changes
...
docs: restructed phrasing for clarity
2021-10-12 16:49:31 +05:00
Andrey Rahmatullin
d90b2a2bfc
Merge pull request #5250 from iDeepverma/URLLENGTH_LIMIT-doc
...
Documentation update for URLLENGTH_LIMIT
2021-10-12 16:48:42 +05:00
Andrey Rahmatullin
8a743ae43a
Merge pull request #5266 from MarvinPetzoldt/patch-1
...
Fixed documentation example
2021-10-12 16:46:51 +05:00
Andrey Rahmatullin
ce96a961e1
Merge pull request #5271 from kianmeng/fix-typos
...
Fix typos
2021-10-12 16:46:05 +05:00
Andrey Rahmatullin
eb0e99dc20
Merge pull request #5254 from PeterMorrison1/FilePipeline-expire-doc
...
Document file expiration method in media-pipeline (#5120 )
2021-10-12 16:41:16 +05:00
Andrey Rakhmatullin
66d8a71920
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-10-11 20:24:22 +05:00
Kian-Meng, Ang
3a263280ba
Fix typos
2021-10-11 22:32:42 +08:00
ankur19
6fbd6f941f
Fix issue#5145
...
Fix condition for failing tests
set Selector to None on AttributeError
Add test and remove unused imports
Fix imports
2021-10-10 15:55:22 -04:00
Eugenio Lacuesta
65d60b9692
[docs] add missing parameter to headers_received signal ( #5270 )
2021-10-10 10:06:36 +02:00
Georgiy Zatserklianyi
d3f1bf79e8
Use f-strings where appropriate ( #5246 )
2021-10-07 16:27:20 +02:00
Eugenio Lacuesta
029cab72e8
[CI] fix pypy test ( #5264 )
2021-10-06 19:34:09 +02:00
MarvinPetzoldt
b1cb007b3b
Fixed documentation example
2021-10-06 19:08:19 +02:00
Laerte
6c858cec91
Cookies: Cast primitive types to str ( #5253 )
...
* cast primitive types to str
* add tests
2021-10-06 12:32:04 -03:00
Adrián Chaves
214525c2c1
Merge pull request #5263 from Gallaecio/port-security-fix
...
Port security fix from 1.8.1 and 2.5.1 to the main branch
2021-10-06 13:14:35 +02:00
Adrián Chaves
735750c254
Cover 1.8.1 in the release notes
2021-10-06 12:33:57 +02:00
Adrián Chaves
f0105a882d
Cover 2.5.1 in the release notes
2021-10-06 12:33:44 +02:00
Andrey Rakhmatullin
7ec5f299c4
Small documentation fixes.
2021-10-06 12:33:32 +02:00
Andrey Rakhmatullin
b081f18a2f
Add http_auth_domain to HttpAuthMiddleware.
2021-10-06 12:33:18 +02:00
Ryan Whelchel
764cf0178b
Update docs/intro/tutorial.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-10-05 10:22:57 -04:00
Ryan Whelchel
b9647b85d3
docs: restructed phrasing for clarity
2021-10-03 17:32:38 -04:00
Andrey Rahmatullin
cbf9349552
Merge pull request #5255 from raihan71/raihan71-patch-1
...
Using Logo Scrapy in Readme.md
2021-10-03 19:59:47 +05:00
Raihan Nismara
ef263042d7
Using Logo Scrapy in Readme.md
...
Logo scrapy used in readme.md made looks nicer
2021-10-03 13:26:20 +07:00
Adrián Chaves
f108800222
Update spider-middleware.rst
2021-10-02 13:25:15 +02:00
Deepanshu verma
de70b3c58b
Update spider-middleware.rst
...
added empty line
2021-10-02 12:12:58 +05:30
Peter Morrison
47533985f4
Document file expiration method in media-pipeline
2021-10-01 12:30:14 -06:00
Deepanshu
de2043f9c1
updated docs/topics/spider-middleware.rst
2021-10-01 20:20:00 +05:30
Adrián Chaves
d91d82b506
Make Scrapy SFW again
2021-10-01 16:31:29 +02:00
Deepanshu verma
fbb1236fd6
Update docs/topics/settings.rst
...
added suggestion
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-10-01 18:46:11 +05:30
Deepanshu verma
552457e6f2
Merge branch 'scrapy:master' into URLLENGTH_LIMIT-doc
2021-10-01 16:40:48 +05:30
Eugenio Lacuesta
890f884de4
Allow 'callback' key in keyword arguments for request callbacks ( #5251 )
2021-10-01 09:50:42 +02:00
Deepanshu
74f146bbe0
Document update URLLENGTH_LIMIT
2021-10-01 01:47:05 +05:30
Andrey Rahmatullin
7d557f898c
Merge pull request #5239 from maanijou/master
...
Improve documentation for spider middlewares
2021-09-27 15:42:31 +05:00
Andrey Rahmatullin
6249175317
Merge pull request #5244 from kamran890/spider-state-doc
...
Document spider.state attribute (#5174 )
2021-09-27 15:41:58 +05:00
Adrián Chaves
3c57825b0f
Update docs/topics/spider-middleware.rst
2021-09-26 13:41:26 +02:00
Reza (Milad) Maanijou
dfdb779756
Apply review comments
2021-09-26 12:45:44 +03:30
Reza (Milad) Maanijou
1829dd774c
Update spider-middleware.rst
2021-09-25 20:22:09 +03:30
kamran890
e5998fb846
Document spider.state attribute ( #5174 )
2021-09-22 03:15:12 +05:00
maanijou
ac9175964d
Improve documentation for spider middlewares
2021-09-12 17:59:20 +02:00
Andrey Rahmatullin
8284de5e76
Fix/silence the Pylint messages added in 2.10 ( #5235 )
2021-08-24 12:15:29 +02:00
D R Siddhartha
43ea21e830
Feed post-processing plugin support ( #5190 )
2021-08-24 11:48:01 +02:00
Matsievskiy S.V
3f635eb683
Extract domain from genspider URL ( #4439 )
2021-08-24 11:05:50 +02:00
Andrey Rahmatullin
ada539a63a
Merge pull request #4676 from Gallaecio/startproject-existing-folder
...
Fix startproject failing for existing folders
2021-08-24 12:18:49 +05:00
Andrey Rakhmatullin
cd17c829cf
Revert "Move documentation about avoiding bans into a topic of its own ( #4039 )"
...
This reverts commit 2d2581c68f .
2021-08-23 19:55:35 +05:00
Andrey Rahmatullin
731f2d3085
Merge pull request #4178 from elacuesta/remove_spider_make_requests_from_url
2021-08-20 16:16:25 +05:00
Eugenio Lacuesta
10ebf6384e
Remove unnecessary comma
2021-08-19 14:12:55 -03:00
Eugenio Lacuesta
5792e1c922
Merge remote-tracking branch 'upstream/master' into case-insensitive-dict
2021-08-19 14:09:39 -03:00
Eugenio Lacuesta
bbeed6ae8f
CaseInsensitiveDict: preserve original keys (only lookups are key-insensitive)
2021-08-19 14:09:30 -03:00
Andrey Rahmatullin
bdf8355ce1
Merge pull request #5231 from umairnsr87/umairnsr87/issues/5226
...
updated documentation for python version for reppy
2021-08-18 21:08:32 +05:00
databender
572d347b3b
warning view updated
2021-08-18 16:17:52 +05:30
Adrián Chaves
2d2581c68f
Move documentation about avoiding bans into a topic of its own ( #4039 )
2021-08-18 12:46:42 +02:00
databender
d623ed15d1
indentation updated
2021-08-18 14:51:03 +05:30
databender
bcf38a6719
added upstream issue for not supported python version
2021-08-18 14:48:47 +05:30
Andrey Rahmatullin
a7bd6fa229
Merge pull request #3669 from Gallaecio/spider-name-collision
2021-08-17 19:42:53 +05:00
Andrey Rakhmatullin
5d4b232de8
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-08-16 20:20:43 +05:00
databender
79bad0cf82
updated suggested changes after review
2021-08-16 18:10:23 +05:30
databender
ebddb77a33
updated suggested changes after review
2021-08-16 18:08:26 +05:30
umair ansari
013ac90f61
Update docs/topics/downloader-middleware.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-08-16 18:00:06 +05:30
databender
cc1cb2de0c
updated suggested changes
2021-08-16 17:21:47 +05:30
databender
1a8b98843a
updated documentation for python version for reppy
2021-08-16 17:00:05 +05:30
databender
8bbaea9892
updated documentation for python version for reppy
2021-08-16 16:57:43 +05:30
Andrey Rahmatullin
2814e0e197
Disable builtin middlewares in spider middleware tests. ( #5229 )
2021-08-16 13:22:01 +02:00
Andrey Rahmatullin
47a281d231
Merge pull request #5224 from aaron-tan/jobdir-doc
2021-08-16 12:52:02 +05:00
Andrey Rahmatullin
0915be7300
Merge pull request #5228 from wRAR/test-reqs
...
Rename tests/requirements-py3.txt to tests/requirements.txt.
2021-08-11 21:04:10 +05:00
Andrey Rakhmatullin
b63369c148
Rename tests/requirements-py3.txt to tests/requirements.txt.
2021-08-11 20:02:45 +05:00
Andrey Rahmatullin
0590c3756c
Merge pull request #5221 from wRAR/3.10-tests
...
Fixing tests for upcoming 3.10.
2021-08-11 14:19:51 +05:00
Andrey Rakhmatullin
74cee38a4e
Don't run the asyncio tests on 3.9.
2021-08-11 14:19:08 +05:00
Andrey Rahmatullin
902fce0640
Merge pull request #5225 from divtiply/patch-3
...
Allow comma-separated values in the rel attribute
2021-08-11 10:58:28 +05:00
Andrey Rakhmatullin
983b89ad4f
Fix SpiderLoaderTest on Python 3.10.
2021-08-11 10:39:23 +05:00
Michel Ace
ce9d6c658b
Add more rel_has_nofollow tests
2021-08-10 22:21:51 +02:00
Michel Ace
295f0e2bf5
Make flake8 happy
2021-08-10 21:38:29 +02:00
Michel Ace
07d20a8ce4
Fix test_rel_has_nofollow test
2021-08-10 21:21:43 +02:00
Michel Ace
18b6f30a73
Add test for rel_has_nofollow
2021-08-10 21:13:50 +02:00
Michel Ace
1ba0f68483
Allow comma-separated values in the rel tag
...
Comma-separated `rel` values are often seen in the wild, because Google allows it (see https://developers.google.com/search/docs/advanced/guidelines/qualify-outbound-links ).
2021-08-10 17:09:37 +02:00
Aaron Tan
954f303590
Update docs/topics/settings.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-08-09 22:23:23 +10:00
Aaron Tan
48eff4ee8f
Remove JOBDIR from default settings
2021-08-08 20:52:14 +10:00
Aaron Tan
8e7d2ef133
Document JOBDIR option issue #5173
...
Add JOBDIR setting to the settings page.
Add default JOBDIR setting to global defaults in scrapy.settings.default_settings module.
2021-08-07 11:44:12 +10:00
Mannan2812
94baa4b272
Fix FileFeedStoragePreFeedOptionsTest fails in CI/CD pipeline ( #5198 )
2021-08-05 21:23:11 +02:00
Andrey Rakhmatullin
93bf1ae7e3
Fix tests for the 3.10 TypeError message change.
2021-08-03 20:16:59 +05:00
Andrey Rakhmatullin
ef6fb933b5
Fix a Python 3.10 logging issue.
2021-08-03 20:16:59 +05:00
Andrey Rakhmatullin
2bf2f9d6db
Add Python 3.10b4 tests on Ubuntu.
2021-08-03 20:16:59 +05:00
Andrey Rahmatullin
4d1ecc31c9
Merge pull request #5217 from aaron-tan/docs-extension
2021-08-02 17:36:35 +05:00
Aaron Tan
880a4d9493
Update docs/topics/extensions.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-08-01 11:02:27 +10:00
Andrey Rahmatullin
b406affd5b
Merge pull request #5210 from laggardkernel/feature/aws-session-token
2021-07-30 15:15:55 +05:00
Eugenio Lacuesta
cc89f6be38
Response.attributes ( #5218 )
2021-07-29 22:12:44 +02:00
Andrey Rahmatullin
22bd01237b
Merge pull request #4613 from elacuesta/docs-headless-browser
...
Update headless browser docs
2021-07-29 15:25:08 +05:00
Eugenio Lacuesta
4b62ac6c3a
Update headless browser docs to mention playwright
2021-07-28 15:00:24 -03:00
Eugenio Lacuesta
9aef9b78eb
Merge remote-tracking branch 'upstream/master' into docs-headless-browser
2021-07-28 14:31:49 -03:00
Eugenio Lacuesta
0e3d50dd18
Update docs/topics/dynamic-content.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-07-28 14:30:16 -03:00
Eugenio Lacuesta
494e0ad8ff
Update docs/topics/dynamic-content.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-07-28 14:29:50 -03:00
Aaron Tan
d55b6fcad6
Fix for duplicate object description error
2021-07-28 12:10:34 +10:00
Aaron Tan
714aa3970e
Merge branch 'scrapy:master' into docs-extension
2021-07-30 20:36:58 +10:00
laggardkernel
8e7b96d8a2
Tweak doc for setting AWS_SESSION_TOKEN
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-07-27 19:40:02 +08:00
laggardkernel
7e4321f201
Add support for temporary security credential in AWS auth
2021-07-27 19:39:59 +08:00
laggardkernel
abe0b37d30
Cleanup leftover boto2 code in S3DownloaderHandler ( #5209 )
...
S3DownloaderHandler.conn is a leftover attribute from 5e99758 .
2021-07-27 11:11:32 +02:00
Rob Banagale
b22a004398
Document media pipeline file naming ( #5152 )
2021-07-26 20:51:32 +02:00
Aaron Tan
209c1fce02
Reference MailSender in StatsMailer
...
Added a reference to MailSender in the StatsMailer extension description and included a link to the document detailing how to instantiate MailSender and using Scrapy settings objects.
2021-07-24 14:50:48 +10:00
Mikhail Korobov
ff272d6332
Merge pull request #5215 from pcorpet/types
...
Typing: switch to a newer version of MyPy to check types
2021-07-22 17:52:48 +05:00
Pascal Corpet
70dddfe2b2
Typing: switch to a newer version of MyPy to check types
2021-07-21 17:10:10 +02:00
Andrey Rakhmatullin
7306a81188
Disable builtin middlewares in spider middleware tests.
2021-07-19 20:09:11 +05:00
Adrián Chaves
8a2768561f
Merge branch 'master' into asyncio-parse-asyncgen-proper-rebased
2021-07-16 14:32:15 +02:00
Andrey Rahmatullin
ee2df97bbd
Pin the libxml2 version in CI as a newer one breaks lxml ( #5208 )
2021-07-16 14:28:32 +02:00
Andrey Rahmatullin
89b654b82d
Make the pylint test pass ( #5207 )
...
Co-authored-by: Vostretsov Nikita <whalebot.helmsman@gmail.com>
2021-07-16 12:18:14 +02:00
Eugenio Lacuesta
bcce066057
Update ItemFilter ( #5203 )
2021-07-14 17:56:07 +02:00
Adrián Chaves
e7d3fad00e
Merge branch 'master' into master
2021-07-14 11:24:56 +02:00
Marlena Chatzigrigoriou
d7deba7e89
Document all import paths and use the shortest in examples ( #5099 )
2021-07-14 10:34:28 +02:00
Türkalp Burak KAYRANCIOĞLU
fcc6becc58
S3FeedStorage: allow custom endpoint ( #4998 )
...
Co-authored-by: Andrey Rahmatullin <wrar@wrar.name>
2021-07-14 10:00:43 +02:00
D R Siddhartha
4ddc9d6b55
Feeds: Item Filters ( #5178 )
2021-07-13 17:22:29 +02:00
Eugenio Lacuesta
c062ed017a
[CI] fail-fast: false ( #5200 )
2021-07-12 18:34:22 +02:00
Andrey Rahmatullin
1c46d5aa93
Merge pull request #5191 from ivanprado/master
...
CloseSpider can be raised on spider_idle signal handler to set the closing reason
2021-07-12 18:46:40 +05:00
Eugenio Lacuesta
cb08e3644b
Remove trailing whitespaces
2021-07-08 09:22:21 -03:00
Iván de Prado
eca641aa3d
Update tests/test_engine.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-07-08 12:40:20 +01:00
Iván de Prado
6b8f694653
Update scrapy/core/engine.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-07-08 12:40:02 +01:00
Iván de Prado
7597d860c8
Update scrapy/core/engine.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-07-08 12:39:17 +01:00
Andrey Rahmatullin
15dfc8a76f
Merge pull request #5194 from scrapy/doc-spiders-warning-indentation-1
...
spiders.rst: indent warnings into class descriptions
2021-06-29 17:54:22 +05:00
Iván de Prado Alonso
e94d3ac173
Expanded doc for idle signal
2021-06-29 13:40:43 +01:00
Iván de Prado Alonso
f35970778b
Test case for raising CloseSpider on spider idle signal handler
2021-06-29 13:21:38 +01:00
Adrián Chaves
73ff9ffd64
spiders.rst: indent warnings into class descriptions
2021-06-26 08:58:29 +02:00
Iván de Prado Alonso
ce445f2046
Fix typing
2021-06-24 09:56:05 +01:00
Iván de Prado Alonso
812b4bb518
CloseSpider can be raised on spider_idle signal handler
2021-06-23 17:22:01 +01:00
Andrey Rahmatullin
016c7e92d1
Merge pull request #3579 from maramsumanth/duplicate_key
...
[MRG+1] Issue #2919 : Fix FormRequest.formdata with GET method duplicates same key in query string
2021-06-15 13:36:53 +05:00
Andrey Rahmatullin
af975a5b0a
Merge pull request #4649 from ajaymittur28/http-proxy-schema
...
Support schema-less HTTP proxy (#4504 )
2021-06-15 13:36:17 +05:00
ajaymittur28
eb324fadad
Merge branch 'http-proxy-schema' of https://github.com/ajaymittur28/scrapy into http-proxy-schema
2021-06-14 21:39:43 +05:30
ajaymittur28
7d653288e3
Update unittest
2021-06-14 21:39:18 +05:30
ajaymittur28
857e0e225a
Merge branch 'master' into http-proxy-schema
2021-06-14 21:18:49 +05:30
Ajay Mittur
5044549c55
Update proxyScheme assignment
2021-06-14 14:58:19 +00:00
Andrey Rahmatullin
66e2004239
Fix a flake8 problem
2021-06-14 18:58:35 +05:00
Andrey Rahmatullin
16be658a31
Merge branch 'master' into duplicate_key
2021-06-14 18:45:33 +05:00
Andrey Rahmatullin
9f81de2a50
Merge pull request #5171 from elacuesta/request-types
...
Type hints for Request and subclasses
2021-06-11 17:11:19 +05:00
Andrey Rakhmatullin
de69d967f9
Fix async spider examples.
2021-06-11 16:12:25 +05:00
pdt1931
28858574d9
Add FAQ to code of Conduct ( #5177 )
...
* added to CODE_OF_CONDUCT.md to include link to FAQ about the code of conduct
* added to CODE_OF_CONDUCT.md to include link to FAQ about the code of conduct
2021-06-11 12:49:41 +05:00
Veniamin Gvozdikov
e876d8e387
Rename scrapy-crawlera to scrapy-zyte-smartproxy ( #5074 )
2021-06-11 08:22:04 +02:00
Eugenio Lacuesta
ce6447731a
Replace return type
2021-06-07 13:25:04 -03:00
Andrey Rakhmatullin
ecfc924ca8
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-06-04 18:55:32 +05:00
Eugenio Lacuesta
479260dca0
Type hints for Request subclasses
2021-06-01 12:52:46 -03:00
Eugenio Lacuesta
c9fecca010
More type hints
2021-06-01 12:41:37 -03:00
Eugenio Lacuesta
85f88a5710
More type hints for private functions used by FormRequest
2021-06-01 12:02:16 -03:00
Eugenio Lacuesta
c594017e51
Type hints for private functions used by FormRequest
2021-06-01 11:27:21 -03:00
Eugenio Lacuesta
216dd37953
Type hints for FormRequest
2021-06-01 11:16:40 -03:00
Eugenio Lacuesta
c92e8ad0a5
Merge branch 'master' into request-types
2021-06-01 11:01:23 -03:00
Vostretsov Nikita
23cfdb058e
Reducing amount of warnings during test run ( #5162 )
...
* put flake8 options into separate file to remove pytest warnings
* remove ResourceLeaked warning in pypy
* suppress warnings from twisted
* ignore deprecation warnings here
* ignore deprecation warning in tests of deprecated methods
* ignore deprecation warnings here
* update test classes
* don`t use deprecated method call
* ignore deprecation warnings here
* proper warning class
* more selective ignoring
* Revert "don`t use deprecated method call"
This reverts commit 59216ab560 .
2021-05-28 14:45:06 +05:00
Gustavo Bordin
09a07c9b4a
removed whitespaces
2021-05-18 19:07:28 -03:00
Gustavo Bordin
5bacc4822e
changing dunder-str to dunder-repr
2021-05-16 18:40:30 -03:00
Eugenio Lacuesta
52d0df5f98
CaseInsensitiveDict (deprecate CaselessDict)
2021-05-12 13:08:08 -03:00
Bhavesh
ee682af3b0
[Fix] Change the truncation limit of Proxy TunnelError from 32 to 1000 ( #5007 )
...
* [Fix] Change the truncation limit oof Proxy TunnelError from 32 to 64
* [Fix] Change the truncation limit for Proxy tunnel error
* [Fix] flake8 check
* [Fix] formatting issues
* [Remove] coverage report
* [Fix] truncation error issue
* [Fix] formatting issues
* [Remove] coverage report
2021-05-12 01:23:02 +05:00
Adrián Chaves
c5b1ee8101
Make Twisted[http2] installation optional ( #5113 )
...
Co-authored-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
2021-05-11 09:04:53 +02:00
Shinichi Takayanagi
bd60c3f41f
More documentation for setting spider atributes
...
* docs: require sphinx-rtd-theme>=0.5.2 and the latest pip to prevent installing breaking docutils>=0.17
* Update feed-exports.rst
* Update feed-exports.rst
* Reflects the comments
* Remove redundant newline
* Update docs/topics/feed-exports.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* Apply suggestions from code review
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
2021-05-11 00:58:04 +05:00
Eugenio Lacuesta
cec36a9284
Refactor request to/from dict ( #5130 )
2021-05-10 18:00:08 +02:00
Renne Rocha
34b216289c
Update link for reasoning value of URLLENGTH_LIMIT ( #5134 )
2021-05-06 16:34:05 +02:00
Eugenio Lacuesta
19c7415aae
Request type hints
2021-05-01 16:34:46 -03:00
Andrey Rahmatullin
e27eff47ac
Merge pull request #5122 from hrnciar/patch-1
...
Require setuptools, scrapy/cmdline.py, /setup.py and tests/test_webclient.py import pkg_resources
2021-04-28 17:28:04 +05:00
Tomáš Hrnčiar
4f500342c8
Require setuptools, scrapy/cmdline.py, /setup.py and tests/test_webclient.py import pkg_resources
2021-04-28 11:57:44 +02:00
Eugenio Lacuesta
02ae1deaf4
Deprecate unused squeues ( #5117 )
2021-04-27 09:41:44 -03:00
Eugenio Lacuesta
ddea6b7bfa
Scheduler: minimal interface, API docs ( #3559 )
2021-04-26 16:16:14 -03:00
Eugenio Lacuesta
6837919798
Add peek method to queues ( #5112 )
2021-04-26 14:55:02 -03:00
Andrey Rahmatullin
7095df1558
Merge pull request #5082 from storymode7/shell-fix
...
Find bash from PATH instead of /bin/bash
2021-04-21 14:30:50 +05:00
Eugenio Lacuesta
e779ed7d93
Dupefilter type hints ( #5108 )
2021-04-20 21:39:07 +02:00
Eugenio Lacuesta
e3f81d8d5f
Engine: remove unnecessary parameter ( #5106 )
2021-04-20 11:46:43 -03:00
Eugenio Lacuesta
7e23677b52
Engine: deprecations and type hints ( #5090 )
2021-04-20 08:45:28 -03:00
Andrey Rahmatullin
5b78a64fca
Merge pull request #5070 from ric2b/patch-1
2021-04-15 14:50:59 +05:00
Andrey Rakhmatullin
ffca87ae88
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-04-14 21:00:27 +05:00
Andrey Rahmatullin
06f3d12c12
Merge pull request #5100 from wRAR/more-scraper-typing
...
Additional typing for scraper and a small code change.
2021-04-14 20:58:51 +05:00
Andrey Rakhmatullin
309a637f32
Small changes.
2021-04-14 20:26:37 +05:00
Andrey Rakhmatullin
77bff0db0a
Additional typing for scraper and a small code change.
2021-04-14 19:10:13 +05:00
Andrey Rahmatullin
9db01a483c
Update scrapy/core/spidermw.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-04-14 19:02:38 +05:00
Andrey Rakhmatullin
61197d3dba
Add/update typing, cleanup iterator/iterable inconsistencies.
2021-04-14 18:21:58 +05:00
Andrey Rakhmatullin
ffc6f525ce
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-04-14 17:34:58 +05:00
Andrey Rahmatullin
9bf9ab7291
Merge pull request #5077 from wRAR/deferred-typing
...
Add typing for middleware and coroutine related code.
2021-04-13 23:29:49 +05:00
Andrey Rakhmatullin
08e4eaf973
Import Deferred directly in scrapy/utils/defer.py.
2021-04-13 22:41:01 +05:00
Andrey Rakhmatullin
cef0a8b3d6
Import Deferred directly in scrapy/middleware.py.
2021-04-13 21:08:06 +05:00
Andrey Rahmatullin
a8de04c823
Update scrapy/utils/defer.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-04-13 21:05:30 +05:00
Andrey Rahmatullin
b0e7512574
Update scrapy/middleware.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-04-13 21:05:25 +05:00
Andrey Rahmatullin
335a256752
Update scrapy/core/spidermw.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-04-13 21:05:20 +05:00
Andrey Rakhmatullin
76fa2257ef
Add typing also for return values, other small fixes.
2021-04-13 20:22:02 +05:00
Andrey Rakhmatullin
5b547f0808
Merge remote-tracking branch 'origin/master' into deferred-typing
2021-04-13 19:47:20 +05:00
Andrey Rahmatullin
15edb3f656
Merge pull request #5095 from wRAR/scraper-slot-cleanup
...
Cleanup of slot handling in Scraper.
2021-04-13 19:46:26 +05:00
Andrey Rahmatullin
38010997a4
Merge pull request #5098 from storymode7/docs-update
...
Add DataURI download handler in DOWNLOAD_HANDLERS_BASE documentation
2021-04-13 18:52:10 +05:00
Mayank Singhal
a4415e4e6f
Add DataURI download handler in DOWNLOAD_HANDLERS_BASE documentation
2021-04-13 17:56:44 +05:30
Adrián Chaves
18502981f7
Merge pull request #5094 from elacuesta/fix-item-class-in-engine-tests
...
Engine tests: fix item class spider, add minimal type hints
2021-04-13 11:07:15 +02:00
Eugenio Lacuesta
d8d1dc5b50
Ignore typing warning in test
2021-04-12 10:43:02 -03:00
Andrey Rakhmatullin
4673f05dde
Cleanup of slot handling in Scraper.
2021-04-09 23:42:24 +05:00
Eugenio Lacuesta
b6f77806b0
Engine tests: fix item class spider, add minimal type hints
2021-04-09 13:09:47 -03:00
Eugenio Lacuesta
91f8144552
Remove deprecated Spider.make_requests_from_url method
2021-04-07 15:16:55 -03:00
Adrián Chaves
5a75b14a5f
docs: require sphinx-rtd-theme>=0.5.2 and the latest pip to prevent installing breaking docutils>=0.17
2021-04-07 14:04:00 +02:00
Ricardo Amendoeira
8603f9d7a5
Apply changes to other examples in the same section.
2021-04-06 20:23:07 +01:00
Andrey Rakhmatullin
e63188cbf7
Bump version: 2.4.1 → 2.5.0
2021-04-06 19:13:32 +05:00
Adrián Chaves
a71d6ef29d
2.5.0 release notes ( #5028 )
...
Co-authored-by: Eugenio Lacuesta <1731933+elacuesta@users.noreply.github.com>
2021-04-06 16:09:07 +02:00
Mayank Singhal
e7d51886ef
Find bash from PATH instead of /bin/bash
2021-04-06 02:21:18 +05:30
Andrey Rakhmatullin
7dc857668f
Also some typing for Scraper.
2021-04-04 16:15:33 +05:00
Andrey Rakhmatullin
a0101361e2
Merge remote-tracking branch 'origin/master' into deferred-typing
2021-04-04 16:01:47 +05:00
Andrey Rahmatullin
099fb6ead0
Merge pull request #5076 from wRAR/qualname
...
Use __qualname__ in middleware handling.
2021-04-04 15:52:32 +05:00
Andrey Rakhmatullin
414dd1119a
Drop an unused import.
2021-04-03 17:54:55 +05:00
Andrey Rakhmatullin
a9e96f9907
Add typing for middleware and coroutine related code.
2021-04-03 17:40:45 +05:00
Andrey Rakhmatullin
9e3b868dd8
Use __qualname__ in middleware handling.
2021-04-03 17:04:09 +05:00
Andrey Rakhmatullin
7bd1d888d4
More robust sync/async middleware mix checking.
2021-04-02 23:07:24 +05:00
Andrey Rakhmatullin
30ed7fa349
Some cleanup, make sync middlewares fail earlier.
2021-04-02 22:20:56 +05:00
Andrey Rakhmatullin
849472535e
Update docs.
2021-04-02 20:20:35 +05:00
Mikhail Korobov
8c5a3a5189
Merge pull request #5073 from elacuesta/fix-urlencode-doseq-arg
...
Fix type for urlencode's doseq argument
2021-04-02 00:51:15 +05:00
Eugenio Lacuesta
9e7cbc05ae
Fix type for urlencode's doseq argument
2021-04-01 15:22:51 -03:00
Mikhail Korobov
127a8586e1
Merge pull request #5063 from noviluni/update_usageError_message
...
Update UsageError message
2021-04-01 22:47:59 +05:00
Mikhail Korobov
12f2006b7b
Merge pull request #4799 from GeorgeA92/patch-2
...
httpcompression stats added
2021-04-01 22:47:24 +05:00
Mikhail Korobov
f0c8d31193
Merge pull request #4694 from Jgaldos/improve-httpstatus-all-meta
...
Improve http status all on http error middleware
2021-04-01 22:43:45 +05:00
Akshay Sharma
cc095aa895
Windows pip installation guide ( #4736 )
...
* added initial steps
* fixing link
* python3 -> python
* remaining steps
* steps updated
* Update docs/intro/install.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* added link to Visual Studio
* removed 'install V'
* Update docs/intro/install.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-04-01 22:39:33 +05:00
Mikhail Korobov
0007a4c117
Merge pull request #4895 from elacuesta/minimal-type-hints
...
Some type hints
2021-04-01 22:36:33 +05:00
Kader DJEHAF
ad74567469
Fix argument type (int -> bool) ( #4950 )
...
* Fix warning: Expected type 'bool', got 'int' instead
* Update defer.py
* Fix warning: Expected type 'bool', got 'int' instead
Co-authored-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
2021-04-01 22:33:56 +05:00
anay2103
5492972d8a
added customized filtering examples in logging.rst ( #4965 )
...
* added customized filtering examples in logging.rst
* Update logging.rst
* Update docs/topics/logging.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* Update docs/topics/logging.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* Update docs/topics/logging.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* Update docs/topics/logging.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* Update logging.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-04-01 22:30:48 +05:00
Mikhail Korobov
b09ff99d81
Merge pull request #4974 from Gallaecio/ul-margin
...
Move lists closer to their introducing paragraph
2021-04-01 22:27:59 +05:00
Mikhail Korobov
e0a2d2b3c9
Merge pull request #5014 from jpmckinney/patch-1
...
docs: Clarify there's one extension instance per crawler
2021-04-01 22:26:20 +05:00
Mikhail Korobov
d0e23486b4
Merge pull request #4902 from Gallaecio/retry-request
...
Implement a retry request function
2021-04-01 22:23:56 +05:00
Eugenio Lacuesta
d458ccff3b
Retry request: priority_adjust cannot be float (Request.priority is int)
2021-04-01 12:27:35 -03:00
Mikhail Korobov
9a91586f6f
Merge pull request #5072 from zloidemon/rebranding_update_ga
...
Updated GA code for docs, remove Segment tracking
2021-04-01 20:26:11 +05:00
Veniamin Gvozdikov
90fe494ba2
Rebranding, updated GA code
2021-04-01 11:11:28 +03:00
Ricardo Amendoeira
b247fa9982
Include loading settings in `Running multiple spiders in the same process` section
...
The example in the documentation doesn't take into account the project settings
2021-03-29 01:48:28 +01:00
Andrey Rakhmatullin
6803779eb7
Add more tests for _process_iterable_universal.
2021-03-26 22:29:07 +05:00
Andrey Rakhmatullin
b5f501df7b
Remove some unneeded code from _AsyncCooperatorAdapter.
2021-03-26 20:17:41 +05:00
Eugenio Lacuesta
1d200258a5
Adjust h2 version requirement ( #5066 )
2021-03-26 14:45:26 +01:00
Andrey Rakhmatullin
7b515a0485
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-03-25 22:13:49 +05:00
Andrey Rakhmatullin
0638d6f01c
Fix handling middlewares that change sync iterables into async.
2021-03-25 21:58:29 +05:00
Andrey Rakhmatullin
f422861ef4
Add more tests for spider middlewares.
2021-03-25 20:49:12 +05:00
Andrey Rakhmatullin
a97dc55c71
Add/improve docs.
2021-03-25 20:49:12 +05:00
Andrey Rakhmatullin
0596f2bf6e
Remove not needed deferred_from_coro call.
2021-03-25 20:49:07 +05:00
Eugenio Lacuesta
9c9e1a318d
[HTTP/1.1] Skip Content-Length header if its value is UNKNOWN_LENGTH ( #5062 )
2021-03-25 15:58:39 +01:00
Andrey Rakhmatullin
a6034f942b
Add tests for _AsyncCooperatorAdapter.
2021-03-23 22:47:37 +05:00
Andrey Rakhmatullin
c51ec1ae1c
Drop process_iterable_helper, add _process_iterable_universal.
2021-03-23 22:47:30 +05:00
Pratik Mahankal
f0e1a33225
Sort the list of Request.meta alphabetically #5061 ( #5065 )
2021-03-23 22:16:50 +05:00
Marc
64d4ae1a19
Update UsageError message
2021-03-22 21:46:05 +01:00
Eugenio Lacuesta
72e8cea8af
Avoid exceptions in is_generator_with_return_value ( #4935 )
2021-03-22 11:51:11 -03:00
Adrián Chaves
ec5a7918ec
Include Content-Length in HTTP/1.1 responses ( #5057 )
2021-03-22 11:25:40 +01:00
Adrián Chaves
2973d8d51a
Remove unnecessary reference to private parsel.Selector._default_type ( #5006 )
2021-03-22 11:24:10 +01:00
Mikhail Korobov
0e7ee1256c
Merge pull request #5036 from dmiwell/urllength-dont-skip-silently
...
UrlLengthMiddleware: don't skip silently
2021-03-20 00:55:33 +05:00
Adrián Chaves
308a58aa27
Update CI to support Twisted 21.2.0 ( #5027 )
2021-03-19 18:39:44 +01:00
Adrián Chaves
0dad0fce72
Use pip<20.3 to fix ReadTheDocs builds ( #5052 )
2021-03-19 11:13:05 +01:00
Adrián Chaves
8e302f2906
Merge pull request #5053 from Gallaecio/constraints
...
Fix master CI issues due to pip backtracking
2021-03-19 10:34:36 +01:00
Adrián Chaves
a390b934de
Do not install mitmproxy in Python 3.9
2021-03-18 23:53:58 +01:00
Adrián Chaves
8e73e1dfb5
upper-constraints.txt: restrict botocore further
2021-03-18 23:42:29 +01:00
Adrián Chaves
94201612bc
Simplify the get_retry_request code example
2021-03-18 23:35:47 +01:00
Adrián Chaves
1d83697990
Merge pull request #4769 from scrapy/http2
...
Implement experimental HTTP/2 support
2021-03-18 22:18:12 +01:00
vinayak
42e4dbb23d
Support Python 3.9 ( #4759 )
...
* Update .travis.yml
* Update .travis.yml
* updage travis.yml
* Make 3.9 support official
* Upgrade mitmproxy for Python 3.9
* Restore the Pylint job
* Undo unintended change to mitmproxy requirement
* Enable Python 3.9 in GitHub Actions
* Work around reppy’s Python version limitation
* Disable tests in Windows / Python 3.9 due to a Twisted bug
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2021-03-18 09:40:03 -03:00
Eugenio Lacuesta
2f61d7cc03
Remove unnecesary del statement
2021-03-15 14:25:46 -03:00
Dmitriy Pomazunovskiy
9cc4513bd6
simpler stats access
2021-03-15 21:38:03 +06:00
Adrián Chaves
c0f3ca1938
get_retry_request: add typing information
2021-03-12 14:05:44 +01:00
Dmitriy Pomazunovskiy
0f254a6afb
Test from_settings
2021-03-12 17:11:50 +06:00
Dmitriy Pomazunovskiy
d4b2b61255
Use from_settings for backward compatibility
2021-03-12 16:59:37 +06:00
Dmitriy Pomazunovskiy
6e5ea7924c
Log skipped urls by length to INFO, add skipped stats
2021-03-12 11:08:41 +06:00
Mikhail Korobov
ab037ab7c9
Merge pull request #5016 from deepang17/scrapy-4996
...
DOCS: Cover scrapy-bench in the documentation
2021-03-12 04:18:56 +05:00
Eugenio Lacuesta
0c16088230
headers_received signal ( #4897 )
2021-03-11 11:52:35 -03:00
Adrián Chaves
3bea5e1a97
Remove unused _is_data_lost method
2021-03-09 16:19:51 +01:00
Adrián Chaves
5b2d3e17a3
Merge branch 'master' into http2
2021-03-09 14:59:17 +01:00
deepang17
2d41c77e6a
Merge branch 'master' of https://github.com/scrapy/scrapy into scrapy-4996
2021-03-09 17:33:05 +05:30
deepang17
3d88ac605b
FIX: Updated benchmarking.rst
2021-03-09 17:19:34 +05:30
Andrey Rahmatullin
954c4b48e6
Merge pull request #3667 from Gallaecio/long-allowed-domains
...
Add a FAQ entry on how to deal with long lists of allowed domains
2021-03-05 20:16:37 +05:00
Adrián Chaves
dfd4ab2b6c
Merge pull request #3 from elacuesta/retry-request-customization
...
Allow logger/stats customization in get_retry_request
2021-03-03 16:30:08 +01:00
Andrey Rahmatullin
d50bedbeea
Merge pull request #5022 from Gallaecio/fix-ci
...
Limit tests to Twisted < 21
2021-03-03 16:45:00 +05:00
Adrián Chaves
4fe26ae970
Limit tests to Twisted < 21
2021-03-02 19:46:34 +01:00
deepang17
36f1dbf665
DOCS: Covered scrapy-bench
2021-03-02 22:12:44 +05:30
Eugenio Lacuesta
9e62355271
Allow logger/stats customization in get_retry_request
2021-03-02 12:12:22 -03:00
James McKinney
3c5668d0db
docs: Clarify there's one extension instance per spider
2021-03-01 22:00:33 -05:00
deepang17
b25616d107
DOCS: Cover scrapy-bench in the documentation
2021-02-28 16:26:46 +05:30
deepang17
7a54580679
DOCS:Cover scrapy-bench in the documentation
2021-02-28 15:33:09 +05:30
Mikhail Korobov
f95ebd8f7c
Merge pull request #5002 from djikoSal/refactor-curl-to-request-kwargs
...
Refactor curl_to_request_kwargs #5001
2021-02-25 02:00:55 +05:00
Mikhail Korobov
bda5472943
Merge pull request #5008 from Gallaecio/close-file
...
Close files in the PerYearXmlExportPipeline documentation example
2021-02-25 01:49:59 +05:00
Adrián Chaves
f689615e8d
Close files in the PerYearXmlExportPipeline documentation example
2021-02-24 12:54:56 +01:00
Djiar
3894ebb149
Refactor curl_to_request_kwargs #5001
...
Co-authored-by: alkazaz alkazaz@kth.se
Co-authored-by: swill swill@kth.se
Co-authored-by: lerjevik lerjevik@kth.se
Co-authored-by: aljica aljica@kth.se
2021-02-24 11:04:48 +01:00
Adrián Chaves
386e2a51ae
tests/test_downloader_handlers_http2.py: fix style issue
2021-02-24 10:41:01 +01:00
Adrián Chaves
12064d799b
HTTP/2: improve header handling
2021-02-24 10:37:38 +01:00
Wehzie
a36f952198
fixed typo "an quotes.json" -> "a quotes.json" ( #5005 )
2021-02-24 08:15:44 +01:00
Adrián Chaves
5101094207
HTTP/2: test a CONNECT request
2021-02-24 07:33:39 +01:00
Adrián Chaves
5ba31cd1a2
HTTP/2 stream close reason handling: Use else + assert instead of elif
2021-02-23 11:57:33 +01:00
Adrián Chaves
bd29f32dee
HTTP/2: do not make conn_lost_deferred optional
2021-02-23 06:42:28 +01:00
Adrián Chaves
7605f19ec4
HTTP/2: test 2 concurrent requests to the same domain
2021-02-23 05:54:48 +01:00
Eugenio Lacuesta
6326178bc5
http2: acceptable protocol update, tests ( #4994 )
2021-02-22 16:50:51 +01:00
Adrián Chaves
1f7665c4cf
Silence a PyLint check on a mistake made for testing purposes
2021-02-22 16:48:10 +01:00
Adrián Chaves
722a33a2ac
Fix style issues
2021-02-22 16:42:38 +01:00
Adrián Chaves
80f5003c88
Add tests for get_retry_request
2021-02-22 16:38:38 +01:00
Adrián Chaves
6ab990181c
Document get_retry_requests
2021-02-22 14:48:03 +01:00
Adrián Chaves
ec836dcc92
Solve style issues
2021-02-22 14:15:28 +01:00
Adrián Chaves
3f5a1956d8
Merge remote-tracking branch 'upstream/master' into retry-request
2021-02-22 14:10:26 +01:00
Adrián Chaves
825462615a
get_retry_request: set the default retry reason to “unspecified”
2021-02-22 14:09:48 +01:00
Adrián Chaves
5fc27b1e6f
Remove RetrySpiderMixin and retry_request
2021-02-22 14:09:06 +01:00
Andrey Rakhmatullin
f9a5385146
Revert "Move spider middlewares to process_iterable_helper."
...
This reverts commit 92f2c9e308 .
2021-02-19 21:19:21 +05:00
Andrey Rakhmatullin
fa8de2d396
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-02-18 23:06:06 +05:00
Andrey Rakhmatullin
40eab1d473
Drop a duplicate import.
2021-02-18 19:56:12 +05:00
Andrey Rahmatullin
fa3ebb1ced
Merge pull request #4987 from wRAR/asyncdef-tests
...
Making sure we can run async def tests
2021-02-18 18:34:25 +05:00
Andrey Rakhmatullin
58706c6598
Merge branch 'asyncdef-tests' into asyncio-parse-asyncgen-proper-rebased
2021-02-18 17:20:25 +05:00
Andrey Rakhmatullin
49af7c4c8b
Drop pytest-twisted, use Scrapy code to install the reactor.
2021-02-18 17:10:30 +05:00
Eugenio Lacuesta
4418f78941
Simplify check for negotiated protocol
...
negotiatedProtocol's type is Optional[bytes]
See https://github.com/twisted/twisted/blob/twisted-20.3.0/src/twisted/protocols/tls.py#L563-L587
and https://www.pyopenssl.org/en/20.0.1/api/ssl.html#OpenSSL.SSL.Connection.get_alpn_proto_negotiated
Note that OpenSSL.SSL.Connection.get_next_proto_negotiated is deprecated:
https://www.pyopenssl.org/en/20.0.0/changelog.html#backward-incompatible-changes
2021-02-17 18:36:52 -03:00
Eugenio Lacuesta
e80f37bd3f
Test http2 agent for unsupported scheme
2021-02-17 16:34:29 -03:00
Eugenio Lacuesta
ac82a4a8a0
Merge remote-tracking branch 'upstream/master' into http2
2021-02-17 16:33:57 -03:00
Andrey Rakhmatullin
abbbfbbb38
Add tests for deferred_f_from_coro_f.
2021-02-12 22:41:16 +05:00
Andrey Rakhmatullin
a7557f2a49
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-02-11 16:09:14 +05:00
Adrián Chaves
ea92b49aaa
Merge pull request #4986 from wRAR/uvloop-py36
...
Skip uvloop 0.15.0+ on py36.
2021-02-11 12:07:28 +01:00
Andrey Rakhmatullin
54fd371481
Skip uvloop 0.15.0+ on py36.
2021-02-11 14:24:11 +05:00
Andrey Rakhmatullin
67cff0e8a9
Silence pylint "naked raise" error.
2021-02-10 22:44:14 +05:00
Adrián Chaves
15b501c089
Do not force string interpolation while logging
2021-02-10 18:10:57 +01:00
Andrey Rakhmatullin
1cd953e1b0
Merge remote-tracking branch 'origin/master' into asyncio-parse-asyncgen-proper-rebased
2021-02-09 13:28:36 +05:00
Adrián Chaves
9ac5b1d021
Adjust test constraints
2021-02-09 09:13:25 +01:00
Adrián Chaves
bb72bba178
tox: apply upper constraints to all non-pinned package installations
2021-02-09 09:13:25 +01:00
Adrián Chaves
45345ba6b5
Use constraints.txt to limit pip resolver backtracking
2021-02-09 09:13:25 +01:00
Adrián Chaves
de82ca8547
Merge pull request #4982 from wRAR/refactor-spidermiddlewaremanager
...
Refactor SpiderMiddlewareManager.scrape_response.
2021-02-08 21:27:21 +01:00
Andrey Rakhmatullin
1e9b52c3e0
Refactor SpiderMiddlewareManager.scrape_response.
2021-02-08 22:02:03 +05:00
Andrey Rakhmatullin
5cf403295d
Remove a duplicate definition.
2021-02-05 19:40:14 +05:00
Adrián Chaves
8527b53e14
Revert "Use --use-deprecated=legacy-resolver"
...
This reverts commit 7b11b74c77 .
2021-02-05 13:06:27 +01:00
Adrián Chaves
7afcd634ab
Remove unused import
2021-02-05 13:04:54 +01:00
Andrey Rakhmatullin
58f8481301
Update docs.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
2152a2a508
Add main infrastructure for async callbacks.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
2a1e9359ca
Add parallel_async.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
92f2c9e308
Move spider middlewares to process_iterable_helper.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
d66d52d3ed
Add process_iterable_helper.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
d658552f23
Add only_not_asyncio.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
7e9f498e00
Add MutableAsyncChain.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
acff1eb496
Add aiter_errback.
2021-02-05 16:21:56 +05:00
Andrey Rakhmatullin
76abcedaf4
Add as_async_generator.
2021-02-05 16:21:56 +05:00
Adrián Chaves
7b11b74c77
Use --use-deprecated=legacy-resolver
...
Let’s see how test results change
2021-02-04 11:08:01 +01:00
Adrián Chaves
0e4b291701
HTTP/2: fix canceling a request before a connection has been established
2021-02-03 21:28:04 +01:00
Adrián Chaves
248800328c
Fix test_pinned_twisted_version
2021-02-03 21:13:43 +01:00
Adrián Chaves
4c801551fa
Document that the bytes_received signal is not yet implemented for HTTP/2
2021-02-03 21:11:46 +01:00
Adrián Chaves
1773eaf5dc
Move lists closer to their introducing paragraph
2021-02-03 11:43:18 +01:00
Adrián Chaves
1a7bde0d8e
Document that HTTP/2 server pushes are ignored
2021-02-03 10:55:11 +01:00
Adrián Chaves
c8d8b180bf
Merge remote-tracking branch 'upstream/master' into http2
2021-02-03 09:37:35 +01:00
Adrián Chaves
536e749ecc
HTTP/2: remove verbose protocol-handling logging
2021-02-03 09:22:02 +01:00
Adrián Chaves
d1024566d8
setup.py: Twisted → Twisted[http2]
2021-02-03 09:13:45 +01:00
Adrián Chaves
2ce8e0c742
Document the (hard-coded) maximum HTTP/2 frame size accepted from servers
2021-02-03 09:09:53 +01:00
Mikhail Korobov
904a50138b
Merge pull request #4973 from Gallaecio/zyte
...
Scrapinghub → Zyte
2021-02-03 01:10:52 +05:00
Adrián Chaves
f30f53b3cc
Scrapinghub → Zyte
2021-02-02 15:03:20 +01:00
Mikhail Korobov
28262d4b24
Merge pull request #4956 from Gallaecio/readme-contributors
...
Mention contributors in the README
2021-01-14 19:58:52 +05:00
Adrián Chaves
6e7ae789f9
Reuse the text from https://scrapy.org/
2021-01-14 11:59:38 +01:00
M Ikram Ullah Khan
0a1e2fefab
Docs: fix typo in news.rst ( #4942 )
2021-01-04 10:30:23 -03:00
Eugenio Lacuesta
80db569aea
Migrate CI to GitHub actions ( #4924 )
2021-01-01 19:13:39 -03:00
Eugenio Lacuesta
e494a3f733
protocol attribute for h2 responses
2020-12-31 11:50:15 -03:00
Eugenio Lacuesta
d698b5147b
Merge branch 'master' into http2
2020-12-31 11:13:25 -03:00
Kader DJEHAF
44a7ab5bf0
Fix warning: Expected type 'bool', got 'int' instead ( #4940 )
...
* Fix warning: Expected type 'bool', got 'int' instead
* Update defer.py
2020-12-30 11:22:27 -03:00
Adrián Chaves
39bc9a4d28
Merge pull request #4814 from dswij/tox-pip20.2
...
add pip 20.2 test for tox
2020-12-24 15:31:42 +01:00
Adrián Chaves
24e1b350ae
Merge pull request #4936 from timgates42/bugfix_typo_without
...
docs: fix simple typo, wihout -> without
2020-12-22 13:57:03 +01:00
Tim Gates
6dccf82eaa
docs: fix simple typo, wihout -> without
...
There is a small typo in scrapy/http/request/form.py.
Should read `without` rather than `wihout`.
2020-12-22 07:49:13 +11:00
Eugenio Lacuesta
b83a1a6fbf
Disable test under pypy
2020-12-21 17:21:08 +01:00
Adrián Chaves
45eb099ed1
Maybe it’s about having a newer libssl
2020-12-21 15:37:02 +01:00
Adrián Chaves
1c1255a75d
Use sudo for apt-get
2020-12-21 14:41:02 +01:00
Adrián Chaves
798a818caf
Move apt-get command from Tox to Travis CI
2020-12-21 13:35:40 +01:00
Adrián Chaves
0dff5781bc
Blind attempt to fix the build of the cryptography-provided OpenSSL
2020-12-21 11:13:14 +01:00
Adrián Chaves
0567fdc56e
Merge remote-tracking branch 'upstream/master' into tox-pip20.2
2020-12-21 11:02:05 +01:00
Adrián Chaves
d0af008608
Merge pull request #4878 from elacuesta/response-protocol-attribute
...
Response.protocol attribute
2020-12-16 15:27:40 +01:00
Mikhail Korobov
212163e199
Merge pull request #4912 from elacuesta/remove_deprecated_pickled_settings_to_override
...
Remove deprecated SCRAPY_PICKLED_SETTINGS_TO_OVERRIDE
2020-12-04 01:36:47 +05:00
gunadhya
db10aaf9eb
Update links in installation guide ( #4899 )
2020-12-03 10:56:36 +01:00
Eugenio Lacuesta
ef09e0d10f
Some type hints
2020-12-02 10:39:10 -03:00
Eugenio Lacuesta
6091f3cc03
Remove unused pickle import
2020-12-01 10:26:21 -03:00
Eugenio Lacuesta
a80bafe5cd
Remove deprecated SCRAPY_PICKLED_SETTINGS_TO_OVERRIDE
2020-11-30 19:03:13 -03:00
Kader DJEHAF
7fec9f991f
[Cleaned] PEP 8: E251 unexpected spaces around keyword / parameter equals ( #4911 )
...
[Cleaned] PEP 8: E251 unexpected spaces around keyword / parameter equals
2020-11-30 17:47:28 -03:00
Adrián Chaves
487e19528b
Merge pull request #4901 from elacuesta/remove_deprecated_stuff
...
Remove deprecated stuff
2020-11-30 14:41:40 +01:00
Mikhail Korobov
aed1707f24
Merge pull request #4909 from etimoz/exporters-doc-super-fix
...
Removed wrong super argument in overriding serialize_fields code example
2020-11-29 23:09:20 +05:00
etimoz
95d39d5cb4
removed wrong super argument in overriding serialize_fields code example
2020-11-29 13:24:04 +01:00
Andrey Rahmatullin
440e45d172
Merge pull request #4900 from elacuesta/deprecate_utils_py36
...
Deprecate scrapy.utils.py36 module
2020-11-24 23:59:00 +05:00
Adrián Chaves
f6879c681e
SCRAPY_PINNED → _SCRAPY_PINNED
2020-11-23 23:53:03 +01:00
Adrián Chaves
a752fa072e
Implement retry request functions and mixin
2020-11-23 22:58:54 +01:00
Adrián Chaves
0dc3e6350c
Add a test to check the Twisted version in pinned environments
2020-11-23 22:10:45 +01:00
Eugenio Lacuesta
fe8bb6bd90
Fix import
2020-11-23 16:51:04 -03:00
Eugenio Lacuesta
18b05af877
Remove tests/test_utils_http.py
2020-11-23 16:18:58 -03:00
Eugenio Lacuesta
0a93df9efd
Move collect_asyncgen to utils.asyncgen
2020-11-23 16:16:18 -03:00
Eugenio Lacuesta
462014bc57
Scheduler: remove support for deprecated queuelib.PriorityQueue
2020-11-23 15:51:59 -03:00
Eugenio Lacuesta
51ca4d0138
Remove deprecated scrapy.utils.gz.is_gzipped function
2020-11-23 15:47:08 -03:00
Eugenio Lacuesta
4075e1eadd
Remove deprecated modules (utils.http/markup/multipart)
2020-11-23 15:07:56 -03:00
Eugenio Lacuesta
075ab156b0
Deprecate scrapy.utils.py36 module
2020-11-23 11:59:59 -03:00
Adrián Chaves
07379cf9b7
Merge branch 'master' into allow-customizing-export-column-names
2020-11-20 20:06:18 +01:00
Adrián Chaves
e17c890be1
Merge pull request #4898 from scrapy/2.4
...
Scrapy 2.4.1
2020-11-19 20:31:57 +01:00
Adrián Chaves
08f5ed712f
Fix memory issue due to unexpectedly large server frames
2020-11-18 17:38:18 +01:00
Adrián Chaves
bde96a5ad9
Ignore server-initiated events
2020-11-18 16:42:44 +01:00
Adrián Chaves
6ef3dc2029
Use the new pip resolver for Tox environments with pinned dependencies
2020-11-17 22:28:20 +01:00
Adrián Chaves
63becd1bc8
Update news.rst
2020-11-17 21:58:08 +01:00
Adrián Chaves
26836c4e1a
Bump version: 2.4.0 → 2.4.1
2020-11-17 09:17:39 +01:00
Adrián Chaves
15d301e968
Cover Scrapy 2.4.1 in the release notes ( #4884 )
...
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-11-17 09:16:08 +01:00
Eugenio Lacuesta
2405df49f1
Add tests for Response.protocol=None
2020-11-16 12:50:33 -03:00
joaquin garmendia
85604e1078
Add failed and success count stats to feedstorage backends ( #4850 )
2020-11-11 21:16:01 +01:00
Adrián Chaves
034d61e6cb
Restrict pip’s --use-feature=2020-resolver to the extra-deps environment
2020-11-11 16:46:03 +01:00
Eugenio Lacuesta
b0368228d7
Add exception to catch
2020-11-11 11:18:03 -03:00
Eugenio Lacuesta
5e9a99e6a1
Reponse.protocol as string
2020-11-11 11:15:29 -03:00
Eugenio Lacuesta
2242412556
Docs: placeholder for versionadded directive
2020-11-11 10:50:54 -03:00
Eugenio Lacuesta
61d089485c
Docs: sort versionadded directives
2020-11-11 01:31:21 -03:00
Eugenio Lacuesta
0fb7bcb2cf
Style adjustment
2020-11-11 01:26:08 -03:00
Eugenio Lacuesta
587b4dd71f
Docs for the Response.protocol attribute
2020-11-11 01:22:33 -03:00
Eugenio Lacuesta
5b6b56240c
Test Response.protocol attribute
2020-11-11 01:08:37 -03:00
Eugenio Lacuesta
99cc853d69
Response.protocol attribute
2020-11-11 00:44:11 -03:00
Eugenio Lacuesta
c20b34269f
Remove unnecessary pytest-azurepipelines package ( #4876 )
2020-11-10 15:35:09 -03:00
Mikhail Korobov
91a8451c98
Merge pull request #4874 from stummjr/fix-missing-fstring-prefix-genspider
...
Fix incorrect output on the genspider command
2020-11-10 17:23:28 +05:00
Mikhail Korobov
27b07c692c
Merge pull request #4872 from elacuesta/asyncio_get_event_loop
...
Call asyncio.get_event_loop when installing the asyncio reactor
2020-11-10 17:22:20 +05:00
Eugenio Lacuesta
b20cfef1e5
Remove unnecessary line from test
2020-11-09 13:58:52 -03:00
Eugenio Lacuesta
7e98a76ac4
Use deferred_from_coro in asyncio test
2020-11-09 12:17:15 -03:00
Valdir Stumm Junior
a2c4a7f920
Add missing f-string prefix to genspider output
2020-11-08 20:14:59 -03:00
Eugenio Lacuesta
114229eb4a
Docs: add a note about asyncio.set_event_loop
2020-11-06 13:29:14 -03:00
Adrián Chaves
4b28da4333
Fix syntax error
2020-11-06 16:46:22 +01:00
Adrián Chaves
f3064254ce
Merge branch 'patch-2' of github.com:GeorgeA92/scrapy into patch-2
2020-11-06 16:42:58 +01:00
Adrián Chaves
ee98771fa7
Remove unused variable
2020-11-06 16:42:32 +01:00
Adrián Chaves
1941f607ca
Skip 2 additional tests with older Twisted versions
2020-11-06 16:25:56 +01:00
Eugenio Lacuesta
3095d39740
Test: disable asyncio reactor on Windows for Py>=3.8
2020-11-06 12:16:18 -03:00
Adrián Chaves
5d2a9cf5b1
Merge branch 'master' into patch-2
2020-11-06 14:17:54 +01:00
Adrián Chaves
a3e53027ec
Test HttpCompressionMiddleware subclasses with custom, parameterless __init__
2020-11-06 14:16:26 +01:00
Adrián Chaves
fea5a11899
Also skip test_asyncdef_asyncio on old Twisted versions
2020-11-06 13:00:42 +01:00
Adrián Chaves
ea851b910e
Clean up Twisted version check
2020-11-06 13:00:31 +01:00
Eugenio Lacuesta
5b5478ae9d
Call asyncio.get_event_loop when installing the asyncio reactor
2020-11-05 14:01:34 -03:00
Eugenio Lacuesta
c292957cb1
Run Windows tests on GitHub actions ( #4869 )
2020-11-05 15:15:58 +01:00
Adrián Chaves
6eaf0c5cc9
Use Ubuntu Bionic for PyPy tests to try to get a newer OpenSSL version recognized
2020-11-04 21:54:00 +01:00
Adrián Chaves
906626cf0b
Skip MiddlewareUsingCoro::test_asyncdef on asyncio and old Twisted
2020-11-04 21:50:12 +01:00
Adrián Chaves
8e7b756727
Solve Flake8-reported issues
2020-11-04 21:26:55 +01:00
Adrián Chaves
7327145bf3
Remove mitmproxy from pinned environments
2020-10-30 21:34:15 +01:00
Georgiy Zatserklianyi
e9c3188189
Update scrapy/downloadermiddlewares/httpcompression.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-10-30 21:23:29 +02:00
Georgiy Zatserklianyi
a5872a0fad
Fix output file overwrite with -O (FeedExporter updated) ( #4859 )
2020-10-30 19:36:39 +01:00
Adrián Chaves
3e5bc77737
Remove pinning from the PyPy job
2020-10-30 10:31:33 +01:00
Adrián Chaves
13bcdc9f88
Restore pinned dependencies in tox.ini
2020-10-30 10:28:42 +01:00
Adrián Chaves
7187247c01
Add PyDispatcher>=2.0.5 back to dependencies for old pip
2020-10-30 10:23:59 +01:00
Andrey Rahmatullin
75f35f558f
Merge pull request #4803 from elacuesta/instantiate-resolution-receiver
...
CachingHostnameResolver
2020-10-20 13:55:07 +05:00
Eugenio Lacuesta
585e4a8aee
Replace local server address
2020-10-15 09:07:34 -03:00
GeorgeA92
872b2e4ce4
testcase added for COMPRESSION_ENABLED setting
2020-10-13 18:41:58 +03:00
GeorgeA92
d32d0d2739
testcase added for HttpCompressionMiddleware with no stats
2020-10-13 18:36:41 +03:00
GeorgeA92
fd663fd4ad
__init__ stats parameter - optional, stats==None - covered.
2020-10-13 18:35:06 +03:00
Adrián Chaves
c340e72988
Bump version: 2.3.0 → 2.4.0
2020-10-11 22:12:45 +02:00
Adrián Chaves
47eac83740
Set a release date for Scrapy 2.4.0
2020-10-11 22:11:14 +02:00
Adrián Chaves
015c82b974
Scrapy 2.4 release notes ( #4808 )
2020-10-11 22:09:45 +02:00
Eugenio Lacuesta
868826b346
CachingHostnameResolver tests
2020-10-09 10:38:07 -03:00
Eugenio Lacuesta
8fe5876597
HostResolution implementation
2020-10-09 10:38:07 -03:00
Eugenio Lacuesta
b55c911ddc
Fix CachingHostnameResolver
2020-10-09 10:38:03 -03:00
Andrey Rahmatullin
da426fb3cf
Merge pull request #4839 from elacuesta/pytest_xfail_strict
...
Add xfail_strict=true to pytest.ini
2020-10-09 00:39:05 +05:00
Eugenio Lacuesta
13ae17aecc
Add xfail_strict=true to pytest.ini
2020-10-08 14:04:52 -03:00
Andrey Rahmatullin
9f8c3938cc
Merge pull request #4823 from elacuesta/cookies-revert-header
...
Do not process cookies from headers
2020-10-08 20:20:32 +05:00
Andrey Rahmatullin
45c06cfd80
Merge pull request #4831 from starrify/downloadermw-support-zstd
...
Adding support for zstd in HttpCompressionMiddleware
2020-10-08 14:08:18 +05:00
Andrey Rahmatullin
8fc4e2e011
Merge pull request #4836 from OfirD1/patch-1
...
moved the sentence about processing pending requests when a spider is closed onto a generic note.
2020-10-07 16:00:38 +05:00
Andrey Rahmatullin
ded9a5a085
Merge pull request #4835 from Gallaecio/about-url-support
...
Do not consider about: URLs invalid
2020-10-07 14:50:28 +05:00
dswij
9461414b14
minor changes to remove unnecessary lines
2020-10-07 11:26:53 +07:00
Adrián Chaves
269fe35d6d
Merge branch 'master' into http2
2020-10-06 21:05:10 +02:00
OfirD1
1a597d5e3d
moved the sentence about processing pending requests when a spider is closed onto a generic note.
2020-10-06 21:54:42 +03:00
P. Chen
156bb0a1d4
Fixing the minor typo on test file path in tests/test_downloadermiddleware_httpcompression.py
2020-10-06 19:53:40 +01:00
P. Chen
2e734e6b35
Minor update on the import order in scrapy/downloadermiddlewares/httpcompression.py
2020-10-06 19:51:05 +01:00
dswij
9f02df20c5
Remove PyDispatcher from general requirements
2020-10-07 01:10:23 +07:00
Adrián Chaves
e40788153c
Do not consider about: URLs invalid
2020-10-06 19:13:29 +02:00
GeorgeA92
6050604f62
httocompression/response_bytes tests added
2020-10-06 18:59:57 +03:00
Andrey Rahmatullin
b1255b016a
Merge pull request #4746 from Gallaecio/fix_iternodes
...
Fix iternodes
2020-10-06 20:14:04 +05:00
Andrey Rahmatullin
9b1f86b613
Use f-strings
2020-10-06 18:50:55 +05:00
Eugenio Lacuesta
137c8ba6ee
Docs: mention limitation about Cookie header
2020-10-06 10:50:17 -03:00
Andrey Rahmatullin
1aeda66435
Merge pull request #4804 from Gallaecio/mock-s3
...
Use mocking for S3 tests that currently need server credentials
2020-10-06 18:23:01 +05:00
dswij
ce6884d517
Update tox.ini
2020-10-06 19:51:42 +07:00
dswij
371bb80868
Explicitly declare PyDispatcher as dependencies
2020-10-06 19:45:05 +07:00
P. Chen
6032a9a310
Minor adjustment to the test case in tests/test_downloadermiddleware_httpcompression.py
2020-10-05 23:55:48 +01:00
P. Chen
50e1f35d1f
Adding test cases for the zstd content encoding
2020-10-05 23:43:12 +01:00
P. Chen
da3171d4f7
Using the `zstandard` package than `zstd` for supporting frames both with and without the content size info
...
See also: https://github.com/sergey-dryabzhinsky/python-zstd/issues/53
2020-10-05 23:18:58 +01:00
P. Chen
c6c3f2ce66
Updating the doc entry for the HTTP compress downloader middleware on zstd
2020-10-05 21:10:40 +01:00
P. Chen
892dd9da57
Adding support for zstd in HttpCompressionMiddleware
2020-10-05 21:03:01 +01:00
D R Siddhartha
0c24cdb257
Improved warning messages a little
2020-10-04 02:09:21 +05:30
Adrián Chaves
004b40a719
as soon as → as long as ( #4825 )
2020-10-02 19:53:55 -03:00
Eugenio Lacuesta
797a6690c0
Tests: use classes instead of paths in settings ( #4817 )
2020-10-01 23:11:11 -03:00
Mikhail Korobov
4f27c5f82b
Merge pull request #4768 from maranqz/feature/4606-exporter-from-FEEDS
...
Pass info from FEEDS to ItemExporter
2020-10-02 00:10:05 +05:00
Mikhail Korobov
f173af6b9d
Merge pull request #4778 from drs-11/unparseable-no-proxy-fix
...
Check for unparseable no_proxy values
2020-10-01 23:57:00 +05:00
Akshay Sharma
159e2b2e2f
allowing to run .pyw files ( #4646 )
...
* allow .pyw in scrapy/commands/runspider.py
* aesthetics
* added tests for '.pyw'
* created class for testing .pyw files
* name=None parameter in get_log
* small fix
* .pyw tests for non-windows
* used @skipIf for tests
* two more tests skipped
2020-10-01 23:53:08 +05:00
Habeeb Shopeju
f47b120e2b
Documentation of link extractor usage ( #4775 )
...
* Added description when using link extractor outside crawlspiders and created reference documentation for scrapy.link.Link class
* Added link.rst to toctree
* Corrected spelling errors, moved docs to Link doctstring to use autoclass
* Moved link docs to link_extractors
* Update docs/topics/link-extractors.rst
Co-authored-by: Adrián Chaves <adrian@chaves.io>
* Update link.py
Improvements to URL description
* Update link.py
* Update link.py
Fixed line length Flake issue
* Update link.py
Fixed trailing whitespace
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-10-01 23:50:11 +05:00
Mikhail Korobov
7b1bc9b7fe
Merge pull request #4816 from sashreek1/master
...
removed datatype specification for *args & ** kwargs
2020-10-01 23:46:14 +05:00
Mikhail Korobov
872f68a989
Merge pull request #4818 from elacuesta/crawl-rule-remove-deprecated-code
...
Crawl rule: remove deprecated code
2020-10-01 23:45:14 +05:00
Andrey Rahmatullin
e42d82526a
Drop the conditional code for old Twisted ( #4820 )
2020-10-01 20:22:17 +02:00
Andrey Rahmatullin
44f0fde905
Simplify TLS logging for the modern pyOpenSSL. ( #4822 )
2020-10-01 20:21:09 +02:00
dswij
95b2e94496
fix comment error on tox and re-add cache for travis
2020-10-02 01:05:45 +07:00
dswij
cc81f9ed06
add download setting for tox
2020-10-02 00:56:59 +07:00
Eugenio Lacuesta
744f352d09
Do not process cookies from headers
2020-10-01 14:52:23 -03:00
dswij
c83a16898f
try removing cache in travis to install pip
2020-10-01 20:59:05 +07:00
dswij
392b489a65
travis
2020-10-01 20:32:49 +07:00
dswij
f7201b1427
travis and deps
2020-10-01 19:59:23 +07:00
dswij
0ea6ff1136
travis pip version and deps
2020-10-01 16:14:36 +07:00
dswij
66201737a0
fix travis and deps
2020-10-01 15:47:19 +07:00
dswij
f4629fe2cc
Update travis-pip and tox deps conflict for pip20.2
2020-10-01 14:58:14 +07:00
Sashreek Shankar
9661a8dcfc
removed datatype specification for *args & ** kwargs
2020-10-01 06:46:12 +05:30
Adrián Chaves
774ebe8796
Mention contributors in the README
2020-09-30 14:17:30 +02:00
Eugenio Lacuesta
894b509d7a
Crawl rule: remove deprecated code
...
Remove the compatibility layer that handles 'process_request'
methods that do not receive a 'response' parameter
2020-09-29 23:37:28 -03:00
dswij
9186e5a686
add pip 20.2 test for tox
2020-09-29 00:39:36 +07:00
Andrey Rahmatullin
5a38639359
Merge pull request #4809 from madeny/patch-1
...
Correct some typos
2020-09-28 18:26:43 +05:00
madeny
eff96038c7
Correct some typos
...
This won't be an issue if **your** spider doesn't rely on cookies.
2020-09-26 22:50:38 +02:00
Adrián Chaves
6ef7c44061
Fix timezone test issue
2020-09-22 12:45:21 +02:00
GeorgeA92
c22e810658
httocompression tests added
2020-09-22 07:47:37 +03:00
Adrián Chaves
07c1d9c25b
Remove boto3 as a dependency for tests
2020-09-21 23:32:55 +02:00
Adrián Chaves
8f46e84519
Fix style issues
2020-09-21 23:28:16 +02:00
Adrián Chaves
c3b740f078
Use mocking for tests/test_pipeline_files.py::TestS3FilesStore::test_persist
2020-09-21 23:25:37 +02:00
Adrián Chaves
35726da434
tests/test_feedexport.py: remove unused import
2020-09-21 22:55:25 +02:00
Adrián Chaves
17e135377a
Use mocking for tests/test_feedexport.py::BatchDeliveriesTest::test_s3_export
2020-09-21 22:54:39 +02:00
Adrián Chaves
56f05fb164
Use mocking for tests/test_feedexport.py::S3FeedStorageTest::test_store
2020-09-21 22:01:09 +02:00
Adrián Chaves
008cf1c75e
Remove a test that has never been executed in Python 3
2020-09-21 20:45:21 +02:00
Mirwaisse Djanbaz
3989f64baa
dependecies → dependencies ( #4801 )
2020-09-21 14:40:00 +02:00
Mirwaisse Djanbaz
7f1e74daa2
dependencides → dependencies ( #4800 )
2020-09-21 14:38:16 +02:00
Georgiy Zatserklianyi
70c82d33c0
httpcompression stats added ( #4797 )
2020-09-20 16:24:05 +03:00
Andrey Rahmatullin
5e997587d9
Remove dead boto2 code, deprecate is_botocore() ( #4776 )
2020-09-20 15:06:46 +02:00
Eugenio Lacuesta
6e8d20a07a
HTTP/2: add some type hints ( #4785 )
2020-09-16 09:57:07 +02:00
Mikhail Korobov
85e13aff74
Merge pull request #4782 from sripriyesha/patch-1
...
add mention of FTP server storage in media storage intro
2020-09-15 01:17:46 +05:00
Adrián Chaves
4d6359df2d
Mark HTTP/2 as experimental
2020-09-11 13:51:05 +02:00
drs-11
82ba7c8b52
created separate test for invalid no-proxy values
2020-09-10 20:56:39 +05:30
KAILASA's Sri Nithya Priyeshananda
7a83474cc5
add mention of FTP server storage in media storage intro
...
At the beginning of this doc, in "Specifying where to store the media" feature details, FTP server storage mention was missing
2020-09-08 17:16:31 +02:00
drs-11
959222df7e
check for unparseable no_proxy values
2020-09-05 21:32:05 +05:30
drs-11
35e2d25689
Merge remote-tracking branch 'upstream/master' into 3689-update
2020-09-02 20:51:09 +05:30
drs-11
6565adc471
added test case for get_images
2020-09-02 20:44:26 +05:30
Andrey Rahmatullin
c1cc3f2f42
Merge pull request #4761 from Gallaecio/on-the-fly-certificates
...
Generate localhost keys for tests on the fly
2020-09-02 13:37:44 +05:00
Adrián Chaves
9731d91f34
Merge branch 'master' into fix_iternodes
2020-09-01 12:38:37 +02:00
Adrián Chaves
ddc26f3f8f
Revert Travis CI changes
2020-09-01 11:26:07 +02:00
Eugenio Lacuesta
307e35c664
Improve check for invalid cookie in CookiesMiddleware ( #4772 )
2020-09-01 11:04:00 +02:00
Ilia Sergunin
d10464ca96
Update docs/topics/feed-exports.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-09-01 10:13:40 +03:00
Adrián Chaves
8a3ba34a75
Merge remote-tracking branch 'upstream/master' into http2
2020-08-31 16:43:32 +02:00
Adrián Chaves
e6dcfd3c99
Merge pull request #4610 from adityaa30/h2-client-protocol
...
Add H2ClientProtocol
2020-08-31 16:35:35 +02:00
Jose Galdos
a41c205928
Update httpstatus documentation.
2020-08-31 08:58:43 -05:00
Aditya
eff33a2e79
fix(h2): Mockserver test uses H2DownloadHandler
2020-08-30 23:55:17 +05:30
maranqz
71d2c2f1a3
improve view of dict
2020-08-30 12:43:44 +03:00
maranqz
fc3c66ce95
fix tests:
...
* FeedExportConfigTestCase.test_feed_complete_default_values_from_settings_empty
* FeedExportConfigTestCase.test_feed_complete_default_values_from_settings_non_empty
2020-08-30 11:44:48 +03:00
maranqz
a8e895e684
kwargs for Item exporters classes
...
test
docs
2020-08-30 10:57:22 +03:00
Mikhail Korobov
be655b855d
Merge pull request #4765 from scrapy/simplify-test_crawl
...
Simplify tests/test_crawl
2020-08-29 13:31:20 +05:00
Mikhail Korobov
5e9cc3298b
Merge pull request #4324 from ammarnajjar/4307-use-f-strings
...
refactor: use f-strings
2020-08-29 13:28:38 +05:00
Ammar Najjar
90ca9350f5
Update scrapy/commands/check.py
...
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-08-29 08:03:03 +00:00
Andrey Rakhmatullin
8123c42737
Simplify running spiders in CrawlSpiderTestCase.
2020-08-29 12:01:58 +05:00
Aditya
a8aedbeb7c
chore: rearrange imports
2020-08-29 12:12:18 +05:30
Ammar Najjar
ffdf6fe100
use f-strings for the newly merged code from master
...
Issue: #4324
2020-08-29 07:21:48 +02:00
Ammar Najjar
defeaacbc2
Merge branch 'master' into 4307-use-f-strings
...
Conflicts resolved:
- delete tests/py36/_test_crawl.py
2020-08-29 07:12:44 +02:00
Mikhail Korobov
7e6476ff0a
Merge pull request #4764 from scrapy/test_crawl-move-py36
...
Merge back tests/py36/_test_crawl.py.
2020-08-29 00:12:53 +05:00
Andrey Rahmatullin
59a0157ef1
Merge pull request #4722 from Gallaecio/umask
...
Do not let umask affect the permissions of startproject-generated files
2020-08-28 18:41:02 +05:00
Andrey Rakhmatullin
de640f41ec
Merge back tests/py36/_test_crawl.py.
2020-08-28 18:27:36 +05:00
Ammar Najjar
0e57918231
test(Slot): cover __repr__
...
Issue: #4324
2020-08-28 13:58:32 +02:00
Mikhail Korobov
64905e3397
Merge pull request #4691 from elacuesta/typing-spider-attributes
...
Typing: annotate a few Spider attributes
2020-08-28 00:03:40 +05:00
Adrián Chaves
3f0a677c04
Cover version directive usage in the documentation policy ( #4310 )
...
* Cover version directives in the documentation policy
* Remove version directives in preparation for Scrapy 2.0
* Update the policy based on the deprecation policy
* Only remove version directives after 3 years
2020-08-27 23:56:58 +05:00
Adrián Chaves
195f738bba
Update Python version references after dropping support for 3.5 ( #4742 )
...
* Update Python version references after dropping support for 3.5
* Remove outdated test
* Undo change affecting collect_asyncgen
* Undo change to be handled by #4743
* Remove unused import
* Remove unused import
* Update tests/requirements-py3.txt
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-08-27 15:43:43 +05:00
Aditya
5e36f539e2
chore: remove typing-extensions dependency
2020-08-27 15:12:22 +05:30
Adrián Chaves
dd378b4bb1
Generate localhost keys for tests on the fly
2020-08-27 11:33:18 +02:00
Mikhail Korobov
a6b67cf4a1
Merge pull request #4755 from maranqz/csv-item-exporter-errors
...
Add errors parameter for CsvItemExporter with tests
2020-08-27 12:51:53 +05:00
Ammar Najjar
5ab1a318e8
test: list appears in ValueError Exception message
...
Issue #4324
2020-08-26 15:11:46 +02:00
Eugenio Lacuesta
a8114d3731
Typing: annotate a few Spider attributes
2020-08-26 09:00:36 -03:00
Aditya
450ba6b51f
fix(typo): stream -> streams, use isinstance
2020-08-26 17:20:59 +05:30
Ammar Najjar
2ca8dfb4b0
revert f-string changes for files under sep/
...
Issue #4324
2020-08-26 13:49:39 +02:00
Ammar Najjar
7597193dbe
Merge branch 'master' into 4307-use-f-strings
...
Resolve Conflicts:
tests/test_middleware.py
2020-08-26 13:46:46 +02:00
Ammar Najjar
9aaddcde0a
Update scrapy/utils/conf.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-08-26 11:44:20 +00:00
Ammar Najjar
ea03e4254f
Update scrapy/http/request/form.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-08-26 11:43:52 +00:00
Ammar Najjar
92dfa7176d
Update scrapy/extensions/statsmailer.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-08-26 11:43:40 +00:00
Ammar Najjar
c77450990d
Update scrapy/commands/version.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-08-26 11:41:24 +00:00
maranqz
29725e4b58
Fix tabulation of rst and change documentation link.
2020-08-26 14:38:37 +03:00
nyov
cf50561b86
Allow passing classes directly in Settings ( #3873 )
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-08-26 13:08:14 +02:00
maranqz
560c335c07
Add errors parameter in documentation.
2020-08-26 14:00:51 +03:00
Ammar Najjar
58ca8bbf6d
Use f-strings ( #4307 )
2020-08-26 07:11:05 +02:00
Mikhail Korobov
0ccaf89a6f
Merge pull request #4756 from ivanprado/master
...
Support for delegated methods as callbacks
2020-08-26 00:10:43 +05:00
Adrián Chaves
2f28cee3ce
Add a test to cover searching for a missing node name
2020-08-25 17:49:17 +02:00
Adrián Chaves
6eb1fc4ab5
Merge remote-tracking branch 'upstream/master' into fix_iternodes
2020-08-25 17:01:54 +02:00
Iván de Prado
0524df8669
Code simplification.
...
Thanks @victor-torres for the suggestion
2020-08-25 14:37:10 +01:00
Andrey Rahmatullin
067125c303
Merge pull request #4752 from drs-11/master
...
DOWNLOAD_MAXSIZE logger level changed from Error to Warning
2020-08-25 18:35:50 +05:00
Adrián Chaves
39affea93c
Fix style issues
2020-08-25 13:57:48 +02:00
maranqz
a2d6fa5adc
Add errors parameter for CsvItemExporter with tests
2020-08-25 13:34:43 +03:00
Iván de Prado
3e726b9df7
Support for delegated methods as callbacks
...
It can be useful to structure the spiders code around some helper classes.
2020-08-25 11:31:20 +01:00
Andrey Rahmatullin
64e0ea4ee5
Merge pull request #4735 from wRAR/ciphers-tests
...
Re-enable TLS 1.2 in cipher tests.
2020-08-25 11:48:31 +05:00
drs-11
ecec5f9e51
Cleaned up code
2020-08-25 02:46:44 +05:30
drs-11
1f9598ada4
Update branch to latest
2020-08-25 02:14:22 +05:30
drs-11
8b84a65a6b
cleaned up code relating to issue #3689
2020-08-25 00:30:17 +05:30
drs-11
0b3881d65e
Reverted maxsize warning log message
2020-08-24 20:37:40 +05:30
WinterComes
2d8ec9d44f
Change DOWNLOAD_MAXSIZE logger level from Error to Warning
2020-08-24 20:37:40 +05:30
Aditya
1432161477
fix: bump min typing-extensions version to 3.7.4
...
- typing-extensions>=3.7.4 only supports TypedDict
2020-08-24 15:40:01 +05:30
Aditya
26d344b762
Merge branch 'http2' of https://github.com/scrapy/scrapy into h2-client-protocol
2020-08-24 14:58:23 +05:30
Eugenio Lacuesta
f1250177dc
Remove Python 3.5 from CI ( #4743 )
2020-08-22 09:33:35 +02:00
Mikhail Korobov
ba0e7f3c85
Merge pull request #4747 from Gallaecio/pylint-update
...
Skip checks introduced in Pylint 2.6.0
2020-08-21 23:18:51 +05:00
Adrián Chaves
7c076122eb
Skip checks introduced in Pylint 2.6.0
2020-08-21 17:06:54 +02:00
Adrián Chaves
afd3a4d116
Fix style issue
2020-08-21 17:04:02 +02:00
Adrián Chaves
e90be0d8a5
Mark the new test as xfail for xmliter_lxml
2020-08-21 14:09:52 +02:00
Adrián Chaves
d711eca4d9
Merge remote-tracking branch 'upstream/master' into fix_iternodes
2020-08-21 13:52:52 +02:00
Andrey Rahmatullin
07b0c591e0
Merge pull request #4745 from Yogendra0Sharma/fix4741
...
Removed appveyor.xml no longer needed
2020-08-21 12:36:13 +05:00
yogendra0sharma
2fbfe2c214
Removed appveyor.xml no longer needed
2020-08-21 12:18:15 +05:30
Grisha Temchenko
d68aab992e
Smarter generator check for combined return/yield statements ( #4721 )
2020-08-20 10:22:07 -03:00
Hugo van Kemenade
a57db9e302
Bitbucket no longer supports Mercurial repositories ( #4738 )
2020-08-19 17:45:24 +02:00
sakshamb2113
42383cc267
Add a setting to customize the asyncio event loop ( #4414 )
2020-08-19 09:18:14 +02:00
Aditya
2f00666d74
refactor: move agents & context-factory
2020-08-19 07:31:52 +05:30
Aditya
30eb005639
fix: InvalidNegotiatedProtocol __str__ method
2020-08-19 06:25:04 +05:30
Aditya
e3233b79de
refactor(h2-stream): alphabetical order of imports
2020-08-19 05:10:19 +05:30
Aditya
a206ac5f6f
tests: disable python 3.5 for travis and azure
2020-08-18 07:36:39 +05:30
Aditya
a87ab71d10
refactor(http2): metadata for Stream
...
- Add Note about HTTP/2 Cleartext not supported in settings.rst
2020-08-18 05:52:40 +05:30
Andrey Rakhmatullin
d9e69bfb51
Re-enable TLS 1.2 in cipher tests.
2020-08-17 19:46:24 +05:00
Adrián Chaves
e70975f0bb
Allow overwriting feeds ( #4512 )
...
Co-authored-by: Yuval Hager <yhager@yhager.com>
2020-08-17 15:10:08 +02:00
Mikhail Korobov
282a6d4fc1
Merge pull request #4727 from wRAR/mitmproxy-ca
...
Use a longer key in mitmproxy-ca.pem.
2020-08-17 14:06:58 +05:00
Mikhail Korobov
61459de476
Merge pull request #4688 from ashellunts/obsolete-s3feednokeys
...
Remove obsolete S3FeedStorage instancing without AWS credentials
2020-08-17 13:58:32 +05:00
Adrián Chaves
792d29380e
Merge Twisted’s deprecated HTTPClientFactory into ScrapyHTTPClientFactory ( #4165 )
...
* Port code from Twisted’s deprecated HTTPClientFactory into ScrapyHTTPClientFactory
* Mention that ScrapyHTTPClientFactory has Twisted code
2020-08-17 10:54:58 +02:00
Mikhail Korobov
5ac135f036
Merge pull request #4718 from Gallaecio/support-pinned-3.6
...
Upgrade minimum dependencies for Python 3.6 support
2020-08-17 13:54:45 +05:00
Grammy Jiang
55edf8d3b8
Add typing hint to httpcache downloadermiddlewares ( #4243 )
2020-08-17 10:50:52 +02:00
Ajay Mittur
a8e08d51cd
Check if file is already present on running `scrapy genspider` and terminate if so ( #4623 )
2020-08-17 10:45:52 +02:00
Eugenio Lacuesta
2aa4f3cbf9
Conditional request attribute binding for responses ( #4632 )
2020-08-17 10:39:59 +02:00
adityaa30
75fe3d1365
fix: increase timeout to 0.5 seconds
...
- In Windows specifically the reactor was left unclean by the
HostnameEndpoint due to the tearDown method of
test_downloader_handlers.py::HttpTestCase due to
which the following 2 tests were failing:
1. test_timeout_download_from_spider_server_hangs
2. test_timeout_download_from_spider_nodata_rcvd
- Increasing the timeout fixed the test (in local)
2020-08-17 04:18:03 +05:30
Aditya
38d361792c
fix: typing & pylint errors
...
- Ignore typing check for http2 test files
2020-08-16 17:55:16 +05:30
Aditya
f9f008e935
test: add typing-extensions
2020-08-16 17:04:40 +05:30
Aditya
d97cf973dd
Merge branch 'master' of https://github.com/scrapy/scrapy into h2-client-protocol
2020-08-16 11:31:10 +05:30
Aditya
af73f141b2
refactor: move all http2 tests in separate files
2020-08-16 11:26:32 +05:30
Andrey Rakhmatullin
756c368a6b
Use a longer key in mitmproxy-ca.pem.
2020-08-14 22:09:24 +05:00
Andrey Rahmatullin
acb3b4433a
Merge pull request #4724 from Gallaecio/feed-uri-params
...
Document FEED_URI_PARAMS
2020-08-14 14:47:55 +05:00
Mikhail Korobov
61653418ff
Merge pull request #4090 from Gallaecio/documentation-build
...
Fix references to Python types in parameter type fields
2020-08-14 00:58:06 +05:00
Mikhail Korobov
cd0d3fd48d
Merge pull request #4705 from Gallaecio/deprecation-policy
...
Cover our deprecation policy in the documentation
2020-08-14 00:27:37 +05:00
Mikhail Korobov
1f44464a4a
Merge pull request #4723 from Gallaecio/windows
...
test_utils_iterators.py: support Windows the right way
2020-08-14 00:23:55 +05:00
Adrián Chaves
65e0abaea5
Document FEED_URI_PARAMS
2020-08-13 09:05:51 +02:00
Adrián Chaves
24ba5a71ac
Maybe the problem is not in the code after all
2020-08-13 06:35:09 +02:00
Adrián Chaves
5f4df622a1
test_utils_iterators.py: support Windows the right way
2020-08-13 05:41:06 +02:00
Adrián Chaves
4c0afb606c
Update permission expectations
2020-08-12 17:45:26 +02:00
Adrián Chaves
125a058340
Do not let umask affect the permissions of startproject-generated files
2020-08-12 17:07:21 +02:00
Adrián Chaves
b1de55d37d
Fix marker syntax
2020-08-12 12:34:40 +02:00
Adrián Chaves
8e393a0b21
Do not change the mitmproxy version for no-3.6 Python versions
2020-08-12 12:29:51 +02:00
Adrián Chaves
394631fc0a
Restore 3.5 support for mitmproxy-based tests
2020-08-12 12:08:09 +02:00
Ajay Mittur
1c4b4cc6b0
Support defining file path based on item in media pipelines ( #4686 )
2020-08-11 14:12:44 +02:00
Adrián Chaves
5138f9a965
Merge remote-tracking branch 'upstream/master' into allow-customizing-export-column-names
2020-08-11 13:42:05 +02:00
Adrián Chaves
b2f4df5cb7
Merge remote-tracking branch 'upstream/master' into documentation-build
2020-08-11 13:16:14 +02:00
Adrián Chaves
aefd43a6c6
Upgrade minimum dependencies for Python 3.6 support
2020-08-11 12:52:54 +02:00
Adrián Chaves
90f85a2b9b
Enable Travis CI
2020-08-11 10:20:30 +02:00
Aditya
c67d6dea31
fix: H2 docs, NotImplementedError for H2 Tunnel
2020-08-11 04:39:41 +05:30
Andrey Rahmatullin
0cf1340c29
Merge pull request #4663 from ajaymittur28/scrapy-check-test
...
Add Tests to `scrapy check` command
2020-08-10 16:18:29 +05:00
Andrey Rahmatullin
702de0480b
Merge pull request #4564 from jacty/patch-1
...
Unnecessary update when value is None
2020-08-10 16:14:42 +05:00
Aditya
e0c3019d90
fix: ScrapyProxyH2Agent
...
- add required test cases
BREAKING CHANGES
Presently the tests (in test_downloader_handlers.py)
1. test_download_without_proxy
2. test_download_with_proxy_https_timeout
collide with each other when run together. However, if both of the tests
are ran individually then both pass.
2020-08-09 16:19:35 +05:30
Jose Galdos
13181ba788
Improve http status all on http error middleware
2020-08-06 20:43:16 -05:00
Adrián Chaves
1cc8d5829f
Remove unneeded try-except
...
Exceptions only happen when find_spec gets a 2nd parameter.
2020-08-06 13:52:47 +02:00
Andrey Rahmatullin
cad84458ac
Merge pull request #4714 from linchiwei123/fix
...
Remove duplicated install_requires
2020-08-06 12:17:04 +05:00
linchiwei123
4dc09f09aa
Update setup.py
2020-08-05 22:23:19 +08:00
Andrey Rahmatullin
1f0722c87e
Merge pull request #4701 from kshitijcode/weakkeycache-cleanup-4684
...
Code cleanup scrapy.utils.python.WeakKeyCache #4684
2020-08-05 17:48:41 +05:00
Kshitij Sharma
983b7ddf2e
aesthetic fixes
2020-08-05 16:13:52 +05:30
Kshitij Sharma
b35d1f2b2c
deleted tester.py
2020-08-05 09:14:04 +05:30
Kshitij Sharma
9d84289109
deprecated weakkeycache by specifying in __init__
2020-08-05 09:11:59 +05:30
Marc Hernández
336f19f5cc
Change super syntax ( #4707 )
2020-08-04 20:42:01 +02:00
Adrián Chaves
4ee538e44b
Update unicode references from Python 2 times in the documentation ( #4703 )
2020-08-04 20:34:11 +02:00
Adrián Chaves
1278e76d90
Bump version: 2.2.0 → 2.3.0
2020-08-04 20:07:02 +02:00
Adrián Chaves
3600582f56
Cover Scrapy 2.2.1 and 2.3 in the release notes ( #4708 )
2020-08-04 20:05:56 +02:00
Mikhail Korobov
015b71d89f
Merge pull request #4704 from Gallaecio/python2-u-prefixes
...
Remove the u prefix from strings
2020-07-31 01:23:00 +05:00
Artur Shellunts
5ec66be4a4
Merge branch 'master' into obsolete-s3feednokeys
2020-07-30 22:18:00 +02:00
Aditya
d707f8b5d9
docs: mention H2DownloadHandler in settings.rst
2020-07-30 18:06:21 +05:30
Adrián Chaves
6f4ccec567
Cover our deprecation policy in the documentation
2020-07-30 14:03:14 +02:00
Adrián Chaves
890b2138a6
Remove the u prefix from strings
2020-07-30 13:39:30 +02:00
Aditya
a3fecaf07f
test: fix host-name H2DownloadHandler tests
2020-07-30 15:45:27 +05:30
Kshitij Sharma
49337bd2ae
Code cleanup scrapy.utils.python.WeakKeyCache #4684 and fixing ci alerts
2020-07-30 12:25:21 +05:30
Kshitij Sharma
33ddc3d4f3
Trigger CI
2020-07-30 09:47:08 +05:30
Mikhail Korobov
5e2d1bd187
Merge pull request #4434 from BroodingKangaroo/ISSUE-4250-add_batch_deliveries
...
Feed exports: add batch deliveries
2020-07-29 23:03:28 +05:00
Kshitij Sharma
403bc7020a
Code cleanup scrapy.utils.python.WeakKeyCache #4684 and fixing ci alerts
2020-07-29 18:05:33 +05:30
Aditya
19f2b4b53d
refactor: AcceptableProtocolsContextFactory
...
- rename H2WrappedContextFactory to AcceptableProtocolsContextFactory
- AcceptableProtocolsContextFactory accepts an argument
acceptable_protocols which can be used to override the context factory
priority list of protocols during ALPN or NPN
2020-07-29 17:25:59 +05:30
Aditya
e8342996f6
test: H2DownloadHandler
...
Following tests are skipped as Content-Length header not matching the
data received is considered as a ProtocolError
- test_download_broken_content_cause_data_loss
- test_download_broken_chunked_content_cause_data_loss
- test_download_broken_content_allow_data_loss
- test_download_broken_chunked_content_allow_data_loss
- test_download_broken_content_allow_data_loss_via_setting
- test_download_broken_chunked_content_allow_data_loss_via_setting
BREAKING CHANGES
The following tests currently fail
- test_content_length_zero_bodyless_post_request_headers
- test_host_header_seted_in_request_headers
- test_download_with_maxsize_very_large_file
2020-07-29 13:51:01 +05:30
Aditya
92bec38591
feat: MethodNotAllowed405, Content-Length header
...
- add tests to check for Content-Length header
- raise MethodNotAllowed405 when remote send 'HTTP/2.0 405 Method Not
Allowed'
2020-07-29 13:49:14 +05:30
Kshitij Sharma
e7a58fe157
Code cleanup scrapy.utils.python.WeakKeyCache #4684
2020-07-29 10:16:18 +05:30
Eugenio Lacuesta
5265853937
Use ItemAdapter.field_names when writing header in CsvItemExporter ( #4668 )
2020-07-28 11:15:14 +02:00
BroodingKangaroo
a6c1d79b7c
pep8 tiny changes
2020-07-28 11:53:05 +03:00
Mikhail Korobov
ce0c25fc85
Merge pull request #4690 from elacuesta/typing-setup-remove-monkeypatches
...
Remove monkeypatches module from mypy section in setup.cfg
2020-07-23 17:56:08 +05:00
Eugenio Lacuesta
8fae3d5bb7
Remove monkeypatches module from mypy section in setup.cfg
2020-07-22 16:08:35 -03:00
Aditya
031bfc9c3b
feat(wip): ScrapyH2Agent, ScrapyProxyH2Agent
2020-07-22 15:01:59 +05:30
Aditya
62ce842afc
fix: multiple h2 connections to same uri
...
- When multiple requests are sent to H2ConnectionPool to the same uri
while the connection is in connecting state -- multiple connections were
establised.
- Fixed the bug using a deque of all the request deferred's which fire
with the H2ClientProtocol (connection) instance when connection is
established
2020-07-22 14:52:49 +05:30
Aditya
8252a6f8d8
fix: H2Agent not able to connect via SSL
...
- add H2WrappedContextFactory class which wraps the context factory
passed to H2Agent and updates the SSL context acceptable protocols list
to only h2
2020-07-22 14:52:49 +05:30
Aditya
9fffb801ed
feat: H2Agent, H2ConnectionPool base implementation
2020-07-22 14:52:49 +05:30
Aditya
3685e99cca
test: http2 connection timeout
2020-07-22 14:47:20 +05:30
Aditya
316620b517
chore: pass spider as argument for request method
...
- download_maxsize and download_warnsize can now be extracted from the
spider directly and passed to the stream
- remove `partial` flag from the response as per RFC 7540 - Section
8.1.2.6
2020-07-22 13:57:49 +05:30
Artur Shellunts
430d22e46e
Remove not used import warnings
2020-07-21 23:39:04 +02:00
nyov
2829cd4268
Allow use without credentials
2020-07-21 23:38:02 +02:00
nyov
98e8086d1b
Adapt S3FeedStorage testcase
2020-07-21 23:38:02 +02:00
nyov
234c8b8c50
Removing deprecated S3FeedStorage without AWS keys instancing.
2020-07-21 23:38:01 +02:00
nyov
ece4fa6c7c
Fix ignored testcase: boto is never installed
2020-07-21 23:38:01 +02:00
Andrey Rahmatullin
f3372a3753
Merge pull request #4254 from elacuesta/spider.parse
...
Change Scraper API to call internal `_parse` method
2020-07-21 17:37:54 +05:00
Akshay Sharma
de297a3a16
enable ANSI color (instead of ANSI color codes) in the Windows terminal #4393 ( #4403 )
...
* changed ie. -> i.e.(spelling error) on lines 667, 763 (issue scrapy#4332)
* updated all text files for issue #4332 (ie. -> i.e.)
* Apply ie. → i.e. in source comments
* ie → e.g.
* modified scrapy/utils/display.py to stop ANSI color sequences in the Windows terminal (issue #4393 )
* modified scrapy/utils/display.py to stop ANSI color sequences in the Windows terminal (issue #4393 )
* enabled virtual terminal processing (pr #4403 )
* check for specific windows 10 version (pr #4403 )
* fixing flake-8 test (pr #4403 )
* added error handling for terminal info (pr #4403 )
* corrected stderr (pr #4403 )
* changed orientation, removed unwanted spaces (pr #4403 )
* no need for style variable (pr #4403 )
* fixing trailing whitespaces
* commenting windows check
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* small fixes
* Shifting _color_support_info() function
* enabled virtual terminal processing (pr #4403 )
* check for specific windows 10 version (pr #4403 )
* fixing flake-8 test (pr #4403 )
* added error handling for terminal info (pr #4403 )
* corrected stderr (pr #4403 )
* changed orientation, removed unwanted spaces (pr #4403 )
* no need for style variable (pr #4403 )
* fixing trailing whitespaces
* commenting windows check
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update scrapy/utils/display.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* small fixes
* Shifting _color_support_info() function
* error handling
* error handlingy
* raise ValueError
* added in-built function for version comparison
* recommit changes
* changed check -> parse
* version comparison -> parse_version
* added scrapy/utils/display.py in pytest.ini
* Trigger
* Add simple test for scrapy.utils.display._colorize
* Flake8: E501 for tests/test_utils_display.py
* assertEquals -> assertEqual
* Normal formatter for all platforms
* separate test for windows
* all curses under try block
* added global TestStr
* more test added
* small fix
* covering exceptions
* windows test failing
* Refactor output color handling
* Fix pprint test
* fix flake8
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
2020-07-20 17:23:38 +05:00
BroodingKangaroo
3e0492741d
Another try to fix test errors on Windows
2020-07-19 00:10:29 +03:00
BroodingKangaroo
86f7ac2f2b
Try to fix error at Windows
2020-07-17 18:22:47 +03:00
Artur Shellunts
62a4ede5e9
Remove deprecated classes BaseSgmlLinkExtractor, RegexLinkExtractor and SgmlLinkExtractor ( #4356 )
2020-07-17 12:40:04 +02:00
Adrián Chaves
d29bec60d7
Upgrade PyPy for CI, and test both 3.5 (oldest) and 3.6 (newest) ( #4504 )
...
* Upgrade PyPy for CI, and test both 3.5 (oldest) and 3.6 (newest)
* Log a detailed error message to discover why MockServer is not working
* Go for all lines!
* Disable tests based on mitmproxy while running on PyPy
* Fix test_get_func_args for PyPy 3.6+
* Make testPayloadDefaultCiphers work regardless of OpenSSL default ciphers
* Crossing fingers…
* Rename: testPayloadDefaultCiphers → testPayloadDisabledCipher
* Test the PyPy version currently documented as the minimum required version
* Fix the PYPY_VERSION tag
* Update the documentation about supported PyPy versions
* Also test the latest 3.5 Python version with PyPy
* Fix the PYPY_VERSION value for the latest 3.5 version
* Use pinned dependencies for asyncio and PyPy tests against oldest supported Python versions
* Fix PyPy installation for the pypy3-pinned Tox environment
* Try installing Cython
* Maybe PyPy requires lxml 3.6.0?
* install.rst: minor clarification
* lxml 4.0.0 is required on PyPy
* Require setuptools 18.5+
* Revert "Require setuptools 18.5+"
This reverts commit 017ec33ac2 .
* Maintain lxml as a dependency if setuptools < 18.5 is used
2020-07-17 02:19:24 +05:00
Mikhail Korobov
9a74a71c63
Merge pull request #4682 from noviluni/remove_python2_reminiscence
...
remove python 2 reminiscence in cookies
2020-07-16 23:58:58 +05:00
Adrián Chaves
c4f9250220
Merge branch 'master' into ISSUE-4250-add_batch_deliveries
2020-07-16 17:44:18 +02:00
BroodingKangaroo
41263f61c6
Change single quotes to double in example in docs
2020-07-16 18:41:45 +03:00
Marc Hernández
b97a39fda0
deprecate retry_on_eintr ( #4683 )
2020-07-16 17:38:22 +02:00
Mikhail Korobov
07470e1a3c
Merge pull request #3608 from ejulio/feat-685
...
[MRG+1] Fix for #685 Add Google Cloud Storage Feed Export
2020-07-16 18:11:19 +05:00
Mikhail Korobov
0f2f1acf04
Merge pull request #4458 from scrapy/azure-pipelines
...
Set up CI with Azure Pipelines
2020-07-16 18:09:31 +05:00
Marc
0e0d1ad643
remove python 2 reminiscence in cookies
2020-07-16 14:25:46 +02:00
BroodingKangaroo
8bdcdb0a76
Add quotes to example in docs
2020-07-16 09:13:54 +03:00
Júlio César Batista
38496a00b7
Use the itemlaoders library ( #4516 )
2020-07-15 12:08:36 +02:00
Andrey Rahmatullin
eb1bc74417
Merge pull request #4674 from ashellunts/delete_deprecated_htmlparserlinkextractor
...
Remove deprecated class HtmlParserLinkExtractor
2020-07-15 12:51:42 +05:00
Aditya
e662762e6a
chore: Handle ConnectionTerminated event
2020-07-15 07:48:34 +05:30
Aditya
1dd27a92fa
feat: Idle Timeout for H2Connection (240s)
2020-07-14 22:46:32 +05:30
Artur Shellunts
ed5247ca4c
Remove htmlparser.py from tests/ignore.txt
2020-07-14 18:06:11 +02:00
Adrián Chaves
6e119bd3e3
Merge branch 'master' into azure-pipelines
2020-07-14 11:26:19 +02:00
Aditya
aeaeb7385b
feat: assert negotiated protocol as h2
...
- implement IHandshakeListener in H2ClientProtocol to know when
handshake is completed
- implement IProtocolNegotiationFactory in H2ClientFactory to provide
information about the acceptableProtols (h2) during NPN or ALPN protocol
2020-07-14 03:55:14 +05:30
Adrián Chaves
544c1f6e39
Fix the issue
2020-07-13 16:30:34 +02:00
Adrián Chaves
0770961054
Write a test for #4665
2020-07-13 16:05:57 +02:00
Adrián Chaves
53c323b19d
_is_path → _is_filesystem_path
2020-07-13 15:29:30 +02:00
Adrián Chaves
d54c4496ee
Refactor guess_scheme
2020-07-13 14:37:08 +02:00
Andrey Rahmatullin
0ebba175ea
Merge pull request #4666 from Gallaecio/execution-access
...
Fix permission handling on project generation from template files
2020-07-13 16:01:06 +05:00
Andrey Rahmatullin
b6f8693db9
Merge pull request #4673 from elacuesta/remove-backslash
...
Remove backslash
2020-07-13 11:14:00 +05:00
Aditya
64c6af10e1
refactor: use str instead of to_unicode
2020-07-13 00:57:49 +05:30
Aditya Kumar
3f7e8635f4
Allow the parse command to write data to a file ( #4377 )
2020-07-11 08:48:24 +02:00
Artur Shellunts
a6a5fa91da
Remove deprecated class HtmlParserLinkExtractor
...
Issue #4356
2020-07-10 23:10:49 +02:00
Ajay Mittur
cbe4dc57f3
Update pytest.ini
2020-07-10 18:22:43 +05:30
Eugenio Lacuesta
9aea1f0961
Remove backslash (tests)
2020-07-09 11:04:46 -03:00
Eugenio Lacuesta
9e99be982a
Remove backslash
2020-07-09 09:51:28 -03:00
Eugenio Lacuesta
2be2bdd2df
Merge remote-tracking branch 'upstream/master' into spider.parse
2020-07-08 14:00:54 -03:00
ajaymittur28
75bff7b6d3
Update url contract value
2020-07-08 19:48:42 +05:30
Aditya
2ea7d82534
feat: H2ClientFactory
2020-07-08 18:57:13 +05:30
ajaymittur28
3e98ed24b6
Convert f-string to .format()
2020-07-08 17:13:57 +05:30
Ajay Mittur
b6d4f28ea7
Merge branch 'master' into scrapy-check-test
2020-07-08 15:13:37 +05:30
Adrián Chaves
7e38615703
Remove unused import
2020-07-07 15:30:19 +02:00
Adrián Chaves
ca77ca1f75
Generate read-only files on the fly
2020-07-07 14:44:03 +02:00
Adrián Chaves
e1450799ce
Remove debug test case variable
2020-07-07 14:11:37 +02:00
Adrián Chaves
a3afff4a0e
Fix style issue
2020-07-07 14:11:02 +02:00
Adrián Chaves
79b4dfc53e
Fix permission handling on project generation from template files
2020-07-07 14:07:04 +02:00
Aditya
1c40dfa740
fix: handle CONNECTION_LOST & RESET separately
2020-07-07 15:36:41 +05:30
ajaymittur28
d014840672
Ignore flake8 E501 for `scrapy check` tests`
2020-07-07 15:24:33 +05:30
ajaymittur28
770a8127e8
Added basic `scrapy check` tests
2020-07-07 15:23:29 +05:30
Eugenio Lacuesta
54e4228c3a
refactor: use protocol
...
- H2ClientProtocol.close_stream
- Fix and add missing type hints
- More adjustments
- Rename stream id generator
- Simplify decrement
2020-07-06 22:40:45 +05:30
BroodingKangaroo
f1020e0e6a
Tiny changes
2020-07-06 15:40:53 +03:00
Adrián Chaves
17aec5944c
Update tests/CrawlerRunner/ip_address.py
...
Co-authored-by: Eugenio Lacuesta <1731933+elacuesta@users.noreply.github.com>
2020-07-06 10:47:25 +02:00
Adrián Chaves
ec06cf79a6
Update tests/CrawlerRunner/ip_address.py
...
Co-authored-by: Eugenio Lacuesta <1731933+elacuesta@users.noreply.github.com>
2020-07-06 10:47:11 +02:00
Aditya
7f5bb6b34c
chore: add h2 to setup.py, tox.ini
...
- Change log level for hpack to ERROR
2020-07-06 13:12:04 +05:30
Aditya
a94b30342a
test: reduce test data size to 1MB
2020-07-06 12:49:12 +05:30
BroodingKangaroo
6454d456d2
Make check of placeholder less strict
2020-07-03 10:24:13 +03:00
Adrián Chaves
eb93774256
TrackrefTestCase.test_get_oldest: protect from lack of precision
2020-07-03 01:41:47 +02:00
Adrián Chaves
3199048520
Complete Azure Pipelines CI setup
2020-07-03 00:56:24 +02:00
Adrián Chaves
6e58da1dcd
Merge branch 'master' into azure-pipelines
2020-07-02 17:49:42 +02:00
BroodingKangaroo
1e245046ed
Change setting name. Add leading zeroes to batch_id. Minor fixes.
2020-07-02 12:38:08 +03:00
Mikhail Korobov
56a6d22352
Merge pull request #4653 from scrapy/openssl-man-update
...
Update the OpenSSL cipher list format link
2020-07-01 23:28:52 +05:00
Andrey Rahmatullin
af55d23167
Update the OpenSSL cipher list format link
...
OpenSSL `ciphers(1)` is now almost empty: https://www.openssl.org/docs/manmaster/man1/ciphers.html
Alternative would be linking to 1.1.1 docs specifically.
2020-07-01 19:46:54 +05:00
Aditya
4acdc2e5d6
refactor: use __qualname__, () for large strings
2020-07-01 20:15:33 +05:30
Aditya
c361fe0d3b
feat: check for invalid hostname
...
- Initiating requests having hostname or (ip_address, port) different
from the peer to which HTTP/2 connection is made can lead to closing the
whole connection and close out all the pending streams.
- This change aims to fix that problem
- Add required tests
- Save hostname & port in H2ConnectionMetadataDict
2020-07-01 18:14:44 +05:30
Andrey Rahmatullin
0379df8608
Merge pull request #4652 from elacuesta/docs-loaders-dataclass
...
Docs: Simplify dataclass example in item loader page
2020-07-01 17:35:33 +05:00
ajaymittur28
065b9b1170
Update regex import
2020-07-01 15:53:29 +05:30
BroodingKangaroo
7b1d3c35ea
Minor updates
2020-07-01 12:24:31 +03:00
ajaymittur28
006a945214
Update schemaless http proxy test
2020-07-01 13:32:58 +05:30
ajaymittur28
7fc80671a8
Update schemaless URI support
2020-07-01 13:32:17 +05:30
Aditya
7b1ad995a4
test: query params, certificate & ip_address
...
- refactor from str.format() to f-strings
2020-07-01 10:45:36 +05:30
Eugenio Lacuesta
5b88c522ac
Simplify dataclass example in item loader docs
2020-06-30 12:18:21 -03:00
Aditya
50dd9271b4
fix: disable redundant logs
...
- while testing the job exceeded the maximum log length
and was terminated
- reduce the number of requests from 20 to 10
2020-06-30 07:36:56 +05:30
Aditya
26ab3e4137
feat: FIFO policy to handle large no. of requests
...
- add required test -- test by sending 1000 requests
- increase test timeout to 180 seconds to account for tests taking long
time
2020-06-30 06:44:20 +05:30
Aditya
d17417b03a
Merge branch 'master' of https://github.com/scrapy/scrapy into h2-client-protocol
2020-06-29 18:43:42 +05:30
Aditya Kumar
e46b47c365
Renew the localhost certificate for tests ( #4650 )
...
Validity
Not Before: Jun 28 12:54:15 2020 GMT
Not After : Jun 28 12:54:15 2021 GMT
Subject: C = IE, O = Scrapy, CN = localhost
2020-06-29 15:05:13 +02:00
Aditya
90a7007f88
test: warnsize logs, no content header, dataloss
2020-06-29 18:29:31 +05:30
Aditya
23906b6bee
refactor: move TypedDict types to types.py
...
- rename LOGGER -> logger
- remove self._write_to_transport from Stream class and handle all
transport related activities inside HTTP2ClientProtocol class
2020-06-29 18:21:05 +05:30
Marc Hernández
464f24f8c1
Add --data-raw to utils.curl and fix missing method with data ( #4612 )
2020-06-29 14:20:29 +02:00
Aditya
6387445ef5
test(tox.ini): change Twisted -> Twisted[http2]
2020-06-28 18:44:57 +05:30
Aditya
690dd7f38b
test: GET & POST request test for h2 client
...
- Remove repeated dependency Twisted from setup.py
- Test for both GET & POST when
- Only 1 request
- Large number (=20) of requests
and
- Small Data (10 KB) per request
- Large Data (10 MB) per request
- Test when request is cancelled by the client'
BREAKING CHANGES
Tests raises OpenSSL.SSL.Error when run using tox. However, all tests
passes when ran using `python -m unittest`.
2020-06-28 16:38:49 +05:30
BroodingKangaroo
05c2587c6a
Docs update and tiny fixes
2020-06-28 09:45:45 +03:00
ajaymittur28
f53f06020b
Test http schemaless proxy
2020-06-27 23:28:40 +05:30
ajaymittur28
23da8e1068
Add schemaless http proxy support
2020-06-27 20:36:45 +05:30
BroodingKangaroo
88a52198b9
Add batch_item_count support in FEEDS setting
2020-06-27 12:45:08 +03:00
BroodingKangaroo
c3cee74fd4
Change default value of FEED_STORAGE_BATCH_ITEM_COUNT to 0
2020-06-26 18:45:21 +03:00
BroodingKangaroo
77333666f1
resolve conflicts
2020-06-26 14:55:46 +03:00
Mikhail Korobov
0c8d8c5e85
Merge pull request #4645 from Lukas0907/fix-starturlsspider
...
Spider constructor expects name as argument, not start_urls.
2020-06-25 18:36:43 +05:00
Adrián Chaves
9f60481360
Bump version: 2.1.0 → 2.2.0
2020-06-24 12:27:39 +02:00
Adrián Chaves
6f4c964aa4
Cover Scrapy 2.2.0 in the release notes ( #4630 )
2020-06-24 12:26:38 +02:00
Aditya
065b3153fe
Merge branch 'master' of https://github.com/scrapy/scrapy into h2-client-protocol
2020-06-24 07:51:41 +05:30
Aditya
69f6d038c0
feat: TypedDict for Stream._response
...
- remove test_protocol.py as working testing environment is setup 🙂 🙃
- Add typing_extensions as dependency to support TypedDict for
python<3.8
2020-06-24 07:50:21 +05:30
Aditya
a97ac0adf8
test: GET request for HTTP2Client using mockserver
2020-06-24 06:40:20 +05:30
Lukas Anzinger
3672f5f988
Spider constructor expects name as argument, not start_urls.
...
Fixes #4644
2020-06-23 14:56:12 +02:00
Andrey Rahmatullin
536643efde
Merge pull request #4629 from StasDeep/fix/duplicated-feed-logs
...
Fix duplicated feed logs
2020-06-23 15:33:48 +05:00
Andrey Rahmatullin
4bee73cfa7
Merge pull request #4637 from elacuesta/typing
...
Typing: Tox env, CI job
2020-06-23 15:31:37 +05:00
Andrey Rahmatullin
374d996093
Merge pull request #4642 from elacuesta/docs-loaders-dataclass
...
Docs: add note about dataclass items and loaders
2020-06-23 15:30:48 +05:00
Adrián Chaves
cfd039aeb6
Remove a duplicate GCS_PROJECT_ID reference target
2020-06-22 19:28:33 +02:00
Eugenio Lacuesta
73b6ce8cb5
Update docs about dataclass items and loaders
2020-06-22 14:13:37 -03:00
Eugenio Lacuesta
1335d9053e
Update docs/topics/loaders.rst
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-06-22 14:05:44 -03:00
Eugenio Lacuesta
3efea98e05
Docs: add note about dataclass items and loaders
2020-06-22 12:41:25 -03:00
Aditya
c74ef660c7
feat: handle response for different reasons
...
- Add StreamCloseReason enum
- Send response for different cases considering download_warnsize,
download_maxsize, fail_on_data_loss, connection lost, etc.
2020-06-21 09:34:23 +05:30
Aditya
303485a9b4
fix(http2): POST request not sending large body
2020-06-21 00:33:34 +05:30
Eugenio Lacuesta
b99fe4aa4c
Add google-cloud-storage to the 'pinned' tox environment
2020-06-19 21:41:15 -03:00
Eugenio Lacuesta
c7f1c7e3f3
Merge branch 'master' into feat-685
2020-06-19 21:30:54 -03:00
Stanislau Hluboki
a4bfd5ab6f
Fix duplicated feed logs
2020-06-19 17:51:56 +03:00
Eugenio Lacuesta
7babf359e0
Typing: Tox env, CI job
2020-06-18 13:56:07 -03:00
Adrián Chaves
f9c63384c0
Merge branch 'master' into allow-customizing-export-column-names
2020-06-18 14:09:20 +02:00
Adrián Chaves
88ade19675
Merge branch 'master' into spider-name-collision
2020-06-18 14:01:02 +02:00
Devi Sandeep
5d54173187
Update docs on accessing callback arguments in errback ( #4634 )
2020-06-18 12:01:38 +02:00
Aditya
700df3eeb7
test: mockserver with h2 protocol for tests
...
- add Twisted[http2] in setup.py requirements
- add test_protocol.py to test the current implementation
BREAKING CHANGES
test_download times out because of no protocol negotiated between
Mockserver and HTTP/2 client
2020-06-17 21:02:14 +05:30
Aditya
089dbc75e7
chore: use deque for pending request pool
...
- Use itertools.count to generate next stream_id
BREAKING CHANGES
When sending data/body more than the local flow control window -- no
window update occurs to send the remaining data frames. Hence, the
complete body is not send resulting in no response received.
2020-06-17 20:57:03 +05:30
Stas Glubokiy
3d027fb578
Fix missing storage.store calls in FeedExporter.close_spider ( #4626 )
2020-06-17 17:08:14 +02:00
Andrey Rahmatullin
89e900e013
Merge pull request #4635 from cool-RR/patch-1
...
Use chain.from_iterable in python.py
2020-06-17 18:54:10 +05:00
Ram Rachum
214da8e523
Use chain.from_iterable in python.py
2020-06-17 13:50:54 +03:00
Aditya
01ad8b31ab
refactor(http2): clean up
...
- make separate function to parse http headers from Request instance
2020-06-15 05:14:00 +05:30
Aditya
de4a34365a
fix: large data chunk not received
...
Every data chunk received needs to be acknowledged to
- update the flow control window size
- get furthur data chunks from the server
2020-06-14 22:43:36 +05:30
Eugenio Lacuesta
ec98dabfab
Support for dataclass and attrs items ( #3881 )
2020-06-14 11:45:27 +02:00
Aditya
d06bb12e35
refactor: move H2Connection instance to stream
...
- Remove all wrapper funtions made such that stream can send header/data
to H2Connection as they were not necessary
BREAKING CHANGES
Looks like, for small set of response data the StreamEnded event is
emitted and everything works well -- tested for both GET & POST request.
Maybe some issue with window size and/or flow control as when the
response data needs to be broken into separate chunks -- not all chunks
are received everytime which leads to indefinite waiting for next data
chunk and the connection is lost due to timeout. 😥
Working on setting up testing environment now. After testing is setup
I'll debug the above bug furthur.
2020-06-13 22:33:28 +05:30
Aditya
d09ccf8d3b
feat(http2): support for POST requests
...
BREAKING CHANGES
- Request is sent successfully with its Response received as well.
However, the StreamEnded event is not received which do not fires the
response deferred
2020-06-13 20:40:01 +05:30
Eugenio Lacuesta
8b549392f9
Bump minimum Python version to 3.5.2 ( #4615 )
2020-06-11 14:53:59 +02:00
Eugenio Lacuesta
b6c5289fb9
Close page in pyppeteer example, mention asyncio reactor
2020-06-10 12:11:49 -03:00
Andrey Rahmatullin
092f6fdea1
Merge pull request #4604 from MMesch/fix-startproject-permissions
...
give write access to template files after copying with startproject
2020-06-10 11:58:16 +05:00
Adrián Chaves
76a2cbf0ff
Apply minor style changes
2020-06-09 21:30:19 +02:00
Eugenio Lacuesta
78aa1b2bfc
Fix typo
2020-06-08 11:19:15 -03:00
Aditya
9ff9caecad
feat(http2): support for GET requests
2020-06-07 14:04:53 +05:30
Eugenio Lacuesta
bdabc500aa
Update headless browser docs
2020-06-06 16:47:15 -03:00
Matthias Meschede
2df3b54c7d
refactor
2020-06-05 09:29:05 +02:00
Matthias Meschede
0cabf406d5
set write permission to startproject folder
2020-06-04 10:39:40 +02:00
Andrey Rahmatullin
63929e75e3
Merge pull request #4552 from jay24rajput/common_commands
...
Code sharing between crawl and runspider command
2020-06-03 12:06:12 +05:00
Eugenio Lacuesta
91e505edfe
Return single element from coroutine callback ( #4609 )
2020-06-02 10:32:14 +02:00
Aditya
791292334e
chore(http2): Stream class
2020-06-02 09:13:31 +05:30
Mikhail Korobov
1d2b692666
Merge pull request #4596 from sharmarohit/remove-unneeded-escape-sequence
...
remove unneeded escape sequence
2020-06-02 02:30:33 +05:00
Adrián Chaves
c86a1035dd
Merge pull request #4563 from willbeaufoy/hoverxref
...
Extend hoverxref_roles to custom crossrefs (#4495 )
2020-06-01 07:18:13 +02:00
Bulat Khabibullin
5cef927944
Implement TextResponse.json() ( #4574 )
2020-06-01 06:57:23 +02:00
Aditya Kumar
9408c77a1e
feat(http2): IH2EventsHandler, http2 module
2020-05-31 18:08:51 +05:30
Mikhail Korobov
6aab3badfa
Merge pull request #4568 from elacuesta/remove-monkeypatches-flake8-e402
...
Remove _monkeypatches, import-related Flake8 codes
2020-05-30 00:07:50 +05:00
Mikhail Korobov
13215cfb71
Merge pull request #4559 from elacuesta/cancel-request-download
...
Stop response download from signal handler
2020-05-27 21:46:00 +05:00
Andrey Rahmatullin
ff699eb1f8
Merge pull request #4599 from elacuesta/LocalWeakReferencedCache-getitem-fix
...
Fix KeyError in LocalWeakReferencedCache
2020-05-27 21:42:04 +05:00
Andrey Rahmatullin
7bf375098e
Merge pull request #2400 from elacuesta/keep_cookie_header
...
[MRG+1] CookiesMiddleware: keep cookies from 'Cookie' request header, fix encoding
2020-05-27 21:41:43 +05:00
Eugenio Lacuesta
44d5801b05
Fix KeyError in LocalWeakReferencedCache
2020-05-27 11:15:33 -03:00
Eugenio Lacuesta
492197e477
StopDownload: store response in the exception instead of the failure
2020-05-27 10:45:07 -03:00
Eugenio Lacuesta
634ad5ebca
Merge remote-tracking branch 'upstream/master' into cancel-request-download
2020-05-27 10:27:45 -03:00
Will Beaufoy
898bdd3feb
Update docs README with build instructions using tox
...
None of the existing commands built the docs properly for me (I had to
revert the changes in 901892d to docs/conf.py to get them to build
properly, and even then no tooltips displayed).
Building them with tox worked for me, but other developers say they
can still use the original method, so the docs now contain both.
2020-05-26 19:09:23 +01:00
Mikhail Korobov
b82a480e91
Merge pull request #4588 from altendky/patch-1
...
Incompatible with pytest 5.4 and 5.4.1
2020-05-26 01:38:53 +05:00
Rohit Sharma
0cc0e51ca3
remove uneeded escape sequence
...
removed uneeded wscape sequences from method arguments in the docs
folder
2020-05-24 13:38:44 -07:00
BroodingKangaroo
dd96f94e8c
Push datetime.utcnow() to its own variable
2020-05-22 23:30:33 +03:00
Kyle Altendorf
5b2af85289
Link to issue describing troublesome pytest versions
2020-05-22 15:09:58 -04:00
Mikhail Korobov
3e854a69de
Merge pull request #4593 from Gallaecio/4514
...
Fix the description of the ScreenshotPipeline example item pipeline
2020-05-22 23:12:58 +05:00
Adrián Chaves
08756cd87a
Fix the description of the ScreenshotPipeline example item pipeline
2020-05-22 18:06:54 +02:00
Eugenio Lacuesta
f6ed5edc31
CookiesMiddleware: keep cookies from 'Cookie' request header
2020-05-21 11:07:41 -03:00
BroodingKangaroo
677e619d37
Fix too long lines
2020-05-21 14:57:03 +03:00
BroodingKangaroo
5f6c1dceb1
Merge remote-tracking branch 'upstream/master' into ISSUE-4250-add_batch_deliveries
2020-05-21 12:43:04 +03:00
Eugenio Lacuesta
fbe915d9cb
StopDownload: check partial response contents
2020-05-20 20:20:30 -03:00
Eugenio Lacuesta
9514393bd1
Reduce amount of lines
2020-05-20 15:28:54 -03:00
Eugenio Lacuesta
276721a5dc
Stop response download
2020-05-20 14:46:26 -03:00
Mikhail Korobov
6f3e3411b1
Merge pull request #4587 from Gallaecio/4510
...
logging.rst: remove unused, misleading import
2020-05-20 22:23:42 +05:00
Kyle Altendorf
eb8493f09c
Incompatible with pytest 5.4 and 5.4.1
2020-05-20 09:21:34 -04:00
Adrián Chaves
f418c6d5f7
logging.rst: remove unused, misleading import
2020-05-19 20:04:47 +02:00
Mikhail Korobov
6e79216425
Merge pull request #4585 from nsirletti/fix-readthedocs-build
...
Make doc downloadable on ReadTheDocs.org
2020-05-19 20:45:20 +05:00
nsirletti
c2a0cca0fe
Suppress Sphinx warnings about MIME types other than .rst
2020-05-19 02:17:11 +02:00
nsirletti
afb2e5011f
Allow doc to be downloadable on readthedocs.org
2020-05-19 02:17:11 +02:00
BroodingKangaroo
a7d070f3bb
Change log level to error
2020-05-18 22:25:29 +03:00
Mikhail Korobov
febe82a907
Merge pull request #4486 from ilias-ant/add-file-status-on-media-pipelines-file-info
...
Add status (downloaded, uptodate) to files information
2020-05-18 22:30:30 +05:00
Mikhail Korobov
bcc40c4077
better deprecation warning for Response.body_as_unicode() ( #4579 )
2020-05-18 19:12:31 +02:00
Eugenio Lacuesta
a22f97052e
Cleanup import in selector module
2020-05-15 21:18:26 -03:00
Eugenio Lacuesta
a915af2e45
Remove monkeypatches module, E402 flake8 code
2020-05-15 20:41:51 -03:00
Mikhail Korobov
314adf6c38
Merge pull request #4237 from elacuesta/flake8-max-line-length
...
Set flake8-max-line-length to 119
2020-05-16 03:26:45 +05:00
Mikhail Korobov
14612fc3d3
Merge pull request #4534 from elacuesta/deprecate-baseitem
...
Deprecate scrapy.item.BaseItem
2020-05-16 03:24:06 +05:00
Jay Rajput
604fe33bad
Update scrapy/commands/__init__.py
...
Changed typo in a comment for BaseRunSpiderCommand
Co-authored-by: Eugenio Lacuesta <1731933+elacuesta@users.noreply.github.com>
2020-05-16 01:53:49 +05:30
BroodingKangaroo
10ae1a284f
Minor fixes
2020-05-15 22:50:54 +03:00
Jay Rajput
cd32a9d9f4
Merge branch 'common_commands' of https://github.com/jay24rajput/scrapy into common_commands
2020-05-16 00:27:02 +05:30
Jay Rajput
4cdd00e21f
Changed BaseRunSpiderCommands to BaseRunSpiderCommand
2020-05-16 00:25:57 +05:30
Adrián Chaves
36c3c9713e
Run tests with Python 3.5.0 ( #4518 )
...
* Run tests with Python 3.5.0
* Use Ubuntu Trusty 14.04 to test Python 3.5.0
* Use mitmproxy<3.0.0 on Python 3.5.0
* Skip tests requiring mitmproxy in Python 3.5.0
* Change the minimum Python version from 3.5 to 3.5.1
* Do not prevent Scrapy from working with Python 3.5.0
* Force system Python 3.5.1
* Do not install a non-system Python in Python 3.5.1 jobs
* Switch to Trusty to be able to test Xenial’s Python version ¯\_(ツ)_/¯
* Add missing trusty
* Stop breaking old PyPy
* Allow installing Scrapy on Python 3.5.0
2020-05-15 22:37:56 +05:00
BroodingKangaroo
1cdcf8b08b
Minor fixes
2020-05-15 20:14:07 +03:00
Eugenio Lacuesta
3eeecb4273
Merge branch 'master' into flake8-max-line-length
2020-05-15 11:11:20 -03:00
Marc Hernández
fffb0a5b6a
replace set constructor with set literals ( #4573 )
2020-05-15 15:23:09 +02:00
Adrián Chaves
7701c39655
Merge branch 'master' into common_commands
2020-05-15 13:44:45 +02:00
BroodingKangaroo
0627bf476e
Merge remote-tracking branch 'upstream/master' into ISSUE-4250-add_batch_deliveries
2020-05-14 20:59:22 +03:00
Eugenio Lacuesta
ee13c3e95f
Merge branch 'master' into deprecate-baseitem
2020-05-14 13:31:16 -03:00
Eugenio Lacuesta
3d58e5e3be
Merge pull request #4545 from elacuesta/flake8-remove-e128
...
Flake8: Remove E128
2020-05-14 13:28:50 -03:00
Eugenio Lacuesta
89d0c98f7a
Merge remote-tracking branch 'upstream/master' into flake8-remove-e128
2020-05-14 11:35:30 -03:00
Eugenio Lacuesta
602bb13bdc
Merge pull request #4558 from elacuesta/flake8-remove-e741
...
Flake8: Remove E741
2020-05-14 11:26:59 -03:00
Eugenio Lacuesta
df8a1d1c01
Flake8: Remove E741
2020-05-14 10:40:50 -03:00
Eugenio Lacuesta
cfe4bf7e50
Merge pull request #4572 from noviluni/add_missed_flake8_rules
...
Flake8: remove E306 and F523
2020-05-14 10:38:55 -03:00
BroodingKangaroo
69c005f013
Documentation indent fix
2020-05-14 10:35:56 +03:00
BroodingKangaroo
111a58fe3d
Merge remote-tracking branch 'upstream/master' into ISSUE-4250-add_batch_deliveries
2020-05-14 09:53:14 +03:00
BroodingKangaroo
8662d3587d
Documentation and code refactoring
2020-05-14 00:05:36 +03:00
Adrián Chaves
e31b6ccc45
Merge branch 'master' into flake8-remove-e128
2020-05-13 22:39:45 +02:00
BroodingKangaroo
2327ecead0
Rename FEED_STORAGE_BATCH_SIZE to FEED_STORAGE_BATCH_ITEM_COUNT
2020-05-13 22:50:04 +03:00
Adrián Chaves
7dac99bb12
Merge branch 'master' into deprecate-baseitem
2020-05-13 20:35:03 +02:00
marc
8971878c1d
fix new detected flake8 cases
2020-05-13 14:11:10 +02:00
Andrey Rahmatullin
519f752d6d
Merge pull request #4566 from elacuesta/flake8-remove-f841
...
Flake8: remove F841
2020-05-13 11:46:48 +05:00
Jacty
33ab0a3663
Update __init__.py
2020-05-13 06:11:07 +08:00
Aditya Kumar
8d1269bcbc
Cover chompjs in documentation ( #4562 )
2020-05-12 20:42:28 +02:00
Aditya Kumar
97532a9144
test(spiderloader): no duplicate spider names ( #4560 )
2020-05-12 17:10:09 +02:00
Jay Rajput
07e125f4c9
Travis CI fixes in __init__.py
2020-05-12 16:31:56 +05:30
Jay Rajput
28d223dd87
Update __init__.py
2020-05-12 15:28:22 +05:30
Jay Rajput
e01c30f0d5
Update scrapy/commands/__init__.py
...
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-05-12 01:05:20 +05:30
willbeaufoy
cf9be5344a
Prevent create_instance() returning None ( #4532 )
...
Currently create_instance() can return None if an extension is
incorrectly implemented, but the extension will still show up as
enabled in the logs. This can cause confusion, as in the linked bug.
This change prevents this occurring by throwing an error if
create_instance() will return None.
2020-05-11 20:35:25 +02:00
nsirletti
cb8140a42a
Deprecate Response.body_as_unicode() ( #4555 )
...
Co-authored-by: Nicolas Sirletti <n.sirletti@gmail.com>
2020-05-11 20:20:31 +02:00
Eugenio Lacuesta
6f8758624c
Flake8: remove F841
2020-05-11 13:50:34 -03:00
Eugenio Lacuesta
25e9bc2d0d
Merge branch 'master' into flake8-remove-e128
2020-05-11 13:23:57 -03:00
Eugenio Lacuesta
abfdc1b542
Update docstring for Item class
2020-05-11 13:20:06 -03:00
Eugenio Lacuesta
fb7ba6964d
Merge branch 'master' into deprecate-baseitem
2020-05-11 10:21:56 -03:00
Mikhail Korobov
892467cb8a
Merge pull request #4541 from elacuesta/pickle-adjustments
...
Pickle: use protocol 4, update tests
2020-05-11 15:16:14 +05:00
Mikhail Korobov
b183579564
Merge pull request #4205 from elacuesta/bytes_received_signal
...
Add bytes_received signal
2020-05-11 15:09:55 +05:00
Jacty
b5684909d1
Unnecessary update when value is None
...
When value is None, it is not necessary to invoke update and run other methods and conditions to make the code complicated there.
2020-05-11 11:18:25 +08:00
Will Beaufoy
1bfbcc6180
Extend hoverxref_roles to custom crossrefs ( #4495 )
2020-05-10 13:49:13 +01:00
Jay Rajput
02ac6664a5
Travis CI fixes
2020-05-10 00:26:48 +05:30
Jay Rajput
ed4f4f8408
Applied suggested format changes
2020-05-10 00:08:34 +05:30
Adrián Chaves
e07708e374
request-response: update the consequences of str(b'')
2020-05-09 15:54:31 +02:00
Adrián Chaves
c6746f0e38
bytes array → bytes object
2020-05-09 15:51:11 +02:00
Jay Rajput
92792cc3f7
Moved common_commands.py to __init__.py
2020-05-09 17:28:10 +05:30
Eugenio Lacuesta
f689e917bf
Update Item docstring
2020-05-08 19:44:05 -03:00
Eugenio Lacuesta
9485724d98
Merge branch 'master' into deprecate-baseitem
2020-05-08 19:32:47 -03:00
Eugenio Lacuesta
be39f274b8
Merge branch 'master' into flake8-remove-e128
2020-05-08 18:33:29 -03:00
Mikhail Korobov
794ab19660
Merge pull request #3727 from Gallaecio/pylint
...
Use pylint
2020-05-09 02:22:54 +05:00
Mikhail Korobov
333910f6c8
Merge pull request #4554 from elacuesta/linkextractor-remove-lambdas
...
Remove lambda attributes in default link extractor
2020-05-09 02:11:59 +05:00
Mikhail Korobov
707f591767
Merge pull request #4557 from elacuesta/flake8-remove-e1xx
...
Flake8: remove E111, E114, E116, E117, E121
2020-05-09 02:08:27 +05:00
Eugenio Lacuesta
c2c3054ac1
Flake8: remove E121
2020-05-08 16:43:47 -03:00
Eugenio Lacuesta
83ce82f400
Flake8: remove E114 and E117 (unused)
2020-05-08 16:43:28 -03:00
Eugenio Lacuesta
1a157f2e26
Flake8: remove E116
2020-05-08 16:42:56 -03:00
Eugenio Lacuesta
81d0b2f61a
Flake8: remove E111
2020-05-08 16:42:50 -03:00
Eugenio Lacuesta
3ebf2a0d82
Remove lambdas in link extractor
2020-05-08 15:24:37 -03:00
Eugenio Lacuesta
b852fff6f8
Style changes in link extractor
2020-05-08 15:22:41 -03:00
Antonio Gordillo Toledo
cf09af787e
Remove Python 2 encoding header from files ( #4553 )
2020-05-08 15:45:19 +02:00
Jay Rajput
dcf7235f0e
Code sharing between crawl and runspider command
2020-05-08 01:48:23 +05:30
Eugenio Lacuesta
38f01dd243
Merge remote-tracking branch 'upstream/master' into flake8-remove-e128
2020-05-07 14:52:31 -03:00
Eugenio Lacuesta
6160370927
Merge remote-tracking branch 'upstream/master' into deprecate-baseitem
2020-05-07 14:38:54 -03:00
Eugenio Lacuesta
5256eae60d
Meta class to handle isinstance checks for BaseItem
2020-05-07 14:37:41 -03:00
Mikhail Korobov
77492cd945
Merge pull request #4543 from elacuesta/flake8-remove-e126
...
Flake8: remove E126
2020-05-07 22:14:51 +05:00
Eugenio Lacuesta
8b4485134e
Merge branch 'flake8-remove-e126' into flake8-remove-e128
2020-05-07 12:50:20 -03:00
Eugenio Lacuesta
e0127a3123
Refactor warnings in spiderloader
2020-05-07 12:48:43 -03:00
Eugenio Lacuesta
8659b0d896
Merge remote-tracking branch 'upstream/master' into flake8-remove-e126
2020-05-07 09:24:38 -03:00
Eugenio Lacuesta
422e6429b5
Add mising len check in spiderloader
2020-05-07 09:22:14 -03:00
Adrián Chaves
b59dfb75fa
Update disabled Pylint checks
2020-05-07 14:15:37 +02:00
Adrián Chaves
4605c66a80
Fix AttributeError
2020-05-07 12:38:51 +02:00
Mikhail Korobov
a8f61e909f
Merge pull request #4544 from elacuesta/flake8-remove-e129
...
Flake8: remove E129
2020-05-07 15:08:11 +05:00
Mikhail Korobov
a18bfccac2
Merge pull request #4542 from elacuesta/flake8-remove-e122-e124
...
Flake8: remove E122 and E124
2020-05-07 15:05:01 +05:00
Adrián Chaves
bbd9d05dbf
request-response.rst: review type references around body mentions
2020-05-07 11:44:43 +02:00
Eugenio Lacuesta
7fd2085725
Merge remote-tracking branch 'upstream/master' into bytes_received_signal
2020-05-06 22:41:16 -03:00
Eugenio Lacuesta
d472402a02
Fix pickle test for pypy
2020-05-06 20:30:22 -03:00
Eugenio Lacuesta
881b4f417f
Flake8: Remove E128 (tests, part 3)
2020-05-06 19:33:22 -03:00
Eugenio Lacuesta
bf56517abf
Flake8: Remove E128 (tests, part 2)
2020-05-06 19:18:29 -03:00
Mikhail Korobov
2da952b928
Merge pull request #4519 from Gallaecio/test-ubuntu-bionic
...
Test the latest Ubuntu along the latest Python
2020-05-07 03:12:19 +05:00
Eugenio Lacuesta
9c6d13075a
Flake8: Remove E128 (tests, part 1)
2020-05-06 18:56:14 -03:00
Eugenio Lacuesta
2851f641f2
Flake8: Remove E128 (item, mail, responsetypes)
2020-05-06 18:35:50 -03:00
Eugenio Lacuesta
2fbbca56fb
pytest.ini: remove unnecessary E128 lines
2020-05-06 18:34:40 -03:00
Eugenio Lacuesta
4171b3f663
Flake8: Remove E128 (extensions module)
2020-05-06 18:28:12 -03:00
Eugenio Lacuesta
a72f5aadcf
Flake8: Remove E128 (utils module)
2020-05-06 17:38:39 -03:00
Eugenio Lacuesta
7383b2b428
Flake8: Remove E128 (core module)
2020-05-06 17:27:44 -03:00
Eugenio Lacuesta
2af34873cc
Flake8: Remove E128 (commands module)
2020-05-06 17:25:14 -03:00
Mikhail Korobov
0a7581df23
Merge pull request #4537 from Gallaecio/restric-travis-ci-tests
...
Travis CI: do not run security and Flake8 on multiple jobs
2020-05-07 00:54:17 +05:00
Eugenio Lacuesta
25eeb77ba6
Merge remote-tracking branch 'upstream/master' into flake8-max-line-length
2020-05-06 16:52:17 -03:00
Eugenio Lacuesta
88efc98847
Flake8: remove E129
2020-05-06 16:42:47 -03:00
Eugenio Lacuesta
4c12a234ae
Flake8: Remove E126
2020-05-06 16:10:21 -03:00
Adrián Chaves
a19d15013a
Merge remote-tracking branch 'upstream/master' into spider-name-collision
2020-05-06 20:52:36 +02:00
Eugenio Lacuesta
cc23d1cb58
Flake8: Remove E124
2020-05-06 15:40:37 -03:00
Eugenio Lacuesta
d71804ef29
Flake8: Remove E122
2020-05-06 15:23:36 -03:00
Adrián Chaves
a859ea0c8b
Merge remote-tracking branch 'upstream/master' into allow-customizing-export-column-names
2020-05-06 19:48:32 +02:00
Eugenio Lacuesta
0e382c8160
Remove unused import
2020-05-06 14:09:10 -03:00
Eugenio Lacuesta
93436f9d3a
Chain pickling exception, test_squeues.py updates
2020-05-06 14:05:27 -03:00
Eugenio Lacuesta
b1ddd7bd7b
Refactor test_squeues.py
2020-05-06 13:44:02 -03:00
Andrey Rahmatullin
b76d280cc3
Merge pull request #4540 from elacuesta/flake8-remove-e123
...
Flake8: remove E123
2020-05-06 21:38:04 +05:00
Eugenio Lacuesta
d0bb04f089
Switch to pickle protocol 4
2020-05-06 13:37:23 -03:00
Andrey Rahmatullin
4957a0a172
Merge pull request #4539 from elacuesta/flake8-remove-e125
...
Flake8: remove E125
2020-05-06 21:36:20 +05:00
Andrey Rahmatullin
977ce9f7a8
Merge pull request #4538 from elacuesta/flake8-remove-e127
...
Flake8: remove E127
2020-05-06 21:34:24 +05:00
Eugenio Lacuesta
8643e8d355
Flake8: remove E123 (Closing bracket does not match indentation of opening bracket's line)
2020-05-06 12:26:04 -03:00
Michał Panek
628c4a5319
Add a warning/error in case of incorrect gcs permissions ( #4508 )
2020-05-06 17:09:20 +02:00
Adrián Chaves
a79cfce57b
Merge branch 'master' into pylint
2020-05-06 16:24:13 +02:00
Adrián Chaves
286fca733f
Fix parameter name, broken by copy-pasting
2020-05-06 16:20:55 +02:00
Eugenio Lacuesta
63600243e0
Flake8: remove E125 (Continuation line with same indent as next logical line)
...
Also remove E401 from pytest.ini - no occurrences in the codebase
2020-05-06 10:26:52 -03:00
Eugenio Lacuesta
fe0c582ee0
Flake8: remove E127 in tests (continuation line over-indented for visual indent)
2020-05-06 09:49:10 -03:00
Eugenio Lacuesta
49e8a337f7
Flake8: remove E127 (continuation line over-indented for visual indent)
2020-05-06 09:37:01 -03:00
Eugenio Lacuesta
8d1e3ee0dd
Remove deprecated BaseItem from the docs
2020-05-06 09:24:40 -03:00
Adrián Chaves
98835a0d40
Merge branch 'master' into test-ubuntu-bionic
2020-05-06 13:59:01 +02:00
Adrián Chaves
418b9b5f52
Travis CI: do not run security and Flake8 on multiple jobs
2020-05-06 11:15:02 +02:00
Eugenio Lacuesta
17c0cf64ae
Flake8: remove W504 code ( #4525 )
...
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-05-06 00:14:48 +02:00
Eugenio Lacuesta
7988c676a9
Update Item docstring, update BaseItem occurrences
2020-05-05 13:11:01 -03:00
Eugenio Lacuesta
622ce86066
Test: make sure scrapy.item.Item does not issue a deprecation warning
2020-05-04 16:22:24 -03:00
Mikhail Korobov
8f72b70f06
Merge pull request #4533 from scrapy/doc-old-twisted
...
Don't mention unsupported package versions in docs
2020-05-04 23:51:40 +05:00
Mikhail Korobov
fe6154e4fa
clarify DOWNLOADER_HTTPCLIENTFACTORY docs
2020-05-04 18:18:38 +05:00
Eugenio Lacuesta
e1948b4923
Add example about bytes_received signal
2020-05-04 09:07:27 -03:00
Eugenio Lacuesta
f75941f79d
Deprecate scrapy.item.BaseItem
2020-05-04 08:53:32 -03:00
Mikhail Korobov
83d7360bb7
Don't mention unsupported package versions in docs
2020-05-04 02:00:11 +05:00
BroodingKangaroo
dad2ea7522
Change time_id to batch_time
2020-05-02 01:21:03 +03:00
Eugenio Lacuesta
4d625afda5
Merge branch 'master' into bytes_received_signal
2020-05-01 16:11:32 -03:00
BroodingKangaroo
df81870f39
Merge branch 'master' of https://github.com/scrapy/scrapy into ISSUE-4250-add_batch_deliveries
2020-05-01 12:18:39 +03:00
BroodingKangaroo
3f9874fac9
Add test s3 export
2020-05-01 11:52:16 +03:00
Mikhail Korobov
b6eae22b38
Merge pull request #4522 from Gallaecio/travis-tox-py
...
Remove TOXENV from .travis.yml unless needed
2020-04-29 00:26:00 +05:00
Mikhail Korobov
6c69b03a27
Merge pull request #4521 from Gallaecio/tox-asyncio
...
Simplify the asyncio Tox environment
2020-04-29 00:25:42 +05:00
Mikhail Korobov
65ba9e1063
Merge pull request #4517 from Gallaecio/run-quick-tests-first
...
Run quick tests first in Travis CI
2020-04-29 00:19:55 +05:00
Adrián Chaves
ec0a0eb3ab
Merge branch 'master' into spider-name-collision
2020-04-28 21:13:08 +02:00
Adrián Chaves
1006db1e10
Merge branch 'master' into documentation-build
2020-04-28 21:07:14 +02:00
Adrián Chaves
f2bbdb43ee
Merge branch 'master' into remove-deprecated-http-client-factory
2020-04-28 18:24:16 +02:00
Eugenio Lacuesta
f787b8483c
IPv6 test: check for the absence of DNSLookupError
2020-04-28 17:50:06 +02:00
Adrián Chaves
3a64f3eb29
Remove TOXENV from .travis.yml unless needed
2020-04-28 17:44:19 +02:00
Adrián Chaves
5c0f11b4ef
Simplify the asyncio Tox environment
2020-04-28 17:32:53 +02:00
Adrián Chaves
15d96ab8b5
Test the latest Ubuntu along the latest Python
2020-04-28 17:09:05 +02:00
Adrián Chaves
e3c3ec2ba9
Run quick tests first in Travis CI
2020-04-28 13:48:50 +02:00
Ashe
c207dbf939
Remove the asyncio warning from coroutines page ( #4513 )
2020-04-27 19:45:19 +02:00
BroodingKangaroo
204737042a
Extract the slot closing functionality to the function; minor changes
2020-04-27 12:52:18 +03:00
BroodingKangaroo
a18621552f
Merge branch 'master' of https://github.com/BroodingKangaroo/scrapy into ISSUE-4250-add_batch_deliveries
2020-04-27 10:34:36 +03:00
BroodingKangaroo
2eee6c8101
Documentation spelling fix
2020-04-27 09:58:14 +03:00
BroodingKangaroo
f0f1be76d1
Using time_id instead of time as a timestamp
2020-04-27 09:56:57 +03:00
Adrián Chaves
3878b67a37
Bump version: 2.0.0 → 2.1.0
2020-04-24 11:46:54 +02:00
Adrián Chaves
ffe576c4ed
Cover Scrapy 2.1 in the release notes ( #4499 )
...
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-04-24 11:44:36 +02:00
Eugenio Lacuesta
efb6f13deb
Remove assertions from production code ( #4440 )
2020-04-23 12:40:10 +02:00
Aditya Kumar
e4750f2fbd
async/deferred signal handlers ( #4390 )
...
* [docs] async/deferred signal handlers
* [docs] update deferred signals example
* [docs] add subsections for built-in signals
* docs(signals): update signal handler example
* docs(signals): update signal handler example
2020-04-20 20:47:57 +05:00
Eugenio Lacuesta
1fecacbb1a
IPv6 test: check for the absence of DNSLookupError
2020-04-20 12:05:15 -03:00
ilias-ant
773ddf77ba
added more tests to cover the (downloaded, uptodate, cached) status functionality
2020-04-19 14:14:17 +03:00
sakshamb2113
bfeb2c8c13
Added warning to use double quotes in Windows for scrapy shell in shell.rst ( #4450 )
...
* modified debugging memory leaks with guppy in leaks.rst
* modified leaks.rst(issue #4285 )
* removed guppy from telnet.py
* Fix undefined name error
* removed hpy key from telnet_vars in telnet.py
* updated shell.rst
* Update docs/topics/shell.rst
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-04-18 20:21:26 +05:00
Mikhail Korobov
66ab3347c2
Merge pull request #4507 from elacuesta/docs-update-deprecated-feed-settings
...
Docs: replace deprecated FEED_FORMAT and FEED_URI settings
2020-04-18 20:19:01 +05:00
BroodingKangaroo
ec76445dd6
Update tests
2020-04-18 09:29:23 +03:00
Eugenio Lacuesta
04b6295a69
Docs: replace deprecated FEED_* settings
2020-04-17 20:50:17 -03:00
Mikhail Korobov
209ab05315
Merge pull request #4500 from victor-torres/reference-callback
...
Serialize requests with callback references as spider attribute
2020-04-17 18:58:28 +05:00
Victor Torres
1ade3fc723
trying to improve test coverage
2020-04-17 10:34:34 -03:00
Eugenio Lacuesta
7926da4bd0
Merge branch 'master' into flake8-max-line-length
2020-04-16 16:05:09 -03:00
Mikhail Korobov
cf39602c30
Merge pull request #4471 from elacuesta/fix-pycodestyle-e731
...
Fix pycodestyle E731 ("do not assign a lambda expression, use a def")
2020-04-16 23:17:31 +05:00
Mikhail Korobov
c33fd47a80
Merge pull request #3940 from elacuesta/response_ip_address
...
Get server IP address for HTTP/1.1 Responses
2020-04-16 21:05:41 +05:00
Adrián Chaves
ea3e675801
test_utils_iterators: use os.linesep
2020-04-16 17:10:45 +02:00
Adrián Chaves
cf41803089
Skip test_reactor_poll on Windows
2020-04-16 17:07:29 +02:00
Adrián Chaves
7cc9601029
Improve reporting on test_ipv6_alternative_name_resolver
2020-04-16 16:57:48 +02:00
Eugenio Lacuesta
c922992277
Tests: Move code inside __main__ block
2020-04-16 11:37:37 -03:00
Victor Torres
94c95020b3
add comment to explain the use of __func__ instead of instance method objects
2020-04-16 11:37:03 -03:00
Eugenio Lacuesta
1f2e2a6006
Merge branch 'master' into response_ip_address
2020-04-16 11:32:37 -03:00
Victor Torres
e0921cab66
remove not used code
...
This code is not needed anymore because we're getting the
already mangled name when matching func with spider attributes.
2020-04-16 11:18:59 -03:00
Adrián Chaves
94ee68695a
Mock server: use 127.0.0.1 also for HTTPS
...
Windows throws an error about 0.0.0.0 being external:
https://stackoverflow.com/a/23857995/939364
2020-04-16 15:37:06 +02:00
Mikhail Korobov
fe7043a648
Merge pull request #4503 from Gallaecio/hoverxref-configuration
...
Fix the hoverxref configuration
2020-04-16 18:19:46 +05:00
Adrián Chaves
1d77eac950
Fix Flake8-reported issues
2020-04-16 14:57:55 +02:00
Adrián Chaves
901892dab3
Fix the hoverxref configuration
2020-04-16 14:48:38 +02:00
BroodingKangaroo
5980ae72c6
Some minor fixes and refactoring
2020-04-16 10:13:39 +03:00
BroodingKangaroo
cac1f3a6ad
Update documentation
2020-04-16 10:06:56 +03:00
Victor Torres
47a992615a
serialize requests with callback references as spider attribute
...
You could define a spider attribute that references a callback method
but if this method has a different name than your spider attribute,
the request serializer is not able to find it on the spider class.
With this commit we're fixing this behavior as we're searching for
callback references in the spider object itself instead of looking
for attributes with the same function's name, that could be different.
2020-04-15 20:03:58 -03:00
BroodingKangaroo
16836e9e77
Merge branch 'ISSUE-4250-add_batch_deliveries' of https://github.com/BroodingKangaroo/scrapy into ISSUE-4250-add_batch_deliveries
2020-04-16 00:41:21 +03:00
BroodingKangaroo
963580463b
Update tests
2020-04-15 23:39:46 +03:00
BroodingKangaroo
ffa8a533e7
Set batch_id in _get_uri_params
2020-04-15 23:38:27 +03:00
BroodingKangaroo
39d0d13d3f
Add partial deliveries tests
2020-04-15 23:38:27 +03:00
BroodingKangaroo
d11411b402
fix comments
2020-04-15 23:38:27 +03:00
BroodingKangaroo
0723e3f4f9
add batch_id, add error if uri is specified incorrectly
2020-04-15 23:38:27 +03:00
BroodingKangaroo
8b4566ff93
fix wrong name of first file in partial deliveries
2020-04-15 23:38:27 +03:00
BroodingKangaroo
e5b23f4b00
fix #4250 : add batch deliveries
2020-04-15 23:38:27 +03:00
Adrián Chaves
2f510fd47d
Fix ShellTest.test_local_file on Windows
2020-04-15 21:10:05 +02:00
Mikhail Korobov
36abe9235c
Merge pull request #4445 from adityaa30/docs-redirect-links
...
update redirect links to python3
2020-04-15 23:13:55 +05:00
Mikhail Korobov
066c02d0c3
Merge pull request #4455 from aditi137/docs-curl2scrapy
...
[Docs] mention curl2scrapy in Request.from_curl
2020-04-15 23:12:33 +05:00
Mikhail Korobov
2d46777d0a
Merge pull request #4489 from elacuesta/remove-returnValue-function
...
Remove twisted.internet.defer.returnValue occurrences
2020-04-15 22:45:52 +05:00
Mikhail Korobov
885b0ad2d4
Merge pull request #4480 from elacuesta/pin-sphinx-versions
...
Pin version for Sphinx and extensions, configure hoverxref
2020-04-15 22:42:49 +05:00
Eugenio Lacuesta
ac869181fb
Update docs/topics/downloader-middleware.rst
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-04-15 13:42:35 -03:00
Adrián Chaves
c28dd0cedb
Merge branch 'master' into duplicate_key
2020-04-15 16:22:59 +02:00
Eugenio Lacuesta
f242751b62
Remove empty line
2020-04-15 09:39:28 -03:00
Eugenio Lacuesta
01d73dd3f0
Merge branch 'master' into flake8-max-line-length
2020-04-15 09:24:33 -03:00
santoshkosgi
c3257dc610
Change Content-type to Content-Type ( #4481 )
...
Co-authored-by: santosh <santosh@acalvio.com>
2020-04-15 14:24:10 +02:00
Adrián Chaves
d323a57381
Merge branch 'master' into fix-pycodestyle-e731
2020-04-15 14:16:15 +02:00
Eugenio Lacuesta
94d7ad76cb
Fix pycodestyle E2XX (whitespace) ( #4468 )
2020-04-15 14:11:37 +02:00
Eugenio Lacuesta
ee4ee486b1
Revert unnecessary changes to docs/conf.py
2020-04-14 15:06:54 -03:00
Eugenio Lacuesta
0a4ef97fa3
Loose restrictions for docs requirements
2020-04-14 14:57:20 -03:00
Eugenio Lacuesta
4023d5db33
Replace _DefGen_Return exception handling
...
Handle StopIteration instead
2020-04-13 06:35:26 -03:00
Eugenio Lacuesta
1bd8f392c9
Initial removal of twisted.internet.defer.returnValue
2020-04-13 06:12:30 -03:00
ilias-ant
83a0cc6cdf
Add status to files information
2020-04-12 23:22:17 +03:00
Eugenio Lacuesta
2205f04631
Docs: Add hoverxref_role_types setting
2020-04-10 18:08:04 -03:00
Eugenio Lacuesta
34e81d0d74
Docs: remove duplicated setting definitions
2020-04-10 17:29:02 -03:00
Eugenio Lacuesta
4383f45299
Replace os.path with pathlib in docs config
2020-04-10 16:49:14 -03:00
Eugenio Lacuesta
24a1d9acae
Get version in docs config
2020-04-10 16:48:42 -03:00
Eugenio Lacuesta
f97fec5ebd
Pin Sphinx version, including extensions
2020-04-10 16:02:53 -03:00
Eugenio Lacuesta
950a52468c
Merge branch 'master' into flake8-max-line-length
2020-04-10 15:24:22 -03:00
Eugenio Lacuesta
2265c1fda9
Merge branch 'master' into fix-pycodestyle-e731
2020-04-10 14:32:30 -03:00
Mikhail Korobov
39b01b6892
Merge pull request #4469 from elacuesta/fix-pycodestyle-e502
...
Fix pycodestyle E502 ("the backslash is redundant between brackets")
2020-04-10 22:03:39 +05:00
Andrey Rahmatullin
49357cccbd
Merge pull request #4472 from elacuesta/remove-request-body-producer-empty-body
...
Remove empty _RequestBodyProducer for POST requests
2020-04-06 19:48:20 +05:00
Eugenio Lacuesta
c4a5e3f0da
Simplify bytes_received signal
...
Remove "source" parameter
2020-04-06 09:26:13 -03:00
Eugenio Lacuesta
e3342669ae
Merge branch 'master' into bytes_received_signal
2020-04-06 09:17:35 -03:00
Eugenio Lacuesta
862f0301e2
Remove empty _RequestBodyProducer for POST requests
2020-04-05 00:53:10 -03:00
Eugenio Lacuesta
c887fe37ad
Simplify parse command
2020-04-04 22:15:36 -03:00
Eugenio Lacuesta
4270e0a0da
Fix E731: do not assign a lambda expression
2020-04-04 21:54:55 -03:00
Eugenio Lacuesta
e2d5d357a7
Fix pycodestyle E502
2020-04-01 14:24:30 -03:00
Adrián Chaves
bdb28ac600
Merge remote-tracking branch 'origin/sybil' into azure-pipelines
2020-03-30 20:25:40 +02:00
Adrián Chaves
3fb0027138
Require sybil ≥ 1.3.0 for tests
2020-03-28 17:36:50 +01:00
Mikhail Korobov
8845773d44
Merge pull request #4456 from whalebot-helmsman/project_links
...
Project URLs in machine-readable format for showing in pypi
2020-03-27 14:11:03 +05:00
Daniel Graña
0699e6bb16
no need to install requirements.txt
2020-03-27 02:22:05 -03:00
Daniel Graña
02206e5ffe
Run tox
2020-03-27 02:20:39 -03:00
Daniel Graña
a175b6efc3
Set up CI with Azure Pipelines
...
[skip ci]
2020-03-27 02:10:10 -03:00
Aditya
b1904729d5
[docs] change mod to doc redirect link
2020-03-27 04:37:26 +05:30
Vostretsov Nikita
16f2cb4a83
project URLs in machine-readable format for showing in pypi
2020-03-26 12:57:39 +00:00
Aditi Dutta
010edfe85c
[Docs] mention curl2scrapy in Request.from_curl
2020-03-25 14:38:22 -04:00
elacuesta
ee510cf0d6
Update scrapy/spiders/crawl.py
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-03-24 13:31:44 -03:00
Aditya
80c69d68ad
[docs] refactor python docs links using intersphinx
2020-03-24 18:35:42 +05:30
Eugenio Lacuesta
4663f0b9df
Update pytest.ini after removing E501
2020-03-22 23:39:20 -03:00
Eugenio Lacuesta
182394bcec
E501 compliance (tests)
2020-03-22 23:29:30 -03:00
Eugenio Lacuesta
36a3913a41
E501 compliance
2020-03-22 21:34:20 -03:00
Mikhail Korobov
0ee04e1e91
Merge pull request #4448 from adityaa30/fix-zope
...
[fix] zope interface 5.0.0 unsupported
2020-03-20 23:18:42 +05:00
Mikhail Korobov
c26308dd45
Merge pull request #4438 from seregaxvm/master
...
edit zsh completion
2020-03-20 18:30:50 +05:00
Aditya
532cd1d93e
[fix] zope interface 5.0.0 unsupported
2020-03-20 17:36:49 +05:30
Aditya
f37b1bdc56
[docs] update redirect links to python3
2020-03-20 05:31:41 +05:30
Aditya
ca08e04198
[docs] update redirect links python2 -> python3
2020-03-20 02:31:35 +05:30
Eugenio Lacuesta
34d607194b
Merge branch 'master' into feat-685
2020-03-18 21:24:36 -03:00
Adrián Chaves
6c747953f9
Cover 2.0.1 in the release notes ( #4437 )
2020-03-18 19:17:16 +01:00
Matsievskiy S.V
9ab45325ff
edit zsh completion
...
- Fix bug introduced in https://github.com/scrapy/scrapy/pull/4291
- Enforce `[command] [options] [arguments]` syntax. Do not allow options after arguments
- Exclude already used option aliases from completion list
2020-03-17 18:45:00 +03:00
sakshamb2113
533131a30f
Remove Guppy-specific code and documentation ( #4343 )
2020-03-17 10:12:49 +01:00
elacuesta
dfbe1d9507
Remove object base class ( #4430 )
2020-03-16 20:12:46 +01:00
elacuesta
e5711127b1
Remove deprecated ChunkedTransferMiddleware ( #4431 )
2020-03-16 19:43:02 +01:00
Andrey Rahmatullin
ecd3a976d2
Merge pull request #4398 from nyov/remove-crawler-spiders
...
Remove deprecated Crawler.spiders property
2020-03-16 17:21:07 +05:00
Andrey Rahmatullin
1d862e0d35
Merge pull request #4404 from nyov/obsolete2
...
Remove obsolete DEPRECATED_SETTINGS (deprecated.py)
2020-03-16 17:18:48 +05:00
Eugenio Lacuesta
aa6075e08c
Merge branch 'master' into bytes_received_signal
2020-03-15 18:05:04 -03:00
Eugenio Lacuesta
bde0384dfd
Merge branch 'master' into spider.parse
2020-03-14 19:53:36 -03:00
Aditya Kumar
f9bf4b8d4d
Remove all top-level imports for twisted.internet.reactor ( #4406 )
2020-03-14 10:39:00 +01:00
Andrey Rahmatullin
0afe3da3dd
Merge pull request #4422 from Gallaecio/pin-working-pytest
...
Restrict pytest to versions prior to 5.4
2020-03-13 18:28:11 +05:00
Adrián Chaves
3f6cdcabce
Restrict pytest to versions prior to 5.4
2020-03-13 13:25:53 +01:00
Lukas Anzinger
ccc4d88779
Ignore a domain in allowed_domains with port and issue a warning ( #4413 )
2020-03-12 20:42:14 +01:00
nyov
3b0820d747
Deprecate Spider.make_requests_from_url, part 2 ( #4412 )
2020-03-12 20:15:49 +01:00
Mikhail Korobov
db9198bc20
Merge pull request #4409 from nyov/remove-deprecation-warning
...
Remove a 'twisted.test.proto_helpers' deprecation warning
2020-03-12 18:46:47 +05:00
Mikhail Korobov
ae5f59856c
Merge pull request #4420 from elacuesta/response_follow_all_empty_generator
...
Response.follow_all: return empty generators for empty sequences
2020-03-12 18:44:49 +05:00
Eugenio Lacuesta
8d30dc0888
Response.follow_all: return empty generators for empty sequences
2020-03-12 09:36:15 -03:00
Andrey Rahmatullin
388f23c30c
Merge pull request #3858 from elacuesta/multiple_feed_export_formats
...
[MRG+1] Support for exporting to multiple feeds in a single crawl
2020-03-12 14:31:57 +05:00
Eugenio Lacuesta
21f1eddc90
Merge branch 'master' into bytes_received_signal
2020-03-11 21:16:35 -03:00
Eugenio Lacuesta
c886a70eae
Use dict.setdefault in scrapy.utils.conf.feed_complete_default_values_from_settings
2020-03-11 21:06:51 -03:00
Eugenio Lacuesta
f3bab819ab
Add tests for scrapy.utils.conf.feed_complete_default_values_from_settings
2020-03-11 20:57:31 -03:00
Eugenio Lacuesta
49156f2ecb
[doc] Feed exports: full local path as example
2020-03-11 20:45:54 -03:00
Eugenio Lacuesta
1785095707
Remove single-use variable
2020-03-11 20:41:59 -03:00
Andrey Rahmatullin
2eb990a252
Merge pull request #4410 from Lukas0907/fix-offsite-middleware-tests
...
Fix handling of None in allowed_domains
2020-03-11 23:11:35 +05:00
Eugenio Lacuesta
91a78eef3e
Pass callback results as dicts instead of tuples
2020-03-08 22:32:17 -03:00
Eugenio Lacuesta
ac73bcc79c
Merge branch 'master' into response_ip_address
2020-03-08 22:30:59 -03:00
Lukas Anzinger
9d9dea0d69
Fix handling of None in allowed_domains.
...
Nones in allowed_domains ought to be ignored and there are also tests
for that scenario. This commit fixes the handling of None and also the
accompanying tests which are now executed again.
2020-03-07 20:34:18 +01:00
nyov
915e363db5
Remove a 'twisted.test.proto_helpers' deprecation warning
2020-03-07 18:03:25 +00:00
nyov
c2c6ea376c
Remove obsolete DEPRECATED_SETTINGS (deprecated.py)
2020-03-07 15:52:05 +00:00
Eugenio Lacuesta
ada37c5409
Export to multiple formats in a single crawl
2020-03-05 09:33:57 -03:00
Daniel Graña
c57512fa66
Merge pull request #4384 from nyov/nodeb
...
Drop horribly outdated deb package build files
2020-03-04 19:02:36 -03:00
nyov
b1566a6962
Remove deprecated Crawler.spiders property
...
Deprecated since 419026615 (2014, Scrapy 0.25)
2020-03-04 21:23:42 +00:00
Mikhail Korobov
ff8e826dd6
Merge pull request #4385 from nyov/obsolete
...
Obsolete REDIRECT_MAX_METAREFRESH_DELAY, LOG_UNSERIALIZABLE_REQUESTS
2020-03-05 00:04:29 +05:00
Mikhail Korobov
29f957d8cb
Merge pull request #4400 from nyov/obsolete-datatypes
...
Remove deprecated SiteNode and MultiValueDict classes
2020-03-04 23:56:36 +05:00
nyov
6c35baae25
Remove deprecated SiteNode and MultiValueDict classes
2020-03-04 00:40:11 +00:00
Eugenio Lacuesta
3aa5eab993
Merge branch 'master' into response_ip_address
2020-03-03 13:53:43 -03:00
nyov
6400225555
Drop horribly outdated deb package build files
2020-03-03 14:03:44 +00:00
nyov
1b591ff061
Obsolete deprecated settings
...
Obsolete REDIRECT_MAX_METAREFRESH_DELAY
which has been deprecated since Scrapy 0.18
Obsolete LOG_UNSERIALIZABLE_REQUESTS
which has been deprecated since Scrapy 1.2.0
and is replaced by SCHEDULER_DEBUG
2020-03-03 14:03:30 +00:00
Adrián Chaves
a4dbb7754b
Bump version: 1.8.0 → 2.0.0
2020-03-03 09:13:00 +01:00
Adrián Chaves
6aa0ba4553
Write release notes for Scrapy 2.0.0 ( #4329 )
2020-03-03 09:11:11 +01:00
Adrián Chaves
431f6e7d90
Merge branch 'master' into patch-1
2020-03-01 18:17:18 +01:00
MaliCN
ef00f8eb8e
updated with new macOS name ( #4308 ) ( #4323 )
...
* changed for new name as "macOS" (issue #4308 )
* updated macOS name
* update macOS name
* updated macOS name
* update for new macOS name
* docs/intro/install.rst: fix macOS header symbols
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: elacuesta <elacuesta@users.noreply.github.com>
2020-02-29 00:42:07 +05:00
Adrián Chaves
231c9ddef8
Update docs/intro/install.rst
2020-02-28 18:50:45 +01:00
sakshamb2113
c411a51f42
Fix random failures from test_fixed_delay in some machines ( #4372 )
2020-02-28 13:17:02 +01:00
Andrey Rahmatullin
09d9e75c08
Merge pull request #4375 from Gallaecio/env-warn-whitelist
...
Stop deprecation warnings on arbitrary SCRAPY-prefixed env vars
2020-02-28 13:26:17 +05:00
Adrián Chaves
9aae4c0be7
Add tests for envvar setting warnings
2020-02-27 16:31:43 +01:00
Adrián Chaves
2acaa86231
Do not warn about valid environment variables
2020-02-27 15:46:21 +01:00
HEndo12345
6109ad9aac
Clean up the deprecated settings list ( #4378 )
2020-02-27 15:15:30 +01:00
Mikhail Korobov
647cba0f10
Merge pull request #4373 from Gallaecio/fix-readthedocs
...
Fix the ReadTheDocs build
2020-02-26 02:27:02 +05:00
Adrián Chaves
778813717d
Use ReadTheDocs install.path
2020-02-25 21:58:28 +01:00
Adrián Chaves
a9d7d8f064
Add Scrapy dependencies back to docs/requirements.txt
2020-02-25 21:41:07 +01:00
Adrián Chaves
7291173f6b
Have ReadTheDocs builds fail on warning
2020-02-25 21:35:21 +01:00
gunblues
034e2c31c7
Use a non-zero exit code when a pipeline's open_spider method throws an exception ( #4207 )
...
* fix issue 4175 - Scrapy does not use a non-zero exit code when pipeline's open_spider throws the exception
* remove extra blank lines
* remove redundant code
* remove blank line at end of file
* more suitable naming for response and make if-condition shorter
* avoid error - AttributeError: 'Deferred' object has no attribute 'result'
* use getattr to make code concisely
* add test
* remove useless file
* modify test class name
* remove unneccessary files
* Fix Flake8-reported issue
* fix these items which are suggested by Gallaecio
・Sort those imports at tests/test_cmdline_crawl_with_pipeline/__init__.py
・Remove the unused setUp method.
・Remove comments generated by Scrapy’s project generation tool.
・Remove the [deploy] section from the scrapy.cfg file (I don’t think it’s needed here)
・Remove BOT_NAME and NEWSPIDER_MODULE from settings.py (I think there are not needed either, although I’m less sure about NEWSPIDER_MODULE)
* have to reserve BOT_NAME, SPIDER_MODULES in settings.py
* Remove unneeded empty lines
* Empty __init__.py file with unneeded comments
* Remove an unneeded empty line at the end
* Remove unneeed empty line from __init__.py file
* Update __init__.py
* Update __init__.py
* Update exception.py
* Update normal.py
* Update __init__.py
* Update __init__.py
* fix W391 blank line at end of file
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-02-26 00:46:05 +05:00
Mikhail Korobov
ea6ab179d9
Merge pull request #4361 from nyov/linkfix
...
Documentation linkcheck run, fixing some links.
2020-02-25 22:30:44 +05:00
nyov
a34c366fa4
DOC linkcheck run; https and 301 link updates.
...
Closes #4359
2020-02-25 16:51:33 +00:00
Mikhail Korobov
caa1dea890
Merge pull request #4370 from Gallaecio/dont-fail-kw-only
...
Make BaseItemExporter’s dont_fail parameter keyword-only
2020-02-25 13:12:01 +05:00
Adrián Chaves
7417a9871c
Make BaseItemExporter’s dont_fail parameter keyword-only
2020-02-24 13:28:15 +01:00
elacuesta
31f35c9c00
Remove unnecessary comma ( #4369 )
2020-02-24 12:02:00 +01:00
Eugenio Lacuesta
889b471852
Import changes
2020-02-23 18:40:43 -03:00
Eugenio Lacuesta
f85bf77da3
Restore unrelated change
2020-02-23 18:31:13 -03:00
Eugenio Lacuesta
a44942d27d
Merge branch 'master' into response_ip_address
2020-02-23 18:13:52 -03:00
Mikhail Korobov
49480225d7
Merge pull request #4365 from noviluni/fix_flake8_E701_E271
...
Fix flake8 E131, E211, E251, E271, E701
2020-02-23 15:52:52 +05:00
elacuesta
9d983c1b99
Expose certificate for HTTPS responses ( #4054 )
...
* Expose certificate for HTTPS responses
* Fix test (missing inlineCallbacks decorator)
* Note about Response.certificate
* Explicitly cover None as the default value of Response.certificate
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-02-22 17:20:31 +05:00
Vostretsov Nikita
67ee0b097f
Remove specifics of downstream request queues from scheduler ( #3884 )
...
* move serialization/deserialization logic to downstream queues
* make memory queues conform to common interface
* make ScrapyPriorityQueue conform common interface
* ScrapyPriorityQueue works with disk
* make key as string
* return list instead of dict as earlier
* downloader aware pq works with new interface
* we don`t need these methods anymore
* create directories for files
* remove dummy priority
* remove priority as parameter, let every queue decide for itself
* rename obj to request
* DownloaderAwarePriorityQueue is too thin wrapper around _SlotPriorityQueues, just remove second one
* remove priority as parameter, let every queue decide for itself
* rename argument
* more granular class separation
* python2 compatible
* one more argument for common interface
* more simple downstream queue interface
* single place for easier customization
* rename function
* shorter
* shorter
* use named arguments
* fix typo
* add docstring
* Update scrapy/pqueues.py
Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>
* Update scrapy/pqueues.py
Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>
* 4 spaces indentation
* we ok with existing directories
* remove unused import
* rename method
* remove unused imports
* it has no sense now
* relining
* note about queues
* add value
* Revert "it has no sense now"
This reverts commit b61604275b .
* pep8 E261
* pep8 E303
* pep8 E501
* pep8 E123
* pep8 E123
* use create instance
* remove excessive import
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
2020-02-22 17:02:57 +05:00
Marc Hernandez Cabot
6e8e117aee
fix flake E211
2020-02-22 12:32:38 +01:00
Marc Hernandez Cabot
69a8648bef
fix E251
2020-02-22 12:32:38 +01:00
Marc Hernandez Cabot
9ad10bb6f7
fix E131
2020-02-22 12:32:38 +01:00
Marc Hernandez Cabot
b49ece0b87
fix E701 and E271 flake8
2020-02-22 12:32:38 +01:00
Mikhail Korobov
e551bc5170
Merge pull request #4318 from wRAR/asyncio-parse-asyncgen
...
Support yield in async def callbacks.
2020-02-21 23:50:01 +05:00
Mikhail Korobov
b0a7efb88f
Merge pull request #4360 from noviluni/fix_flake8_E22X
...
fix E22X flake8
2020-02-21 23:45:27 +05:00
Mikhail Korobov
1be1101fe4
Merge pull request #4362 from noviluni/delete_deprecated_functions
...
delete old deprecated functions from scrapy.utils.python
2020-02-21 23:44:44 +05:00
Marc Hernandez Cabot
03ed9e1786
delete old deprecated functions from scrapy.utils.python
2020-02-21 09:29:29 +01:00
Marc Hernandez Cabot
6fb85951ce
fix E22X flake8
2020-02-21 08:39:14 +01:00
Marc Hernández
91bbc70bc1
fix E30X flake8 ( #4355 )
2020-02-21 06:05:31 +01:00
Mikhail Korobov
c4ee4b6075
Merge pull request #4347 from noviluni/deprecate_sel_shortcut
...
Remove deprecated `sel` shortcut in scrapy shell
2020-02-20 02:56:34 +05:00
Adrián Chaves
0f78a591f8
Fix Flake8-reported “Too many blank lines”
2020-02-19 19:09:39 +01:00
Adrián Chaves
6972a19707
Remove unused imports
2020-02-19 18:59:09 +01:00
Andrey Rahmatullin
88179027de
Merge pull request #4331 from Gallaecio/response-cb-kwargs
...
Implement Response.cb_kwargs
2020-02-19 22:40:14 +05:00
Marc Hernandez Cabot
eb21dae524
deprecare sel shortcut in scrapy shell
2020-02-19 17:49:42 +01:00
Andrey Rahmatullin
f558df2558
Merge pull request #4188 from elacuesta/logformatter-error-formatting
...
LogFormatter error formatting
2020-02-19 19:05:08 +05:00
Andrey Rahmatullin
528b894f28
Merge pull request #4321 from Gallaecio/link-extractor-encoding
...
Use safe_url_string in link extraction
2020-02-19 18:19:21 +05:00
Akshay Sharma
182445f9d9
Fix a spelling error: ie. → i.e. ( #4338 )
2020-02-18 17:58:31 +01:00
Mikhail Korobov
320cea62ff
Merge pull request #4309 from Gallaecio/virtualenv-doc
...
Update installation instructions regarding Python 3 and virtual environments
2020-02-18 19:56:35 +05:00
Adrián Chaves
5834088e67
Apply feedback
2020-02-18 14:18:15 +01:00
leobalestri
6d6243afbb
Update install.rst
...
Minor grammar and typo fixes
2020-02-16 23:45:41 -08:00
Adrián Chaves
a04dd13cd0
ie. → i.e.
2020-02-14 22:31:30 +01:00
Adrián Chaves
5ae3e1678f
ie. → i.e.
...
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
2020-02-14 22:30:36 +01:00
Adrián Chaves
43b43654a1
Add tests for meta and cb_kwargs not being available
2020-02-13 22:39:58 +01:00
Adrián Chaves
5ff9eb90ea
Add a test for the copy of cb_kwargs from Request to Response
2020-02-13 22:36:18 +01:00
Adrián Chaves
df937d8280
Implement Response.cb_kwargs
2020-02-13 22:33:36 +01:00
Adrián Chaves
b4958358e8
Update tests to account for link extractors escaping spaces
2020-02-12 19:00:04 +01:00
Adrián Chaves
e1be078eaa
Fix Flake8-reported issues
2020-02-12 17:38:06 +01:00
Adrián Chaves
73e88d036c
Import mock from unittest
2020-02-12 17:17:38 +01:00
Drew Seibert
2d6d4fb233
Deprecate overriding settings with SCRAPY-prefixed environment variables ( #4300 )
2020-02-11 10:35:23 +01:00
Mikhail Korobov
a6ef065eb5
Merge pull request #4271 from wRAR/asyncio-signals
...
async def support for signal handlers that already supported Deferreds
2020-02-11 02:05:45 +05:00
Adrián Chaves
61e74bac76
Extract links with safe_url_string
...
canonicalize_url changes links in undesirable ways.
2020-02-10 21:57:21 +01:00
Andrey Rakhmatullin
1f0f52cbf7
Improve async signal tests.
2020-02-11 01:05:45 +05:00
Andrey Rakhmatullin
36dcf90184
Also test non-default async callbacks.
2020-02-11 01:00:16 +05:00
Adrián Chaves
037ae5b22e
Explicitly indicate None as ip_address’s default value
2020-02-10 19:54:47 +01:00
Abhishek Pratap Singh
4626e90df8
Allow updating flags in follow and follow_all ( #4279 )
2020-02-10 19:48:31 +01:00
Adrián Chaves
96bb3b5144
Merge branch 'master' into feat-685
2020-02-10 19:45:09 +01:00
Adrián Chaves
7025c18b15
Clear line of spaces
2020-02-10 19:43:23 +01:00
Eugenio Lacuesta
13ba9bc629
Note about Response.ip_address
2020-02-10 12:29:39 -03:00
Eugenio Lacuesta
42b4e9b337
Reword signal docs
2020-02-10 11:23:38 -03:00
Eugenio Lacuesta
122ce6d6fb
Check bytes are received in order (bytes_received signal)
2020-02-10 10:20:26 -03:00
Eugenio Lacuesta
a64fa2f086
Keyword arguments when creating a _ResponseReader
2020-02-10 10:16:05 -03:00
Adrián Chaves
35723d76c0
Use canonicalize_url in link extraction
2020-02-07 22:59:53 +01:00
Adrián Chaves
c2f484de88
Merge branch 'master' into response_ip_address
2020-02-07 21:49:38 +01:00
Adrián Chaves
4c6993f264
Merge branch 'master' into asyncio-parse-asyncgen
2020-02-07 21:34:54 +01:00
Adrián Chaves
aae4935605
Merge branch 'master' into spider.parse
2020-02-07 21:17:56 +01:00
Adrián Chaves
59653ebac6
Update installation instructions regarding Python 3 and virtual environments
2020-02-07 21:07:57 +01:00
Mikhail Korobov
b0eaf114e5
Merge pull request #4197 from elacuesta/sphinx-twisted-api
...
[Docs] Fix Twisted links
2020-02-07 23:51:15 +05:00
Mikhail Korobov
bd7780277c
Merge pull request #4275 from abhishekh2001/master
...
Fixed artwork/README formatting
2020-02-07 23:44:15 +05:00
Mikhail Korobov
7e341e0f6b
Merge pull request #4291 from seregaxvm/master
...
add zsh -h autocomplete option
2020-02-07 23:42:10 +05:00
Mikhail Korobov
c3b690a5b5
Merge pull request #4290 from dekimsey/patch-1
...
FilesPipeline.file_path has optional arguments
2020-02-07 23:41:31 +05:00
Mikhail Korobov
957681bcfa
Merge pull request #4272 from elacuesta/spider-middleware
...
Spider middleware: catch spider callback exceptions early
2020-02-07 23:40:50 +05:00
Mikhail Korobov
afbaf9d430
Merge pull request #4303 from whalebot-helmsman/request_left_downloader_signal
...
request_left_downloader signal
2020-02-07 23:33:51 +05:00
Mikhail Korobov
0f62e44def
Merge pull request #4316 from wRAR/asyncio-parse-request-tests
...
Add a test for an async callbacks that returns requests.
2020-02-07 23:22:19 +05:00
Andrey Rakhmatullin
7323780c97
Support yield in async def callbacks.
2020-02-07 21:32:45 +05:00
Andrey Rakhmatullin
31f6c7112f
Add a test for an async callbacks that returns requests.
2020-02-07 17:14:52 +05:00
Andrey Rakhmatullin
4a7c7340a0
Merge remote-tracking branch 'origin/master' into asyncio-signals
2020-02-07 16:58:59 +05:00
Vostretsov Nikita
153b78e53f
Update docs/topics/signals.rst
...
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
2020-02-07 11:08:55 +05:00
Vostretsov Nikita
8817b9e8e9
Update docs/topics/signals.rst
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-02-07 11:07:53 +05:00
Vostretsov Nikita
2f83f3e2cb
Update docs/topics/signals.rst
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-02-07 11:07:43 +05:00
Vostretsov Nikita
84b55b7364
Update docs/topics/signals.rst
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2020-02-07 11:07:35 +05:00
Eugenio Lacuesta
6c333491a8
Merge branch 'master' into response_ip_address
2020-02-06 18:53:11 -03:00
Joy Bhalla
4f31c3ce01
Document a backward incompatibility that may affect custom schedulers ( #4274 )
2020-02-06 22:21:33 +01:00
Eugenio Lacuesta
7f2d3051fe
Fix Flake8 issue
2020-02-06 18:19:40 -03:00
Lane Shaw
3263441fbc
Update RFPDupeFilter line separator for correct universal newlines mode usage ( #4283 )
2020-02-06 22:14:40 +01:00
Adrián Chaves
24bb9fd5f7
Merge branch 'master' into spider.parse
2020-02-06 21:39:09 +01:00
Mikhail Korobov
042e71e2b8
Merge pull request #4311 from Gallaecio/metarefresh-ignore-tags
...
Make METAREFRESH_IGNORE_TAGS an empty list by default
2020-02-06 23:40:45 +05:00
Mikhail Korobov
8d2705f23c
Merge pull request #4305 from Respawnz/patch-1
...
fix a typo in devloper-tools.rst
2020-02-06 23:17:28 +05:00
elacuesta
35dafef7f1
Specify Twisted reactor (TWISTED_REACTOR setting) ( #4294 )
...
* Add the ability to install a specific reactor
* Add docs for the TWISTED_REACTOR setting
* Add tests for the TWISTED_REACTOR setting
* Update asyncio reactor test
* Ignore W503 globally
W503 is not PEP8-compliant:
c59c4376ad
* Line length adjustment
* Adjust asyncio reactor tests
* Merge ASYNCIO_ENABLED and TWISTED_REACTOR settings
* More docs about TWISTED_REACTOR
* Fix asyncio reactor test
* Docs: fix title
* Reword docs
* Check the TWISTED_REACTOR setting outside of the installing function
* Remove unrelated change
* Update scrapy/utils/log.py
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update docs/topics/settings.rst
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Update docs/topics/settings.rst
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
2020-02-06 22:42:34 +05:00
Andrey Rakhmatullin
489ffcda51
Add a test for an async item_scraped handler.
2020-02-06 22:40:11 +05:00
Vostretsov Nikita
4be19e443e
name signla catcher in accord with signal name
2020-02-06 13:46:23 +00:00
Vostretsov Nikita
4bcc0933d9
Merge branch 'request_left_downloader_signal' of github.com:whalebot-helmsman/scrapy into request_left_downloader_signal
2020-02-06 13:45:00 +00:00
Vostretsov Nikita
4a91a5427d
fix typo
2020-02-06 13:44:51 +00:00
Vostretsov Nikita
6733f4d976
Update docs/topics/signals.rst
...
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
2020-02-06 18:40:42 +05:00
Mikhail Korobov
bbbb8f1418
Merge pull request #4304 from elacuesta/remove-six-from-tox-ini
...
Remove elusive six occurrence from tox.ini
2020-02-06 17:09:57 +05:00
Adrián Chaves
576663e5a7
Make METAREFRESH_IGNORE_TAGS an empty list by default
2020-02-06 10:43:20 +01:00
Respawnz
c2cca36821
typo
2020-02-06 05:39:15 +08:00
Eugenio Lacuesta
11941c3244
Remove elusive six occurrence from tox.ini
2020-02-05 13:27:54 -03:00
Vostretsov Nikita
3769f75386
pep8 E302
2020-02-05 12:08:08 +00:00
Vostretsov Nikita
aab39f6341
docummentation for new signal
2020-02-05 11:35:03 +00:00
Vostretsov Nikita
9916f6e556
tests for new signal
2020-02-05 11:32:54 +00:00
Vostretsov Nikita
ae04174884
emit new signal
2020-02-05 11:32:31 +00:00
Vostretsov Nikita
898bc00811
new signal
2020-02-05 11:31:27 +00:00
Eugenio Lacuesta
fbea370c58
Rename function parameter
2020-02-05 01:35:13 -03:00
Eugenio Lacuesta
ad70497416
Remove unnecessary parentheses in class definition
2020-02-04 13:30:13 -03:00
Eugenio Lacuesta
13670f0397
Ignore tests/CrawlerRunner directory
2020-02-03 16:16:43 -03:00
Eugenio Lacuesta
e0ef8ad2d6
CrawlerRunner test for Response.ip_address
2020-02-03 15:52:15 -03:00
Eugenio Lacuesta
4851efdfb0
Flake8 adjustments
2020-02-03 14:50:54 -03:00
Eugenio Lacuesta
bb8f7dc609
Mock DNS server
2020-02-03 14:50:14 -03:00
Eugenio Lacuesta
a2ae380efc
Remove unnecessary commas
2020-02-03 13:23:52 -03:00
Eugenio Lacuesta
b9e3a6201b
Merge branch 'master' into response_ip_address
2020-02-03 04:07:44 -03:00
faizan2700
0641ba0faa
SCRAPY_CHECK will be set while running contact
2020-02-02 16:54:22 +05:30
Mikhail Korobov
22f7934fcc
Merge pull request #4269 from wRAR/asyncio-parse
...
Support for async def callbacks.
2020-01-31 23:50:19 +05:00
Andrey Rakhmatullin
7687564c73
Merge remote-tracking branch 'origin/master' into asyncio-signals
2020-01-30 17:42:03 +05:00
Andrey Rakhmatullin
cc825c21de
Test returning items from an async def callback.
2020-01-30 16:17:06 +05:00
Mikhail Korobov
47b9de93a9
Merge pull request #4288 from petervandenabeele/patch-1
...
[Docs] 2 typos + 1 clarification in docs
2020-01-30 03:15:18 +05:00
Mikhail Korobov
534ce07b10
Merge pull request #4293 from edorofeev/fix-accept-encoding-delimiter
...
[HttpCompressionMiddleware] fix delimiter for Accept-Encoding header
2020-01-30 00:19:40 +05:00
Eugenio Lacuesta
6f02a8dccb
Add source parameter to bytes_received signal
2020-01-29 15:51:25 -03:00
Eugenio Lacuesta
a499f38b14
Remove object parent class
2020-01-29 14:35:17 -03:00
Eugenio Lacuesta
2c9643d38c
Test: bytes_received signal fired multiple times
2020-01-29 14:17:06 -03:00
Evgeny Dorofeev
4e56571a19
[HttpCompressionMiddleware] fix delimiter for Accept-Encoding header
2020-01-29 15:49:22 +03:00
Daniel Kimsey
752e8f7018
FilesPipeline.file_path has optional arguments
...
Documented signature doesn't match the actual interface in [files.py](https://github.com/scrapy/scrapy/blob/master/scrapy/pipelines/files.py#L520 ).
Specifically, it looks like it may be [called](https://github.com/scrapy/scrapy/blob/master/scrapy/pipelines/files.py#L422 ) without a response value.
I found this when I was implementing the pipeline with the signature `file_path(self, request, response, info)` and the following error was being return in my results :
[(False, <twisted.python.failure.Failure builtins.TypeError: file_path() missing 1 required positional argument: 'response'>)]
Scrapy==1.8.0
2020-01-28 15:21:15 -06:00
Kevin Lloyd Bernal
a3b168948c
Log an error when giving up requests after too many retries ( #3566 )
2020-01-28 21:53:25 +01:00
Eugenio Lacuesta
ad4477d335
Remove unnecessary else
2020-01-27 14:16:43 -03:00
Eugenio Lacuesta
4ffd18fb11
[docs] Mention that signals.bytes_received could be fired multiple times
2020-01-27 13:29:33 -03:00
Eugenio Lacuesta
613fd41f44
bytes_received signal: improve test performance
2020-01-27 13:25:06 -03:00
Mikhail Korobov
a6bf895474
Merge pull request #4286 from petervandenabeele/fix-documentation
...
[Docs] Fix variable name `author_page_links`
2020-01-27 20:57:22 +05:00
Eugenio Lacuesta
dbe20a863f
bytes_received signal: send spider argument
2020-01-27 12:28:54 -03:00
Matsievskiy S.V
c9d3652230
add zsh -h autocomplete option
2020-01-27 18:24:57 +03:00
Adrián Chaves
89483ce9f7
Fix Flake8 issues
2020-01-27 12:08:56 -03:00
Eugenio Lacuesta
bda37e38bd
[Tests] bytes_received signal
2020-01-27 12:08:56 -03:00
Eugenio Lacuesta
cab449b195
Typo fix
2020-01-27 12:08:34 -03:00
Eugenio Lacuesta
72b8613ee9
bytes_received signal (no tests)
2020-01-27 12:06:48 -03:00
Eugenio Lacuesta
8529dff41d
Update docs regarding Response.ip_address and IPv6
2020-01-26 18:00:56 -03:00
Eugenio Lacuesta
e8da7e2966
Test DNS resolution using CrawlerProcess
2020-01-26 17:53:39 -03:00
Eugenio Lacuesta
80925ab845
Get server IP address for HTTP/1.1 responses
2020-01-26 16:57:04 -03:00
Peter Vandenabeele
f72d4e93e6
[Docs] 2 typos + 1 clarification in docs
...
Fixing 2 small typos and adding 1 word as clarification in the downloader-middlewares.
Also, I was confused with the entries like `ref:Reppy <reppy-parser>` and similar entries.
Are these supposed to be links to other parts of the doc, or is this the intended way of showing these references ?
2020-01-26 10:48:28 +01:00
Peter Vandenabeele
f3374a5047
Fix variable name `author_page_links`
...
I did not test this code, but the change from `href` to this
author_page_links seems to have a typo ?
2020-01-25 16:53:29 +01:00
Mikhail Korobov
8b8df31961
Merge pull request #4227 from elacuesta/name-resolver
...
Name resolver with IPv6 support
2020-01-25 05:03:13 +05:00
Mikhail Korobov
5f407cf657
Merge pull request #3961 from OmarFarrag/ftp_files#3928
...
Add FTPFileStore to FilesPipeline
2020-01-25 04:58:23 +05:00
Mikhail Korobov
7a62bd310c
Merge pull request #4126 from elacuesta/from_crawler_downloader_handlers
...
Download handlers: from_crawler factory method, take crawler in __init__
2020-01-25 04:52:56 +05:00
OmarFarrag
9e6d5573f1
Fix Flake8 errors
2020-01-24 15:58:52 +02:00
OmarFarrag
40e0a11aa8
Fix Flake8 errors
2020-01-24 15:51:48 +02:00
OmarFarrag
f5d9eb15f8
use `__future__` imports at the begining of the file
2020-01-24 15:06:40 +02:00
OmarFarrag
fc98aa6b67
Merge branch 'master' into ftp_files#3928
2020-01-24 14:52:40 +02:00
OmarFarrag
c544c0d2b8
Use context management with `FTP`
2020-01-24 14:36:16 +02:00
Eugenio Lacuesta
9899414300
Name resolver: return result directly
2020-01-23 18:06:59 -03:00
Mikhail Korobov
bd54f22fef
Merge pull request #4282 from petervandenabeele/patch-1
...
fix logical documentation error with PER_DOMAIN or PER_DOMAIN
2020-01-24 02:01:22 +05:00
Mikhail Korobov
6a98d660e5
Merge pull request #3551 from jpbalarini/change_scraper_slot
...
[MRG+1] Add ability to change max_active_size by setting
2020-01-23 23:40:05 +05:00
Mikhail Korobov
f80c7776ae
Merge pull request #4008 from elacuesta/docs_request_errback
...
Request: remove restriction about errback without callback
2020-01-23 23:12:44 +05:00
Peter Vandenabeele
7d5cebcf77
fix logical documentation error with PER_DOMAIN or PER_DOMAIN
2020-01-23 09:08:21 +01:00
Mikhail Korobov
c0a7dfbc01
Merge pull request #4057 from elacuesta/response_follow_all
...
Response.follow_all
2020-01-23 02:15:24 +05:00
Eugenio Lacuesta
c75cf15b7a
Update CSS selectors in tutorial
2020-01-22 10:38:59 -03:00
OmarFarrag
06ab668ec7
Use kwargs-only parameters in `ftp_store_file`
2020-01-22 03:48:07 +02:00
OmarFarrag
8ea8f14827
Update scrapy/utils/ftp.py
...
Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>
2020-01-20 18:19:36 +02:00
JP Balarini
0f2d871d88
Use PEP 515 style for SCRAPER_SLOT_MAX_ACTIVE_SIZE documentation
2020-01-20 11:28:28 -03:00
Juan Pablo Balarini
eaa8ed02d0
Add ability to change max_active_size by settings
2020-01-20 11:27:58 -03:00
Eugenio Lacuesta
b471765d40
[doc] FAQ entry about the IPv6 and the DNS_RESOLVER setting
2020-01-18 01:52:29 -03:00
Eugenio Lacuesta
302d3f552b
[doc] DNS_RESOLVER setting
2020-01-18 01:46:24 -03:00
Eugenio Lacuesta
41f7ebf3ad
CachingThreadedResolver: No need to store the reactor as an instance attribute
...
It's already done in the parent class
2020-01-17 12:40:59 -03:00
Eugenio Lacuesta
dee420a69c
Fix name resolvers tests
2020-01-16 23:48:16 -03:00
Eugenio Lacuesta
d487498cff
Update name resolvers tests
2020-01-16 22:02:01 -03:00
Eugenio Lacuesta
90e3bd8715
[test] Name resolvers
2020-01-16 20:32:40 -03:00
Eugenio Lacuesta
1040f581ec
Name resolvers: do not pass the reactor to the install method
2020-01-16 20:14:52 -03:00
Eugenio Lacuesta
3cfa73b8b1
Name resolvers: install_on_reactor as instance method
2020-01-16 18:01:18 -03:00
Eugenio Lacuesta
f45b4c7f8d
from_crawler support for name resolvers
2020-01-16 10:09:34 -03:00
Eugenio Lacuesta
0f155b059a
Make Flake8 happy (remove unused import)
2020-01-16 04:27:13 -03:00
Eugenio Lacuesta
e69cf415c8
Ability to choose name resolver
2020-01-16 03:58:07 -03:00
Mikhail Korobov
50310fc0f9
Merge pull request #4270 from wRAR/asyncio-pipelines
...
async def support in pipelines
2020-01-16 03:28:09 +05:00
Eugenio Lacuesta
8c3de288fa
Remove non-working DNS timeout code
2020-01-15 12:38:10 -03:00
Eugenio Lacuesta
55babf9acd
Cache resolution only if the DNS request was successful
2020-01-15 12:38:09 -03:00
Eugenio Lacuesta
f1c184631e
Name resolver: timeout
2020-01-15 12:38:09 -03:00
Eugenio Lacuesta
735c0ceb78
Custom name resolver implementing twisted.internet.interfaces.IHostnameResolver
2020-01-15 12:38:08 -03:00
abhishekh2001
03241aa4a6
Fixed artwork/README formatting
2020-01-15 08:54:25 +04:00
Eugenio Lacuesta
9770ca35fb
Spider middleware: simplify deferred errback handling
2020-01-10 18:45:39 -03:00
Eugenio Lacuesta
d6e928f472
Remove object as base class for MutableChain
...
Plus some minor styling adjustments
2020-01-10 04:40:10 -03:00
Eugenio Lacuesta
c088c04f44
Spider middleware: catch exceptions right after the spider callback
2020-01-10 04:20:55 -03:00
Eugenio Lacuesta
6ce1ad3107
[test] Spider middleware: catch exceptions right after the spider callback
2020-01-10 04:20:37 -03:00
Andrey Rakhmatullin
a91a13b443
Support for async def callbacks.
2020-01-09 15:59:19 +05:00
Andrey Rakhmatullin
3faef2d082
Add async def support to signal handlers that already supported Deferreds.
2020-01-09 15:17:45 +05:00
Andrey Rakhmatullin
7d85984880
Use get_from_asyncio_queue in the pipeline test.
2020-01-09 14:49:16 +05:00
Andrey Rakhmatullin
9d8c54c0f2
Fix/ignore flake8 problems.
2020-01-09 14:49:02 +05:00
Andrey Rakhmatullin
bdef948aae
Mark the asyncio pipelines test as only_asyncio.
2020-01-09 14:19:02 +05:00
Andrey Rakhmatullin
bfdd552a32
Add a test for pipelines using asyncio.
2020-01-09 14:19:02 +05:00
Andrey Rakhmatullin
1f9cef787d
Add async def support to pipelines.
2020-01-09 14:19:02 +05:00
Andrey Rakhmatullin
8117566974
Add utils.defer.deferred_f_from_coro_f.
2020-01-09 14:19:02 +05:00
Eugenio Lacuesta
2e405d2d5c
Merge branch 'master' into response_follow_all
2020-01-05 00:33:19 -03:00
Mikhail Korobov
ce618fb6f2
Merge pull request #4259 from scrapy/asyncio-mw
...
Asyncio support in downloader middlewares
2020-01-03 22:28:41 +05:00
Andrey Rakhmatullin
b2dd379bc2
Remove the py35-asyncio env for 3.5 from Travis.
2020-01-03 21:38:05 +05:00
Andrey Rakhmatullin
2b9254c2bd
Add a test function that uses asyncio.Queue().
2019-12-31 17:54:41 +05:00
Andrey Rakhmatullin
e3b8ba6188
Run py35-asyncio also on 3.5.2 to test Xenial.
2019-12-31 17:54:01 +05:00
Andrey Rakhmatullin
16787f5bf4
Merge middleware tests back as we don't need to set the setting anymore.
2019-12-30 12:02:19 +05:00
Andrey Rakhmatullin
50aa6ef22c
Add deferred_from_coro.
2019-12-30 11:46:45 +05:00
Andrey Rakhmatullin
5cf1ac0005
Move the asyncio downloader mw test to a separate class.
2019-12-30 11:46:45 +05:00
Andrey Rakhmatullin
3603644552
Add a non-asyncio async def middleware test.
2019-12-30 11:46:45 +05:00
Andrey Rakhmatullin
21f50c795a
Add async def support to downloader middlewares.
2019-12-30 11:46:45 +05:00
1um0s
14d4428e70
Rephrasing documentation for image and file pipelines ( #4252 )
...
* scrapy#4034 Clarify documentation for image and file pipelines
* scrapy#4034 Clarify documentation for file pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Clarify documentation for image and file pipelines
* scrapy#4034 Clarify documentation for file pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Revert image, file pipeline docs. Enhance custom media pipeline docs.
* scrapy#4034 rebase master
* scrapy#4034 Clarify documentation for image and file pipelines
* scrapy#4034 Clarify documentation for file pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Clarify documentation for image and file pipelines
* scrapy#4034 Clarify documentation for file pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Simplify documentation for pipeline
* scrapy#4034 Revert image, file pipeline docs. Enhance custom media pipeline docs.
* scrapy#4034 rebase master
* Rebase master
* Add class to media pipeline docs
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
Co-authored-by: elacuesta <elacuesta@users.noreply.github.com>
2019-12-30 00:56:22 +05:00
Mikhail Korobov
f0ae673452
Merge pull request #4258 from atul-g/patch-1
...
Edited the link provided to homepage of lxml's website
2019-12-30 00:55:15 +05:00
Mikhail Korobov
bb991cd303
Merge pull request #4010 from scrapy/asyncio-base
...
Base support for asyncio
2019-12-30 00:51:28 +05:00
Atul Gopinathan
82861c73c8
Edited the link of the homepage of lxml website
...
The link "https://lxml.de " is redirecting to a completely different and unintended website. I changed the link to the index page of lxml's official website. I thought of changing it to the PyPi page of lxml, but even they are providing the same "https://lxml.de " link which doesn't seem to be working now.
2019-12-27 22:57:58 +05:30
Andrey Rakhmatullin
dc1ee09481
Rename ASYNCIO_ENABLED to ASYNCIO_REACTOR, change the logic accordingly.
2019-12-27 21:56:28 +05:00
Andrey Rakhmatullin
f75ccc997a
FIx a typo in the only_asyncio fixture.
2019-12-27 19:48:54 +05:00
Andrey Rakhmatullin
30ebd05a5f
Simplify the tox asyncio entries.
2019-12-27 00:05:14 +05:00
Eugenio Lacuesta
8a1dc26d46
[doc] Note about the 'parse' method for CrawlSpider/XMLFeedSpider
2019-12-26 15:14:47 -03:00
Eugenio Lacuesta
c54df8253a
[test] Handle keyword args in CrawlSpider.parse
2019-12-26 15:12:19 -03:00
Eugenio Lacuesta
8d4948f6ca
[test] Override CrawlSpider.parse
2019-12-26 14:38:11 -03:00
Andrey Rakhmatullin
37ac47ff80
Fix a deprecation warning.
2019-12-26 20:46:54 +05:00
Andrey Rakhmatullin
87ece066ca
Remove conditional asyncio imports.
2019-12-26 20:41:06 +05:00
Eugenio Lacuesta
ab54e0d33e
Keyword-only args for S3DownloadHandler
2019-12-23 20:37:18 -03:00
Eugenio Lacuesta
982a66f9fb
[test] Download handler: avoid passing settings if not necessary
2019-12-23 20:28:17 -03:00
Eugenio Lacuesta
9a75b46fb8
Explicit argument names
2019-12-23 20:26:58 -03:00
Eugenio Lacuesta
2fb160e3ba
Use settings instead of crawler
2019-12-23 20:24:16 -03:00
Mikhail Korobov
4d594b8c2b
Merge pull request #4193 from Gallaecio/lgtm
...
Use super().__init__ in BaseItemExporter subclasses
2019-12-23 23:52:43 +05:00
Eugenio Lacuesta
5982e3477c
Take keyword arguments in base parsing methods
2019-12-23 14:12:21 -03:00
nyov
b9a58798ee
change Scraper API to call internal `_parse` method
...
A Spider class using internal pre-processing can have first dibs
at this and then call a public `parse` method for subclass hooking.
2019-12-23 13:55:06 -03:00
Eugenio Lacuesta
e2e15d6651
Downloader handlers: sort imports
2019-12-23 10:48:19 -03:00
Eugenio Lacuesta
a6ec89251e
Downloader handlers: crawler=None in __init__
2019-12-23 10:47:08 -03:00
Eugenio Lacuesta
8a567e98bb
Remove unnecessary __init__ methods in downloader handler tests
2019-12-23 10:36:46 -03:00
Eugenio Lacuesta
7e6387de40
Use create_instance in FTPDownloadHandler/DataURIDownloadHandler tests
2019-12-23 10:02:58 -03:00
Eugenio Lacuesta
fa21d8687a
Use create_instance in S3DownloadHandler tests
2019-12-23 10:00:25 -03:00
Eugenio Lacuesta
9e5d945ef2
Use create_instance in downloader handler tests
2019-12-23 09:55:47 -03:00
Eugenio Lacuesta
342bf3cd35
Explicit keyword arguments
2019-12-23 09:52:55 -03:00
Eugenio Lacuesta
931b7e68d3
Update FileDownloadHandler test
2019-12-23 09:50:28 -03:00
Eugenio Lacuesta
310cc081d0
Merge branch 'master' into from_crawler_downloader_handlers
2019-12-21 17:24:45 -03:00
Andrey Rakhmatullin
8de80f59db
Raise an exception if ASYNCIO_ENABLED but the reactor is wrong.
2019-12-21 13:08:29 +05:00
Mikhail Korobov
5577d4d2be
Merge pull request #3869 from elacuesta/detect_return_in_generator_callbacks
...
[MRG+1][Py3] Check for 'return' with arguments inside generators
2019-12-20 22:46:46 +05:00
Andrey Rakhmatullin
e342de5038
Remove a stray newline.
2019-12-20 19:37:50 +05:00
Andrey Rakhmatullin
40697dcbfa
Remove deferred_from_coro from this PR.
2019-12-20 19:33:44 +05:00
Andrey Rakhmatullin
20289be810
Merge remote-tracking branch 'origin/master' into asyncio-base
2019-12-20 19:31:20 +05:00
Mikhail Korobov
fb3fb17c28
Merge pull request #4045 from Gallaecio/documentation-coverage
...
Deprecate FilteringLinkExtractor direct usage; add API docs for scrapy.linkextractors
2019-12-20 02:01:45 +05:00
Mikhail Korobov
6a32a36e09
Merge pull request #4143 from Gallaecio/undent-rst-doctests
...
Do not indent doctests from the documentation unnecessarily
2019-12-20 01:59:07 +05:00
Mikhail Korobov
1213c0e5f0
Merge pull request #4247 from noviluni/fix_typos
...
fix typos
2019-12-20 01:56:36 +05:00
Mikhail Korobov
a611a7c0f2
Merge pull request #4249 from Gallaecio/docs-py37
...
Use Python 3.7 to build the documentation
2019-12-20 01:54:26 +05:00
Adrián Chaves
c7f9b955bd
Pylint: ignore not-an-iterable
2019-12-19 12:44:52 +01:00
Adrián Chaves
b4a2d985a7
Merge branch 'master' into undent-rst-doctests
2019-12-19 12:39:17 +01:00
Adrián Chaves
e22c0c27d9
Revert "Improve FilteringLinkExtractor.__new__"
...
This reverts commit ee9881d270 .
2019-12-19 12:15:54 +01:00
Adrián Chaves
f6bc1940a3
Use Python 3.7 to build the documentation
2019-12-19 12:06:15 +01:00
Andrey Rahmatullin
c841a1f3e7
Merge pull request #4140 from Gallaecio/docs-py38
...
Use the latest Python version to build the documentation
2019-12-19 14:09:02 +05:00
Marc Hernandez Cabot
16b363de31
Merge branch 'master' into fix_typos
2019-12-19 10:02:21 +01:00
Marc Hernandez Cabot
23a67cec27
fix first letter capitalization for Raring and Scrapy
2019-12-19 09:57:17 +01:00
Mikhail Korobov
3bcb14fe4d
Merge pull request #4164 from Gallaecio/speed-up-tests-2
...
Improve the performance of the DOWNLOAD_DELAY test
2019-12-18 23:56:56 +05:00
Mikhail Korobov
8f7faaa63d
Merge pull request #4190 from Gallaecio/doctest
...
Make developer-tools doctests pass
2019-12-18 23:40:21 +05:00
Marc Hernandez Cabot
c0d84f0962
fix typos
2019-12-18 19:39:21 +01:00
Mikhail Korobov
c976230b5f
Merge pull request #4246 from noviluni/fix_W293_blank_line_contains_whitespace
...
Fix W291, W292 and W293 flake8 issues (whitespaces)
2019-12-18 23:39:04 +05:00
Marc Hernandez Cabot
a5de2c64e6
fix W291, W292, W293 (whitespaces)
2019-12-18 16:33:46 +01:00
elacuesta
916382e109
Add errback parameter to scrapy.spiders.crawl.Rule ( #4000 )
...
* Add errback parameter to scrapy.spiders.crawl.Rule
* CrawlSpider: optimize by reducing iterations
* [test] Rule.errback
* [doc] Rule.errback
* [doc] Use autoclass in docs/topics/spiders.rst
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
* Rule.process_links takes a list
* Fix aesthetic issue reported by Flake8
2019-12-18 20:05:33 +05:00
Andrey Rahmatullin
0e8ee22a88
Merge pull request #4244 from wRAR/split-EngineTest
...
Split a long test in test_engine.py into three.
2019-12-18 20:00:36 +05:00
Adrián Chaves
00517ec273
Merge branch 'master' into docs-py38
2019-12-18 15:50:49 +01:00
Adrián Chaves
8c5a8a02ae
Merge branch 'master' into pylint
2019-12-18 15:43:40 +01:00
Andrey Rakhmatullin
7ccb169a27
Split a long test in test_engine.py into three.
2019-12-18 19:41:16 +05:00
Mikhail Korobov
053319334c
Merge pull request #4179 from Gallaecio/user-friendlier-tox
...
Make tox configuration more user friendly
2019-12-18 18:35:19 +05:00
Andrey Rahmatullin
e2b5cdeb88
Merge pull request #4242 from whalebot-helmsman/single_place_for_dependencies
...
Remove requirements-py3.txt
2019-12-18 18:27:09 +05:00
Vostretsov Nikita
012533924a
remove requirements from here too
2019-12-18 11:13:36 +00:00
Mikhail Korobov
e90f276903
Merge pull request #4198 from wRAR/deprecate-noconnect
...
Deprecate the HTTPS proxy noconnect mode.
2019-12-18 16:11:24 +05:00
Adrián Chaves
1f689b50c6
Merge remote-tracking branch 'origin/documentation-coverage' into documentation-coverage
2019-12-18 12:09:34 +01:00
Adrián Chaves
174769a3f0
Use a better name for the LxmlLinkExtractor subclassing test
2019-12-18 12:09:03 +01:00
Adrián Chaves
ee9881d270
Improve FilteringLinkExtractor.__new__
2019-12-18 12:08:34 +01:00
Vostretsov Nikita
12f9ffeb5d
remove requirements-py3.txt
2019-12-18 10:53:27 +00:00
Andrey Rakhmatullin
ac302c3f61
Fix a flake8 problem.
2019-12-18 15:43:05 +05:00
Andrey Rakhmatullin
bb2ff13e4c
Skip Http10ProxyTestCase.test_download_with_proxy_https_noconnect
2019-12-18 15:39:08 +05:00
Andrey Rakhmatullin
2d92a39003
Restore test_download_with_proxy_https_noconnect, check for a warning there.
2019-12-18 12:07:08 +05:00
Adrián Chaves
607815dfc2
Merge branch 'master' into documentation-coverage
2019-12-17 16:54:27 +01:00
Adrián Chaves
b8cf522916
Merge branch 'master' into user-friendlier-tox
2019-12-17 16:53:08 +01:00
Andrey Rahmatullin
4be2bbfe75
Merge pull request #4239 from Apuyuseng/master
...
Fix mail attachs tcmime *** (#4229 )
2019-12-17 19:43:30 +05:00
Andrey Rahmatullin
bb3f164280
Merge pull request #4236 from wRAR/pipeline-tests
...
Add simple tests for pipelines.
2019-12-17 19:38:06 +05:00
Adrián Chaves
20719bac5c
Fix import error
2019-12-17 15:09:43 +01:00
Adrián Chaves
ab13221b0b
Merge remote-tracking branch 'upstream/master' into allow-customizing-export-column-names
2019-12-17 14:06:14 +01:00
Marc Hernández
63cf5c75c8
Fix E502: backslash is redundant between brackets ( #4238 )
2019-12-17 13:53:15 +01:00
apu
7d0096da6e
Fix mail attachs tcmime *** ( #4229 )
...
When the file name consists of alphanumeric characters, it is normal to receive the attachment name.
However,However, problems will occur if the file name is changed to Chinese.
This has nothing to do with the file type
2019-12-17 09:47:01 +08:00
Andrey Rakhmatullin
5980d3bbff
Add simple tests for pipelines.
2019-12-16 22:41:28 +05:00
Mikhail Korobov
e9b24d62c6
Merge pull request #4231 from noviluni/docs_fix
...
Docs fix
2019-12-16 21:56:43 +05:00
Andrey Rakhmatullin
900de7c146
Fix the reactor_pytest fixture.
2019-12-16 21:11:58 +05:00
Andrey Rakhmatullin
039e6fe691
Refactor install_asyncio_reactor slightly.
2019-12-16 20:17:41 +05:00
Eugenio Lacuesta
451e7a616e
Scan callbacks/errbacks for return statements with values different than None
2019-12-16 11:30:40 -03:00
Andrey Rakhmatullin
2db7d45378
Enable skipping tests based on --reactor.
2019-12-16 19:25:49 +05:00
marc
a59bb279d1
add year through code
2019-12-15 17:33:00 +01:00
marc
1aab20e1ce
update copyright notice year
2019-12-14 10:37:31 +01:00
marc
e3a3ad4aaf
remove reference to old (Python 2.7) environment
2019-12-14 10:34:31 +01:00
Andrey Rakhmatullin
a1605cade6
Hide utils.defer.isfuture().
2019-12-13 19:35:09 +05:00
Andrey Rakhmatullin
afc886e578
Simplify tox.ini asyncio entries.
2019-12-13 19:34:58 +05:00
Adrián Chaves
a4ef9750f9
Fix Flake8-reported issues
2019-12-13 14:32:06 +01:00
Adrián Chaves
b5c4c2cae8
Keep 2 spaces between code and inline comments ( #4195 )
2019-12-13 14:20:48 +01:00
Andrey Rakhmatullin
bfb78b8dea
Add CrawlerProcess tests for ASYNCIO_ENABLED.
2019-12-13 18:12:07 +05:00
Andrey Rakhmatullin
855bbebc8b
Move install_asyncio_reactor() from commands to CrawlerProcess.
2019-12-13 18:11:49 +05:00
Andrey Rakhmatullin
69cd2e247e
Move a bunch of "from twisted.internet import reactor" inside functions.
2019-12-13 18:07:55 +05:00
Andrey Rakhmatullin
3560123090
Rename ASYNCIO_SUPPORT to ASYNCIO_ENABLED.
2019-12-13 18:07:47 +05:00
Andrey Rakhmatullin
352ddbb336
Merge remote-tracking branch 'origin/master' into asyncio-base
2019-12-13 18:07:23 +05:00
Andrey Rahmatullin
02cdc53fb8
Add a test for a CrawlerProcess script. ( #4218 )
...
* Add a test for a CrawlerProcess script.
* Add tests/CrawlerProcess to collect_ignore.
* Remove an extra line.
* Fix/improve conftest.py.
2019-12-13 18:04:05 +05:00
Eugenio Lacuesta
21a2f8c6f8
Merge branch 'master' into response_follow_all
2019-12-10 17:30:59 -03:00
Adrián Chaves
07b8cd28aa
Mark bandit’s 402 check as addressed by #4180 ( #4181 )
2019-12-05 14:48:31 +01:00
Adrián Chaves
1fc2b140c1
Merge branch 'master' into documentation-coverage
2019-12-05 14:43:36 +01:00
Andrey Rahmatullin
076f0764b7
Merge pull request #4121 from scrapy/remove-six-code
...
Remove six-related code and __future__ imports
2019-12-05 18:20:14 +05:00
Adrián Chaves
d7b1c138f1
Merge branch 'master' into user-friendlier-tox
2019-12-05 14:02:24 +01:00
Adrián Chaves
83b8046fdc
Do not indent doctests from the documentation unnecessarily
2019-12-05 13:52:31 +01:00
Mikhail Korobov
250da28952
Merge pull request #4170 from mabelvj/4133-handle-start_url
...
Raise error when start_url found instead of start_urls.
2019-12-05 17:47:03 +05:00
Adrián Chaves
57e36b5f0d
Merge branch 'master' into spider-name-collision
2019-12-05 13:03:43 +01:00
Andrey Rahmatullin
7079d12c5e
Merge pull request #4212 from grammy-jiang/fix-imports
...
Convert the relative imports to absolute imports
2019-12-05 12:44:22 +05:00
Andrey Rahmatullin
aaf94affee
Merge pull request #4213 from dqwerter/patch-1
...
Update overview.rst | Fix an inconsistency
2019-12-05 12:43:24 +05:00
Wang Qin
af624ef414
Update overview.rst | Fix an inconsistency
...
There exists an inconsistency between the code (line 37 - 38) and the output 'quotes.json' (line 56 - 68).
Note that even though according to line 53 - 54 'quotes.json' is "reformatted here for better readability", it cannot explain why the "author" field precedes the "text" field.
Intended output for the code BEFORE change:
[{
"text": "\u201cThe person, be it gentleman or lady, who has not pleasure in a good novel, must be intolerably stupid.\u201d",
"author": "Jane Austen"
},
{
"text": "\u201cOutside of a dog, a book is man's best friend. Inside of a dog it's too dark to read.\u201d",
"author": "Groucho Marx"
},
{
"text": "\u201cA day without sunshine is like, you know, night.\u201d",
"author": "Steve Martin"
},
...]
Intended output for the code After change (the inconsistency is fixed):
[{
"author": "Jane Austen",
"text": "\u201cThe person, be it gentleman or lady, who has not pleasure in a good novel, must be intolerably stupid.\u201d"
},
{
"author": "Groucho Marx",
"text": "\u201cOutside of a dog, a book is man's best friend. Inside of a dog it's too dark to read.\u201d"
},
{
"author": "Steve Martin",
"text": "\u201cA day without sunshine is like, you know, night.\u201d"
},
...]
2019-12-05 09:29:12 +08:00
Grammy Jiang
9b4b43f8ac
Convert the relative imports to absolute imports
...
This commits converts the relative imports to absolute imports in the
entire package
2019-12-05 11:25:19 +11:00
Eugenio Lacuesta
2c010152c3
Merge remote-tracking branch 'upstream/master' into remove-six-code
2019-12-04 15:43:02 -03:00
Andrey Rakhmatullin
0b9f29215f
Update .travis.yml.
2019-12-04 22:06:35 +05:00
Andrey Rakhmatullin
97fb61cec8
Move an import to postpone another "import twisted.internet.reactor".
2019-12-04 21:53:07 +05:00
Andrey Rakhmatullin
ed34ce14c0
Add the ASYNCIO_SUPPORT setting, reshuffle other logic accordingly.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
c079d5002b
Run tests without asyncio support by default, add py35-asyncio and py38-asyncio envs.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
794cf71806
Fix or ignore flake8 problems.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
3ba25ccbd3
Don't use asyncio.iscoroutine, as it is True for generators.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
f41c2f3874
Add py38-no-asyncio to Travis.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
cc19ab5439
Add tests that check asyncio support.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
2fbe7d49dc
Log asyncio support on spider start.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
b04b541372
Install the asyncio reactor only in scrapy.cmdline.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
8d8fbddbde
Switch to the released version of pytest-twisted.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
63c3c62305
Add utils.deferred_from_coro.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
9777639533
Run tests using the asyncio reactor.
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
1b437bbe9f
Install the asyncio reactor on "import scrapy".
2019-12-04 21:32:56 +05:00
Andrey Rakhmatullin
1b35260625
Add a test for downloader middlewares using Deferreds.
2019-12-04 21:32:56 +05:00
Grammy Jiang
74627033c4
Remove the used import and re-arrange the imports ( #4208 )
...
This commit removes unused import and re-arrange the imports in cookies
module
2019-12-04 14:24:14 +01:00
Grammy Jiang
702333478d
Re-arrange the imports in httpcache module ( #4209 )
...
This commit re-arrange the imports in httpcache module to follow pep8
2019-12-04 14:23:28 +01:00
Grammy Jiang
5d8d4bb7d7
Re-arrange the imports in the httpproxy module ( #4210 )
...
This commit re-arranges the imports in the httpproxy module to follow
pep8
2019-12-04 14:22:10 +01:00
Eugenio Lacuesta
62778cf23f
Request: remove restriction about errback without callback
2019-12-04 08:53:38 -03:00
Eugenio Lacuesta
2a9f5a0aef
Skip invalid links when passing SelectorLists to Response.follow_all
2019-12-03 16:01:42 -03:00
Mikhail Korobov
9b7452211a
Merge pull request #4099 from BurnzZ/itemloader-docs
...
update docs of scrapy.loader.ItemLoader.item
2019-12-03 13:14:45 +05:00
Eugenio Lacuesta
e43f37fff3
Pass args/kwargs in S3DownloadHandler.from_crawler, update tests
2019-12-02 17:36:31 -03:00
Eugenio Lacuesta
3d77f74e40
Download handlers: from_crawler factory method, take crawler instead of settings in __init__
2019-12-02 17:36:31 -03:00
Adrián Chaves
5980b0f284
Don’t use follow_all where a single item is expected ( #4 )
2019-12-02 12:47:44 -03:00
Grammy Jiang
d1cdfb4701
Use pprint.pformat on overridden settings ( #4199 )
...
Keeps consistency with scrapy.middleware
2019-11-29 09:13:57 +01:00
Mikhail Korobov
3a5b86220f
Merge pull request #4194 from Gallaecio/intersphinx
...
Use InterSphinx for coverage links
2019-11-28 17:36:19 +05:00
Eugenio Lacuesta
048cd74ae5
Add separate mapping for Twisted API docs
2019-11-27 19:16:18 -03:00
Eugenio Lacuesta
17e6481823
[Docs] Fix Twisted links
2019-11-27 18:42:42 -03:00
Andrey Rakhmatullin
63546cbf3e
Deprecate the HTTPS proxy noconnect mode.
2019-11-27 22:42:52 +05:00
Adrián Chaves
b73fc99b60
Use InterSphinx for coverage links
2019-11-26 10:31:55 +01:00
Adrián Chaves
dd12f5fdcd
Use Response.follow_all in the documentation where appropiate
2019-11-25 11:59:59 -03:00
Adrián Chaves
ed1e577610
Use super().__init__ in BaseItemExporter subclasses
2019-11-25 13:38:10 +01:00
Adrián Chaves
54b056c4be
Make developer-tools doctests pass
2019-11-25 12:32:35 +01:00
Adrián Chaves
6d9ed6146d
Merge branch 'master' into remove-six-code
2019-11-25 10:34:21 +01:00
Andrey Rahmatullin
8a1c99676e
Merge pull request #3899 from elacuesta/py3_single_argument_processors
...
[Py3] Item loaders: allow single argument functions as processors
2019-11-25 13:47:58 +05:00
Eugenio Lacuesta
03af8885ff
LogFormatter.download_error
2019-11-23 20:02:44 -03:00
Eugenio Lacuesta
4756e7c587
LogFormatter.spider_error
2019-11-23 19:33:29 -03:00
Eugenio Lacuesta
facb926542
Remove quotes from item_error message
2019-11-23 19:16:41 -03:00
Eugenio Lacuesta
7a7d13b112
Rename LogFormatter.error to item_error
2019-11-23 19:12:03 -03:00
Eugenio Lacuesta
40b5cfc0a4
Item loaders: allow single-argument processors (unbound methods)
2019-11-22 20:47:22 -03:00
Eugenio Lacuesta
6fa8f06b64
Merge remote-tracking branch 'upstream/master' into response_follow_all
2019-11-22 13:05:06 -03:00
Eugenio Lacuesta
55cc5c9068
Skip pickle in bandit check
2019-11-22 12:41:31 -03:00
Eugenio Lacuesta
5bab3c0261
Merge remote-tracking branch 'upstream/master' into remove-six-code
2019-11-22 12:12:29 -03:00
Mikhail Korobov
16e0636dcf
Merge pull request #4186 from Gallaecio/lgtm
...
Remove unused imports
2019-11-22 12:28:29 +05:00
Adrián Chaves
9b5053c564
Undo unintended tox.ini changes
2019-11-21 22:00:34 +01:00
Mikhail Korobov
0d416c6191
Merge pull request #4185 from Gallaecio/intersphinx
...
Use InterSphinx for links to the pytest and tox documentation
2019-11-21 23:27:57 +05:00
Mabel Villalba
070b3a4e84
Merge branch 'master' into 4133-handle-start_url
2019-11-21 17:10:31 +01:00
Mabel Villalba
1718e450ef
[start_url] Fixes #4133 : Raise AttributeError error when empty 'start_urls' and 'start_url' found. Added test.
2019-11-21 17:06:47 +01:00
Mikhail Korobov
82c01c261f
Merge pull request #4184 from Gallaecio/doctest
...
Make debug doctests pass
2019-11-21 20:53:56 +05:00
Eugenio Lacuesta
bf503869e9
Merge remote-tracking branch 'upstream/master' into remove-six-code
2019-11-21 10:58:24 -03:00
Adrián Chaves
b232881356
Restore intentional import of unused objects
2019-11-21 14:30:10 +01:00
Mikhail Korobov
91c9576675
Merge pull request #4183 from Gallaecio/sphinx-extensions-2
...
Enable sphinx-hoverxref for all references
2019-11-21 18:25:21 +05:00
Mikhail Korobov
d2b73b8e21
Merge pull request #4114 from scrapy/remove-py2-tests
...
Remove py2 tests
2019-11-21 18:22:10 +05:00
Adrián Chaves
a2bf340bab
Remove unused imports
2019-11-21 14:21:17 +01:00
Adrián Chaves
fcfcabf1bd
Use InterSphinx for links to the pytest and tox documentation
2019-11-21 12:15:13 +01:00
Adrián Chaves
f251dda268
Make debug doctests pass
2019-11-21 11:59:10 +01:00
Adrián Chaves
4f80eff1e1
Enable sphinx-hoverxref for all references
2019-11-21 10:30:21 +01:00
Eugenio Lacuesta
714e0d3ac9
Merge remote-tracking branch 'upstream/master' into remove-six-code
2019-11-20 12:41:38 -03:00
Mikhail Korobov
f1fd7ec318
Merge pull request #4171 from Gallaecio/doctest
...
Make command doctests pass
2019-11-20 19:47:22 +05:00
Mikhail Korobov
65e2fb7d89
Merge pull request #4153 from Gallaecio/lgtm
...
MutableChain: return self from __iter__
2019-11-20 19:46:20 +05:00
Mikhail Korobov
d69e788fec
Merge pull request #4172 from Gallaecio/intersphinx
...
Use InterSphinx to link to the Twisted documentation
2019-11-20 19:38:50 +05:00
Mikhail Korobov
1f61b6b941
Merge pull request #4173 from Gallaecio/sphinx-extensions-2
...
Add tooltips to documentation cross-references
2019-11-20 19:38:05 +05:00
Mikhail Korobov
1b4afa28e7
Merge pull request #4169 from Gallaecio/sphinx-extensions
...
Include /requirements-py3.txt from /docs/requirements.txt
2019-11-20 19:36:43 +05:00
Mikhail Korobov
e96ca89a1d
Merge pull request #4174 from Gallaecio/flake8
...
Add missing blank lines between functions and classes
2019-11-20 19:34:04 +05:00
Eugenio Lacuesta
6781d2f5b2
Update sample file references
2019-11-20 09:58:25 -03:00
Eugenio Lacuesta
6f4e84ecf9
PEP8 adjustments for scrapy.http.response module
2019-11-20 09:55:15 -03:00
Eugenio Lacuesta
48223c107a
Merge remote-tracking branch 'upstream/master' into response_follow_all
2019-11-20 09:41:42 -03:00
Eugenio Lacuesta
b602c61e1c
[Test] Rename outdated sample files
2019-11-20 09:38:54 -03:00
Eugenio Lacuesta
e6c5292a7c
Response.follow_all: Specific exception for invalid selectors
2019-11-20 09:29:55 -03:00
Adrián Chaves
42954d0df9
Mention that ScrapyHTTPClientFactory has Twisted code
2019-11-20 08:16:33 +01:00
Adrián Chaves
fc3af54dbd
Make tox configuration more user friendly
2019-11-20 08:04:17 +01:00
Eugenio Lacuesta
6f6426559d
Merge remote-tracking branch 'upstream/remove-py2-tests' into remove-six-code
2019-11-19 11:04:46 -03:00
Eugenio Lacuesta
05785c1c17
Merge remote-tracking branch 'upstream/master' into remove-six-code
2019-11-19 11:01:34 -03:00
Andrey Rahmatullin
78ad01632f
Fix flake8 problems in PR #3989 ( #4176 )
2019-11-19 10:43:30 +01:00
Andrey Rakhmatullin
beb7d80d6a
Add a comment about the noconnect tests.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
922a66cf07
Fix or ignore flake8 problems.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
a7b640991d
Rename tests/py3-ignores.txt to tests/ignores.txt.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
8b730a3670
Use self.proc.communicate() after killing mitmdump.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
5970d00eb9
Only xfail test_https_connect_tunnel_error on 3.6+.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
5080180c75
Improve the test_https_tunnel_without_leak_proxy_authorization_header change.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
c4ef950efd
Use an older mitmproxy for py3.5.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
3ec6960732
Fix test_proxy_connect.py for py3.5.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
c327ad9ba6
Remove an unused six import.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
cbb6d0c6a7
Mark failing proxy tests.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
f066257e95
Restore tests/test_proxy_connect.py and update it to modern mitmproxy.
2019-11-19 13:52:49 +05:00
Andrey Rakhmatullin
e18014d84d
Remove Python 2-only tests.
2019-11-19 13:52:49 +05:00
Andrey Rahmatullin
25cd7ac7ab
Merge pull request #4094 from victor-torres/invalid-url
...
Improve URL schema validation on scrapy.Request initialization
2019-11-19 13:50:08 +05:00
Andrey Rahmatullin
3408b757c1
Merge pull request #3989 from elacuesta/logformatter_error_method
...
LogFormatter improvements
2019-11-19 13:44:43 +05:00
Andrey Rahmatullin
e829c47eb8
Merge pull request #3937 from sbs2001/patch-10
...
Update reactor.py, updated 'if' sequencing .
2019-11-19 11:20:56 +05:00
Adrián Chaves
f261cf65e9
Add missing blank lines between functions and classes
...
Also fixed 2 unrelated Flake8 issues
2019-11-18 17:16:09 +01:00
Adrián Chaves
fed93515de
Add tooltips to documentation cross-references
2019-11-18 16:11:03 +01:00
Adrián Chaves
e84cb18ca0
Use InterSphinx to link to the Twisted documentation
2019-11-18 15:50:45 +01:00
Adrián Chaves
74589df02f
Make command doctests pass
2019-11-18 14:51:44 +01:00
Adrián Chaves
e1af85619f
Add a configuration file for Read the Docs
2019-11-18 11:13:38 +01:00
Adrián Chaves
6d1667d5b8
Use the latest Python version to build the documentation
2019-11-18 11:13:34 +01:00
Adrián Chaves
99d8b05a0b
Deprecate scrapy.utils.python.MutableChain.next
2019-11-18 10:58:47 +01:00
Adrián Chaves
393a2a1972
Include /requirements-py3.txt from /docs/requirements.txt
2019-11-18 09:15:48 +01:00
Andrey Rahmatullin
a78e58afe0
Merge pull request #4167 from noviluni/fix_E711_and_E713
...
fix E711 and E713
2019-11-17 16:46:15 +05:00
Marc Hernandez Cabot
0e252f5a13
fix E711 and E713
2019-11-15 19:12:43 +01:00
Andrey Rahmatullin
786a55b2a6
Merge pull request #4059 from josealberto4444/master
...
Make punctuation consistent
2019-11-15 15:39:27 +05:00
José Alberto / Speedy
77a84f620f
Fix string
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-11-15 11:09:24 +01:00
Mikhail Korobov
a541c329a9
Merge pull request #4152 from Gallaecio/sphinx-extensions
...
Install the sphinx-notfound-page Sphinx extension
2019-11-15 00:36:56 +05:00
Mikhail Korobov
7b4637d083
Merge pull request #4146 from Gallaecio/doctest
...
Make tutorial doctests pass
2019-11-15 00:19:20 +05:00
Mikhail Korobov
49b5251e06
Merge pull request #4147 from Gallaecio/intersphinx
...
Use intersphinx for links to the Sphinx documentation
2019-11-15 00:16:39 +05:00
Mikhail Korobov
cc0026f733
Merge pull request #4148 from Gallaecio/doc-view-code
...
Allow opening the source code from the API documentation
2019-11-14 23:43:44 +05:00
Mikhail Korobov
550d8046fd
Merge pull request #4157 from Gallaecio/flake8
...
Add missing whitespace after ‘,’, ‘;’ or ‘:’
2019-11-14 23:42:06 +05:00
Mikhail Korobov
298d709e16
Merge pull request #4162 from Gallaecio/bandit
...
Add bandit to CI
2019-11-14 23:40:01 +05:00
Mikhail Korobov
d61088f47d
Merge pull request #4163 from Gallaecio/speed-up-tests
...
Have CI record the 10 slowest tests
2019-11-14 23:35:21 +05:00
Mikhail Korobov
494f38a99d
Merge pull request #4115 from scrapy/remove-py2-code
...
Remove py2 code
2019-11-14 23:33:58 +05:00
Andrey Rakhmatullin
3b2289ad01
Rename test_non_str_url_py2 to test_bytes_url.
2019-11-14 22:53:28 +05:00
Andrey Rakhmatullin
fe3a121f13
Use kwargs when calling get_func_args.
2019-11-14 22:50:53 +05:00
Adrián Chaves
0946eb335a
Port code from Twisted’s deprecated HTTPClientFactory into ScrapyHTTPClientFactory
2019-11-14 17:56:21 +01:00
Adrián Chaves
058bdda0af
Improve the performance of the DOWNLOAD_DELAY test
2019-11-14 16:53:20 +01:00
Adrián Chaves
5ee5508cc3
Have CI record the 10 slowest tests
2019-11-14 15:42:34 +01:00
Adrián Chaves
b8ef12cd47
Add bandit to CI
2019-11-14 12:11:28 +01:00
Andrey Rahmatullin
5a2b057355
Merge pull request #4066 from akhterwahab/update-ignored-extensions
...
Add .dmg, .iso & .apk to ignored other extensions
2019-11-14 15:26:03 +05:00
Andrey Rakhmatullin
e291460db6
Fix flake8-detected errors.
2019-11-14 15:24:37 +05:00
Andrey Rahmatullin
3631453bfb
Remove spaces on a blank line.
2019-11-14 15:07:53 +05:00
Adrián Chaves
be6da52019
Include extensions from #2067
2019-11-14 10:31:55 +01:00
Adrián Chaves
1a4a77d49f
Remove Python 2 check from MutableChainTest
2019-11-14 10:24:31 +01:00
Andrey Rakhmatullin
dd367438fa
Improve the dbm module ref.
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
a9c891399d
Fix a duplicate ref name in docs.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
87c23ba22d
Remove Py2-only code that checks sys.version_info.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
a138fb05d4
Replace to_native_str calls with to_unicode.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
92ffd2f249
Simplify some more imports.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
cfa633f5e8
Some text function messages cleanup, deprecate to_native_str.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
85e79ae792
Remove cStringIO imports.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
065fe29d3c
Deprecate scrapy.utils.gz.read1.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
0e696ed06d
Remove unneeded and unused code from XmlItemExporter.
2019-11-14 13:45:39 +05:00
Andrey Rakhmatullin
1d7c8cb0b1
Remove six.PY2 and six.PY3 conditionals.
2019-11-14 13:45:37 +05:00
Adrián Chaves
33ef24c757
Add missing whitespace after ‘,’, ‘;’ or ‘:’
2019-11-13 10:52:05 +01:00
Adrián Chaves
a3a3107bc4
MutableChain: return self from __iter__
2019-11-13 09:46:54 +01:00
Adrián Chaves
76c31094df
Install the sphinx-notfound-page Sphinx extension
2019-11-13 09:28:48 +01:00
Adrián Chaves
b642a1fca2
Fix doctest skipping based on the running Python version
2019-11-13 09:14:20 +01:00
Adrián Chaves
414e6e2fd5
Skip a doctest in Python 3.5- because of dictionary changes
2019-11-13 08:40:31 +01:00
Andrey Rahmatullin
c911e80209
Merge pull request #4088 from ammarnajjar/4086-constructor-initializer-docs
...
docs: use __init__ method instead of constructor
2019-11-12 21:48:16 +05:00
Andrey Rahmatullin
c91390558d
Merge pull request #4074 from purvaudai/master
...
Added Pathlib.Path support: Issue #3731
2019-11-12 21:43:28 +05:00
Andrey Rahmatullin
4c9a1cd2d9
Merge pull request #4097 from Gallaecio/test-coverage
...
Remove unused method from scrapy.pqueues._SlotPriorityQueues
2019-11-12 18:45:29 +05:00
purvaudai
4b8b0345e5
Mades Changes as per review
2019-11-12 18:17:15 +05:30
Andrey Rahmatullin
d8098350f0
Merge pull request #3960 from thernstig/issue_2149
...
Update documentation for logging manually
2019-11-12 16:17:49 +05:00
Andrey Rahmatullin
93385e647a
Merge pull request #4123 from elacuesta/utils-local-cache-limit
...
Fix LocalCache limit issue, add tests
2019-11-12 16:05:22 +05:00
Adrián Chaves
8a6a063778
Allow opening the source code from the API documentation
2019-11-12 10:23:19 +01:00
Adrián Chaves
7b7bb028f4
Use intersphinx for links to the Sphinx documentation
2019-11-12 08:49:06 +01:00
Adrián Chaves
79d2f99995
Make tutorial doctests pass
2019-11-12 08:08:50 +01:00
purvaudai
50eaabe1fc
Added Test
2019-11-11 20:00:26 +05:30
purvaudai
f39ff49458
Added Test
2019-11-11 18:54:21 +05:30
purvaudai
0c2dcd5092
Added Test
2019-11-11 18:35:50 +05:30
purvaudai
970c3be160
Added Test
2019-11-11 18:34:15 +05:30
purvaudai
9e6e2dde2b
Adding test
2019-11-11 16:10:37 +05:30
purvaudai
0042c389eb
Adding test
2019-11-11 15:57:58 +05:30
purvaudai
084a1cda6d
Adding test
2019-11-11 15:41:00 +05:30
Adrián Chaves
ecc46ac741
Merge branch 'master' into pylint
2019-11-11 10:45:25 +01:00
Eugenio Lacuesta
07fa768d33
Merge branch 'remove-six-code' of github.com:scrapy/scrapy into remove-six-code
2019-11-08 22:17:12 -03:00
Eugenio Lacuesta
b6bbb28197
PEP8 adjustments
2019-11-08 22:13:03 -03:00
Andrey Rahmatullin
d267e183b4
Merge pull request #4139 from Gallaecio/jobdir-pickle-documentation
...
Improve the details about request serialization requirements for JOBDIR
2019-11-08 22:49:33 +05:00
Andrey Rahmatullin
ea41117229
Merge pull request #4142 from Gallaecio/doctest
...
Set the bases for testing code examples from the documentation
2019-11-08 22:44:52 +05:00
Eugenio Lacuesta
342e3b5bd5
Merge remote-tracking branch 'upstream/master' into remove-six-code
2019-11-08 12:29:15 -03:00
Eugenio Lacuesta
6cde428af4
Remove deprecated MergeDict class
2019-11-08 12:26:40 -03:00
Adrián Chaves
1df5755699
Set the bases for testing code examples from the documentation
2019-11-08 16:00:10 +01:00
elacuesta
44f19df311
[test] Update mitmproxy version
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-11-08 11:32:50 -03:00
Adrián Chaves
40ed184914
Merge branch 'master' into pylint
2019-11-07 18:40:58 +01:00
Adrián Chaves
aef98188fa
Improve the details about request serialization requirements for JOBDIR
2019-11-07 18:06:55 +01:00
Andrey Rahmatullin
d874c4d90b
Remove the old Python 2 PyPy installation code from .travis.yml ( #4138 )
2019-11-07 18:02:17 +01:00
Marc Hernández
c377c14e32
Fix W391 Blank line at end of file ( #4137 )
2019-11-07 17:47:35 +01:00
Marc Hernández
e8b1e46e85
Add pytest-flake8 ( #3945 )
2019-11-07 14:05:01 +01:00
Adrián Chaves
98caf055b5
Fix a typo: specifiy → specify ( #4128 )
2019-11-06 11:53:46 +01:00
elacuesta
fe31695ba0
Remove unused import (urllib.parse.unquote)
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-11-05 15:36:19 -03:00
seregaxvm
698aa704b9
Fix zsh completion file extension ( #4122 )
2019-11-05 16:30:01 +01:00
Eugenio Lacuesta
613c66a034
Do not override built-in max function
2019-11-05 09:45:51 -03:00
elacuesta
fed9fbe62d
Update tests/test_utils_datatypes.py
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-11-04 15:34:27 -03:00
Eugenio Lacuesta
439a3e59b8
Fix scrapy.utils.datatypes.LocalCache limit issue
2019-11-04 10:35:58 -03:00
Eugenio Lacuesta
0c4e5b68ea
Remove six from requirements and setup files
2019-11-03 12:30:34 -03:00
Eugenio Lacuesta
00b793dc59
Remove elluding six occurrences
2019-11-03 12:26:38 -03:00
Eugenio Lacuesta
5797aefd4c
Remove six.assertCountEqual
2019-11-03 12:18:35 -03:00
Eugenio Lacuesta
586b25d27e
Remove six types
2019-11-03 12:10:37 -03:00
Eugenio Lacuesta
7f3cb05d8e
Remove metaclass-related six code
2019-11-03 12:03:02 -03:00
Eugenio Lacuesta
e461570f99
Remove protego from requirements file
2019-11-03 01:28:14 -03:00
Eugenio Lacuesta
cca1959c07
Merge remote-tracking branch 'upstream/remove-py2-tests' into remove-six-code
2019-11-03 01:20:08 -03:00
Eugenio Lacuesta
d72444b9c8
Remove more six imports
2019-11-03 01:11:28 -03:00
Eugenio Lacuesta
eaeaa40b99
Remove six.PY* checks
2019-11-03 01:08:08 -03:00
Eugenio Lacuesta
5d8abdde59
Remove six.text_type from tests
2019-11-03 01:01:23 -03:00
Eugenio Lacuesta
ac62524824
Remove six.get_method_*
2019-11-03 01:00:54 -03:00
Eugenio Lacuesta
54a786b102
Remove six imports
2019-11-03 00:58:47 -03:00
Eugenio Lacuesta
ce8e515fa8
Remove six type wrappers
2019-11-03 00:36:25 -03:00
Eugenio Lacuesta
68bf192172
Fix bad import
2019-11-03 00:32:07 -03:00
Eugenio Lacuesta
1aba513693
Remove six.iter* occurrences
2019-11-03 00:26:44 -03:00
Eugenio Lacuesta
5ab0f189ce
Remove six.moves occurrences from tests
2019-11-03 00:01:09 -03:00
Eugenio Lacuesta
df00389c16
Remove six.moves occurrences
2019-11-03 00:00:49 -03:00
Eugenio Lacuesta
c0bfaef37a
Remove __future__ imports from tests
2019-11-02 23:27:04 -03:00
Eugenio Lacuesta
415526d922
Remove __future__ imports
2019-11-02 23:26:38 -03:00
Andrey Rakhmatullin
48b8ac6009
Improve the dbm module ref.
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-11-01 20:05:37 +05:00
Andrey Rakhmatullin
350aa67c3d
Rename tests/py3-ignores.txt to tests/ignores.txt.
2019-11-01 19:52:57 +05:00
Andrey Rakhmatullin
4b0cdf7f3e
Use self.proc.communicate() after killing mitmdump.
2019-11-01 19:51:52 +05:00
Andrey Rakhmatullin
3c9963ab04
Only xfail test_https_connect_tunnel_error on 3.6+.
2019-11-01 19:47:12 +05:00
Andrey Rakhmatullin
e0c5c72496
Improve the test_https_tunnel_without_leak_proxy_authorization_header change.
2019-11-01 19:46:19 +05:00
Andrey Rakhmatullin
5eb01b617d
Use an older mitmproxy for py3.5.
2019-10-31 23:21:30 +05:00
Andrey Rakhmatullin
a5eb59b92d
Fix test_proxy_connect.py for py3.5.
2019-10-31 23:21:14 +05:00
Andrey Rakhmatullin
864123132a
Fix a duplicate ref name in docs.
2019-10-31 22:55:58 +05:00
Adrián Chaves
f02c3d1dcf
Use communicate() instead of wait() after killing the mock server ( #4095 )
2019-10-31 13:31:33 +01:00
Andrey Rakhmatullin
7299e91b1f
Remove Py2-only code that checks sys.version_info.
2019-10-31 15:22:53 +05:00
Andrey Rakhmatullin
397e883556
Replace to_native_str calls with to_unicode.
2019-10-31 15:22:53 +05:00
Andrey Rakhmatullin
75b1d051d9
Simplify some more imports.
2019-10-31 15:22:45 +05:00
Andrey Rakhmatullin
3ac4b430ae
Remove an unused six import.
2019-10-31 15:20:28 +05:00
Andrey Rakhmatullin
5b70b051a6
Some text function messages cleanup, deprecate to_native_str.
2019-10-31 15:07:59 +05:00
Andrey Rakhmatullin
cea2f5e244
Remove cStringIO imports.
2019-10-31 15:07:54 +05:00
Andrey Rakhmatullin
c2898fdcf9
Deprecate scrapy.utils.gz.read1.
2019-10-31 15:07:50 +05:00
Andrey Rakhmatullin
de7789e52d
Remove unneeded and unused code from XmlItemExporter.
2019-10-31 15:07:46 +05:00
Andrey Rakhmatullin
bbd9f4be90
Remove six.PY2 and six.PY3 conditionals.
2019-10-31 15:07:10 +05:00
Andrey Rakhmatullin
186f9d88ac
Fix the skip message for test_download_gzip_response.
2019-10-31 15:03:44 +05:00
Andrey Rakhmatullin
439e37fc7b
Mark failing proxy tests.
2019-10-31 15:03:44 +05:00
Andrey Rakhmatullin
b0d6f4917d
Restore tests/test_proxy_connect.py and update it to modern mitmproxy.
2019-10-31 15:03:44 +05:00
Andrey Rakhmatullin
b44bd6f825
Remove Python 2-only tests.
2019-10-31 15:03:09 +05:00
Adrián Chaves
15c55d0c1d
Remove LevelDB support ( #4112 )
2019-10-31 10:47:29 +01:00
Andrey Rahmatullin
229e722a03
Initial Python 2 removal ( #4091 )
2019-10-31 10:46:02 +01:00
Benjamin Ooghe-Tabanou
6d6da78eda
Add a keep_fragments parameter to the request_fingerprint function ( #4104 )
2019-10-30 09:13:36 +01:00
Amardeep Bhowmick
66cbceeb0a
Fix redirection error when the Location header value starts with 3 slashes ( #4042 )
2019-10-30 09:09:12 +01:00
Adrián Chaves
02577f55a0
Have PyLint cover all Python files in the repository
2019-10-24 13:25:11 +02:00
Kevin Lloyd Bernal
84fe4011b0
update docs of scrapy.loader.ItemLoader.item
2019-10-23 20:39:53 +08:00
Adrián Chaves
3b6f7ac9f2
Use pylint
2019-10-22 19:44:11 +02:00
Adrián Chaves
c623a16a22
Remove unused method from scrapy.pqueues._SlotPriorityQueues
2019-10-22 17:52:34 +02:00
Ammar Najjar
bf5c1a3dec
docs: use "constructor" for "from_crawler"
...
Issue #4086
2019-10-22 15:56:46 +02:00
Ammar Najjar
7fba8434f3
use instantiation for "Crawler"
...
Issue #4086
Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>
2019-10-22 15:55:52 +02:00
Victor Torres
f701f5b0db
fix #2552 by improving request schema check on its initialization
2019-10-22 10:48:02 -03:00
Ammar Najjar
7a84a4bdba
docs: use "constructor" for from_settings() & rom_crawler() factory methods
...
Issue #4086
2019-10-22 15:31:34 +02:00
Adrián Chaves
d96b9f860b
Use object as type for parameters that allow any value
2019-10-22 15:24:59 +02:00
Adrián Chaves
5479e7ecc7
Indicate that lists of emails may be provided as a single string or as a list of strings
2019-10-22 15:24:44 +02:00
Ammar Najjar
d21e1034f0
docs: correct point,comma and plural replacements
...
Issue #4086
2019-10-22 13:29:38 +02:00
purvaudai
4184bac068
Added Pathlib.Path test
2019-10-22 16:57:14 +05:30
purvaudai
85f56a92f0
Added Pathlib.Path test
2019-10-22 16:43:17 +05:30
purvaudai
7031e3a124
Added Pathlib.Path test
2019-10-22 16:31:14 +05:30
purvaudai
cd09646438
Added Pathlib.Path test
2019-10-22 16:19:41 +05:30
purvaudai
cd4c211f4b
Added Pathlib.Path test
2019-10-22 15:38:06 +05:30
purvaudai
a776554282
Added Pathlib.Path test
2019-10-22 15:31:55 +05:30
purvaudai
0b7d8a51b4
Added Pathlib.Path test
2019-10-22 15:12:53 +05:30
purvaudai
4226791481
Added Pathlib.Path test
2019-10-22 15:07:13 +05:30
purvaudai
ad96d6ef59
Added Pathlib.Path test correctly
2019-10-22 14:53:59 +05:30
purvaudai
2ee38e8ddb
Added Pathlib.Path test
2019-10-22 14:43:47 +05:30
Ammar Najjar
da8cd9448d
docs: always surround __init__ with `` in docs
...
Issue #4086
2019-10-21 19:56:58 +02:00
Adrián Chaves
ad6075440c
Fix references to Python types in parameter type fields
2019-10-21 19:00:03 +02:00
Ammar Najjar
68a7d05ed8
docs: use __init__ method instead of constructor
...
Issue #4086
2019-10-21 15:42:24 +02:00
Adrián Chaves
0fbd1ff4a9
constructor → __init__ method
2019-10-21 14:06:45 +02:00
Eugenio Lacuesta
6df6b6dd6a
Initializer -> __init__
2019-10-21 03:56:45 -03:00
José Alberto Orejuela García
865d58fd1b
Make punctuation consistent
2019-10-16 22:44:42 +02:00
Eugenio Lacuesta
2c6f7fee64
TextResponse.follow_all: invoke Response.follow_all
2019-10-15 13:48:14 -03:00
Eugenio Lacuesta
2a4d4a466a
TextResponse.follow_all: Simplify implementation
2019-10-15 11:52:12 -03:00
Eugenio Lacuesta
9d5398e7f2
TextResponse.follow_all: improve docs
2019-10-14 14:19:04 -03:00
elacuesta
c7c54f5453
Update scrapy/http/response/text.py
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-10-14 13:47:44 -03:00
elacuesta
498d33aac3
Update scrapy/http/response/text.py
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-10-14 13:35:54 -03:00
elacuesta
ba840c5a6b
Update scrapy/http/response/__init__.py
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-10-14 13:35:24 -03:00
elacuesta
b970851299
Update scrapy/http/response/__init__.py
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-10-14 13:35:06 -03:00
Purva Udai
12f1e468e9
Issue #3731
2019-10-13 15:55:27 +05:30
Eugenio Lacuesta
e1fa1fd8ad
TextResponse.follow_all: skip invalid links
2019-10-10 00:37:30 -03:00
akhter wahab
532770df52
instead of .tar.xz adding .xz in others extensions
2019-10-09 22:53:14 +05:00
akhter wahab
a25a2d5ee4
Add .tar.xz to ignored other extensions
2019-10-09 16:05:39 +05:00
akhter wahab
877ef4269e
Add .webm to ignored video extensions
2019-10-09 16:03:44 +05:00
Eugenio Lacuesta
5f168cd459
Response.follow_all
2019-10-08 16:32:56 -03:00
akhter wahab
f52148143b
Add dmg, iso & apk to ignored other extensions
2019-10-07 23:28:33 +05:00
Eugenio Lacuesta
07a31b13db
Update LogFormatter tests
2019-10-01 17:55:57 -03:00
OmarFarrag
175cd2ece5
Update docs/topics/media-pipeline.rst
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-10-01 07:27:31 +02:00
Adrián Chaves
7f4f98fd38
Provide complete API documentation coverage of scrapy.linkextractors
2019-09-30 18:22:28 +02:00
OmarFarrag
28005b2872
Update media-pipeline.rst
2019-09-28 06:21:14 +02:00
OmarFarrag
b14c3cb612
Add media pipelines FTP documentation
2019-09-19 23:33:57 +02:00
Eugenio Lacuesta
27436cbbc9
[test] LogFormatter.error
2019-09-16 12:12:10 -03:00
Eugenio Lacuesta
f6872189b9
Add LogFormatter.error method
2019-09-16 12:10:24 -03:00
OmarFarrag
0e8770a2f4
test for files pipeline ftp store
2019-09-06 15:47:57 +02:00
Júlio César Batista
b84f99ff5d
Merge
2019-08-29 11:11:56 -03:00
Júlio César Batista
110bc92e6b
Fix default value of FEED_STORAGE_GCS_ACL
2019-08-29 11:10:00 -03:00
OmarFarrag
97d2f717ae
Support extracting ftp settings in `ImagesPipeline`
2019-08-22 16:19:01 +02:00
OmarFarrag
2047124b35
Follow PEP8 .. Remove unnecessary comments
2019-08-22 16:18:14 +02:00
OmarFarrag
bd22b25ef4
Make `stat_file` thread safe .. Refactor file storing.. Support act/psv
2019-08-22 01:30:15 +02:00
OmarFarrag
8c970c636e
port from str to int
...
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
2019-08-21 18:28:36 +02:00
OmarFarrag
790bf90312
Make FTP persiting files thread safe
2019-08-19 19:16:47 +02:00
OmarFarrag
81ac1da381
Handle leading and trailing slashes
2019-08-19 17:17:21 +02:00
OmarFarrag
0a5cb7745b
Fix reference mistake
2019-08-19 17:12:11 +02:00
OmarFarrag
9b1587ed1b
Credentials from settings-Support custom paths-Remove close conenction
2019-08-19 16:13:56 +02:00
OmarFarrag
c025003da2
Add FTPFileStore
2019-08-18 04:44:09 +02:00
Tobias Hernstig
2b0de0606c
Fix merge conflicts
2019-08-15 18:54:28 +02:00
Tobias Hernstig
50c4cafe0c
Update documentation for logging manually
...
Usage of basicConfig() together with crawlerRunner is not recommended.
Update documentation to highlight this fact.
Closes #2149 , #2352 , #3146
2019-08-15 18:46:00 +02:00
Shivam Sandbhor
18d0affc01
Update reactor.py, updated 'if' sequencing , possibly eliminating a bug if portrange=None
...
This should be the proper ordering.This is the explanation.
If 'not portrange' is True ,it is guaranteed that `not hasattr(portrange, '__iter__')` is also True the converse of this is not always true.(for example, consider portrange=None, for such case we were executing the logic for `not hasattr(portrange, '__iter__')` . ).Such case is eliminated by this PR.
2019-08-05 16:53:35 +05:30
Anubhav Patel
90fdefcbca
cache if convert_image has deprecated signature
2019-05-25 19:11:48 +05:30
Anubhav Patel
c8e28ec194
makes suggested changes
2019-05-23 15:04:21 +05:30
Anubhav Patel
2994b624e0
makes suggested changes
2019-05-17 12:14:43 +00:00
Anubhav Patel
653ac3eebe
makes suggested changes
2019-05-16 06:20:39 +00:00
Anubhav Patel
881bade2c1
tests for new API
2019-05-07 16:12:26 +05:30
Anubhav Patel
33925a7761
test for deprecation warning
2019-05-07 15:44:21 +05:30
Anubhav Patel
2a6bcdb413
makes fix backward compatible
2019-04-29 21:21:02 +05:30
Anubhav Patel
6039b66f42
aesthetic changes
2019-04-13 10:17:26 +05:30
Anubhav Patel
c6769d6887
make suggested changes
2019-04-13 10:10:08 +05:30
Anubhav Patel
398639a0bf
fix test
2019-04-08 12:27:36 +05:30
Adrián Chaves
484bd0d22a
Allow customizing export column names
2019-03-29 15:16:54 +01:00
Anubhav Patel
ca882d8d9f
include test
2019-03-27 19:10:44 +05:30
Maram Sumanth
5f2ad5377e
fixed typo
2019-03-26 16:46:15 +05:30
Maram Sumanth
ae856e8ba8
corrected tests
2019-03-26 16:21:52 +05:30
Maram Sumanth
213b9eb879
Update test_http_request.py
2019-03-26 15:59:38 +05:30
Maram Sumanth
dc8310e292
changed tests
2019-03-26 15:42:58 +05:30
Adrián Chaves
ba13de29e1
Merge branch 'master' into feat-685
2019-03-26 10:38:38 +01:00
Adrián Chaves
72cf190145
Add a FAQ entry about name collisions
2019-03-22 15:37:01 +01:00
Júlio César Batista
2cb4dc3205
Mentioning to use JSON API for ACLs
2019-03-22 09:50:11 -03:00
Maram Sumanth
4c89e53e68
Update test_http_request.py
2019-03-20 18:46:25 +05:30
Maram Sumanth
282f24c510
Update form.py
2019-03-20 18:46:22 +05:30
Anubhav Patel
07487dd487
make tests work with new convert_image
2019-03-15 23:29:53 +05:30
Anubhav Patel
25e616fa04
do not degrade JPEG files.
2019-03-15 18:09:47 +05:30
Maram Sumanth
35f7595dbe
changed variable names
2019-03-11 23:58:37 +05:30
Adrián Chaves
120007c057
Add a FAQ entry on how to deal with long lists of allowed domains
2019-03-08 13:53:47 +01:00
Maram Sumanth
f7bf3abbd0
Modified code
2019-03-06 14:10:03 +05:30
Maram Sumanth
7da460b793
Update form.py
2019-03-04 17:25:15 +05:30
Maram Sumanth
8831fafabc
Update test_http_request.py
2019-03-04 15:42:48 +05:30
Maram Sumanth
fdf03a6d0d
correcting tests
2019-03-04 15:12:44 +05:30
Maram Sumanth
d75b61b96a
Update test_http_request.py
2019-03-04 15:07:12 +05:30
Maram Sumanth
6eca6f92c6
Update form.py
2019-03-04 14:59:34 +05:30
Júlio César Batista
0bb3d8ca93
Updating Google Cloud Storage scheme to gs instead of gcs
2019-02-27 18:41:01 -03:00
Júlio César Batista
cb5f800b0f
Adding documentation about Google Cloud Storage Feed Export
2019-02-08 11:26:33 -02:00
Júlio César Batista
2bbbd02bda
Adding an option to set ACL while uploading the blob to GCS
2019-02-08 09:45:10 -02:00
Júlio César Batista
4a53de165a
Sorted schemas alphabetically
2019-02-08 09:09:56 -02:00
Júlio César Batista
fc6809b024
Add gcs schema to FEED_STORAGES_BASE
2019-02-08 09:08:54 -02:00
Júlio César Batista
1bb6c4154c
Turning into instance attributes
2019-02-08 09:04:01 -02:00
Júlio César Batista
a4059851e7
Refactoring tests
2019-01-31 18:29:15 -02:00
Júlio César Batista
5a55c4269d
Adding GCSFeedStorage
2019-01-31 17:20:29 -02:00
Maram Sumanth
722a30ac2b
Update test_http_request.py
2019-01-19 13:20:05 +05:30
Maram Sumanth
7dee841b8b
Update form.py
2019-01-19 13:20:01 +05:30
Maram Sumanth
a9f68acb6d
modified code
2019-01-17 23:51:09 +05:30
Maram Sumanth
6be73f06c3
Updated tests
2019-01-17 23:50:58 +05:30
Maram Sumanth
6f86c93f36
Increased test cases
2019-01-16 23:54:35 +05:30
Maram Sumanth
3e67fa8fc1
Improved for better user readability
2019-01-16 23:01:38 +05:30
Maram Sumanth
9f1f4df966
Update test_http_request.py
2019-01-16 22:59:41 +05:30
Maram Sumanth
023290dabc
Update test_http_request.py
2019-01-13 23:50:31 +05:30
Maram Sumanth
4abcdcb306
Update test_http_request.py
2019-01-13 23:22:53 +05:30
Maram Sumanth
9a4bbd6d02
Update form.py
2019-01-13 23:05:58 +05:30
Maram Sumanth
1bea5d3076
Fixed error
2019-01-13 22:35:16 +05:30
Maram Sumanth
b5e454809e
Included test
2019-01-13 20:12:31 +05:30
Maram Sumanth
ac111088c6
duplicate keys handled
2019-01-13 20:12:29 +05:30
Arvind Prasanna
412f852602
A few typo fixes and some grammatical enhancements
2018-03-06 23:58:27 -05:00
Harrison Gregg
8d97f49e5e
Re-add SIGINT handler in inspect_response after shell closes
2017-09-09 13:54:48 +06:30
Pengyu CHEN
114437c169
added: Doc for `scrapy.http.TextResponse.urljoin`
2016-09-10 10:38:36 +12:00
Jakob de Maeyer
a65fc0db7d
Drop support for providing file paths as add-ons
2015-11-12 18:37:26 +01:00
Jakob de Maeyer
33dfb3e167
Remove unused project path util function
2015-11-11 21:08:20 +01:00
Jakob de Maeyer
b7b00fb956
PEP8ify add-ons and tests
2015-11-11 21:08:20 +01:00
Jakob de Maeyer
e924d38238
Drop component configuration (copied from default_settings) from built-in add-ons
2015-11-11 21:08:20 +01:00
Jakob de Maeyer
388c5c4b78
Fix component exporting for Addon base class
2015-11-11 21:08:20 +01:00
Jakob de Maeyer
8e5d067af1
Drop BaseSettings.get_addon() prefix magic
2015-11-11 21:08:20 +01:00
Jakob de Maeyer
b10caf91a1
Drop support for add-on configuration in scrapy.cfg
2015-11-11 21:08:20 +01:00
Jakob de Maeyer
f7ed239fcb
Replace INSTALLED_ADDONS tuple setting with ADDONS dictionary setting
2015-11-11 21:08:20 +01:00
Jakob de Maeyer
9f7fcf5582
Make update_classpath() util function return non-string objects
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
d18b6a61d7
Add missing AddonManager tests
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
18c7f3dbe2
Document built-in add-ons
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
4ac6a83072
Fix class signatures in Extensions docs
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
25498c3c21
Remove unused imports in add-ons
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
2946b67414
Document add-ons
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
d91647c38b
Add built-in add-ons
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
07455b1883
Integrate add-ons into start-up process
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
d8af395d76
Introduce add-ons via AddonManager and Addon base class
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
e5b8def0b8
Redraft SEP-021
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
cfed9b6659
Allow passing Python objects to middleware dict settings
2015-11-11 21:08:19 +01:00
Jakob de Maeyer
2629997a2f
Make Spider.update_settings() an instance method
2015-11-10 23:48:20 +01:00
Jakob de Maeyer
daec045711
Move spider settings tests
2015-11-09 18:07:05 +01:00
Jakob de Maeyer
380f76d35f
Fix tests that had multiple calls to crawl()
2015-11-09 16:54:22 +01:00
Jakob de Maeyer
fc26397319
Revert "Allow multiple calls to Crawler.crawl()"
...
This reverts commit 4e40377bcb .
2015-11-09 16:32:45 +01:00
Jakob de Maeyer
aafb31d6fb
Revert "Move stats & log init into crawl()"
...
This reverts commit 2c68c95cad .
2015-11-09 16:26:55 +01:00
Jakob de Maeyer
2c68c95cad
Move stats & log init into crawl()
2015-11-03 23:46:48 +01:00
Jakob de Maeyer
4e40377bcb
Allow multiple calls to Crawler.crawl()
2015-11-03 23:32:02 +01:00
Jakob de Maeyer
86c74ce53e
Allow Spider.update_settings() to be an instance method
2015-11-02 16:57:57 +01:00
Jakob de Maeyer
b06a670777
Initialize spider before calling its update_settings()
2015-11-02 16:47:07 +01:00
Jakob de Maeyer
d67f292d92
Move Spider.update_settings() into Crawler.crawl()
2015-11-02 16:36:33 +01:00
Jakob de Maeyer
c0566b2b07
Move extension init into Crawler.crawl()
2015-11-02 16:18:56 +01:00
nramirezuy
2a540206a7
fix xmliter namespace on selected node
2014-08-19 15:44:49 -03:00